mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 09:35:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Protect assertion when reload from about:blank

Browse Source 
(and hopefully all other cases) where a commit happens on a previously blank
slate.
This commit is contained in:
Karl Seguin
2026-05-07 09:14:07 +08:00
parent 4f7db8e974
commit 5a0c7eff66
1 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/browser/webapi/navigation/Navigation.zig
View File

@@ -153,10 +153,14 @@ pub fn updateEntries(
pub fn commitNavigation(self: *Navigation, frame: *Frame) !void {
const url = frame.url;
const kind: NavigationKind = self._current_navigation_kind orelse .{ .push = null };
var kind: NavigationKind = self._current_navigation_kind orelse .{ .push = null };
defer self._current_navigation_kind = null;
const from_entry = self.getCurrentEntryOrNull();
if (from_entry == null) {
kind = .{ .push = null };
}
try self.updateEntries(url, kind, frame, false);
self._activation = NavigationActivation{
@@ -517,3 +521,31 @@ test "Navigation: about:blank commits entry" {
);
try testing.expect(result.isTrue());
}
test "Navigation: reload on empty stack seeds an entry" {
const frame = try testing.test_session.createPage();
defer testing.test_session.removePage();
testing.test_session.navigation._entries.clearRetainingCapacity();
testing.test_session.navigation._index = 0;
// Mirrors CDP Page.reload arriving on a fresh session: doReload reads
// frame.url (default "about:blank") and routes through the synchronous
// about:blank commit with kind=.reload. updateEntries is a no-op for
// .reload, so without the empty-stack guard this would assert
// `len: 0` in getCurrentEntry.
try frame.navigate("about:blank", .{ .kind = .reload });
var runner = try testing.test_session.runner(.{});
try runner.wait(.{ .ms = 1000 });
var ls: js.Local.Scope = undefined;
frame.js.localScope(&ls);
defer ls.deinit();
const result = try ls.local.exec(
"navigation.currentEntry.url === 'about:blank'",
"Navigation.test",
);
try testing.expect(result.isTrue());
}