mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-12 01:56:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix segfault on Frame deinit

Browse Source
This commit is contained in:
Nikolay Govorov
2026-04-29 13:33:10 +01:00
parent bb1070f80a
commit 91f5988fe5
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/browser/Session.zig
View File

@@ -133,9 +133,15 @@ pub fn createPage(self: *Session) !*Frame {
}
pub fn removePage(self: *Session) void {
lp.assert(self.page != null, "Session.removePage - page is null", .{});
if (self.page.?.frame._script_manager.is_evaluating) {
// Reentrant teardown from a CDP message drained inside syncRequest;
// Session.deinit reclaims the page when the connection closes.
return;
}
// Inform CDP the frame is going to be removed, allowing other worlds to remove themselves before the main one
self.notification.dispatch(.frame_remove, .{});
lp.assert(self.page != null, "Session.removePage - page is null", .{});
self.page.?.deinit(false);
self.page = null;