mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-08-01 02:06:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf: Skip CSSStyleProperty creation if there is no style attribute

Browse Source 
Was reviewing https://github.com/lightpanda-io/browser/pull/2836 and realized
the StyleManager's getInlineStyleProperty could be optimized  to avoid creating
the CSSStyleProperties in the case where there's no style attribute.
This commit is contained in:
Karl Seguin
2026-06-30 12:50:50 +08:00
parent fe3e53c34a
commit 96e23f78e8
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/browser/StyleManager.zig
View File

@@ -864,6 +864,10 @@ const CheckVisibilityOptions = struct {
const INLINE_PRIORITY: u64 = std.math.maxInt(u64);
fn getInlineStyleProperty(el: *Element, property_name: String, frame: *Frame) ?*CSSStyleProperty {
if (!el.hasAttributeSafe(comptime .wrap("style"))) {
// cheap guard to avoid creating the CSSStyleProperty if there is no style attribute
return null;
}
const style = el.getOrCreateStyle(frame) catch |err| {
log.err(.browser, "StyleManager getOrCreateStyle", .{ .err = err });
return null;