mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-07-31 17:55:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2848 from lightpanda-io/perf/skip-inline-style-alloc

Browse Source 
perf(css): skip inline-style allocation for elements without inline styles
This commit is contained in:
Karl Seguin
2026-07-01 08:21:21 +08:00
committed by GitHub
parent c843025380 7a2f4ff2da
commit a36874f688
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/StyleManager.zig
View File

@@ -864,13 +864,13 @@ const CheckVisibilityOptions = struct {
const INLINE_PRIORITY: u64 = std.math.maxInt(u64);
fn getInlineStyleProperty(el: *Element, property_name: String, frame: *Frame) ?*CSSStyleProperty {
if (!el.hasAttributeSafe(comptime .wrap("style"))) {
// cheap guard to avoid creating the CSSStyleProperty if there is no style attribute
return null;
}
const style = el.getOrCreateStyle(frame) catch |err| {
log.err(.browser, "StyleManager getOrCreateStyle", .{ .err = err });
return null;
const style = frame._element_styles.get(el) orelse blk: {
// No JS-set style object and no style attribute -> nothing inline to read.
if (el.getAttributeSafe(comptime .wrap("style")) == null) return null;
break :blk el.getOrCreateStyle(frame) catch |err| {
log.err(.browser, "StyleManager getOrCreateStyle", .{ .err = err });
return null;
};
};
return style.asCSSStyleDeclaration().findProperty(property_name);
}