mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 01:25:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

accessibility: bind AX writers to the node's owning frame

Browse Source 
axnodeWriter and axnodeQueryWriter both used session.currentFrame(),
but the root node may belong to a different frame (cross-frame query
from a parent context, iframe content). Name resolution (Label lookup
against ownerDocument) and visibility checks (frame._style_manager)
are per-frame, so the writer needs to bind to the node's owning frame.

Uses the existing Node.ownerFrame(fallback) helper. Fallback is
currentFrame for the orphan/detached-node case.

Also corrects a pre-existing latent bug in getFullAXTree where the
writer ignored the resolved frameId and used currentFrame instead.
This commit is contained in:
Navid EMAD
2026-05-15 22:26:48 +02:00
parent 940e9e9240
commit b9601be45e
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cdp/CDP.zig
View File

@@ -654,7 +654,13 @@ pub const BrowserContext = struct {
}
pub fn axnodeWriter(self: *BrowserContext, temp_arena: Allocator, root: *const Node, opts: AXNode.Writer.Opts) !AXNode.Writer {
const frame = self.session.currentFrame() orelse return error.FrameNotLoaded;
// Bind the writer to the frame that owns the root node, not whatever
// happens to be `currentFrame`. Name resolution (`Label.findLabelByFor`
// against `ownerDocument`) and visibility checks (`frame._style_manager`)
// are per-frame; getting this wrong on cross-frame queries produces
// names/visibility from the wrong document.
const fallback = self.session.currentFrame() orelse return error.FrameNotLoaded;
const frame = root.dom.ownerFrame(fallback);
_ = opts;
const cache = try frame.call_arena.create(Element.VisibilityCache);
cache.* = .empty;
@@ -671,7 +677,9 @@ pub const BrowserContext = struct {
}
pub fn axnodeQueryWriter(self: *BrowserContext, temp_arena: Allocator, root: *const Node, opts: AXNode.QueryWriter.Opts) !AXNode.QueryWriter {
const frame = self.session.currentFrame() orelse return error.FrameNotLoaded;
// See axnodeWriter for the frame-binding rationale.
const fallback = self.session.currentFrame() orelse return error.FrameNotLoaded;
const frame = root.dom.ownerFrame(fallback);
const cache = try frame.call_arena.create(Element.VisibilityCache);
cache.* = .empty;
const label_index = try frame.call_arena.create(Label.LabelByForIndex);