mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-07-31 01:36:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2826 from bebsworthy/fix/cdp-frameattached-double-params

Browse Source 
cdp: Fix Page.frameAttached params double-wrapping that broke sub-frame interception
This commit is contained in:
Pierre Tachoire
2026-06-29 07:50:25 +00:00
committed by GitHub
parent e396cbb90c e6bd65626e
commit cf99ec2fbd
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/cdp/domains/page.zig
View File

@@ -585,10 +585,10 @@ pub fn frameChildFrameCreated(bc: *CDP.BrowserContext, event: *const Notificatio
const cdp = bc.cdp;
const frame_id = &id.toFrameId(event.frame_id);
try cdp.sendEvent("Page.frameAttached", .{ .params = .{
try cdp.sendEvent("Page.frameAttached", .{
.frameId = frame_id,
.parentFrameId = &id.toFrameId(event.parent_id),
} }, .{ .session_id = session_id });
}, .{ .session_id = session_id });
if (bc.page_life_cycle_events) {
try cdp.sendEvent("Page.lifecycleEvent", LifecycleEvent{
@@ -1055,6 +1055,25 @@ test "cdp.frame: getFrameTree" {
}
}
test "cdp.frame: frameAttached" {
var ctx = try testing.context();
defer ctx.deinit();
const bc = try ctx.loadBrowserContext(.{ .session_id = "SID-X" });
bc.notification.dispatch(.frame_child_frame_created, &.{
.frame_id = 2,
.parent_id = 1,
.loader_id = 7,
.timestamp = 0,
});
try ctx.expectSentEvent("Page.frameAttached", .{
.frameId = "FID-0000000002",
.parentFrameId = "FID-0000000001",
}, .{ .session_id = "SID-X" });
}
test "cdp.frame: captureScreenshot" {
const LogFilter = @import("../../testing.zig").LogFilter;
const filter: LogFilter = .init(&.{.not_implemented});