mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 17:46:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

On Page cleanup, capture next linked list node _before_ releasing MO

Browse Source 
Also, switch MO and IO to use a "small" arena, as they probably don't require
too many allocations in most normal cases (just observing 1 or 2 things).
This commit is contained in:
Karl Seguin
2026-04-11 11:39:05 +08:00
parent 071e70e5cc
commit da8d206c52
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/browser/Page.zig
View File

@@ -365,9 +365,10 @@ pub fn deinit(self: *Page, abort_http: bool) void {
}
{
var it: ?*std.DoublyLinkedList.Node = self._mutation_observers.first;
while (it) |node| : (it = node.next) {
const observer: *MutationObserver = @fieldParentPtr("node", node);
var node: ?*std.DoublyLinkedList.Node = self._mutation_observers.first;
while (node) |n| {
node = n.next; // capture before we potentially delete observer
const observer: *MutationObserver = @fieldParentPtr("node", n);
observer.releaseRef(session);
}
}

2
src/browser/webapi/IntersectionObserver.zig
View File

@@ -71,7 +71,7 @@ pub const ObserverInit = struct {
};
pub fn init(callback: js.Function.Temp, options: ?ObserverInit, page: *Page) !*IntersectionObserver {
const arena = try page.getArena(.medium, "IntersectionObserver");
const arena = try page.getArena(.small, "IntersectionObserver");
errdefer page.releaseArena(arena);
const opts = options orelse ObserverInit{};

3
src/browser/webapi/MutationObserver.zig
View File

@@ -76,9 +76,8 @@ pub const ObserveOptions = struct {
};
pub fn init(callback: js.Function.Temp, page: *Page) !*MutationObserver {
const arena = try page.getArena(.medium, "MutationObserver");
const arena = try page.getArena(.small, "MutationObserver");
errdefer page.releaseArena(arena);
const self = try arena.create(MutationObserver);
self.* = .{
._arena = arena,