mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 01:25:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2241 from lightpanda-io/fix/bound-memory-growth-long-waits-main

Browse Source 
browser: bound per-tick memory growth on JS-heavy pages
This commit is contained in:
Karl Seguin
2026-04-25 14:53:10 +08:00
committed by GitHub
parent 25cec9bd82 093555b374
commit ed5bc09951
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/Runner.zig
View File

@@ -72,7 +72,21 @@ fn _wait(self: *Runner, comptime is_cdp: bool, opts: WaitOpts) !CDPWaitResult {
.ms = 200,
.until = opts.until,
};
// Periodic V8 GC hint during long waits. V8 is otherwise only nudged on
// session/page teardown (Browser.zig, Page.zig), so a page that stays
// alive for seconds while running heavy JS accumulates wrappers and
// external-ref'd Zig allocations V8 has no reason to drop. `.moderate`
// speeds up incremental GC without stalling the tick.
const gc_hint_period_ns: u64 = std.time.ns_per_s;
var gc_hint_timer = std.time.Timer.start() catch unreachable;
while (true) {
if (gc_hint_timer.read() >= gc_hint_period_ns) {
gc_hint_timer.reset();
self.session.browser.env.memoryPressureNotification(.moderate);
}
const tick_result = self._tick(is_cdp, tick_opts) catch |err| {
switch (err) {
error.JsError => {}, // already logged (with hopefully more context)