mirror/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-06-11 01:25:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

eval: clarify automatic JSON serialization

Browse Source 
Update agent docs and tool descriptions to note that objects and
arrays are automatically serialized to JSON, making manual
`JSON.stringify` calls unnecessary.
This commit is contained in:
Adrià Arrufat
2026-05-31 16:27:28 +02:00
parent ab3deec523
commit fc15027100
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
docs/agent.md
View File

@@ -210,13 +210,14 @@ for (const s of lp.front.stories) {
'''
/eval '''
JSON.stringify(lp.front.stories)
lp.front.stories
'''
```
A body with no explicit `return` resolves to `undefined`, which the eval
treats as silent — so the loop above prints nothing, and only the final
`JSON.stringify` lands on stdout.
treats as silent — so the loop above prints nothing. The final `/eval`
yields the array, which lands on stdout as JSON: objects and arrays are
serialized automatically, so no `JSON.stringify` is needed.
The store is **script-run scoped**: it's bound to the Session that runs
the script, and goes away when that Session does. There is no

4
src/browser/tools.zig
View File

@@ -192,7 +192,7 @@ pub const Tool = enum {
.input_schema = url_params_schema,
},
.eval => .{
.description = "Evaluate JavaScript in the current page context. A bare trailing expression yields its value; top-level `await` and `return` are supported (the body then runs as an async function, so use `return` to produce a value). If a url is provided, it navigates to that url first. The `globalThis.lp` object exposes a Session-scoped bridge store: values written via `lp.foo = ...` auto-sync at end of eval, surviving navigation; values previously set via `/extract save=` or `/eval save=` appear as `lp.<name>`.",
.description = "Evaluate JavaScript in the current page context. A bare trailing expression yields its value; top-level `await` and `return` are supported (the body then runs as an async function, so use `return` to produce a value). Objects and arrays are returned as JSON, so no `JSON.stringify` is needed. If a url is provided, it navigates to that url first. The `globalThis.lp` object exposes a Session-scoped bridge store: values written via `lp.foo = ...` auto-sync at end of eval, surviving navigation; values previously set via `/extract save=` or `/eval save=` appear as `lp.<name>`.",
.summary = "Run JavaScript in the page",
.input_schema = minify(
\\{
@@ -202,7 +202,7 @@ pub const Tool = enum {
\\ "url": { "type": "string", "description": "Optional URL to navigate to before evaluating." },
\\ "timeout": { "type": "integer", "description": "Optional timeout in milliseconds. Defaults to 10000." },
\\ "waitUntil": { "type": "string", "enum": ["load", "domcontentloaded", "networkidle", "done"], "description": "Optional wait strategy. Defaults to 'done'." },
\\ "save": { "type": "string", "description": "Optional bridge-store key. The eval's return value is stored under this name and re-exposed as `lp.<name>` to subsequent evals. Value must be JSON; wrap non-strings with JSON.stringify(...)." }
\\ "save": { "type": "string", "description": "Optional bridge-store key. The eval's return value is stored under this name and re-exposed as `lp.<name>` to subsequent evals. Objects and arrays are stored as JSON automatically; a returned value must be JSON-serializable." }
\\ },
\\ "required": ["script"]
\\}