addPathCompletions and ghostPathFirstMatch were ~20-line twins (split
dir/base, openDir, iterate, prefix-match, '/' suffix for directories).
A fix landing in one copy — hidden-file filtering, the shared
symlink-to-directory suffix gap — would make Tab completion and the
ghost hint disagree. Both now consume one PathMatchIterator.
ic_style_def registration lived in setup while the Kind->style switch
lived 600 lines away in IcSink: adding a js_highlight.Kind
compile-errored the sink but silently skipped registration, rendering
the new kind unstyled with no test able to catch it (isocline is
live-only). One table now drives both; an unmapped or doubly-mapped
kind is a compile error.
Completion, ghost hints, and prompt highlighting (~640 lines) were
cohabiting with Terminal's readline lifecycle and output printing. They
now live in prompt_assist.zig, which owns the isocline callbacks, the
ps-* style palette, and the slash-command name table. The C callbacks
read a small prompt_assist.State (js_mode, completion_source,
history_paths) embedded in Terminal, replacing the three loose fields.
Pure code motion otherwise; the valueAt/renderSchemaHint tests move
with their code and stay in the suite via Terminal's test hook.
The numbered/interactive picker (ChoiceState, RawTerminal, render loop)
was ~215 self-contained lines inside Terminal.zig. It runs before - or
without - the isocline REPL (provider selection during setup), so
settings.zig no longer imports the isocline-configured Terminal at all.
Pure code motion; the ChoiceState tests move with it and stay in the
suite via Agent.zig's test hook.
Terminal.columns() had exactly one caller (Spinner's line renderer) and
Terminal itself never used it. Moving it breaks the Spinner<->Terminal
import cycle and stops Spinner type-checking against the isocline
@cImport for one ioctl.
- Add highlighting for JS functions, methods, types, and template
interpolations.
- Introduce teal color and adjust cyan to bright cyan.
- Import `ansi.zig` directly instead of through `Terminal`.
- Add PandaScript semantics note to the agent's system prompt.
- Refactor markdown table rendering and streaming.
Fixes the failing subtest of WPT /dom/nodes/Element-children.html
("HTMLCollection edge cases 1"): iterating an HTMLCollection with
for-in must yield only the supported indices; the supported names are
[LegacyUnenumerableNamedProperties] and must be skipped, while
Object.getOwnPropertyNames still returns indices + names.
v8 filters for-in through the named query interceptor, which
HTMLCollection did not register (only a descriptor callback), so every
name reported by the enumerator was treated as enumerable.
HTMLCollection now registers a named query reporting DontEnum for
supported names. The query deliberately does not report ReadOnly: v8
also consults it when a [[Set]] walks the prototype chain, and a
read-only property on the prototype would block the shadowing expando
that the spec's ignore-named-props rule requires
(HTMLCollection-as-prototype.html). Writability as observed through
getOwnPropertyDescriptor still comes from the descriptor callback, and
direct assignments to supported names still fail through the definer.
Coverage: /dom/nodes/Element-children.html 1/2 -> 2/2 (fully green);
/dom/collections stays fully green (53/53).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the last failing subtest of WPT
/dom/nodes/DOMImplementation-createHTMLDocument.html ("URL parsing"):
resolving `a.href = "http://example.org/?ä"` on an anchor inside a
createHTMLDocument() document returned "?%E4" instead of "?%C3%A4".
Two spec violations combined:
- Per DOM, documents synthesized by script (createHTMLDocument,
createDocument, new Document()) have the UTF-8 encoding. We had no
per-document encoding at all: document.characterSet always reflected
the frame's charset, so the new document inherited windows-1252 from
the test page (which uses that encoding deliberately to catch this).
Document gains a _charset override (same pattern as _content_type),
set to UTF-8 in DOMImplementation.createHTMLDocument/createDocument
and the Document constructor.
- Node.resolveURL encoded the query string with the frame's charset.
Per the URL/HTML specs the query percent-encoding uses the encoding
of the element's node document, so it now resolves the owning
document and uses its encoding, falling back to the frame's.
Coverage:
- /dom/nodes/DOMImplementation-createHTMLDocument.html 12/13 -> 13/13
(fully green)
- /dom/nodes/Document-constructor.html 3/5 -> 4/5
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the remaining 30 failing subtests of WPT
/dom/nodes/Element-matches.html, in five clusters:
Matching (selector/List.zig):
- :link now matches a and area elements with an href attribute (in a
headless browser no link is ever visited, so :visited stays
unmatched and :link covers every hyperlink). :any-link gains the
missing area case.
- :empty now ignores comment and processing-instruction children, per
Selectors Level 3 only elements and non-empty text/cdata affect
emptiness (<p><!-- comment --></p> is :empty, <p> </p> is not).
- :lang() is implemented: the element's language is the nearest
ancestor-or-self lang attribute, falling back to the UA default (en)
for elements in a document and to no language at all in detached
subtrees, which is what the WPT expects for the detached/fragment
contexts. Matching is ASCII case-insensitive on the exact tag or a
`-` separated prefix (:lang(en) matches lang="en-AU").
Parsing (selector/Parser.zig):
- An empty selector-list segment ("div," or ",div") is now a parse
error instead of being silently skipped.
- Unexpected EOF closes open attribute brackets per CSS Syntax:
'#attr-value [align="center"' parses and matches.
- Attribute selectors accept a namespace component: [*|TiTlE] (any
namespace) and [|title] (no namespace). Attributes are stored by
qualified name and almost never namespaced, so both forms match by
name; [*|*=test] stays invalid.
Coverage:
- /dom/nodes/Element-matches.html 639/669 -> 669/669 (fully green)
- /dom/nodes/ParentNode-querySelectors-namespaces.html 0/1 -> 1/1
- /dom/nodes/moveBefore/moveBefore-lang.html 0/1 -> 1/1
- /dom/nodes/moveBefore/Node-moveBefore.html 31/32 -> 32/32
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds top and bottom borders around code blocks, displaying the language
tag if present. Also changes horizontal rules to dashed lines to
distinguish them from code block borders.
- Extract ANSI escape codes to a dedicated `ansi.zig` module.
- Consolidate styled output rendering in `Terminal.zig`.
- Simplify dollar variable highlighting and table measurement.
Extracts the JavaScript highlighting logic from `Terminal.zig` into a
reusable `js_highlight.zig` module. Uses this module to syntax-highlight
markdown fenced code blocks in `md_term.zig` using ANSI escape codes.
Adds finalizers to various types. The two most interesting are ImageData (which
could have a large data field) and HTMLCollection which a page could create
many.
Various Crypto types are also finalized to make sure the key is freed. This is
particularly important for freeing any keys created with EVP_PKEY_new.
Fixes the 34 "wrong global" failures in WPT /dom/nodes/Element-matches.html
(and the equivalent checks in the other selector test files): when a DOM
method is called on a node from another realm (the test roots live in an
iframe), the thrown exception must be created in the receiver's relevant
realm, per Web IDL's "create an exception" using the context object's
realm. The harness checks e.constructor === root.ownerDocument.defaultView
.DOMException, which failed because we always built exceptions in the
caller's context.
The creation context of the wrapper can't be used to find that realm:
wrappers are session-level (one JS wrapper per Zig object, shared across
same-origin contexts). Instead, handleError now resolves the receiver
DOM node's document frame: for functions whose receiver is a Node (or a
type with an asNode() cast), errorLocal maps this -> node -> ownerDocument
-> frame, and if that frame differs from the calling one, the error is
constructed inside that frame's v8 context (entered/exited around the
exception creation).
TaggedOpaque.fromJS also learns to reject objects whose internal field
does not hold an aligned TaggedOpaque pointer. Such objects exist: a
custom element whose constructor throws was created from our template
but never mapped to a Zig instance, and its internal field still holds a
v8 tagged value. errorLocal probes the receiver on every error path, so
without the check the @alignCast panics (caught by the unit test suite's
custom_elements constructor.html).
Coverage: /dom/nodes/Element-matches.html 605/669 -> 639/669.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the failing subtest "hasOwnProperty, getOwnPropertyDescriptor,
getOwnPropertyNames" in WPT /dom/nodes/Document-getElementsByTagName.html
(17/18 -> 18/18) and /dom/nodes/Element-getElementsByTagName.html
(18/19 -> 19/19).
Per the DOM spec's supported property names for HTMLCollection, the
name attribute only exposes elements in the HTML namespace (ids expose
any element). The live-collection getByName fallback matched any
element with a name attribute; it now skips non-HTML elements, matching
the enumerator which already had the guard.
Coverage: Document-getElementsByTagName.html 17/18 -> 18/18,
Element-getElementsByTagName.html 18/19 -> 19/19. /dom/collections
stays fully green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes all 21 failing tests in WPT /dom/nodes/Document-createEvent.https.html
(258/279 -> 279/279), Document-createEvent-touchevent.window.html
(0/3 -> 3/3) and, as a side effect, /dom/events/non-cancelable-when-
passive/synthetic-events-cancelable.html (8/12 -> 12/12).
- Five new event interfaces, following the existing patterns:
BeforeUnloadEvent (returnValue, no constructor per spec), StorageEvent
(key/oldValue/newValue/url + initStorageEvent; storageArea is always
null), DeviceMotionEvent and DeviceOrientationEvent (nullable sensor
values), and TouchEvent (UIEvent subclass with modifier keys and empty
touch lists — there is no touch input source).
- document.createEvent maps their aliases to real instances instead of
plain Events, adds "touchevent", and drops the non-spec pluralized
aliases CustomEvents/FocusEvents/TextEvents, which must throw
NotSupportedError (the unit test asserting the old behavior is
updated).
- The "expose legacy touch event APIs" precondition requires
ontouchstart & co. to exist: the four touch handlers are added to the
global event handler set, HTMLElement and Document.
Coverage: /dom/nodes/Document-createEvent.https.html 258/279 ->
279/279, Document-createEvent-touchevent.window.html 0/3 -> 3/3,
synthetic-events-cancelable.html 8/12 -> 12/12. No regressions across
/dom/events; 1002/1002 unit tests pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
While we do sometimes write functions directly in the JsAPI bridge, this is
usually limited to things that are clearly JS/v8 bridging related. None of the
new getters fit this (admittedly loose) definition..they're accessors like any
other.
Fixes 158 failing tests in WPT
/dom/nodes/DOMImplementation-createDocument.html (276/434 -> 434/434)
and improves Document-createElementNS.html (82/596 -> 197/596),
Document-createElement.html (29/147 -> 34/147),
Document-contentType/createDocument.html (0/1 -> 1/1) and
name-validation.html (0/5 -> 2/5). The remaining failures in those
files need XML/XHTML document loading, which Lightpanda doesn't have.
- Document now implements the DOM spec's §1.4 name validation
productions (valid element/attribute local name, valid namespace
prefix) and the "validate and extract" algorithm, replacing the
older ad-hoc element name check: prefixes are validated, and the
prefix/namespace consistency rules throw NamespaceError (prefix
without namespace, xml/xmlns mismatches).
- createElementNS and DOMImplementation.createDocument route through
it. createDocument also now: treats its two first arguments as
required (namespace via the js.Nullable wrapper, qualifiedName as a
raw js.Value so [LegacyNullToEmptyString] null maps to "" while
undefined stringifies), sets the spec's namespace-dependent
contentType, and registers custom namespace URIs for the root
element.
- element.namespaceURI now returns the actual URI for namespaces
outside the built-in set (it returned a lightpanda.io placeholder),
and Element.clone copies the registration. The unit tests asserting
the placeholder are updated to the correct values.
Coverage: DOMImplementation-createDocument.html 276/434 -> 434/434 and
the improvements above. No regressions across /dom/nodes; 1002/1002
unit tests pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 81 failing tests in WPT
/dom/nodes/DOMImplementation-createDocumentType.html (1/82 -> 82/82):
- DOMImplementation was an empty singleton-style object with no link to
its document, so a doctype created through another document's
implementation (e.g. createHTMLDocument().implementation) reported
the frame's main document as its ownerDocument. The implementation
object now stores its associated document and registers created
doctypes in the frame's node-owner-document map, following the
createDocumentFragment pattern.
- createDocumentType now validates the qualified name against the
doctype name production (no ASCII whitespace or '>'), throwing
InvalidCharacterError.
Coverage: /dom/nodes/DOMImplementation-createDocumentType.html 1/82 ->
82/82.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 4 failing tests in WPT
/dom/lists/DOMTokenList-coverage-for-attributes.html (135/140 ->
139/140): area.relList, output.htmlFor, iframe.sandbox and link.sizes
must be DOMTokenList attributes reflecting their content attributes.
Element gains a generic getTokenList lookup (keyed by element and
attribute) alongside the existing class/rel dedicated ones, and the
four elements expose the accessors following the Anchor/Link relList
pattern (undefined outside the HTML namespace).
The remaining failure needs an SVGAElement interface (relList on SVG
<a> elements), which doesn't exist yet — SVG elements are all generic.
Coverage: /dom/lists/DOMTokenList-coverage-for-attributes.html
135/140 -> 139/140.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 6 failing tests in WPT /dom/idlharness.any.worker.html
(211/219 -> 217/219) and the same assertions in the other idlharness
variants:
- addEventListener/removeEventListener had .length 1 instead of 2 and
accepted being called with a single argument. Per Web IDL their
callback parameter is required but nullable ("EventListener?"), which
a plain Zig optional can't express (the bridge treats optionals as
omittable and stops counting length at the first one). The new
js.Nullable(T) wrapper marks a required argument that accepts null or
undefined: omitting it throws a TypeError and it counts towards the
function's length.
- new AbortSignal() didn't throw: the spec defines no constructor, so
the JsApi constructor is removed (the interface object now uses the
illegal-constructor callback; AbortSignal.init stays for internal
use).
- AbortSignal.any() with no argument didn't throw: the trailing slice
parameter was treated as variadic and defaulted to empty. The
parameter is now a required js.Value converted to the signal sequence
explicitly.
The 2 remaining failures need strict-mode receiver validation on the
flattened worker global and the DOMStringList interface.
Coverage: /dom/idlharness.any.worker.html 211/219 -> 217/219. No
regressions across /dom/events and /dom/abort.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the 32 failing tests in WPT /dom/events/passive-by-default.html
(68/100 -> 100/100): per the DOM spec's "default passive value",
touchstart, touchmove, wheel and mousewheel listeners added to the
Window, the Document, or the html or body elements default to
{passive: true} (so their preventDefault is ignored), unless the
options explicitly say {passive: false}.
addEventListener's options dictionary now keeps `passive` optional so
an absent or undefined member can fall back to the default passive
value computed from the event type and target; an explicit boolean
keeps its meaning.
Coverage: /dom/events/passive-by-default.html 68/100 -> 100/100. No
regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the "Real clicks on disabled elements must not dispatch events"
subtest of WPT /dom/events/Event-dispatch-on-disabled-elements.html
(verified in isolation): a testdriver click on a disabled
button/input/select/textarea must not fire any pointer or mouse events,
while a click on the re-enabled element must. WebDriver.click now
checks the disabled state like HTMLElement.click does.
The file's overall score is unchanged (4/9) because its four CSS
transition/animation subtests hang awaiting animation events (no CSS
animation engine in the renderless browser) and, being sequential
promise_tests, also mask this subtest's result in the full run.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 3 failing tests in WPT /dom/events/Event-dispatch-click.html
(29/33 -> 32/33) and both tests in /dom/events/no-focus-events-at-
clicking-editable-content-in-link.html (1/2 -> 2/2).
- Only a MouseEvent click is an activation event.
- The activation target is the nearest inclusive ancestor with
activation behavior (ancestors only for bubbling events), shared by
ActivationState and handleClick via findClickActivationTarget.
- Clicks on editable content don't activate enclosing links; mousedown
focuses the editing host (CDP and WebDriver paths).
- Interactive submission of a disconnected form does nothing; the
programmatic form.submit() stays exempt per HTML 'cannot navigate'.
The remaining Event-dispatch-click.html failure needs javascript: URL
navigation.
Coverage: Event-dispatch-click.html 29/33 -> 32/33,
no-focus-events-at-clicking-editable-content-in-link.html 1/2 -> 2/2.
No regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 5 failing tests across WPT /dom/events/relatedTarget.window.html
(0/6 -> 3/6) and /dom/events/shadow-relatedTarget.html (0/2 -> 2/2).
The remaining 3 relatedTarget.window.html subtests also fail in Chrome
stable (verified on wpt.fyi), so they are out of scope.
Per the DOM dispatch algorithm:
- The event's relatedTarget is retargeted against the dispatch target
when dispatch starts (Event gains relatedTargetPtr() to reach the
MouseEvent/FocusEvent storage generically), so listeners and
post-dispatch reads observe e.g. the shadow host instead of a node
inside a shadow tree.
- The "clear targets" decision (reset target and relatedTarget to null
when they would expose nodes whose root is a shadow root) is now
computed when the event path is built — on the pre-dispatch tree —
instead of after dispatch, so listeners moving nodes out of the
shadow tree during dispatch can't defeat it, and it now also applies
to relatedTarget, not just target.
Coverage: /dom/events/relatedTarget.window.html 0/6 -> 3/6 (Chrome
parity), /dom/events/shadow-relatedTarget.html 0/2 -> 2/2. No
regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes all 4 failing tests in WPT
/dom/events/Event-timestamp-high-resolution.html: event.timeStamp
returned a raw monotonic-clock value (milliseconds since boot) instead
of a DOMHighResTimeStamp sharing performance.now()'s time origin.
- Events now record their creation time with the same (already
coarsened) clock Performance uses, and the timeStamp getter reports
it in milliseconds relative to the time origin.
- Per spec the origin is the *event's relevant global*'s: the JS Event
constructor captures the creating realm's origin so cross-realm reads
(Event-timestamp-cross-realm-getter.html) stay correct; events
without a captured origin fall back to the accessing realm's, which
is the creating realm in all other paths.
Coverage: /dom/events/Event-timestamp-high-resolution.html 0/4 -> 4/4,
Event-timestamp-cross-realm-getter.html stays 1/1. No regressions
across /dom/events; Event-dispatch-single-activation-behavior.html now
runs (0/0 crash -> 3/132).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the 20 failing tests in WPT /dom/events/EventTarget-
dispatchEvent.html (5/25 -> 25/25), all of the form "If the event's
initialized flag is not set, an InvalidStateError must be thrown".
Per the DOM spec, an event created via document.createEvent has its
initialized flag unset until one of the legacy init*Event methods runs,
and dispatchEvent must throw an InvalidStateError for it. Lightpanda
dispatched such events happily. Event now carries an _initialized flag:
true by default (constructor-created and internal events), cleared by
document.createEvent, and set by initEvent, initCustomEvent,
initUIEvent, initMouseEvent, initKeyboardEvent, initCompositionEvent
and initTextEvent. EventTarget.dispatchEvent rejects uninitialized
events.
document.createEvent also gains the spec-required aliases it was
missing: DragEvent, HashChangeEvent and SVGEvents, plus
BeforeUnloadEvent, DeviceMotionEvent, DeviceOrientationEvent and
StorageEvent mapped to a plain Event (logged as not_implemented) until
those interfaces exist.
Coverage: /dom/events/EventTarget-dispatchEvent.html 5/25 -> 25/25. No
regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the failing test in WPT /dom/events/handler-count.html?window and
?document (1/2 -> 2/2 each): setting `window.onclick` or
`document.onclick` did nothing, because neither interface exposed the
accessor — the assignment created an inert expando and the handler
never fired for clicks bubbling up from the page.
Both now store the handler in the frame's attribute-listener map (the
same mechanism as element and ShadowRoot property handlers), which the
dispatch propagation path already consults for any event target.
Non-callable values clear the handler per [LegacyTreatNonObjectAsNull].
Coverage: /dom/events/handler-count.html?window 1/2 -> 2/2,
/dom/events/handler-count.html?document 1/2 -> 2/2. No regressions
across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the 3 failing tests in WPT /dom/events/event-global.html
(5/8 -> 8/8):
- "window.event is undefined if the target is in a shadow tree" (and
the window.onerror variant): per the DOM invoke algorithm, the
window's current event is only set while invoking listeners whose
invocation target is not in a shadow tree. window.event was set once
for the whole dispatch; it is now set per invocation target (in
dispatchPhase and around inline handler calls), left undefined for
targets whose root is a shadow root.
- "window.event is set to the current event, which is the event passed
to dispatch (2)": script-dispatched events on non-node targets only
ran addEventListener listeners. Property event handlers now fire too:
XMLHttpRequestEventTarget resolves its on* fields by event type, and
the Window's handler fields are consulted both when an event
propagates to the window (getInlineHandler) and when one is
dispatched directly on it.
Coverage: /dom/events/event-global.html 5/8 -> 8/8. No regressions
across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collect types with unforgeable upfront, so that detection in the child is only
O(N) over the very small set of types with an unforgeable property.
Remove duplicate comments.
Fixes the 2 remaining failures in WPT
/dom/events/EventListener-handleEvent.html (4/6 -> 6/6): "throws if
`handleEvent` is falsy/truthy and not callable".
Per the Web IDL callback interface invocation steps, when an object
event listener's handleEvent member is not callable, invoking the
listener reports a TypeError to the global (window.onerror / an "error"
event). Lightpanda silently skipped such listeners.
Listener.run's object branch now performs the Get(handleEvent)
explicitly: a throwing getter is reported like a throwing listener, a
non-callable value reports a TypeError, and only a callable one is
invoked (with exceptions reported as before).
Coverage: /dom/events/EventListener-handleEvent.html 4/6 -> 6/6. No
regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the 3 remaining failures in WPT
/dom/events/Event-subclasses-constructors.html (46/49 -> 49/49): the
"argument with non-default values" cases for MouseEvent, WheelEvent and
KeyboardEvent.
- MouseEvent.button is a WebIDL short: any value (e.g. 40) is allowed.
It was stored as the MouseButton enum and construction threw a
TypeError for values outside the named buttons. The field is now a
raw i16 (the enum remains for the named constants); same fix in
WheelEvent, DragEvent and PointerEvent, and in initMouseEvent.
- KeyboardEvent.location is an unsigned long with the same problem
(Location enum); now stored as a raw u32.
- KeyboardEvent supports the legacy KeyboardEventInit members charCode
and keyCode: synthetic events report the initialized values (still 0
by default), while trusted events keep deriving them from the key.
UIEvent.which now returns keyCode for keyboard events, and clamps
negative mouse buttons instead of overflowing.
Coverage: /dom/events/Event-subclasses-constructors.html 46/49 ->
49/49. No regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 4 failing tests in WPT /dom/events/Event-init-while-dispatching.html
(1/5 -> 5/5), and as a side effect most of
Event-subclasses-constructors.html (16/49 -> 46/49). Three distinct
bugs, all about synthetic (constructor-created) events not following
the spec's dictionary defaults:
- UIEvent.view defaulted to the window: the constructor stored
`opts.view orelse frame.window` and the getter fell back to the
window too, so `new UIEvent("x").view` was never null. Per
UIEventInit, view defaults to null. The window fallback is kept for
*trusted* (browser-generated) UI events only, which do target the
window, so internal dispatch call sites stay unchanged.
- initCustomEvent was missing the "short-circuit while dispatching"
guard that initEvent and the other legacy initializers have.
- KeyboardEvent's constructor unconditionally forced bubbles,
cancelable and composed to true (correct only for trusted key events
per UI Events); synthetic KeyboardEvents now follow the EventInit
defaults.
The unit tests asserting the old view-defaults-to-window behavior are
updated to expect null.
Coverage: /dom/events/Event-init-while-dispatching.html 1/5 -> 5/5,
/dom/events/Event-subclasses-constructors.html 16/49 -> 46/49. No
regressions across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the failing test in WPT /dom/events/Event-isTrusted.any.html (and
its .worker variant): Object.getOwnPropertyDescriptor(event,
"isTrusted") returned undefined because the accessor lived on
Event.prototype. Per Web IDL, isTrusted is [LegacyUnforgeable]: an own,
non-configurable accessor property of every Event instance, with the
same getter function shared between instances.
- bridge.accessor gains an `unforgeable` option. Such accessors are
installed on the class's v8 instance template instead of the
prototype template, so every instance gets an own accessor backed by
one getter function per context.
- Since v8's Inherit only chains prototype templates, attachClass now
walks the ancestor chain (via the _proto fields) and re-installs
ancestors' unforgeable accessors on the subclass's instance template,
so MouseEvent instances & co. get their own isTrusted as well. The
accessor installation code is extracted into attachAccessorProperty
for reuse.
- Event.isTrusted is declared unforgeable and non-deletable.
Coverage: /dom/events/Event-isTrusted.any.html 0/1 -> 1/1,
/dom/events/Event-isTrusted.any.worker.html 0/1 -> 1/1. No regressions
across /dom/events.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adrià Arrufat