Fixes the remaining failures of WPT /dom/nodes/Node-insertBefore.html
(16/40), Node-replaceChild.html (15/29) and Node-appendChild.html
(9/11) - all three are now fully green.
The insertion validity checks were incomplete and ran in the wrong
order:
- The reference-child NotFoundError check ran before the parent-type
and cycle checks, but per "ensure pre-insert validity" the
HierarchyRequestError checks for the parent kind and for node being
an inclusive ancestor of parent come first.
- Inserting a Document node was not rejected.
- DocumentFragment insertion into a document skipped validation
entirely: fragments with multiple elements, with a Text child, or
whose element joins an existing document element now throw.
- The doctype rules were missing: a second doctype, a doctype inserted
after an element, and an element inserted before a doctype all throw,
with replaceChild's variants (the replaced child doesn't count).
- replaceChild threw HierarchyRequestError for a child with the wrong
parent; the spec requires NotFoundError (unit test updated
accordingly).
- insertBefore's reference-child argument is required-but-nullable per
WebIDL: omitting it is now a TypeError (js.Nullable), while passing
null still appends.
appendChild/insertBefore/replaceChild now share ensurePreInsertValidity
(insert and replace modes); replaceChildren keeps its replace-all
validation.
Coverage:
- /dom/nodes/Node-insertBefore.html 16/40 -> 40/40 (fully green)
- /dom/nodes/Node-replaceChild.html 15/29 -> 29/29 (fully green)
- /dom/nodes/Node-appendChild.html 9/11 -> 11/11 (fully green)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes WPT /dom/traversal/NodeIterator-removal.html (0/23 -> 23/23) and
/dom/nodes/moveBefore/moveBefore-nodeiterator.html: removing a node
that is an inclusive ancestor of a live NodeIterator's reference node
must move the reference per the DOM pre-removing steps. We never
adjusted iterators, so the reference kept pointing into the detached
subtree.
The frame keeps an intrusive list of live NodeIterators (mirroring
_live_ranges; iterators are slab-allocated for the frame lifetime, so
they are never unlinked) and Frame.removeNode runs the steps while the
tree is still intact:
- removing the root or an ancestor of the root leaves the iterator
untouched (matching browsers and the WPT model);
- with the pointer before the reference, the reference moves to the
first node following the removed subtree, if any;
- otherwise (or when there is no such node) it moves to the node
immediately preceding the removed node in tree order, clearing the
before-pointer in the fallthrough case.
Coverage:
- /dom/traversal/NodeIterator-removal.html 0/23 -> 23/23 (fully green)
- /dom/nodes/moveBefore/moveBefore-nodeiterator.html 0/1 -> 1/1
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the 5 failing subtests of WPT
/dom/traversal/TreeWalker-acceptNode-filter.html (7/12 -> 12/12):
- A filter object was converted eagerly at createTreeWalker time, so an
object without a callable acceptNode threw "invalid argument" at
creation. Per WebIDL any object converts to the NodeFilter callback
interface; the TypeError belongs at invocation time.
- The acceptNode member was cached at conversion. Per "call a user
object's operation" it must be looked up with a fresh Get on every
traversal, rethrowing errors from a throwing getter.
- The callback was invoked with the default this; the spec requires the
filter object itself as the this value.
NodeFilter now stores the raw function or object (js.Object.Global) and
performs the per-invocation lookup, callability check and this-binding
in acceptNode.
Coverage: /dom/traversal/TreeWalker-acceptNode-filter.html 7/12 ->
12/12 (fully green).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the last failing subtest of WPT /dom/traversal/TreeWalker.html
("Recursive filters need to throw"): per the DOM traversal "filter"
algorithm, a NodeFilter that re-enters the walker (calling parentNode()
etc. from inside the callback) must get an InvalidStateError.
DOMTreeWalker tracks an active flag around the filter invocation and
throws InvalidStateError when a traversal starts while it is set.
Coverage: /dom/traversal/TreeWalker.html 760/761 -> 761/761 (fully
green).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes WPT /dom/traversal/TreeWalker-previousSiblingLastChildSkip.html
and 59 subtests of TreeWalker.html (701/761 -> 760/761):
TreeWalker.previousSibling()/nextSibling() only scanned the current
node's direct siblings, but the spec's "traverse siblings" algorithm
also:
- descends into a skipped (FILTER_SKIP) sibling's children - only a
rejected sibling excludes its whole subtree - so from B2 with B1
skipped, previousSibling() must return B1's last child;
- climbs to the parent when the siblings are exhausted and continues
from the parent's siblings, stopping at the root or at an accepted
parent.
Both directions now share the spec's traverseSiblings implementation.
Coverage:
- /dom/traversal/TreeWalker-previousSiblingLastChildSkip.html 0/1 -> 1/1
(fully green)
- /dom/traversal/TreeWalker.html 701/761 -> 760/761
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review pattern from #2943: prefer the local arena for scratch-only
allocations. The collected row list is only read before deleteRow's
removeChild call - the one point that can re-enter JS - so it does not
need to survive a nested callback.
Co-Authored-By: Karl Seguin <karlseguin@users.noreply.github.com>
Fixes the remaining failures of WPT /dom/ranges/Range-selectNode.html
(288/292) and improves several other /dom/ranges files: for
CharacterData, the DOM "node length" is the data length in UTF-16 code
units, but Node.getLength returned the UTF-8 byte length, so
selectNodeContents() on text containing non-ASCII set endOffset to the
byte count (25 instead of 17 in the test's fixture).
Node.getLength now defers to CData.getLength (already UTF-16). Since
Range/Selection offsets are therefore UTF-16 units, the Range routines
that slice the UTF-8 data by offset (insertNode's text split,
deleteContents, cloneContents, toString) convert them with
utf16OffsetToUtf8 (clamped to the end) instead of using them as byte
indices, which would cut surrogate pairs and multi-byte sequences
apart.
Coverage:
- /dom/ranges/Range-selectNode.html 288/292 -> 292/292 (fully green)
- /dom/ranges/Range-deleteContents.html 95/125 -> 105/125
- /dom/ranges/Range-extractContents.html 128/187 -> 141/187
- /dom/ranges/Range-cloneContents.html 168/187 -> 171/187
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes WPT /dom/nodes/Text-wholeText.html: wholeText must return the
concatenated data of the contiguous exclusive Text nodes (adjacent Text
siblings on both sides of the node) in tree order; we returned only the
node's own data.
The old own-data behavior is what every internal caller (semantic tree,
markdown dump, AX names, textarea default value, textContent) actually
wants, since they iterate the text nodes themselves; those now use the
new Text.ownData helper, and getWholeText implements the spec walk
(single-node case stays allocation-free).
Coverage: /dom/nodes/Text-wholeText.html 0/1 -> 1/1 (fully green).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 7 failing WPT /dom/nodes/getElementsByClassName-*.htm files:
- Class attribute matching (getElementsByClassName and .class
selectors) treated only the space character as a token separator, so
class="a\nb" or class="a\tb" never matched "a". Per the spec the
separators are ASCII whitespace (tab, LF, FF, CR, space);
classAttributeContains now accepts all of them at token boundaries
(deliberately not std.ascii.isWhitespace, which would also accept
vertical tab). Fixes getElementsByClassName-02/04/15/22/25.
- getElementsByClassName-20 exercised table.tBodies[0].rows[0].cells[0]
and -21 table.deleteRow(1); the table interfaces were bare stubs.
Added HTMLTableElement.tBodies (child tbody collection),
HTMLTableSectionElement.rows (child tr collection),
HTMLTableRowElement.cells (child td/th collection, a new `cells`
NodeLive mode since child_tag filters a single tag), and
HTMLTableElement.deleteRow with the spec's row ordering (thead rows,
then table/tbody rows in tree order, then tfoot rows), -1 meaning the
last row, and IndexSizeError for out-of-range indices.
Coverage: getElementsByClassName-02/04/15/20/21/22/25.htm each
0/1 -> 1/1 (fully green).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Add highlighting for JS functions, methods, types, and template
interpolations.
- Introduce teal color and adjust cyan to bright cyan.
- Import `ansi.zig` directly instead of through `Terminal`.
- Add PandaScript semantics note to the agent's system prompt.
- Refactor markdown table rendering and streaming.
Fixes WPT /dom/nodes/MutationObserver-inner-outer.html (0/3 -> 3/3):
setting innerHTML must queue a single "replace all" mutation record
(all removed children + all parsed children), and setting outerHTML a
single record replacing the element with the parsed nodes. We emitted
one record per removed child plus one per inserted child.
- Node.setHTML suppresses per-node records (removals via the new
notify_observers opt, insertions by making fragment parsing never
notify) and queues the combined record itself. Parsing still targets
the element directly so html5ever keeps the right fragment context
(e.g. raw-text content of <script>).
- Fragment parsing no longer notifies observers per inserted child:
every other fragment-parse target is a detached DocumentFragment
where notification is a no-op.
- Element.setOuterHTML moves the parsed nodes in with notification
suppressed and queues one record with removedNodes=[the element],
addedNodes=parsed children and the element's siblings.
- The unit test mutation_observer/childlist.html expected the old
6-record innerHTML behavior; updated to the spec's single record
(matches Chrome).
Coverage: /dom/nodes/MutationObserver-inner-outer.html 0/3 -> 3/3
(fully green).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes WPT /dom/nodes/MutationObserver-textContent.html (1/4) and the
remaining failures of ParentNode-replaceChildren.html (25/29): the DOM
"replace all" algorithm (Element.textContent setter,
ParentNode.replaceChildren) must queue a single tree mutation record
with all removedNodes and addedNodes (and null previous/next sibling).
We emitted one record per removed child plus one per added child, so
observers saw 2+ records where the spec requires exactly one.
Frame.removeNode/appendNode gain a notify_observers opt (default true);
Node.replaceChildren suppresses the per-node records and queues the
combined record itself. Removing an added child from its previous
parent still notifies that parent's observers separately, as the spec
requires.
Coverage:
- /dom/nodes/MutationObserver-textContent.html 1/4 -> 4/4 (fully green)
- /dom/nodes/ParentNode-replaceChildren.html 25/29 -> 29/29 (fully green)
- /dom/nodes/MutationObserver-childList.html 29/38 -> 30/38
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes WPT /dom/nodes/MutationObserver-callback-arguments.html: per the
DOM spec ("invoke callback with a list of MutationRecord objects and mo,
and mo as callback this value"), the mutation callback's this value must
be the MutationObserver itself. We invoked it with the default receiver
(undefined -> globalThis), so `this === mo` failed.
deliverRecords now uses tryCallWithThis with the observer as receiver.
Coverage: /dom/nodes/MutationObserver-callback-arguments.html 0/1 -> 1/1
(fully green).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes all failing subtests of WPT /dom/nodes/Element-insertAdjacentElement.html
(1/6), Element-insertAdjacentText.html (5/6) and insert-adjacent.html (11/14):
- insertAdjacentElement/Text wrongly reused insertAdjacentHTML's rule of
throwing NoModificationAllowedError for a null or document parent. Per
DOM's insert-adjacent algorithm they instead return null (no-op) for a
null parent and otherwise rely on pre-insert validity, so inserting
before/after the document element reports HierarchyRequestError.
findAdjacentNodes takes the variant; insertAdjacentHTML keeps its
HTML-spec behavior.
- insertAdjacentElement now returns the inserted element (was void, so
scripts using the return value got undefined).
- The pre-insert validity checks did not implement the document-parent
rules: a document can't contain Text children and has at most one
element child. validateDocumentInsertion enforces both in
appendChild/insertBefore/replaceChild; replaceChild excludes the child
being replaced from the single-element rule, and replaceChildren
(which replaces every child) is intentionally unaffected.
Coverage:
- /dom/nodes/Element-insertAdjacentElement.html 1/6 -> 6/6 (fully green)
- /dom/nodes/Element-insertAdjacentText.html 5/6 -> 6/6 (fully green)
- /dom/nodes/insert-adjacent.html 11/14 -> 14/14 (fully green)
- /dom/nodes/Node-insertBefore.html 13/40 -> 16/40
- /dom/nodes/Node-replaceChild.html 14/29 -> 15/29
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the failing subtest of WPT /dom/nodes/Element-children.html
("HTMLCollection edge cases 1"): iterating an HTMLCollection with
for-in must yield only the supported indices; the supported names are
[LegacyUnenumerableNamedProperties] and must be skipped, while
Object.getOwnPropertyNames still returns indices + names.
v8 filters for-in through the named query interceptor, which
HTMLCollection did not register (only a descriptor callback), so every
name reported by the enumerator was treated as enumerable.
HTMLCollection now registers a named query reporting DontEnum for
supported names. The query deliberately does not report ReadOnly: v8
also consults it when a [[Set]] walks the prototype chain, and a
read-only property on the prototype would block the shadowing expando
that the spec's ignore-named-props rule requires
(HTMLCollection-as-prototype.html). Writability as observed through
getOwnPropertyDescriptor still comes from the descriptor callback, and
direct assignments to supported names still fail through the definer.
Coverage: /dom/nodes/Element-children.html 1/2 -> 2/2 (fully green);
/dom/collections stays fully green (53/53).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the last failing subtest of WPT
/dom/nodes/DOMImplementation-createHTMLDocument.html ("URL parsing"):
resolving `a.href = "http://example.org/?ä"` on an anchor inside a
createHTMLDocument() document returned "?%E4" instead of "?%C3%A4".
Two spec violations combined:
- Per DOM, documents synthesized by script (createHTMLDocument,
createDocument, new Document()) have the UTF-8 encoding. We had no
per-document encoding at all: document.characterSet always reflected
the frame's charset, so the new document inherited windows-1252 from
the test page (which uses that encoding deliberately to catch this).
Document gains a _charset override (same pattern as _content_type),
set to UTF-8 in DOMImplementation.createHTMLDocument/createDocument
and the Document constructor.
- Node.resolveURL encoded the query string with the frame's charset.
Per the URL/HTML specs the query percent-encoding uses the encoding
of the element's node document, so it now resolves the owning
document and uses its encoding, falling back to the frame's.
Coverage:
- /dom/nodes/DOMImplementation-createHTMLDocument.html 12/13 -> 13/13
(fully green)
- /dom/nodes/Document-constructor.html 3/5 -> 4/5
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the remaining 30 failing subtests of WPT
/dom/nodes/Element-matches.html, in five clusters:
Matching (selector/List.zig):
- :link now matches a and area elements with an href attribute (in a
headless browser no link is ever visited, so :visited stays
unmatched and :link covers every hyperlink). :any-link gains the
missing area case.
- :empty now ignores comment and processing-instruction children, per
Selectors Level 3 only elements and non-empty text/cdata affect
emptiness (<p><!-- comment --></p> is :empty, <p> </p> is not).
- :lang() is implemented: the element's language is the nearest
ancestor-or-self lang attribute, falling back to the UA default (en)
for elements in a document and to no language at all in detached
subtrees, which is what the WPT expects for the detached/fragment
contexts. Matching is ASCII case-insensitive on the exact tag or a
`-` separated prefix (:lang(en) matches lang="en-AU").
Parsing (selector/Parser.zig):
- An empty selector-list segment ("div," or ",div") is now a parse
error instead of being silently skipped.
- Unexpected EOF closes open attribute brackets per CSS Syntax:
'#attr-value [align="center"' parses and matches.
- Attribute selectors accept a namespace component: [*|TiTlE] (any
namespace) and [|title] (no namespace). Attributes are stored by
qualified name and almost never namespaced, so both forms match by
name; [*|*=test] stays invalid.
Coverage:
- /dom/nodes/Element-matches.html 639/669 -> 669/669 (fully green)
- /dom/nodes/ParentNode-querySelectors-namespaces.html 0/1 -> 1/1
- /dom/nodes/moveBefore/moveBefore-lang.html 0/1 -> 1/1
- /dom/nodes/moveBefore/Node-moveBefore.html 31/32 -> 32/32
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds top and bottom borders around code blocks, displaying the language
tag if present. Also changes horizontal rules to dashed lines to
distinguish them from code block borders.
- Extract ANSI escape codes to a dedicated `ansi.zig` module.
- Consolidate styled output rendering in `Terminal.zig`.
- Simplify dollar variable highlighting and table measurement.
Extracts the JavaScript highlighting logic from `Terminal.zig` into a
reusable `js_highlight.zig` module. Uses this module to syntax-highlight
markdown fenced code blocks in `md_term.zig` using ANSI escape codes.
Adds finalizers to various types. The two most interesting are ImageData (which
could have a large data field) and HTMLCollection which a page could create
many.
Various Crypto types are also finalized to make sure the key is freed. This is
particularly important for freeing any keys created with EVP_PKEY_new.
Fixes the 34 "wrong global" failures in WPT /dom/nodes/Element-matches.html
(and the equivalent checks in the other selector test files): when a DOM
method is called on a node from another realm (the test roots live in an
iframe), the thrown exception must be created in the receiver's relevant
realm, per Web IDL's "create an exception" using the context object's
realm. The harness checks e.constructor === root.ownerDocument.defaultView
.DOMException, which failed because we always built exceptions in the
caller's context.
The creation context of the wrapper can't be used to find that realm:
wrappers are session-level (one JS wrapper per Zig object, shared across
same-origin contexts). Instead, handleError now resolves the receiver
DOM node's document frame: for functions whose receiver is a Node (or a
type with an asNode() cast), errorLocal maps this -> node -> ownerDocument
-> frame, and if that frame differs from the calling one, the error is
constructed inside that frame's v8 context (entered/exited around the
exception creation).
TaggedOpaque.fromJS also learns to reject objects whose internal field
does not hold an aligned TaggedOpaque pointer. Such objects exist: a
custom element whose constructor throws was created from our template
but never mapped to a Zig instance, and its internal field still holds a
v8 tagged value. errorLocal probes the receiver on every error path, so
without the check the @alignCast panics (caught by the unit test suite's
custom_elements constructor.html).
Coverage: /dom/nodes/Element-matches.html 605/669 -> 639/669.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes the failing subtest "hasOwnProperty, getOwnPropertyDescriptor,
getOwnPropertyNames" in WPT /dom/nodes/Document-getElementsByTagName.html
(17/18 -> 18/18) and /dom/nodes/Element-getElementsByTagName.html
(18/19 -> 19/19).
Per the DOM spec's supported property names for HTMLCollection, the
name attribute only exposes elements in the HTML namespace (ids expose
any element). The live-collection getByName fallback matched any
element with a name attribute; it now skips non-HTML elements, matching
the enumerator which already had the guard.
Coverage: Document-getElementsByTagName.html 17/18 -> 18/18,
Element-getElementsByTagName.html 18/19 -> 19/19. /dom/collections
stays fully green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes all 21 failing tests in WPT /dom/nodes/Document-createEvent.https.html
(258/279 -> 279/279), Document-createEvent-touchevent.window.html
(0/3 -> 3/3) and, as a side effect, /dom/events/non-cancelable-when-
passive/synthetic-events-cancelable.html (8/12 -> 12/12).
- Five new event interfaces, following the existing patterns:
BeforeUnloadEvent (returnValue, no constructor per spec), StorageEvent
(key/oldValue/newValue/url + initStorageEvent; storageArea is always
null), DeviceMotionEvent and DeviceOrientationEvent (nullable sensor
values), and TouchEvent (UIEvent subclass with modifier keys and empty
touch lists — there is no touch input source).
- document.createEvent maps their aliases to real instances instead of
plain Events, adds "touchevent", and drops the non-spec pluralized
aliases CustomEvents/FocusEvents/TextEvents, which must throw
NotSupportedError (the unit test asserting the old behavior is
updated).
- The "expose legacy touch event APIs" precondition requires
ontouchstart & co. to exist: the four touch handlers are added to the
global event handler set, HTMLElement and Document.
Coverage: /dom/nodes/Document-createEvent.https.html 258/279 ->
279/279, Document-createEvent-touchevent.window.html 0/3 -> 3/3,
synthetic-events-cancelable.html 8/12 -> 12/12. No regressions across
/dom/events; 1002/1002 unit tests pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
While we do sometimes write functions directly in the JsAPI bridge, this is
usually limited to things that are clearly JS/v8 bridging related. None of the
new getters fit this (admittedly loose) definition..they're accessors like any
other.
Fixes 158 failing tests in WPT
/dom/nodes/DOMImplementation-createDocument.html (276/434 -> 434/434)
and improves Document-createElementNS.html (82/596 -> 197/596),
Document-createElement.html (29/147 -> 34/147),
Document-contentType/createDocument.html (0/1 -> 1/1) and
name-validation.html (0/5 -> 2/5). The remaining failures in those
files need XML/XHTML document loading, which Lightpanda doesn't have.
- Document now implements the DOM spec's §1.4 name validation
productions (valid element/attribute local name, valid namespace
prefix) and the "validate and extract" algorithm, replacing the
older ad-hoc element name check: prefixes are validated, and the
prefix/namespace consistency rules throw NamespaceError (prefix
without namespace, xml/xmlns mismatches).
- createElementNS and DOMImplementation.createDocument route through
it. createDocument also now: treats its two first arguments as
required (namespace via the js.Nullable wrapper, qualifiedName as a
raw js.Value so [LegacyNullToEmptyString] null maps to "" while
undefined stringifies), sets the spec's namespace-dependent
contentType, and registers custom namespace URIs for the root
element.
- element.namespaceURI now returns the actual URI for namespaces
outside the built-in set (it returned a lightpanda.io placeholder),
and Element.clone copies the registration. The unit tests asserting
the placeholder are updated to the correct values.
Coverage: DOMImplementation-createDocument.html 276/434 -> 434/434 and
the improvements above. No regressions across /dom/nodes; 1002/1002
unit tests pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 81 failing tests in WPT
/dom/nodes/DOMImplementation-createDocumentType.html (1/82 -> 82/82):
- DOMImplementation was an empty singleton-style object with no link to
its document, so a doctype created through another document's
implementation (e.g. createHTMLDocument().implementation) reported
the frame's main document as its ownerDocument. The implementation
object now stores its associated document and registers created
doctypes in the frame's node-owner-document map, following the
createDocumentFragment pattern.
- createDocumentType now validates the qualified name against the
doctype name production (no ASCII whitespace or '>'), throwing
InvalidCharacterError.
Coverage: /dom/nodes/DOMImplementation-createDocumentType.html 1/82 ->
82/82.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes 4 failing tests in WPT
/dom/lists/DOMTokenList-coverage-for-attributes.html (135/140 ->
139/140): area.relList, output.htmlFor, iframe.sandbox and link.sizes
must be DOMTokenList attributes reflecting their content attributes.
Element gains a generic getTokenList lookup (keyed by element and
attribute) alongside the existing class/rel dedicated ones, and the
four elements expose the accessors following the Anchor/Link relList
pattern (undefined outside the HTML namespace).
The remaining failure needs an SVGAElement interface (relList on SVG
<a> elements), which doesn't exist yet — SVG elements are all generic.
Coverage: /dom/lists/DOMTokenList-coverage-for-attributes.html
135/140 -> 139/140.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
