Files
browser/src/Inbox.zig
T

437 lines
14 KiB
Zig

// Copyright (C) 2023-2026 Lightpanda (Selecy SAS)
//
// Francis Bouvier <francis@lightpanda.io>
// Pierre Tachoire <pierre@lightpanda.io>
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
// Thread-safe FIFO of Messages. Producer pushes from one thread,
// consumer pops from another. No wake mechanism is bundled — callers
// arrange that themselves (e.g. curl_multi_wakeup on the consumer's
// curl multi handle).
//
// Backed by a DoublyLinkedList so that pop is O(1) and the
// allowlist-during-sync-wait drain can cherry-pick messages out of
// the middle in O(1) given a node pointer.
const std = @import("std");
const lp = @import("lightpanda");
const CDP = @import("server/cdp/CDP.zig");
const Link = @import("server/Link.zig");
const DoublyLinkedList = std.DoublyLinkedList;
const Inbox = @This();
mutex: std.Io.Mutex = .init,
queue: DoublyLinkedList = .{},
// Payload bytes sitting in the queue. Used to disconnect a client if we've
// fallen too far behind (largely to protect against a misbehaving client)
queued_bytes: usize = 0,
pub fn deinit(self: *Inbox) void {
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
while (self.queue.popFirst()) |node| {
const msg: *Message = @fieldParentPtr("node", node);
msg.discard();
}
self.queued_bytes = 0;
}
pub fn queuedBytes(self: *Inbox) usize {
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
return self.queued_bytes;
}
pub fn isEmpty(self: *Inbox) bool {
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
return self.queue.first == null;
}
pub fn push(self: *Inbox, arena: *lp.Arena, payload: Message.Payload) void {
const msg = arena.create(Message) catch |err| switch (err) {
error.OutOfMemory => @panic("OOM"),
};
msg.* = .{ .payload = payload, .arena = arena };
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
self.queued_bytes += payload.size();
self.queue.append(&msg.node);
}
pub fn pop(self: *Inbox) ?*Message {
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
const node = self.queue.popFirst() orelse return null;
const msg: *Message = @fieldParentPtr("node", node);
self.queued_bytes -= msg.payload.size();
return msg;
}
// Peek for a message matching `predicate` without removing it. Used by
// syncRequest to notice a queued teardown command (which sync_wait can't
// safely dispatch mid-parse) so it can abort the blocking fetch instead
// of stalling for the full per-request timeout.
pub fn contains(self: *Inbox, predicate: *const fn (*Message) bool) bool {
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
var it = self.queue.first;
while (it) |node| : (it = node.next) {
const msg: *Message = @fieldParentPtr("node", node);
if (predicate(msg)) return true;
}
return false;
}
// Cherry-pick the first message for which `predicate(msg)` returns
// true, removing it from the queue. Walks the queue in FIFO order;
// non-matching messages stay in place. Used to dispatch only the
// safe subset of messages during sync-wait paths (the allowlist),
// while leaving unsafe ones to be drained at the next safe point.
pub fn popIf(self: *Inbox, predicate: *const fn (*Message) bool) ?*Message {
self.mutex.lockUncancelable(lp.io);
defer self.mutex.unlock(lp.io);
var it = self.queue.first;
while (it) |node| : (it = node.next) {
const msg: *Message = @fieldParentPtr("node", node);
if (predicate(msg)) {
self.queue.remove(node);
self.queued_bytes -= msg.payload.size();
return msg;
}
}
return null;
}
pub const Message = struct {
arena: *lp.Arena,
payload: Payload,
node: DoublyLinkedList.Node = .{},
pub const Payload = union(enum) {
// A CDP text/binary frame, parsed on the Network thread. `raw`
// is the original JSON bytes (owned). `arena` holds any
// auxiliary allocations from parseFromSliceLeaky (typically
// empty for unescaped messages, but slices in `input` may
// reference it). `input` is the parsed view; its string
// slices reference `raw` or `arena`. Both must outlive the
// consumer's use of `input`.
cdp: Cdp,
// A BiDi text/binary frame, raw (owned). Unlike CDP it isn't
// parsed on the Network thread — nothing on that side needs the
// method name yet.
bidi: []u8,
// WS ping frame body (≤125 bytes per spec). Consumer is
// expected to echo via pong on its thread.
ping: []u8,
// A close frame was received from the peer. Consumer is expected to
// send the close frame and tear the connection down. This may or may
// not kill the worker (up to the driver, CDP: always yes, WebDriver:
// depends)
close: void,
// The Session is over. Currently WebDriver only. Always kills the worker.
// This is because for WebDriver, the Worker isn't necessarily tied to
// a WebSocket connection, so only an explicit DELETE /session/:id (or
// the HTTP reaper) can kill it. tl;dr an explicit "close" needed for
// WebDriver since the implicit socket-is-gone (aka .close) is ambiguous
// for WebDriver.
quit: void,
// No allocation; conveys "no more messages will arrive on
// this inbox" plus an optional reason. The Network thread
// pushes this on peer EOF, fatal WS framing error, or
// (now) JSON parse failure.
disconnect: ?anyerror,
// A websocket for the consumer to adopt (an HTTP WebDriver session
// gets its BiDi connection after the fact).
link: *Link,
pub fn size(self: Payload) usize {
return switch (self) {
.cdp => |c| c.raw.len,
.bidi, .ping => |b| b.len,
.close, .disconnect, .link, .quit => 0,
};
}
};
pub const Cdp = struct {
raw: []u8,
input: CDP.InputMessage,
};
pub fn deinit(self: *const Message) void {
self.arena.release();
}
// For messages that never reached the consumer (Inbox.deinit).
fn discard(self: *const Message) void {
switch (self.payload) {
.link => |link| link.destroy(),
else => {},
}
self.deinit();
}
};
const testing = @import("testing.zig");
test "Inbox: push then pop returns FIFO order" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
defer inbox.deinit();
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "first") });
}
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "second") });
}
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .disconnect = null });
}
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expectEqual("first", m.payload.ping);
}
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expectEqual("second", m.payload.ping);
}
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expectEqual(@as(?anyerror, null), m.payload.disconnect);
}
try testing.expect(inbox.pop() == null);
}
test "Inbox: deinit frees remaining items" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "leftover") });
}
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .disconnect = error.PeerClosed });
}
inbox.deinit();
// Memory leaks would be caught by the test runner.
}
fn testAlwaysTrue(_: *Message) bool {
return true;
}
fn testAlwaysFalse(_: *Message) bool {
return false;
}
fn testIsPing(msg: *Message) bool {
return msg.payload == .ping;
}
test "Inbox: popIf on empty queue returns null" {
var inbox = Inbox{};
defer inbox.deinit();
try testing.expect(inbox.popIf(testAlwaysTrue) == null);
}
test "Inbox: popIf with no match leaves queue intact" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
defer inbox.deinit();
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "first") });
}
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "second") });
}
try testing.expect(inbox.popIf(testAlwaysFalse) == null);
// Original FIFO order preserved.
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expectEqual("first", m.payload.ping);
}
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expectEqual("second", m.payload.ping);
}
try testing.expect(inbox.pop() == null);
}
test "Inbox: popIf with always-true predicate behaves like pop" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
defer inbox.deinit();
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "a") });
}
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "b") });
}
{
const m = inbox.popIf(testAlwaysTrue).?;
defer m.deinit();
try testing.expectEqual("a", m.payload.ping);
}
{
const m = inbox.popIf(testAlwaysTrue).?;
defer m.deinit();
try testing.expectEqual("b", m.payload.ping);
}
try testing.expect(inbox.popIf(testAlwaysTrue) == null);
}
test "Inbox: popIf cherry-picks middle, preserves order of remainder" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
defer inbox.deinit();
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .disconnect = null });
}
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "middle") });
}
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .disconnect = error.PeerClosed });
}
// testIsPing skips the disconnect at the head and picks the middle.
{
const m = inbox.popIf(testIsPing).?;
defer m.deinit();
try testing.expectEqual("middle", m.payload.ping);
}
// Remaining two disconnects pop in original order.
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expect(m.payload.disconnect == null);
}
{
const m = inbox.pop().?;
defer m.deinit();
try testing.expect(m.payload.disconnect.? == error.PeerClosed);
}
try testing.expect(inbox.pop() == null);
}
test "Inbox: popIf picks first match in FIFO order" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
defer inbox.deinit();
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "first") });
}
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .disconnect = null });
}
{
const arena = try arena_pool.acquire(.tiny, "popif test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "second") });
}
const m = inbox.popIf(testIsPing).?;
defer m.deinit();
try testing.expectEqual("first", m.payload.ping);
}
test "Inbox: queued bytes track the payloads" {
const arena_pool = &testing.test_app.arena_pool;
var inbox = Inbox{};
defer inbox.deinit();
try testing.expectEqual(0, inbox.queuedBytes());
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .ping = try arena.dupe(u8, "12345") });
}
try testing.expectEqual(5, inbox.queuedBytes());
{
// control payloads are free; only what the peer sends counts
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .disconnect = null });
}
try testing.expectEqual(5, inbox.queuedBytes());
{
const arena = try arena_pool.acquire(.tiny, "inbox test");
inbox.push(arena, .{ .bidi = try arena.dupe(u8, "abc") });
}
try testing.expectEqual(8, inbox.queuedBytes());
// popIf cherry-picks out of the middle, and has to pay the same toll
{
const m = inbox.popIf(struct {
fn f(msg: *Message) bool {
return msg.payload == .bidi;
}
}.f).?;
defer m.deinit();
}
try testing.expectEqual(5, inbox.queuedBytes());
{
const m = inbox.pop().?;
defer m.deinit();
}
try testing.expectEqual(0, inbox.queuedBytes());
}