mirror/cryptomator
1
0
Fork 0
mirror of https://github.com/cryptomator/cryptomator.git synced 2026-04-20 01:26:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

Reverted ab538cd215

Browse Source
This commit is contained in:
JaniruTEC
2020-10-08 18:51:03 +02:00
parent 7781572b6d
commit 6b6867b826
1 changed files with 3 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
main/commons/src/main/java/org/cryptomator/common/mountpoint/MountPointChooser.java
View File

@@ -1,6 +1,5 @@
package org.cryptomator.common.mountpoint;
import com.google.common.base.Preconditions;
import org.cryptomator.common.vaults.Volume;
import java.nio.file.Path;
@@ -155,31 +154,11 @@ public interface MountPointChooser extends Comparable<MountPointChooser> {
* <p>{@inheritDoc}
*
* @implNote This default implementation sorts the MPCs in ascending order
* of their {@link #getPriority() priority.} It depends on a correct implementation
* of {@link #hashCode()} and {@link #equals(Object)} for the compared objects.
* For this implementation "the least required correct implementation" maps
* the following relationship correctly:<br>
* If the objects {@code a} and {@code b} are {@code equal} as determined by
* {@code #equals(Object)} then the {@code hashCodes} as determined by {@code #hashCode()}
* of {@code a} and {@code b} must be equal. If the objects are {@code not equal}
* then the {@code hashCodes} must be different.<br>
* The default implementations of those two methods are sufficient.
* @see Object#hashCode()
* @see Object#equals(Object)
* of their {@link #getPriority() priority.}
*/
@Override
default int compareTo(MountPointChooser other) {
Preconditions.checkNotNull(other, "Other must not be null!");
//Try to compare by priority and sort in ascending order.
//1) Compare the priorities.
//2) If the result of the comparison is 0 because the priorities are equal,
// we consider this a failure. In this case sort by hashCode (step 3).
// Else return the result of the comparison.
//3) Return the result of the comparison of the hashCodes:
// Either 0 (because they are equal and that's why they had the same priority)
// or a non-null int (because they only share the priority).
int compResult = /* 1 */ Integer.compare(this.getPriority(), other.getPriority());
return compResult != 0 ? /* 2 */ compResult : /* 3 */ Integer.compare(this.hashCode(), other.hashCode());
//Sort by priority (ascending order)
return Integer.compare(this.getPriority(), other.getPriority());
}
}