Enable strict mode for debugging; use thread for DB changes in AccountActivity

app/src/main/java/at/bitfire/davdroid/App.kt

@@ -15,6 +15,7 @@ import android.content.IntentFilter
 import android.graphics.Bitmap
 import android.graphics.drawable.BitmapDrawable
 import android.os.Build
+import android.os.StrictMode
 import android.support.v7.app.AppCompatDelegate
 import at.bitfire.davdroid.log.Logger
 import at.bitfire.davdroid.ui.NotificationUtils
@@ -67,6 +68,23 @@ class App: Application() {
         super.onCreate()
         Logger.initialize(this)
 
+        if (BuildConfig.DEBUG) {
+            StrictMode.setVmPolicy(StrictMode.VmPolicy.Builder()
+                    .detectActivityLeaks()
+                    .detectFileUriExposure()
+                    .detectLeakedClosableObjects()
+                    .detectLeakedRegistrationObjects()
+                    .detectLeakedSqlLiteObjects()
+                    .penaltyLog()
+                    .build())
+
+            // main thread
+            StrictMode.setThreadPolicy(StrictMode.ThreadPolicy.Builder()
+                    .detectAll()
+                    .penaltyLog()
+                    .build())
+        }
+
         if (Build.VERSION.SDK_INT <= 21)
             AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
 

app/src/main/java/at/bitfire/davdroid/ui/AccountActivity.kt

@@ -18,7 +18,9 @@ import android.content.pm.PackageManager
 import android.database.DatabaseUtils
 import android.database.sqlite.SQLiteDatabase
 import android.net.Uri
-import android.os.*
+import android.os.Build
+import android.os.Bundle
+import android.os.IBinder
 import android.provider.CalendarContract
 import android.provider.ContactsContract
 import android.support.design.widget.Snackbar
@@ -46,6 +48,7 @@ import at.bitfire.ical4android.TaskProvider
 import kotlinx.android.synthetic.main.account_caldav_item.view.*
 import kotlinx.android.synthetic.main.activity_account.*
 import java.util.*
+import java.util.concurrent.Executors
 import java.util.logging.Level
 
 class AccountActivity: AppCompatActivity(), Toolbar.OnMenuItemClickListener, PopupMenu.OnMenuItemClickListener, LoaderManager.LoaderCallbacks<AccountActivity.AccountInfo> {
@@ -75,6 +78,8 @@ class AccountActivity: AppCompatActivity(), Toolbar.OnMenuItemClickListener, Pop
 
     private var isActiveIdlingResource: IsActiveIdlingResource? = null
 
+    private val dbExecutor = Executors.newSingleThreadExecutor()
+
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -118,6 +123,9 @@ class AccountActivity: AppCompatActivity(), Toolbar.OnMenuItemClickListener, Pop
 
     override fun onDestroy() {
         super.onDestroy()
+
+        dbExecutor.shutdown()
+
         if (BuildConfig.DEBUG)
             IdlingRegistry.getInstance().unregister(isActiveIdlingResource)
     }
@@ -208,20 +216,24 @@ class AccountActivity: AppCompatActivity(), Toolbar.OnMenuItemClickListener, Pop
         val info = adapter.getItem(position)
         val nowChecked = !info.selected
 
-        OpenHelper(this).use { dbHelper ->
-            val db = dbHelper.writableDatabase
-            db.beginTransactionNonExclusive()
+        dbExecutor.execute {
+            OpenHelper(this).use { dbHelper ->
+                val db = dbHelper.writableDatabase
+                db.beginTransactionNonExclusive()
 
-            val values = ContentValues(1)
-            values.put(Collections.SYNC, if (nowChecked) 1 else 0)
-            db.update(Collections._TABLE, values, "${Collections.ID}=?", arrayOf(info.id.toString()))
+                val values = ContentValues(1)
+                values.put(Collections.SYNC, if (nowChecked) 1 else 0)
+                db.update(Collections._TABLE, values, "${Collections.ID}=?", arrayOf(info.id.toString()))
 
-            db.setTransactionSuccessful()
-            db.endTransaction()
+                db.setTransactionSuccessful()
+                db.endTransaction()
+            }
+
+            info.selected = nowChecked
+            runOnUiThread {
+                adapter.notifyDataSetChanged()
+            }
         }
-
-        info.selected = nowChecked
-        adapter.notifyDataSetChanged()
     }
 
     private val onActionOverflowListener = { anchor: View, info: CollectionInfo ->
@@ -239,17 +251,19 @@ class AccountActivity: AppCompatActivity(), Toolbar.OnMenuItemClickListener, Pop
             when (item.itemId) {
                 R.id.force_read_only -> {
                     val nowChecked = !item.isChecked
-                    OpenHelper(this).use { dbHelper ->
-                        val db = dbHelper.writableDatabase
-                        db.beginTransactionNonExclusive()
+                    dbExecutor.execute {
+                        OpenHelper(this).use { dbHelper ->
+                            val db = dbHelper.writableDatabase
+                            db.beginTransactionNonExclusive()
 
-                        val values = ContentValues(1)
-                        values.put(Collections.FORCE_READ_ONLY, nowChecked)
-                        db.update(Collections._TABLE, values, "${Collections.ID}=?", arrayOf(info.id.toString()))
+                            val values = ContentValues(1)
+                            values.put(Collections.FORCE_READ_ONLY, nowChecked)
+                            db.update(Collections._TABLE, values, "${Collections.ID}=?", arrayOf(info.id.toString()))
 
-                        db.setTransactionSuccessful()
-                        db.endTransaction()
-                        reload()
+                            db.setTransactionSuccessful()
+                            db.endTransaction()
+                            reload()
+                        }
                     }
                 }
                 R.id.delete_collection ->
@@ -379,7 +393,7 @@ class AccountActivity: AppCompatActivity(), Toolbar.OnMenuItemClickListener, Pop
 
         // set idle state for UI tests
         if (BuildConfig.DEBUG && isActiveIdlingResource!!.isIdleNow)
-            Handler(Looper.getMainLooper()).post {
+            runOnUiThread {
                 isActiveIdlingResource!!.callback?.onTransitionToIdle()
             }