Update develop tarball url

Requires https://github.com/vector-im/element-web/pull/23454

.eslintrc.js

@@ -12,6 +12,8 @@ module.exports = {
         // we also have some browser code (ie. the preload script)
         browser: true,
     },
+    // NOTE: These rules are frozen and new rules should not be added here.
+    // New changes belong in https://github.com/matrix-org/eslint-plugin-matrix-org/
     rules: {
         "quotes": "off",
         "indent": "off",
@@ -28,8 +30,9 @@ module.exports = {
             "prefer-promise-reject-errors": "off",
             "quotes": "off",
 
-            // We disable this while we're transitioning
             "@typescript-eslint/no-explicit-any": "off",
+            // We're okay with assertion errors when we ask for them
+            "@typescript-eslint/no-non-null-assertion": "off",
         },
     }],
 };

.github/renovate.json

@@ -0,0 +1,6 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": [
+    "github>matrix-org/renovate-config-element-web"
+  ]
+}

.github/workflows/backport.yml

@@ -0,0 +1,30 @@
+name: Backport
+on:
+  pull_request_target:
+    types:
+      - closed
+      - labeled
+    branches:
+      - develop
+
+jobs:
+  backport:
+    name: Backport
+    runs-on: ubuntu-latest
+    # Only react to merged PRs for security reasons.
+    # See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target.
+    if: >
+      github.event.pull_request.merged
+      && (
+        github.event.action == 'closed'
+        || (
+          github.event.action == 'labeled'
+          && contains(github.event.label.name, 'backport')
+        )
+      )
+    steps:
+      - uses: tibdex/backport@v2
+        with:
+          labels_template: "<%= JSON.stringify([...labels, 'X-Release-Blocker']) %>"
+          # We can't use GITHUB_TOKEN here or CI won't run on the new PR
+          github_token: ${{ secrets.ELEMENT_BOT_TOKEN }}

.github/workflows/build.yaml

@@ -1,4 +1,4 @@
-name: Build
+name: Build and Test
 on:
   pull_request: { }
   push:
@@ -20,8 +20,13 @@ jobs:
       - name: Install Deps
         run: "yarn install --pure-lockfile"
 
+      - name: Fetch Element Web (develop)
+        if: github.event.pull_request.base.ref == 'develop'
+        run: yarn run fetch --noverify develop -d element.io/nightly
+
       - name: Fetch Element Web
-        run: yarn run fetch --noverify --cfgdir element.io/nightly
+        if: github.event.pull_request.base.ref != 'develop'
+        run: yarn run fetch --noverify --cfgdir element.io/release
 
       - uses: actions/upload-artifact@v3
         with:
@@ -154,6 +159,9 @@ jobs:
       - name: Build App
         run: "yarn build --publish never"
 
+      - name: Install .deb
+        run: "sudo apt install ./dist/*.deb"
+
       - name: Upload Artifacts
         uses: actions/upload-artifact@v3
         with:
@@ -205,3 +213,71 @@ jobs:
           name: macos
           path: dist
           retention-days: 1
+
+  test:
+    needs:
+      - macos
+      - linux
+      - windows
+    strategy:
+      matrix:
+        include:
+# Disable macOS tests for now, they fail to run in CI, needs investigation.
+#          - name: macOS Universal
+#            os: macos
+#            artifact: macos
+#            executable: "./dist/mac-universal/Element.app/Contents/MacOS/Element"
+#            prepare_cmd: "chmod +x ./dist/mac-universal/Element.app/Contents/MacOS/Element"
+          - name: 'Linux (sqlcipher: system)'
+            os: ubuntu
+            artifact: linux-sqlcipher-system
+            executable: "element-desktop"
+            prepare_cmd: "sudo apt install ./dist/*.deb"
+          - name: 'Linux (sqlcipher: static)'
+            os: ubuntu
+            artifact: linux-sqlcipher-static
+            executable: "element-desktop"
+            prepare_cmd: "sudo apt install ./dist/*.deb"
+          - name: Windows (x86)
+            os: windows
+            artifact: win-x86
+            executable: "./dist/win-ia32-unpacked/Element.exe"
+          - name: Windows (x64)
+            os: windows
+            artifact: win-x64
+            executable: "./dist/win-unpacked/Element.exe"
+    name: Test ${{ matrix.name }}
+    runs-on: ${{ matrix.os }}-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v3
+        with:
+          cache: "yarn"
+
+      - name: Install Deps
+        run: "yarn install --pure-lockfile"
+
+      - uses: actions/download-artifact@v3
+        with:
+          name: ${{ matrix.artifact }}
+          path: dist
+
+      - name: Prepare for tests
+        run: ${{ matrix.prepare_cmd }}
+        if: matrix.prepare_cmd
+
+      - name: Run tests
+        uses: GabrielBB/xvfb-action@v1
+        timeout-minutes: 5
+        with:
+          run: "yarn test"
+        env:
+          ELEMENT_DESKTOP_EXECUTABLE: ${{ matrix.executable }}
+
+      - name: Upload Artifacts
+        uses: actions/upload-artifact@v3
+        with:
+          name: ${{ matrix.artifact }}
+          path: test_artifacts
+          retention-days: 1

.gitignore

@@ -13,3 +13,5 @@
 /.npmrc
 .vscode
 .vscode/
+/test_artifacts/
+/coverage/

CHANGELOG.md

@@ -1,3 +1,255 @@
+Changes in [1.11.13](https://github.com/vector-im/element-desktop/releases/tag/v1.11.13) (2022-11-01)
+=====================================================================================================
+
+## 🐛 Bug Fixes
+ * Fix default behavior of Room.getBlacklistUnverifiedDevices ([\#2830](https://github.com/matrix-org/matrix-js-sdk/pull/2830)). Contributed by @duxovni.
+ * Catch server versions API call exception when starting the client ([\#2828](https://github.com/matrix-org/matrix-js-sdk/pull/2828)). Fixes vector-im/element-web#23634.
+ * Fix authedRequest including `Authorization: Bearer undefined` for password resets ([\#2822](https://github.com/matrix-org/matrix-js-sdk/pull/2822)). Fixes vector-im/element-web#23655.
+
+Changes in [1.11.12](https://github.com/vector-im/element-desktop/releases/tag/v1.11.12) (2022-10-26)
+=====================================================================================================
+
+## 🐛 Bug Fixes
+ * Fix config.json failing to load for Jitsi wrapper in non-root deployment ([\#23577](https://github.com/vector-im/element-web/pull/23577)).
+
+Changes in [1.11.11](https://github.com/vector-im/element-desktop/releases/tag/v1.11.11) (2022-10-25)
+=====================================================================================================
+
+## ✨ Features
+ * Device manager - tweak string formatting of default device name ([\#23457](https://github.com/vector-im/element-web/pull/23457)).
+ * Add Element Call participant limit ([\#23431](https://github.com/vector-im/element-web/pull/23431)).
+ * Add Element Call `brand` ([\#23443](https://github.com/vector-im/element-web/pull/23443)).
+ * Include a file-safe room name and ISO date in chat exports ([\#9440](https://github.com/matrix-org/matrix-react-sdk/pull/9440)). Fixes vector-im/element-web#21812 and vector-im/element-web#19724.
+ * Room call banner ([\#9378](https://github.com/matrix-org/matrix-react-sdk/pull/9378)). Fixes vector-im/element-web#23453. Contributed by @toger5.
+ * Device manager - spinners while devices are signing out ([\#9433](https://github.com/matrix-org/matrix-react-sdk/pull/9433)). Fixes vector-im/element-web#15865.
+ * Device manager - silence call ringers when local notifications are silenced ([\#9420](https://github.com/matrix-org/matrix-react-sdk/pull/9420)).
+ * Pass the current language to Element Call ([\#9427](https://github.com/matrix-org/matrix-react-sdk/pull/9427)).
+ * Hide screen-sharing button in Element Call on desktop ([\#9423](https://github.com/matrix-org/matrix-react-sdk/pull/9423)).
+ * Add reply support to WysiwygComposer ([\#9422](https://github.com/matrix-org/matrix-react-sdk/pull/9422)). Contributed by @florianduros.
+ * Disconnect other connected devices (of the same user) when joining an Element call ([\#9379](https://github.com/matrix-org/matrix-react-sdk/pull/9379)).
+ * Device manager - device tile main click target ([\#9409](https://github.com/matrix-org/matrix-react-sdk/pull/9409)).
+ * Add formatting buttons to the rich text editor ([\#9410](https://github.com/matrix-org/matrix-react-sdk/pull/9410)). Contributed by @florianduros.
+ * Device manager - current session context menu ([\#9386](https://github.com/matrix-org/matrix-react-sdk/pull/9386)).
+ * Remove piwik config fallback for privacy policy URL ([\#9390](https://github.com/matrix-org/matrix-react-sdk/pull/9390)).
+ * Add the first step to integrate the matrix wysiwyg composer ([\#9374](https://github.com/matrix-org/matrix-react-sdk/pull/9374)). Contributed by @florianduros.
+ * Device manager - UA parsing tweaks ([\#9382](https://github.com/matrix-org/matrix-react-sdk/pull/9382)).
+ * Device manager - remove client information events when disabling setting ([\#9384](https://github.com/matrix-org/matrix-react-sdk/pull/9384)).
+ * Add Element Call participant limit ([\#9358](https://github.com/matrix-org/matrix-react-sdk/pull/9358)).
+ * Add Element Call room settings ([\#9347](https://github.com/matrix-org/matrix-react-sdk/pull/9347)).
+ * Device manager - render extended device information ([\#9360](https://github.com/matrix-org/matrix-react-sdk/pull/9360)).
+ * New group call experience: Room header and PiP designs ([\#9351](https://github.com/matrix-org/matrix-react-sdk/pull/9351)).
+ * Pass language to Jitsi Widget ([\#9346](https://github.com/matrix-org/matrix-react-sdk/pull/9346)). Contributed by @Fox32.
+ * Add notifications and toasts for Element Call calls ([\#9337](https://github.com/matrix-org/matrix-react-sdk/pull/9337)).
+ * Device manager - device type icon ([\#9355](https://github.com/matrix-org/matrix-react-sdk/pull/9355)).
+ * Delete the remainder of groups ([\#9357](https://github.com/matrix-org/matrix-react-sdk/pull/9357)). Fixes vector-im/element-web#22770.
+ * Device manager - display client information in device details ([\#9315](https://github.com/matrix-org/matrix-react-sdk/pull/9315)).
+
+## 🐛 Bug Fixes
+ * Send Content-Type: application/json header for integration manager /register API ([\#9490](https://github.com/matrix-org/matrix-react-sdk/pull/9490)). Fixes vector-im/element-web#23580.
+ * Make ErrorView & CompatibilityView scrollable ([\#23468](https://github.com/vector-im/element-web/pull/23468)). Fixes vector-im/element-web#23376.
+ * Device manager - put client/browser device metadata in correct section ([\#9447](https://github.com/matrix-org/matrix-react-sdk/pull/9447)).
+ * update the room unread notification counter when the server changes the value without any related read receipt ([\#9438](https://github.com/matrix-org/matrix-react-sdk/pull/9438)).
+ * Don't show call banners in video rooms ([\#9441](https://github.com/matrix-org/matrix-react-sdk/pull/9441)).
+ * Prevent useContextMenu isOpen from being true if the button ref goes away ([\#9418](https://github.com/matrix-org/matrix-react-sdk/pull/9418)). Fixes matrix-org/element-web-rageshakes#15637.
+ * Automatically focus the WYSIWYG composer when you enter a room ([\#9412](https://github.com/matrix-org/matrix-react-sdk/pull/9412)).
+ * Improve the tooltips on the call lobby join button ([\#9428](https://github.com/matrix-org/matrix-react-sdk/pull/9428)).
+ * Pass the homeserver's base URL to Element Call ([\#9429](https://github.com/matrix-org/matrix-react-sdk/pull/9429)). Fixes vector-im/element-web#23301.
+ * Better accommodate long room names in call toasts ([\#9426](https://github.com/matrix-org/matrix-react-sdk/pull/9426)).
+ * Hide virtual widgets from the room info panel ([\#9424](https://github.com/matrix-org/matrix-react-sdk/pull/9424)). Fixes vector-im/element-web#23494.
+ * Inhibit clicking on sender avatar in threads list ([\#9417](https://github.com/matrix-org/matrix-react-sdk/pull/9417)). Fixes vector-im/element-web#23482.
+ * Correct the dir parameter of MSC3715 ([\#9391](https://github.com/matrix-org/matrix-react-sdk/pull/9391)). Contributed by @dhenneke.
+ * Use a more correct subset of users in `/remakeolm` developer command ([\#9402](https://github.com/matrix-org/matrix-react-sdk/pull/9402)).
+ * use correct default for notification silencing ([\#9388](https://github.com/matrix-org/matrix-react-sdk/pull/9388)). Fixes vector-im/element-web#23456.
+ * Device manager - eagerly create `m.local_notification_settings` events ([\#9353](https://github.com/matrix-org/matrix-react-sdk/pull/9353)).
+ * Close incoming Element call toast when viewing the call lobby ([\#9375](https://github.com/matrix-org/matrix-react-sdk/pull/9375)).
+ * Always allow enabling sending read receipts ([\#9367](https://github.com/matrix-org/matrix-react-sdk/pull/9367)). Fixes vector-im/element-web#23433.
+ * Fixes (vector-im/element-web/issues/22609) where the white theme is not applied when `white -> dark -> white` sequence is done. ([\#9320](https://github.com/matrix-org/matrix-react-sdk/pull/9320)). Contributed by @florianduros.
+ * Fix applying programmatically set height for "top" room layout ([\#9339](https://github.com/matrix-org/matrix-react-sdk/pull/9339)). Contributed by @Fox32.
+
+Changes in [1.11.10](https://github.com/vector-im/element-desktop/releases/tag/v1.11.10) (2022-10-11)
+=====================================================================================================
+
+## 🐛 Bug Fixes
+ * Use correct default for notification silencing ([\#9388](https://github.com/matrix-org/matrix-react-sdk/pull/9388)). Fixes vector-im/element-web#23456.
+
+Changes in [1.11.9](https://github.com/vector-im/element-desktop/releases/tag/v1.11.9) (2022-10-11)
+===================================================================================================
+
+##   Deprecations 
+ * Legacy Piwik config.json option `piwik.policy_url` is deprecated in favour of `privacy_policy_url`. Support will be removed in the next release.
+
+## ✨ Features
+ * Device manager - select all devices ([\#9330](https://github.com/matrix-org/matrix-react-sdk/pull/9330)). Contributed by @kerryarchibald.
+ * New group call experience: Call tiles ([\#9332](https://github.com/matrix-org/matrix-react-sdk/pull/9332)).
+ * Add Shift key to FormatQuote keyboard shortcut ([\#9298](https://github.com/matrix-org/matrix-react-sdk/pull/9298)). Contributed by @owi92.
+ * Device manager - sign out of multiple sessions ([\#9325](https://github.com/matrix-org/matrix-react-sdk/pull/9325)). Contributed by @kerryarchibald.
+ * Display push toggle for web sessions (MSC3890) ([\#9327](https://github.com/matrix-org/matrix-react-sdk/pull/9327)).
+ * Add device notifications enabled switch ([\#9324](https://github.com/matrix-org/matrix-react-sdk/pull/9324)).
+ * Implement push notification toggle in device detail ([\#9308](https://github.com/matrix-org/matrix-react-sdk/pull/9308)).
+ * New group call experience: Starting and ending calls ([\#9318](https://github.com/matrix-org/matrix-react-sdk/pull/9318)).
+ * New group call experience: Room header call buttons ([\#9311](https://github.com/matrix-org/matrix-react-sdk/pull/9311)).
+ * Make device ID copyable in device list ([\#9297](https://github.com/matrix-org/matrix-react-sdk/pull/9297)). Contributed by @duxovni.
+ * Use display name instead of user ID when rendering power events ([\#9295](https://github.com/matrix-org/matrix-react-sdk/pull/9295)).
+ * Read receipts for threads ([\#9239](https://github.com/matrix-org/matrix-react-sdk/pull/9239)). Fixes vector-im/element-web#23191.
+
+## 🐛 Bug Fixes
+ * Use the correct sender key when checking shared secret ([\#2730](https://github.com/matrix-org/matrix-js-sdk/pull/2730)). Fixes vector-im/element-web#23374.
+ * Fix device selection in pre-join screen for Element Call video rooms ([\#9321](https://github.com/matrix-org/matrix-react-sdk/pull/9321)). Fixes vector-im/element-web#23331.
+ * Don't render a 1px high room topic if the room topic is empty ([\#9317](https://github.com/matrix-org/matrix-react-sdk/pull/9317)). Contributed by @Arnei.
+ * Don't show feedback prompts when that UIFeature is disabled ([\#9305](https://github.com/matrix-org/matrix-react-sdk/pull/9305)). Fixes vector-im/element-web#23327.
+ * Fix soft crash around unknown room pills ([\#9301](https://github.com/matrix-org/matrix-react-sdk/pull/9301)). Fixes matrix-org/element-web-rageshakes#15465.
+ * Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](https://github.com/matrix-org/matrix-react-sdk/pull/9302)). Fixes vector-im/element-web#23314.
+ * Fix tile soft crash in ReplyInThreadButton ([\#9300](https://github.com/matrix-org/matrix-react-sdk/pull/9300)). Fixes matrix-org/element-web-rageshakes#15493.
+
+Changes in [1.11.8](https://github.com/vector-im/element-desktop/releases/tag/v1.11.8) (2022-09-28)
+===================================================================================================
+
+## 🐛 Bug Fixes
+ * Bump IDB crypto store version ([\#2705](https://github.com/matrix-org/matrix-js-sdk/pull/2705)).
+
+Changes in [1.11.7](https://github.com/vector-im/element-desktop/releases/tag/v1.11.7) (2022-09-28)
+===================================================================================================
+
+## 🔒 Security
+* Fix for [CVE-2022-39249](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39249)
+* Fix for [CVE-2022-39250](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39250)
+* Fix for [CVE-2022-39251](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39251)
+* Fix for [CVE-2022-39236](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D39236)
+
+Changes in [1.11.6](https://github.com/vector-im/element-desktop/releases/tag/v1.11.6) (2022-09-20)
+=============================================================================================================
+
+## ✨ Features
+ * Element Call video rooms ([\#9267](https://github.com/matrix-org/matrix-react-sdk/pull/9267)).
+ * Device manager - rename session ([\#9282](https://github.com/matrix-org/matrix-react-sdk/pull/9282)).
+ * Allow widgets to read related events ([\#9210](https://github.com/matrix-org/matrix-react-sdk/pull/9210)). Contributed by @dhenneke.
+ * Device manager - logout of other session ([\#9280](https://github.com/matrix-org/matrix-react-sdk/pull/9280)).
+ * Device manager - logout current session ([\#9275](https://github.com/matrix-org/matrix-react-sdk/pull/9275)).
+ * Device manager - verify other devices ([\#9274](https://github.com/matrix-org/matrix-react-sdk/pull/9274)).
+ * Allow integration managers to remove users ([\#9211](https://github.com/matrix-org/matrix-react-sdk/pull/9211)).
+ * Device manager - add verify current session button ([\#9252](https://github.com/matrix-org/matrix-react-sdk/pull/9252)).
+ * Add NotifPanel dot back. ([\#9242](https://github.com/matrix-org/matrix-react-sdk/pull/9242)). Fixes vector-im/element-web#17641.
+ * Implement MSC3575: Sliding Sync ([\#8328](https://github.com/matrix-org/matrix-react-sdk/pull/8328)).
+ * Add the clipboard read permission for widgets ([\#9250](https://github.com/matrix-org/matrix-react-sdk/pull/9250)). Contributed by @stefanmuhle.
+
+## 🐛 Bug Fixes
+ * Make autocomplete pop-up wider in thread view ([\#9289](https://github.com/matrix-org/matrix-react-sdk/pull/9289)).
+ * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\#9281](https://github.com/matrix-org/matrix-react-sdk/pull/9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140.
+ * Fix in-reply-to previews not disappearing when swapping rooms ([\#9278](https://github.com/matrix-org/matrix-react-sdk/pull/9278)).
+ * Fix invalid instanceof operand window.OffscreenCanvas ([\#9276](https://github.com/matrix-org/matrix-react-sdk/pull/9276)). Fixes vector-im/element-web#23275.
+ * Fix memory leak caused by unremoved listener ([\#9273](https://github.com/matrix-org/matrix-react-sdk/pull/9273)).
+ * Fix thumbnail generation when offscreen canvas fails ([\#9272](https://github.com/matrix-org/matrix-react-sdk/pull/9272)). Fixes vector-im/element-web#23265.
+ * Prevent sliding sync from showing a room under multiple sublists ([\#9266](https://github.com/matrix-org/matrix-react-sdk/pull/9266)).
+ * Fix tile crash around tooltipify links ([\#9270](https://github.com/matrix-org/matrix-react-sdk/pull/9270)). Fixes vector-im/element-web#23253.
+ * Device manager - filter out nulled metadatas in device tile properly ([\#9251](https://github.com/matrix-org/matrix-react-sdk/pull/9251)).
+ * Fix a sliding sync bug which could cause rooms to loop ([\#9268](https://github.com/matrix-org/matrix-react-sdk/pull/9268)).
+ * Remove the grey gradient on images in bubbles in the timeline ([\#9241](https://github.com/matrix-org/matrix-react-sdk/pull/9241)). Fixes vector-im/element-web#21651.
+ * Fix html export not including images ([\#9260](https://github.com/matrix-org/matrix-react-sdk/pull/9260)). Fixes vector-im/element-web#22059.
+ * Fix possible soft crash from a race condition in space hierarchies ([\#9254](https://github.com/matrix-org/matrix-react-sdk/pull/9254)). Fixes matrix-org/element-web-rageshakes#15225.
+ * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\#9259](https://github.com/matrix-org/matrix-react-sdk/pull/9259)).
+ * Handle M_INVALID_USERNAME on /register/available ([\#9237](https://github.com/matrix-org/matrix-react-sdk/pull/9237)). Fixes vector-im/element-web#23161.
+ * Fix issue with quiet zone around QR code ([\#9243](https://github.com/matrix-org/matrix-react-sdk/pull/9243)). Fixes vector-im/element-web#23199.
+
+Changes in [1.11.5](https://github.com/vector-im/element-desktop/releases/tag/v1.11.5) (2022-09-13)
+===================================================================================================
+
+## ✨ Features
+ * Device manager - hide unverified security recommendation when only current session is unverified ([\#9228](https://github.com/matrix-org/matrix-react-sdk/pull/9228)). Contributed by @kerryarchibald.
+ * Device manager - scroll to filtered list from security recommendations ([\#9227](https://github.com/matrix-org/matrix-react-sdk/pull/9227)). Contributed by @kerryarchibald.
+ * Device manager - updated dropdown style in filtered device list ([\#9226](https://github.com/matrix-org/matrix-react-sdk/pull/9226)). Contributed by @kerryarchibald.
+ * Device manager - device type and verification icons on device tile ([\#9197](https://github.com/matrix-org/matrix-react-sdk/pull/9197)). Contributed by @kerryarchibald.
+
+## 🐛 Bug Fixes
+ * Description of DM room with more than two other people is now being displayed correctly ([\#9231](https://github.com/matrix-org/matrix-react-sdk/pull/9231)). Fixes vector-im/element-web#23094.
+ * Fix voice messages with multiple composers ([\#9208](https://github.com/matrix-org/matrix-react-sdk/pull/9208)). Fixes vector-im/element-web#23023. Contributed by @grimhilt.
+ * Fix suggested rooms going missing ([\#9236](https://github.com/matrix-org/matrix-react-sdk/pull/9236)). Fixes vector-im/element-web#23190.
+ * Fix tooltip infinitely recursing ([\#9235](https://github.com/matrix-org/matrix-react-sdk/pull/9235)). Fixes matrix-org/element-web-rageshakes#15107, matrix-org/element-web-rageshakes#15093 matrix-org/element-web-rageshakes#15092 and matrix-org/element-web-rageshakes#15077.
+ * Fix plain text export saving ([\#9230](https://github.com/matrix-org/matrix-react-sdk/pull/9230)). Contributed by @jryans.
+ * Add missing space in SecurityRoomSettingsTab ([\#9222](https://github.com/matrix-org/matrix-react-sdk/pull/9222)). Contributed by @gefgu.
+ * Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\#9209](https://github.com/matrix-org/matrix-react-sdk/pull/9209)). Fixes vector-im/element-web#21369.
+ * Fix progress bar regression throughout the app ([\#9219](https://github.com/matrix-org/matrix-react-sdk/pull/9219)). Fixes vector-im/element-web#23121.
+ * Reuse empty string & space string logic for event types in devtools ([\#9218](https://github.com/matrix-org/matrix-react-sdk/pull/9218)). Fixes vector-im/element-web#23115.
+
+Changes in [1.11.4](https://github.com/vector-im/element-desktop/releases/tag/v1.11.4) (2022-08-31)
+===================================================================================================
+
+## 🔒 Security
+* Fixes for [CVE-2022-36059](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D36059) and [CVE-2022-36060](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE%2D2022%2D36060)
+
+Learn more about what we've been up to at https://element.io/blog/element-web-desktop-1-11-4-a-security-update-deferred-dms-and-more/
+Find more details of the vulnerabilities at https://matrix.org/blog/2022/08/31/security-releases-matrix-js-sdk-19-4-0-and-matrix-react-sdk-3-53-0
+
+## ✨ Features
+ * Upgrade to Electron 20 ([\#403](https://github.com/vector-im/element-desktop/pull/403)).
+ * Device manager - scroll to filtered list from security recommendations ([\#9227](https://github.com/matrix-org/matrix-react-sdk/pull/9227)). Contributed by @kerryarchibald.
+ * Device manager - updated dropdown style in filtered device list ([\#9226](https://github.com/matrix-org/matrix-react-sdk/pull/9226)). Contributed by @kerryarchibald.
+ * Device manager - device type and verification icons on device tile ([\#9197](https://github.com/matrix-org/matrix-react-sdk/pull/9197)). Contributed by @kerryarchibald.
+ * Ignore unreads in low priority rooms in the space panel ([\#6518](https://github.com/matrix-org/matrix-react-sdk/pull/6518)). Fixes vector-im/element-web#16836.
+ * Release message right-click context menu out of labs ([\#8613](https://github.com/matrix-org/matrix-react-sdk/pull/8613)).
+ * Device manager - expandable session details in device list ([\#9188](https://github.com/matrix-org/matrix-react-sdk/pull/9188)). Contributed by @kerryarchibald.
+ * Device manager - device list filtering ([\#9181](https://github.com/matrix-org/matrix-react-sdk/pull/9181)). Contributed by @kerryarchibald.
+ * Device manager - add verification details to session details ([\#9187](https://github.com/matrix-org/matrix-react-sdk/pull/9187)). Contributed by @kerryarchibald.
+ * Device manager - current session expandable details ([\#9185](https://github.com/matrix-org/matrix-react-sdk/pull/9185)). Contributed by @kerryarchibald.
+ * Device manager - security recommendations section ([\#9179](https://github.com/matrix-org/matrix-react-sdk/pull/9179)). Contributed by @kerryarchibald.
+ * The Welcome Home Screen: Return Button ([\#9089](https://github.com/matrix-org/matrix-react-sdk/pull/9089)). Fixes vector-im/element-web#22917. Contributed by @justjanne.
+ * Device manager - label devices as inactive ([\#9175](https://github.com/matrix-org/matrix-react-sdk/pull/9175)). Contributed by @kerryarchibald.
+ * Device manager - other sessions list ([\#9155](https://github.com/matrix-org/matrix-react-sdk/pull/9155)). Contributed by @kerryarchibald.
+ * Implement MSC3846: Allowing widgets to access TURN servers ([\#9061](https://github.com/matrix-org/matrix-react-sdk/pull/9061)).
+ * Allow widgets to send/receive to-device messages ([\#8885](https://github.com/matrix-org/matrix-react-sdk/pull/8885)).
+
+## 🐛 Bug Fixes
+ * Add super cool feature ([\#9222](https://github.com/matrix-org/matrix-react-sdk/pull/9222)). Contributed by @gefgu.
+ * Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\#9209](https://github.com/matrix-org/matrix-react-sdk/pull/9209)). Fixes vector-im/element-web#21369.
+ * Fix progress bar regression throughout the app ([\#9219](https://github.com/matrix-org/matrix-react-sdk/pull/9219)). Fixes vector-im/element-web#23121.
+ * Reuse empty string & space string logic for event types in devtools ([\#9218](https://github.com/matrix-org/matrix-react-sdk/pull/9218)). Fixes vector-im/element-web#23115.
+ * Reduce amount of requests done by the onboarding task list ([\#9194](https://github.com/matrix-org/matrix-react-sdk/pull/9194)). Fixes vector-im/element-web#23085. Contributed by @justjanne.
+ * Avoid hardcoding branding in user onboarding ([\#9206](https://github.com/matrix-org/matrix-react-sdk/pull/9206)). Fixes vector-im/element-web#23111. Contributed by @justjanne.
+ * End jitsi call when member is banned ([\#8879](https://github.com/matrix-org/matrix-react-sdk/pull/8879)). Contributed by @maheichyk.
+ * Fix context menu being opened when clicking message action bar buttons ([\#9200](https://github.com/matrix-org/matrix-react-sdk/pull/9200)). Fixes vector-im/element-web#22279 and vector-im/element-web#23100.
+ * Add gap between checkbox and text in report dialog following the same pattern (8px) used in the gap between the two buttons. It fixes vector-im/element-web#23060 ([\#9195](https://github.com/matrix-org/matrix-react-sdk/pull/9195)). Contributed by @gefgu.
+ * Fix url preview AXE and layout issue & add percy test ([\#9189](https://github.com/matrix-org/matrix-react-sdk/pull/9189)). Fixes vector-im/element-web#23083.
+ * Wrap long space names ([\#9201](https://github.com/matrix-org/matrix-react-sdk/pull/9201)). Fixes vector-im/element-web#23095.
+ * Attempt to fix `Failed to execute 'removeChild' on 'Node'` ([\#9196](https://github.com/matrix-org/matrix-react-sdk/pull/9196)).
+ * Fix soft crash around space hierarchy changing between spaces ([\#9191](https://github.com/matrix-org/matrix-react-sdk/pull/9191)). Fixes matrix-org/element-web-rageshakes#14613.
+ * Fix soft crash around room view store metrics ([\#9190](https://github.com/matrix-org/matrix-react-sdk/pull/9190)). Fixes matrix-org/element-web-rageshakes#14361.
+ * Fix the same person appearing multiple times when searching for them. ([\#9177](https://github.com/matrix-org/matrix-react-sdk/pull/9177)). Fixes vector-im/element-web#22851.
+ * Fix space panel subspace indentation going missing ([\#9167](https://github.com/matrix-org/matrix-react-sdk/pull/9167)). Fixes vector-im/element-web#23049.
+ * Fix invisible power levels tile when showing hidden events ([\#9162](https://github.com/matrix-org/matrix-react-sdk/pull/9162)). Fixes vector-im/element-web#23013.
+ * Space panel accessibility improvements ([\#9157](https://github.com/matrix-org/matrix-react-sdk/pull/9157)). Fixes vector-im/element-web#22995.
+ * Fix inverted logic for showing UserWelcomeTop component ([\#9164](https://github.com/matrix-org/matrix-react-sdk/pull/9164)). Fixes vector-im/element-web#23037.
+
+Changes in [1.11.3](https://github.com/vector-im/element-desktop/releases/tag/v1.11.3) (2022-08-16)
+===================================================================================================
+
+## ✨ Features
+ * Improve auth aria attributes and semantics ([\#22948](https://github.com/vector-im/element-web/pull/22948)).
+ * Device manager - New device tile info design ([\#9122](https://github.com/matrix-org/matrix-react-sdk/pull/9122)). Contributed by @kerryarchibald.
+ * Device manager generic settings subsection component ([\#9147](https://github.com/matrix-org/matrix-react-sdk/pull/9147)). Contributed by @kerryarchibald.
+ * Migrate the hidden read receipts flag to new "send read receipts" option ([\#9141](https://github.com/matrix-org/matrix-react-sdk/pull/9141)).
+ * Live location sharing - share location at most every 5 seconds ([\#9148](https://github.com/matrix-org/matrix-react-sdk/pull/9148)). Contributed by @kerryarchibald.
+ * Increase max length of voice messages to 15m ([\#9133](https://github.com/matrix-org/matrix-react-sdk/pull/9133)). Fixes vector-im/element-web#18620.
+ * Move pin drop out of labs ([\#9135](https://github.com/matrix-org/matrix-react-sdk/pull/9135)).
+ * Start DM on first message ([\#8612](https://github.com/matrix-org/matrix-react-sdk/pull/8612)). Fixes vector-im/element-web#14736.
+ * Remove "Add Space" button from RoomListHeader when user cannot create spaces ([\#9129](https://github.com/matrix-org/matrix-react-sdk/pull/9129)).
+ * The Welcome Home Screen: Dedicated Download Apps Dialog ([\#9120](https://github.com/matrix-org/matrix-react-sdk/pull/9120)). Fixes vector-im/element-web#22921. Contributed by @justjanne.
+ * The Welcome Home Screen: "Submit Feedback" pane ([\#9090](https://github.com/matrix-org/matrix-react-sdk/pull/9090)). Fixes vector-im/element-web#22918. Contributed by @justjanne.
+ * New User Onboarding Task List ([\#9083](https://github.com/matrix-org/matrix-react-sdk/pull/9083)). Fixes vector-im/element-web#22919. Contributed by @justjanne.
+ * Add support for disabling spell checking ([\#8604](https://github.com/matrix-org/matrix-react-sdk/pull/8604)). Fixes vector-im/element-web#21901.
+ * Live location share - leave maximised map open when beacons expire ([\#9098](https://github.com/matrix-org/matrix-react-sdk/pull/9098)). Contributed by @kerryarchibald.
+
+## 🐛 Bug Fixes
+ * Some slash-commands (`/myroomnick`) have temporarily been disabled before the first message in a DM is sent. ([\#9193](https://github.com/matrix-org/matrix-react-sdk/pull/9193)).
+ * Use stable reference for active tab in tabbedView ([\#9145](https://github.com/matrix-org/matrix-react-sdk/pull/9145)). Contributed by @kerryarchibald.
+ * Fix pillification sometimes doubling up ([\#9152](https://github.com/matrix-org/matrix-react-sdk/pull/9152)). Fixes vector-im/element-web#23036.
+ * Fix composer padding ([\#9137](https://github.com/matrix-org/matrix-react-sdk/pull/9137)). Fixes vector-im/element-web#22992.
+ * Fix highlights not being applied to plaintext messages ([\#9126](https://github.com/matrix-org/matrix-react-sdk/pull/9126)). Fixes vector-im/element-web#22787.
+ * Fix dismissing edit composer when change was undone ([\#9109](https://github.com/matrix-org/matrix-react-sdk/pull/9109)). Fixes vector-im/element-web#22932.
+ * 1-to-1 DM rooms with bots now act like DM rooms instead of multi-user-rooms before ([\#9124](https://github.com/matrix-org/matrix-react-sdk/pull/9124)). Fixes vector-im/element-web#22894.
+ * Apply inline start padding to selected lines on modern layout only ([\#9006](https://github.com/matrix-org/matrix-react-sdk/pull/9006)). Fixes vector-im/element-web#22768. Contributed by @luixxiul.
+ * Peek into world-readable rooms from spotlight ([\#9115](https://github.com/matrix-org/matrix-react-sdk/pull/9115)). Fixes vector-im/element-web#22862.
+ * Use default styling on nested numbered lists due to MD being sensitive ([\#9110](https://github.com/matrix-org/matrix-react-sdk/pull/9110)). Fixes vector-im/element-web#22935.
+ * Fix replying using chat effect commands ([\#9101](https://github.com/matrix-org/matrix-react-sdk/pull/9101)). Fixes vector-im/element-web#22824.
+
 Changes in [1.11.2](https://github.com/vector-im/element-desktop/releases/tag/v1.11.2) (2022-08-03)
 ===================================================================================================
 
@@ -1073,8 +1325,12 @@ Changes in [1.9.8](https://github.com/vector-im/element-desktop/releases/tag/v1.
 Changes in [1.9.7](https://github.com/vector-im/element-desktop/releases/tag/v1.9.7) (2021-12-13)
 =================================================================================================
 
- * Security release with updated version of Olm to fix https://matrix.org/blog/2021/12/03/pre-disclosure-upcoming-security-release-of-libolm-and-matrix-js-sdk
- * Fix a crash on logout
+## 🔒 SECURITY FIXES
+* Security release with updated version of Olm to fix https://matrix.org/blog/2021/12/03/pre-disclosure-upcoming-security-release-of-libolm-and-matrix-js-sdk
+* Upgrade Electron to 13.5.2 to fix https://matrix.org/blog/2022/01/31/high-severity-vulnerability-in-element-desktop-1-9-6-and-earlier (https://github.com/vector-im/element-desktop/security/advisories/GHSA-mjrg-9f8r-h3m7)
+
+## 🐛 Bug Fixes
+* Fix a crash on logout
 
 Changes in [1.9.6](https://github.com/vector-im/element-desktop/releases/tag/v1.9.6) (2021-12-06)
 =================================================================================================

README.md

@@ -129,7 +129,7 @@ User-specified config.json
 ==========================
 
 + `%APPDATA%\$NAME\config.json` on Windows
-+ `$XDG_CONFIG_HOME\$NAME\config.json` or `~/.config/$NAME/config.json` on Linux
++ `$XDG_CONFIG_HOME/$NAME/config.json` or `~/.config/$NAME/config.json` on Linux
 + `~/Library/Application Support/$NAME/config.json` on macOS
 
 In the paths above, `$NAME` is typically `Element`, unless you use `--profile

babel.config.js

@@ -0,0 +1,6 @@
+module.exports = {
+    presets: [
+        ['@babel/preset-env', { targets: { node: 'current' } }],
+        '@babel/preset-typescript',
+    ],
+};

element.io/nightly/config.json

@@ -49,5 +49,8 @@
         "feature_spotlight": true,
         "feature_video_rooms": true
     },
+    "element_call": {
+        "url": "https://element-call.netlify.app"
+    },
     "map_style_url": "https://api.maptiler.com/maps/streets/style.json?key=fU3vlMsMn4Jb6dnEIFsx"
 }

package.json

@@ -2,7 +2,7 @@
   "name": "element-desktop",
   "productName": "Element",
   "main": "lib/electron-main.js",
-  "version": "1.11.2",
+  "version": "1.11.13",
   "description": "A feature-rich client for Matrix.org",
   "author": "Element",
   "repository": {
@@ -37,7 +37,8 @@
     "docker:install": "scripts/in-docker.sh yarn install",
     "debrepo": "scripts/mkrepo.sh",
     "clean": "rimraf webapp.asar dist packages deploys lib",
-    "hak": "ts-node scripts/hak/index.ts"
+    "hak": "ts-node scripts/hak/index.ts",
+    "test": "jest"
   },
   "dependencies": {
     "auto-launch": "^5.0.5",
@@ -49,8 +50,13 @@
     "request": "^2.88.2"
   },
   "devDependencies": {
+    "@babel/core": "^7.18.10",
+    "@babel/preset-env": "^7.18.10",
+    "@babel/preset-typescript": "^7.18.6",
     "@types/auto-launch": "^5.0.1",
     "@types/counterpart": "^0.18.1",
+    "@types/detect-libc": "^1.0.0",
+    "@types/jest": "^28",
     "@types/minimist": "^1.2.1",
     "@types/mkdirp": "^1.0.2",
     "@types/pacote": "^11.1.1",
@@ -60,9 +66,10 @@
     "allchange": "^1.0.6",
     "app-builder-lib": "^22.14.10",
     "asar": "^2.0.1",
+    "babel-jest": "^28.1.3",
     "chokidar": "^3.5.2",
     "detect-libc": "^1.0.3",
-    "electron": "^19",
+    "electron": "^20",
     "electron-builder": "22.11.4",
     "electron-builder-squirrel-windows": "22.11.4",
     "electron-devtools-installer": "^3.1.1",
@@ -71,16 +78,20 @@
     "eslint-config-google": "^0.14.0",
     "eslint-plugin-import": "^2.25.4",
     "eslint-plugin-matrix-org": "^0.4.0",
+    "expect-playwright": "^0.8.0",
     "find-npm-prefix": "^1.0.2",
     "fs-extra": "^8.1.0",
     "glob": "^7.1.6",
+    "jest": "^28",
     "matrix-web-i18n": "^1.3.0",
     "mkdirp": "^1.0.3",
     "needle": "^2.5.0",
     "node-pre-gyp": "^0.15.0",
     "pacote": "^11.3.5",
+    "playwright": "^1.25.0",
     "rimraf": "^3.0.2",
     "tar": "^6.1.2",
+    "ts-jest": "^28.0.8",
     "ts-node": "^10.4.0",
     "typescript": "4.5.5"
   },
@@ -144,5 +155,14 @@
         ]
       }
     ]
+  },
+  "jest": {
+    "testEnvironment": "node",
+    "testMatch": [
+      "<rootDir>/test/**/*-test.[jt]s?(x)"
+    ],
+    "setupFilesAfterEnv": [
+      "expect-playwright"
+    ]
   }
 }

release.sh

@@ -1,12 +1,9 @@
 #!/bin/bash
 #
 # Script to perform a release of element-desktop.
-#
-# Requires githib-changelog-generator; to install, do
-#   pip install git+https://github.com/matrix-org/github-changelog-generator.git
 
 set -e
 
-cd `dirname $0`
+cd "$(dirname "$0")"
 
-./node_modules/matrix-js-sdk/release.sh -n "$@"
+./node_modules/matrix-js-sdk/release.sh "$@"

scripts/fetch-package.js

@@ -14,70 +14,9 @@ const { setPackageVersion } = require('./set-version.js');
 
 const PUB_KEY_URL = "https://packages.riot.im/element-release-key.asc";
 const PACKAGE_URL_PREFIX = "https://github.com/vector-im/element-web/releases/download/";
+const DEVELOP_TGZ_URL = "https://element-web-develop.element.io/develop.tar.gz";
 const ASAR_PATH = 'webapp.asar';
 
-async function getLatestDevelopUrl(bkToken) {
-    const buildsResult = await needle('get',
-        "https://api.buildkite.com/v2/organizations/matrix-dot-org/pipelines/element-web/builds",
-        {
-            branch: 'develop',
-            state: 'passed',
-            per_page: 1,
-        },
-        {
-            headers: {
-                authorization: "Bearer " + bkToken,
-            },
-        },
-    );
-    const latestBuild = buildsResult.body[0];
-    console.log("Latest build is " + latestBuild.number);
-    let artifactUrl;
-    for (const job of latestBuild.jobs) {
-        // Strip any colon-form emoji from the build name
-        if (job.name && job.name.replace(/:\w*:\s*/, '') === 'Package') {
-            artifactUrl = job.artifacts_url;
-            break;
-        }
-    }
-    if (artifactUrl === undefined) {
-        throw new Error("Couldn't find artifact URL - has the name of the package job changed?");
-    }
-
-    const artifactsResult = await needle('get', artifactUrl, {},
-        {
-            headers: {
-                authorization: "Bearer " + bkToken,
-            },
-        },
-    );
-    let dlUrl;
-    let dlFilename;
-    for (const artifact of artifactsResult.body) {
-        if (artifact.filename && /^element-.*\.tar.gz$/.test(artifact.filename)) {
-            dlUrl = artifact.download_url;
-            dlFilename = artifact.filename;
-            break;
-        }
-    }
-    if (dlUrl === undefined) {
-        throw new Error("Couldn't find artifact download URL - has the artifact filename changed?");
-    }
-    console.log("Fetching artifact URL...");
-    const dlResult = await needle('get', dlUrl, {},
-        {
-            headers: {
-                authorization: "Bearer " + bkToken,
-            },
-            // This URL will give us a Location header, but will also give us
-            // a JSON object with the direct URL. We'll take the URL and pass it
-            // back, then we can easily support specifying a URL directly.
-            follow_max: 0,
-        },
-    );
-    return [dlFilename, dlResult.body.url];
-}
-
 async function downloadToFile(url, filename) {
     console.log("Downloading " + url + "...");
 
@@ -148,24 +87,21 @@ async function main() {
 
     if (targetVersion === undefined) {
         targetVersion = 'v' + riotDesktopPackageJson.version;
-        filename = 'element-' + targetVersion + '.tar.gz';
-        url = PACKAGE_URL_PREFIX + targetVersion + '/' + filename;
-    } else if (targetVersion === 'develop') {
-        const buildKiteApiKey = process.env.BUILDKITE_API_KEY;
-        if (buildKiteApiKey === undefined) {
-            console.log("Set BUILDKITE_API_KEY to fetch latest develop version");
-            console.log(
-                "Sorry - Buildkite's API requires authentication to access builds, " +
-                "even if those builds are accessible on the web with no auth.",
-            );
-            process.exit(1);
-        }
-        [filename, url] = await getLatestDevelopUrl(buildKiteApiKey);
+    } else if (targetVersion !== 'develop') {
+        setVersion = true; // version was specified
+    }
+
+    if (targetVersion === 'develop') {
+        filename = 'develop.tar.gz';
+        url = DEVELOP_TGZ_URL;
         verify = false; // develop builds aren't signed
+    } else if (targetVersion.includes("://")) {
+        filename = targetVersion.substring(targetVersion.lastIndexOf("/") + 1);
+        url = targetVersion;
+        verify = false; // manually verified
     } else {
-        filename = 'element-' + targetVersion + '.tar.gz';
+        filename = `element-${targetVersion}.tar.gz`;
         url = PACKAGE_URL_PREFIX + targetVersion + '/' + filename;
-        setVersion = true;
     }
 
     const haveGpg = await new Promise((resolve) => {
@@ -207,7 +143,7 @@ async function main() {
     }
 
     let haveDeploy = false;
-    const expectedDeployDir = path.join(deployDir, path.basename(filename).replace(/\.tar\.gz/, ''));
+    let expectedDeployDir = path.join(deployDir, path.basename(filename).replace(/\.tar\.gz/, ''));
     try {
         await fs.opendir(expectedDeployDir);
         console.log(expectedDeployDir + "already exists");
@@ -256,6 +192,12 @@ async function main() {
         await tar.x({
             file: outPath,
             cwd: deployDir,
+            onentry: entry => {
+                // Find the appropriate extraction path, only needed for `develop` where the dir name is unknown
+                if (entry.type === "Directory" && !path.join(deployDir, entry.path).startsWith(expectedDeployDir)) {
+                    expectedDeployDir = path.join(deployDir, entry.path);
+                }
+            },
         });
     }
 
@@ -279,7 +221,7 @@ async function main() {
     await asar.createPackage(expectedDeployDir, ASAR_PATH);
 
     if (setVersion) {
-        const semVer = targetVersion.slice(1);
+        const semVer = fs.readFileSync(path.join(expectedDeployDir, "version"), "utf-8").trim();
         console.log("Updating version to " + semVer);
         await setPackageVersion(semVer);
     }
@@ -287,4 +229,9 @@ async function main() {
     console.log("Done!");
 }
 
-main().then((ret) => process.exit(ret)).catch(e => process.exit(1));
+main().then((ret) => {
+    process.exit(ret);
+}).catch(e => {
+    console.error(e);
+    process.exit(1);
+});

scripts/hak/target.ts

@@ -44,9 +44,6 @@ export type Arch = 'arm64' | 'ia32' | 'x64' | 'ppc64' | 'universal';
 // See https://docs.microsoft.com/cpp/build/building-on-the-command-line?view=msvc-160#vcvarsall-syntax
 export type VcVarsArch = 'amd64' | 'arm64' | 'x86';
 
-// Values are expected to match those used in `detect-libc`.
-export type LibC = GLIBC | MUSL;
-
 export type Target = {
     id: TargetId;
     platform: Platform;
@@ -60,7 +57,7 @@ export type WindowsTarget = Target & {
 
 export type LinuxTarget = Target & {
     platform: 'linux';
-    libC: LibC;
+    libC: typeof processLibC;
 };
 
 export type UniversalTarget = Target & {
@@ -108,56 +105,56 @@ const x8664UnknownLinuxGnu: LinuxTarget = {
     id: 'x86_64-unknown-linux-gnu',
     platform: 'linux',
     arch: 'x64',
-    libC: 'glibc',
+    libC: GLIBC,
 };
 
 const x8664UnknownLinuxMusl: LinuxTarget = {
     id: 'x86_64-unknown-linux-musl',
     platform: 'linux',
     arch: 'x64',
-    libC: 'musl',
+    libC: MUSL,
 };
 
 const i686UnknownLinuxGnu: LinuxTarget = {
     id: 'i686-unknown-linux-gnu',
     platform: 'linux',
     arch: 'ia32',
-    libC: 'glibc',
+    libC: GLIBC,
 };
 
 const i686UnknownLinuxMusl: LinuxTarget = {
     id: 'i686-unknown-linux-musl',
     platform: 'linux',
     arch: 'ia32',
-    libC: 'musl',
+    libC: MUSL,
 };
 
 const aarch64UnknownLinuxGnu: LinuxTarget = {
     id: 'aarch64-unknown-linux-gnu',
     platform: 'linux',
     arch: 'arm64',
-    libC: 'glibc',
+    libC: GLIBC,
 };
 
 const aarch64UnknownLinuxMusl: LinuxTarget = {
     id: 'aarch64-unknown-linux-musl',
     platform: 'linux',
     arch: 'arm64',
-    libC: 'musl',
+    libC: MUSL,
 };
 
 const powerpc64leUnknownLinuxGnu: LinuxTarget = {
     id: 'powerpc64le-unknown-linux-gnu',
     platform: 'linux',
     arch: 'ppc64',
-    libC: 'glibc',
+    libC: GLIBC,
 };
 
 const powerpc64leUnknownLinuxMusl: LinuxTarget = {
     id: 'powerpc64le-unknown-linux-musl',
     platform: 'linux',
     arch: 'ppc64',
-    libC: 'musl',
+    libC: MUSL,
 };
 
 export const TARGETS: Record<TargetId, Target> = {
@@ -179,7 +176,7 @@ export const TARGETS: Record<TargetId, Target> = {
     'powerpc64le-unknown-linux-gnu': powerpc64leUnknownLinuxGnu,
 };
 
-export function getHost(): Target {
+export function getHost(): Target | undefined {
     return Object.values(TARGETS).find(target => (
         target.platform === process.platform &&
         target.arch === process.arch &&

src/electron-main.ts

@@ -247,7 +247,9 @@ const warnBeforeExit = (event: Event, input: Input): void => {
     if (shouldWarnBeforeExit && exitShortcutPressed) {
         const shouldCancelCloseRequest = dialog.showMessageBoxSync(global.mainWindow, {
             type: "question",
-            buttons: [_t("Cancel"), _t("Close Element")],
+            buttons: [_t("Cancel"), _t("Close %(brand)s", {
+                brand: global.vectorConfig.brand || 'Element',
+            })],
             message: _t("Are you sure you want to quit?"),
             defaultId: 1,
             cancelId: 0,

src/i18n/strings/bn.json

@@ -1,5 +1,47 @@
 {
     "Are you sure you want to quit?": "তুমি কি আসলেই বের হতে চাও?",
     "Close Element": "এলিমেন্ট বন্ধ করো",
-    "Cancel": "বাতিল"
+    "Cancel": "বাতিল",
+    "Save image as...": "ছবি সংরক্ষণের ধরন...",
+    "Failed to save image": "ছবি সংরক্ষণ ব্যর্থ",
+    "The image failed to save": "ছবি সংরক্ষণ ব্যর্থ",
+    "Add to dictionary": "অভিধানে যোগ করি",
+    "Copy link address": "সংযোগের ঠিকানা অনুলিপি করো",
+    "Copy image address": "ছবির ঠিকানা অনুলিপি করো",
+    "Copy email address": "ইমেইল ঠিকানা অনুলিপি করো",
+    "Copy image": "ছবি অনুলিপি করো",
+    "File": "নথি",
+    "Bring All to Front": "সবকিছু সামনে আনো",
+    "Zoom": "বড় করা",
+    "Stop Speaking": "কথা বন্ধ করো",
+    "Start Speaking": "কথা শুরু করো",
+    "Speech": "বাচন",
+    "Unhide": "দেখাও",
+    "Hide Others": "অন্যগুলো লুকাও",
+    "Hide": "লুকাও",
+    "Services": "সেবা",
+    "About": "আমাদের সম্পর্কে",
+    "Element Help": "এলিমেন্ট সাহায্য",
+    "Help": "সাহায্য",
+    "Close": "বন্ধ",
+    "Minimize": "সংকোচন",
+    "Window": "জানালা",
+    "Toggle Developer Tools": "ডেভেলপার সরঞ্জামাদি",
+    "Toggle Full Screen": "পূর্ণ পর্দা করো/বের হও",
+    "Preferences": "পছন্দসমূহ",
+    "Zoom Out": "ছোট করো",
+    "Zoom In": "বড়ো করো",
+    "Actual Size": "আসল আকার",
+    "View": "দেখো",
+    "Select All": "সব নির্বাচন",
+    "Delete": "অপসারণ",
+    "Paste and Match Style": "লেপন ও একই ধরনে",
+    "Paste": "লেপন",
+    "Copy": "অনুলিপি",
+    "Cut": "কাটো",
+    "Redo": "পুন",
+    "Undo": "ফিরত",
+    "Edit": "সম্পাদনা",
+    "Quit": "প্রস্থান",
+    "Show/Hide": "দেখাও/লুকাও"
 }

src/i18n/strings/de.json

@@ -26,7 +26,7 @@
     "Window": "Fenster",
     "Toggle Developer Tools": "Developer-Tools an/aus",
     "Toggle Full Screen": "Vollbildschirm an/aus",
-    "Preferences": "Präferenzen",
+    "Preferences": "Einstellungen",
     "Zoom Out": "Verkleinern",
     "Zoom In": "Vergrößern",
     "Actual Size": "Tatsächliche Größe",
@@ -43,5 +43,6 @@
     "Show/Hide": "Anzeigen/Ausblenden",
     "Close Element": "Element schließen",
     "Cancel": "Abbrechen",
-    "Copy image address": "Bild-Adresse kopieren"
+    "Copy image address": "Bild-Adresse kopieren",
+    "Close %(brand)s": "%(brand)s schließen"
 }

src/i18n/strings/en_EN.json

@@ -1,6 +1,6 @@
 {
     "Cancel": "Cancel",
-    "Close Element": "Close Element",
+    "Close %(brand)s": "Close %(brand)s",
     "Are you sure you want to quit?": "Are you sure you want to quit?",
     "Show/Hide": "Show/Hide",
     "Quit": "Quit",

src/i18n/strings/es.json

@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "¿Quieres salir?",
     "Close Element": "Cerrar Element",
     "Cancel": "Cancelar",
-    "Copy image address": "Copiar dirección de la imagen"
+    "Copy image address": "Copiar dirección de la imagen",
+    "Close %(brand)s": "Cerrar %(brand)s"
 }

src/i18n/strings/et.json

@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "Kas sa kindlasti soovid rakendusest väljuda?",
     "Close Element": "Sulge Element",
     "Cancel": "Tühista",
-    "Copy image address": "Kopeeri pildi aadress"
+    "Copy image address": "Kopeeri pildi aadress",
+    "Close %(brand)s": "Sulge %(brand)s"
 }

src/i18n/strings/fa.json

@@ -43,5 +43,6 @@
     "Show/Hide": "نمایش/پنهان",
     "Are you sure you want to quit?": "آیا مطمئنید که می‌خواهید خارج شوید؟",
     "Close Element": "بستن المنت",
-    "Cancel": "لغو"
+    "Cancel": "لغو",
+    "Close %(brand)s": "بستن %(brand)s"
 }

src/i18n/strings/fi.json

@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "Haluatko varmasti poistua?",
     "Close Element": "Sulje Element",
     "Cancel": "Peruuta",
-    "Copy image address": "Kopioi kuvan osoite"
+    "Copy image address": "Kopioi kuvan osoite",
+    "Close %(brand)s": "Sulje %(brand)s"
 }

src/i18n/strings/hu.json

@@ -29,7 +29,7 @@
     "Zoom In": "Nagyít",
     "Actual Size": "Jelenlegi méret",
     "View": "Nézet",
-    "Select All": "Mind kijelölése",
+    "Select All": "Összes kijelölése",
     "Delete": "Töröl",
     "Paste and Match Style": "Beillesztés formázással",
     "Paste": "Beillesztés",
@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "Biztos, hogy kilép?",
     "Close Element": "Element bezárása",
     "Cancel": "Mégsem",
-    "Copy image address": "Kép címének másolása"
+    "Copy image address": "Kép címének másolása",
+    "Close %(brand)s": "%(brand)s bezárása"
 }

src/i18n/strings/id.json

@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "Apakah Anda yakin ingin keluar?",
     "Close Element": "Tutup Element",
     "Cancel": "Batal",
-    "Copy image address": "Salin alamat gambar"
+    "Copy image address": "Salin alamat gambar",
+    "Close %(brand)s": "Tutuo %(brand)s"
 }

src/i18n/strings/it.json

@@ -43,5 +43,6 @@
     "Cancel": "Annulla",
     "Stop Speaking": "Smetti di parlare",
     "Speech": "Dettatura",
-    "Copy image address": "Copia indirizzo immagine"
+    "Copy image address": "Copia indirizzo immagine",
+    "Close %(brand)s": "Chiudi %(brand)s"
 }

src/i18n/strings/lt.json

@@ -0,0 +1,47 @@
+{
+    "Failed to save image": "Nepavyko įrašyti paveikslėlio",
+    "Save image as...": "Įrašyti paveikslėlį kaip...",
+    "Copy image address": "Kopijuoti paveikslėlio adresą",
+    "Copy image": "Kopijuoti paveikslėlį",
+    "The image failed to save": "Paveikslėlio nepavyko išsaugoti",
+    "Bring All to Front": "Viską iškelti į priekį",
+    "Speech": "Kalba",
+    "Actual Size": "Tikrasis dydis",
+    "Toggle Developer Tools": "Perjungti kūrėjo įrankius",
+    "Toggle Full Screen": "Perjungti viso ekrano režimą",
+    "Paste and Match Style": "Įklijuoti ir suderinti stilių",
+    "Redo": "Sugrąžinti veiksmą",
+    "Undo": "Atšaukti veiksmą",
+    "Select All": "Pasirinkti visus",
+    "Delete": "Ištrinti",
+    "Paste": "Įklijuoti",
+    "Copy": "Kopijuoti",
+    "Cut": "Iškirpti",
+    "Add to dictionary": "Pridėti prie žodyno",
+    "Copy link address": "Kopijuoti nuorodos adresą",
+    "Copy email address": "Kopijuoti el. pašto adresą",
+    "File": "Failas",
+    "Zoom": "Priartinti",
+    "Stop Speaking": "Nustoti kalbėti",
+    "Start Speaking": "Pradėti kalbėti",
+    "Unhide": "Nebeslėpti",
+    "Hide Others": "Slėpti kitus",
+    "Hide": "Slėpti",
+    "Services": "Paslaugos",
+    "About": "Apie",
+    "Element Help": "Element Pagalba",
+    "Help": "Pagalba",
+    "Close": "Uždaryti",
+    "Minimize": "Sumažinti",
+    "Window": "Langas",
+    "Preferences": "Nuostatos",
+    "Zoom Out": "Atitolinti",
+    "Zoom In": "Priartinti",
+    "View": "Peržiūrėti",
+    "Edit": "Redaguoti",
+    "Quit": "Išeiti",
+    "Show/Hide": "Rodyti/Slėpti",
+    "Are you sure you want to quit?": "Ar tikrai norite išeiti?",
+    "Close Element": "Uždaryti Element",
+    "Cancel": "Atšaukti"
+}

src/i18n/strings/lv.json

@@ -1,11 +1,11 @@
 {
     "Start Speaking": "Runājiet...",
     "Add to dictionary": "Pievienot vārdnīcai",
-    "The image failed to save": "Attēlu saglabāt neizdevās",
+    "The image failed to save": "Attēlu neizdevās saglabāt",
     "Failed to save image": "Neizdevās saglabāt attēlu",
     "Save image as...": "Saglabāt attēlu kā...",
     "Copy link address": "Kopēt saiti",
-    "Copy email address": "Kopēt e-pastu",
+    "Copy email address": "Kopēt e-pasta adresi",
     "Copy image": "Kopēt attēlu",
     "File": "Fails",
     "Bring All to Front": "Iznest visu priekšplānā",
@@ -15,7 +15,7 @@
     "Unhide": "Rādīt",
     "Hide Others": "Slēpt citus",
     "Hide": "Slēpt",
-    "Services": "Servisi/pakalpojumi",
+    "Services": "Pakalpojumi",
     "About": "Par programmu",
     "Element Help": "Element palīdzība",
     "Help": "Palīdzība",
@@ -24,7 +24,7 @@
     "Window": "Logs",
     "Toggle Developer Tools": "Pārslēgt uz Izstrādātāja rīkiem",
     "Toggle Full Screen": "Pārslēgt uz pilnekrānu",
-    "Preferences": "Parametri/iestatījumi",
+    "Preferences": "Iestatījumi",
     "Zoom Out": "Samazināt",
     "Zoom In": "Palielināt",
     "Actual Size": "Faktiskais izmērs",
@@ -35,12 +35,14 @@
     "Paste": "Ievietot",
     "Copy": "Kopēt",
     "Cut": "Izgriezt",
-    "Redo": "Atatdarīt/atatgriezt (redo)",
-    "Undo": "Atgreizt/atdarīt (undo)",
+    "Redo": "Atatgriezt/atatsaukt/atatdarīt",
+    "Undo": "Atgriezt/atsaukt/atdarīt",
     "Edit": "Rediģēt",
     "Quit": "Iziet",
     "Show/Hide": "Rādīt/nerādīt",
     "Are you sure you want to quit?": "Tiešām vēlaties iziet?",
     "Close Element": "Aizvērt Elementu",
-    "Cancel": "Atcelt"
+    "Cancel": "Atcelt",
+    "Copy image address": "Kopēt attēla adresi",
+    "Close %(brand)s": "Aizvērt %(brand)s"
 }

src/i18n/strings/nl.json

@@ -13,11 +13,11 @@
     "Start Speaking": "Begin met praten",
     "Speech": "Spraak",
     "Unhide": "Weer laten zien",
-    "Hide Others": "Andere verbergen",
+    "Hide Others": "Anderen verbergen",
     "Hide": "Verbergen",
     "Services": "Diensten",
     "About": "Over",
-    "Element Help": "Element Help",
+    "Element Help": "Element-hulp",
     "Help": "Help",
     "Close": "Sluiten",
     "Minimize": "Minimaliseren",
@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "Weet u zeker dat u wilt stoppen?",
     "Close Element": "Element sluiten",
     "Cancel": "Annuleren",
-    "Copy image address": "Kopieer afbeeldingsadres"
+    "Copy image address": "Kopieer afbeeldingsadres",
+    "Close %(brand)s": "Sluit %(brand)s"
 }

src/i18n/strings/pt_BR.json

@@ -43,5 +43,6 @@
     "Cancel": "Cancelar",
     "Bring All to Front": "Trazer Todas Para Frente",
     "Hide Others": "Esconder Outras(os)",
-    "Copy image address": "Copiar endereço de imagem"
+    "Copy image address": "Copiar endereço de imagem",
+    "Close %(brand)s": "Fechar %(brand)s"
 }

src/i18n/strings/ro.json

@@ -35,9 +35,9 @@
     "Redo": "Refă",
     "Undo": "Anulare",
     "Edit": "Editare",
-    "Quit": "Închide",
+    "Quit": "Închid",
     "Show/Hide": "Arată/Ascunde",
-    "Are you sure you want to quit?": "Sunte-ți sigur ca doriți sa inchideți aplicația ?",
-    "Close Element": "închide aplicația",
+    "Are you sure you want to quit?": "Sigur vrei să ieși din cont?",
+    "Close Element": "Închid Element",
     "Cancel": "Anulare"
 }

src/i18n/strings/ru.json

@@ -43,5 +43,6 @@
     "Speech": "Голос",
     "Hide Others": "Скрыть прочие",
     "Paste and Match Style": "Вставить с тем же стилем",
-    "Copy image address": "Копировать адрес изображения"
+    "Copy image address": "Копировать адрес изображения",
+    "Close %(brand)s": "Закрыть %(brand)s"
 }

src/i18n/strings/sk.json

@@ -43,5 +43,6 @@
     "Show/Hide": "Zobraziť/Skryť",
     "Are you sure you want to quit?": "Naozaj chcete zavrieť aplikáciu?",
     "Cancel": "Zrušiť",
-    "Copy image address": "Kopírovať adresu obrázka"
+    "Copy image address": "Kopírovať adresu obrázka",
+    "Close %(brand)s": "Zatvoriť %(brand)s"
 }

src/i18n/strings/sv.json

@@ -43,5 +43,6 @@
     "The image failed to save": "Bilden sparades inte",
     "Failed to save image": "Misslyckades med att spara bilden",
     "Are you sure you want to quit?": "Är du säker att du vill avsluta?",
-    "Copy image address": "Kopiera bildadress"
+    "Copy image address": "Kopiera bildadress",
+    "Close %(brand)s": "Stäng %(brand)s"
 }

src/i18n/strings/zh_Hans.json

@@ -24,7 +24,7 @@
     "Window": "窗口",
     "Toggle Developer Tools": "切换开发者工具",
     "Toggle Full Screen": "切换全屏",
-    "Preferences": "外观",
+    "Preferences": "偏好",
     "Zoom Out": "缩小",
     "Zoom In": "放大",
     "Actual Size": "实际大小",

src/i18n/strings/zh_Hant.json

@@ -43,5 +43,6 @@
     "Are you sure you want to quit?": "您確定要退出嗎？",
     "Close Element": "關閉 Element",
     "Cancel": "取消",
-    "Copy image address": "複製圖片地址"
+    "Copy image address": "複製圖片地址",
+    "Close %(brand)s": "關閉 %(brand)s"
 }

src/ipc.ts

@@ -46,7 +46,7 @@ ipcMain.on('loudNotification', function(): void {
     }
 });
 
-let powerSaveBlockerId: number = null;
+let powerSaveBlockerId: number | null = null;
 ipcMain.on('app_onAction', function(_ev: IpcMainEvent, payload) {
     switch (payload.action) {
         case 'call_state': {
@@ -115,27 +115,27 @@ ipcMain.on('ipcCall', async function(_ev: IpcMainEvent, payload) {
                 global.mainWindow.webContents.goForward();
             }
             break;
-        case 'setSpellCheckLanguages':
-            if (args[0] && args[0].length > 0) {
-                global.mainWindow.webContents.session.setSpellCheckerEnabled(true);
-                global.store.set("spellCheckerEnabled", true);
+        case 'setSpellCheckEnabled':
+            if (typeof args[0] !== 'boolean') return;
 
-                try {
-                    global.mainWindow.webContents.session.setSpellCheckerLanguages(args[0]);
-                } catch (er) {
-                    console.log("There were problems setting the spellcheck languages", er);
-                }
-            } else {
-                global.mainWindow.webContents.session.setSpellCheckerEnabled(false);
-                global.store.set("spellCheckerEnabled", false);
+            global.mainWindow.webContents.session.setSpellCheckerEnabled(args[0]);
+            global.store.set("spellCheckerEnabled", args[0]);
+            break;
+
+        case 'getSpellCheckEnabled':
+            ret = global.store.get("spellCheckerEnabled", true);
+            break;
+
+        case 'setSpellCheckLanguages':
+            try {
+                global.mainWindow.webContents.session.setSpellCheckerLanguages(args[0]);
+            } catch (er) {
+                console.log("There were problems setting the spellcheck languages", er);
             }
             break;
+
         case 'getSpellCheckLanguages':
-            if (global.store.get("spellCheckerEnabled", true)) {
-                ret = global.mainWindow.webContents.session.getSpellCheckerLanguages();
-            } else {
-                ret = [];
-            }
+            ret = global.mainWindow.webContents.session.getSpellCheckerLanguages();
             break;
         case 'getAvailableSpellCheckLanguages':
             ret = global.mainWindow.webContents.session.availableSpellCheckerLanguages;
@@ -147,11 +147,11 @@ ipcMain.on('ipcCall', async function(_ev: IpcMainEvent, payload) {
 
         case 'getPickleKey':
             try {
-                ret = await keytar.getPassword("element.io", `${args[0]}|${args[1]}`);
+                ret = await keytar?.getPassword("element.io", `${args[0]}|${args[1]}`);
                 // migrate from riot.im (remove once we think there will no longer be
                 // logins from the time of riot.im)
                 if (ret === null) {
-                    ret = await keytar.getPassword("riot.im", `${args[0]}|${args[1]}`);
+                    ret = await keytar?.getPassword("riot.im", `${args[0]}|${args[1]}`);
                 }
             } catch (e) {
                 // if an error is thrown (e.g. keytar can't connect to the keychain),
@@ -163,7 +163,7 @@ ipcMain.on('ipcCall', async function(_ev: IpcMainEvent, payload) {
         case 'createPickleKey':
             try {
                 const pickleKey = await randomArray(32);
-                await keytar.setPassword("element.io", `${args[0]}|${args[1]}`, pickleKey);
+                await keytar?.setPassword("element.io", `${args[0]}|${args[1]}`, pickleKey);
                 ret = pickleKey;
             } catch (e) {
                 ret = null;
@@ -172,10 +172,10 @@ ipcMain.on('ipcCall', async function(_ev: IpcMainEvent, payload) {
 
         case 'destroyPickleKey':
             try {
-                await keytar.deletePassword("element.io", `${args[0]}|${args[1]}`);
+                await keytar?.deletePassword("element.io", `${args[0]}|${args[1]}`);
                 // migrate from riot.im (remove once we think there will no longer be
                 // logins from the time of riot.im)
-                await keytar.deletePassword("riot.im", `${args[0]}|${args[1]}`);
+                await keytar?.deletePassword("riot.im", `${args[0]}|${args[1]}`);
             } catch (e) {}
             break;
         case 'getDesktopCapturerSources':

src/keytar.ts

@@ -21,7 +21,7 @@ try {
     // eslint-disable-next-line @typescript-eslint/no-var-requires
     keytar = require('keytar');
 } catch (e) {
-    if (e.code === "MODULE_NOT_FOUND") {
+    if ((<NodeJS.ErrnoException>e).code === "MODULE_NOT_FOUND") {
         console.log("Keytar isn't installed; secure key storage is disabled.");
     } else {
         console.warn("Keytar unexpected error:", e);

src/language-helper.ts

@@ -18,7 +18,7 @@ import counterpart from "counterpart";
 
 import type Store from 'electron-store';
 
-const DEFAULT_LOCALE = "en";
+const FALLBACK_LOCALE = 'en';
 
 export function _td(text: string): string {
     return text;
@@ -27,14 +27,12 @@ export function _td(text: string): string {
 type SubstitutionValue = number | string;
 
 interface IVariables {
-    [key: string]: SubstitutionValue;
+    [key: string]: SubstitutionValue | undefined;
     count?: number;
 }
 
 export function _t(text: string, variables: IVariables = {}): string {
-    const args = Object.assign({ interpolate: false }, variables);
-
-    const { count } = args;
+    const { count } = variables;
 
     // Horrible hack to avoid https://github.com/vector-im/element-web/issues/4191
     // The interpolation library that counterpart uses does not support undefined/null
@@ -43,21 +41,20 @@ export function _t(text: string, variables: IVariables = {}): string {
     // valid ES6 template strings to i18n strings it's extremely easy to pass undefined/null
     // if there are no existing null guards. To avoid this making the app completely inoperable,
     // we'll check all the values for undefined/null and stringify them here.
-    Object.keys(args).forEach((key) => {
-        if (args[key] === undefined) {
+    Object.keys(variables).forEach((key) => {
+        if (variables[key] === undefined) {
             console.warn("safeCounterpartTranslate called with undefined interpolation name: " + key);
-            args[key] = 'undefined';
+            variables[key] = 'undefined';
         }
-        if (args[key] === null) {
+        if (variables[key] === null) {
             console.warn("safeCounterpartTranslate called with null interpolation name: " + key);
-            args[key] = 'null';
+            variables[key] = 'null';
         }
     });
-    let translated = counterpart.translate(text, args);
-    if (translated === undefined && count !== undefined) {
-        // counterpart does not do fallback if no pluralisation exists
-        // in the preferred language, so do it here
-        translated = counterpart.translate(text, Object.assign({}, args, { locale: DEFAULT_LOCALE }));
+    let translated = counterpart.translate(text, variables);
+    if (!translated && count !== undefined) {
+        // counterpart does not do fallback if no pluralisation exists in the preferred language, so do it here
+        translated = counterpart.translate(text, { ...variables, locale: FALLBACK_LOCALE });
     }
 
     // The translation returns text so there's no XSS vector here (no unsafe HTML, no code execution)
@@ -66,17 +63,17 @@ export function _t(text: string, variables: IVariables = {}): string {
 
 type Component = () => void;
 
-type TypedStore = Store<{ locale?: string | string[] }>;
+type TypedStore = Store<{ locale?: string[] }>;
 
 export class AppLocalization {
     private static readonly STORE_KEY = "locale";
 
     private readonly store: TypedStore;
-    private readonly localizedComponents: Set<Component>;
+    private readonly localizedComponents?: Set<Component>;
 
     constructor({ store, components = [] }: { store: TypedStore, components: Component[] }) {
-        counterpart.registerTranslations("en", this.fetchTranslationJson("en_EN"));
-        counterpart.setFallbackLocale('en');
+        counterpart.registerTranslations(FALLBACK_LOCALE, this.fetchTranslationJson("en_EN"));
+        counterpart.setFallbackLocale(FALLBACK_LOCALE);
         counterpart.setSeparator('|');
 
         if (Array.isArray(components)) {
@@ -86,7 +83,8 @@ export class AppLocalization {
         this.store = store;
         if (this.store.has(AppLocalization.STORE_KEY)) {
             const locales = this.store.get(AppLocalization.STORE_KEY);
-            this.setAppLocale(locales);
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+            this.setAppLocale(locales!);
         }
 
         this.resetLocalizedUI();
@@ -110,7 +108,7 @@ export class AppLocalization {
             return require(`./i18n/strings/${this.denormalize(locale)}.json`);
         } catch (e) {
             console.log(`Could not fetch translation json for locale: '${locale}'`, e);
-            return null;
+            return {};
         }
     }
 
@@ -121,16 +119,15 @@ export class AppLocalization {
             locales = [locales];
         }
 
-        locales.forEach(locale => {
+        const loadedLocales = locales.filter(locale => {
             const translations = this.fetchTranslationJson(locale);
             if (translations !== null) {
                 counterpart.registerTranslations(locale, translations);
             }
+            return !!translations;
         });
 
-        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-        // @ts-ignore - this looks like a bug but is out of scope for this conversion
-        counterpart.setLocale(locales);
+        counterpart.setLocale(loadedLocales[0]);
         this.store.set(AppLocalization.STORE_KEY, locales);
 
         this.resetLocalizedUI();
@@ -138,7 +135,7 @@ export class AppLocalization {
 
     public resetLocalizedUI(): void {
         console.log("Resetting the UI components after locale change");
-        this.localizedComponents.forEach(componentSetup => {
+        this.localizedComponents?.forEach(componentSetup => {
             if (typeof componentSetup === "function") {
                 componentSetup();
             }

src/protocol.ts

@@ -86,7 +86,7 @@ export function getProfileFromDeeplink(args: string[]): string | undefined {
     if (deeplinkUrl && deeplinkUrl.includes(SEARCH_PARAM)) {
         const parsedUrl = new URL(deeplinkUrl);
         if (parsedUrl.protocol === PROTOCOL) {
-            const ssoID = parsedUrl.searchParams.get(SEARCH_PARAM);
+            const ssoID = parsedUrl.searchParams.get(SEARCH_PARAM)!;
             const store = readStore();
             console.log("Forwarding to profile: ", store[ssoID]);
             return store[ssoID];

src/seshat.ts

@@ -40,7 +40,7 @@ try {
     ReindexError = seshatModule.ReindexError;
     seshatSupported = true;
 } catch (e) {
-    if (e.code === "MODULE_NOT_FOUND") {
+    if ((<NodeJS.ErrnoException>e).code === "MODULE_NOT_FOUND") {
         console.log("Seshat isn't installed, event indexing is disabled.");
     } else {
         console.warn("Seshat unexpected error:", e);
@@ -49,7 +49,7 @@ try {
 
 const eventStorePath = path.join(app.getPath('userData'), 'EventStore');
 
-let eventIndex: SeshatType = null;
+let eventIndex: SeshatType | null = null;
 
 const seshatDefaultPassphrase = "DEFAULT_PASSPHRASE";
 async function getOrCreatePassphrase(key: string): Promise<string> {
@@ -66,9 +66,8 @@ async function getOrCreatePassphrase(key: string): Promise<string> {
         } catch (e) {
             console.log("Error getting the event index passphrase out of the secret store", e);
         }
-    } else {
-        return seshatDefaultPassphrase;
     }
+    return seshatDefaultPassphrase;
 }
 
 const deleteContents = async (p: string): Promise<void> => {
@@ -180,7 +179,7 @@ ipcMain.on('seshat', async function(_ev: IpcMainEvent, payload): Promise<void> {
 
         case 'addEventToIndex':
             try {
-                eventIndex.addEvent(args[0], args[1]);
+                eventIndex?.addEvent(args[0], args[1]);
             } catch (e) {
                 sendError(payload.id, e);
                 return;
@@ -189,7 +188,7 @@ ipcMain.on('seshat', async function(_ev: IpcMainEvent, payload): Promise<void> {
 
         case 'deleteEvent':
             try {
-                ret = await eventIndex.deleteEvent(args[0]);
+                ret = await eventIndex?.deleteEvent(args[0]);
             } catch (e) {
                 sendError(payload.id, e);
                 return;
@@ -198,7 +197,7 @@ ipcMain.on('seshat', async function(_ev: IpcMainEvent, payload): Promise<void> {
 
         case 'commitLiveEvents':
             try {
-                ret = await eventIndex.commit();
+                ret = await eventIndex?.commit();
             } catch (e) {
                 sendError(payload.id, e);
                 return;
@@ -207,7 +206,7 @@ ipcMain.on('seshat', async function(_ev: IpcMainEvent, payload): Promise<void> {
 
         case 'searchEventIndex':
             try {
-                ret = await eventIndex.search(args[0]);
+                ret = await eventIndex?.search(args[0]);
             } catch (e) {
                 sendError(payload.id, e);
                 return;

src/tray.ts

@@ -22,7 +22,7 @@ import fs from "fs";
 
 import { _t } from "./language-helper";
 
-let trayIcon: Tray = null;
+let trayIcon: Tray | null = null;
 
 export function hasTray(): boolean {
     return (trayIcon !== null);
@@ -65,7 +65,7 @@ export function create(config: IConfig): void {
         if (!favicons || favicons.length <= 0 || !favicons[0].startsWith('data:')) {
             if (lastFavicon !== null) {
                 global.mainWindow.setIcon(defaultIcon);
-                trayIcon.setImage(defaultIcon);
+                trayIcon?.setImage(defaultIcon);
                 lastFavicon = null;
             }
             return;
@@ -88,12 +88,12 @@ export function create(config: IConfig): void {
             }
         }
 
-        trayIcon.setImage(newFavicon);
+        trayIcon?.setImage(newFavicon);
         global.mainWindow.setIcon(newFavicon);
     });
 
     global.mainWindow.webContents.on('page-title-updated', function(ev, title) {
-        trayIcon.setToolTip(title);
+        trayIcon?.setToolTip(title);
     });
 }
 

src/updater.ts

@@ -70,6 +70,7 @@ export function start(updateBaseUrl: string): void {
             // I'm not even going to try to guess which feed style they'd use if they
             // implemented it on Linux, or if it would be different again.
             console.log('Auto update not supported on this platform');
+            return;
         }
 
         if (url) {

src/webcontents-handler.ts

@@ -50,7 +50,7 @@ function safeOpenURL(target: string): void {
     // (for instance, open /bin/sh does indeed open a terminal
     // with a shell, albeit with no arguments)
     const parsedUrl = url.parse(target);
-    if (PERMITTED_URL_SCHEMES.indexOf(parsedUrl.protocol) > -1) {
+    if (PERMITTED_URL_SCHEMES.includes(parsedUrl.protocol!)) {
         // explicitly use the URL re-assembled by the url library,
         // so we know the url parser has understood all the parts
         // of the input string
@@ -69,7 +69,7 @@ function onWindowOrNavigate(ev: Event, target: string): void {
 }
 
 function writeNativeImage(filePath: string, img: NativeImage): Promise<void> {
-    switch (filePath.split('.').pop().toLowerCase()) {
+    switch (filePath.split('.').pop()?.toLowerCase()) {
         case "jpg":
         case "jpeg":
             return fs.promises.writeFile(filePath, img.toJPEG(100));
@@ -181,7 +181,7 @@ function cutCopyPasteSelectContextMenus(params: ContextMenuParams): MenuItemCons
             options.push({
                 label: word,
                 click: (menuItem, browserWindow) => {
-                    browserWindow.webContents.replaceMisspelling(word);
+                    browserWindow?.webContents.replaceMisspelling(word);
                 },
             });
         });
@@ -190,7 +190,7 @@ function cutCopyPasteSelectContextMenus(params: ContextMenuParams): MenuItemCons
         }, {
             label: _t('Add to dictionary'),
             click: (menuItem, browserWindow) => {
-                browserWindow.webContents.session.addWordToSpellCheckerDictionary(params.misspelledWord);
+                browserWindow?.webContents.session.addWordToSpellCheckerDictionary(params.misspelledWord);
             },
         }, {
             type: 'separator',
@@ -251,8 +251,9 @@ function onEditableContextMenu(ev: Event, params: ContextMenuParams) {
 let userDownloadIndex = 0;
 const userDownloadMap = new Map<number, string>(); // Map from id to path
 ipcMain.on('userDownloadAction', function(ev: IpcMainEvent, { id, open = false }) {
-    if (open) {
-        shell.openPath(userDownloadMap.get(id));
+    const path = userDownloadMap.get(id);
+    if (open && path) {
+        shell.openPath(path);
     }
     userDownloadMap.delete(id);
 });

test/launch-test.ts

@@ -0,0 +1,64 @@
+/*
+Copyright 2022 The Matrix.org Foundation C.I.C.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import * as os from "os";
+import * as fs from "fs";
+import * as path from "path";
+import "expect-playwright";
+import { _electron as electron } from "playwright";
+import { ElectronApplication, Page } from "playwright-core";
+
+describe("App launch", () => {
+    const artifactsPath = path.join(process.cwd(), "test_artifacts");
+    fs.mkdirSync(artifactsPath);
+
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "element-desktop-tests"));
+    console.log("Using temp profile directory: ", tmpDir);
+
+    let app: ElectronApplication;
+    let window: Page;
+
+    beforeAll(async () => {
+        const args = ["--profile-dir", tmpDir];
+
+        const executablePath = process.env["ELEMENT_DESKTOP_EXECUTABLE"];
+        if (!executablePath) {
+            // Unpackaged mode testing
+            args.unshift("./lib/electron-main.js");
+        }
+
+        app = await electron.launch({
+            executablePath,
+            args,
+            recordVideo: {
+                dir: artifactsPath,
+            }
+        });
+        window = await app.firstWindow();
+    });
+
+    afterAll(async () => {
+        await app?.close();
+        fs.rmSync(tmpDir, { recursive: true });
+    });
+
+    it("should launch and render the welcome view successfully", async () => {
+        await window.locator("#matrixchat").waitFor();
+        await window.locator(".mx_Welcome").waitFor();
+        await expect(window).toMatchURL("vector://vector/webapp/#/welcome");
+        await window.screenshot({ path: path.join(artifactsPath, "welcome.png") });
+    }, 30000);
+});

tsconfig.json

@@ -14,9 +14,12 @@
     "lib": [
       "es2019",
       "dom"
-    ]
+    ],
+    "types": ["jest", "node"],
+    "strict": true
   },
   "include": [
-    "./src/**/*.ts"
+    "./src/**/*.ts",
+    "./tests/**/*.ts"
   ]
 }