mirror/fdroidclient
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidclient.git synced 2026-05-24 16:35:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add missing "focusable" attributes.

Browse Source 
Fixes lint warnings and improves keyboard navigation
a little bit.
This commit is contained in:
Reimar Döffinger
2018-08-20 13:25:07 +02:00
parent 6345195d41
commit da4c97c4c2
6 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/res/layout/app_card_horizontal.xml
View File

@@ -5,7 +5,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:foreground="?attr/selectableItemBackground"
android:clickable="true">
android:clickable="true"
android:focusable="true">
<android.support.constraint.ConstraintLayout
android:layout_width="match_parent"

3
app/src/main/res/layout/app_card_large.xml
View File

@@ -5,7 +5,8 @@
android:layout_width="match_parent"
android:layout_height="220dp"
android:foreground="?attr/selectableItemBackground"
android:clickable="true">
android:clickable="true"
android:focusable="true">
<android.support.constraint.ConstraintLayout
android:layout_width="match_parent"

3
app/src/main/res/layout/app_card_list_item.xml
View File

@@ -5,7 +5,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:foreground="?attr/selectableItemBackground"
android:clickable="true">
android:clickable="true"
android:focusable="true">
<android.support.constraint.ConstraintLayout
android:layout_width="match_parent"

3
app/src/main/res/layout/app_details2_links.xml
View File

@@ -12,7 +12,8 @@
android:layout_marginBottom="@dimen/details_activity__collapsable_lists__padding__vertical"
android:clickable="true"
android:orientation="vertical"
tools:ignore="UnusedAttribute">
tools:ignore="UnusedAttribute"
android:focusable="true">
<!-- This frame layout is only for showing the material-design-like background ripple when
selecting the TextView. -->

3
app/src/main/res/layout/app_list_item.xml
View File

@@ -6,7 +6,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:clickable="true"
android:background="?attr/selectableItemBackground">
android:background="?attr/selectableItemBackground"
android:focusable="true">
<!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon"
when it will inevitably read out the name of the app straight after. -->

3
app/src/main/res/layout/installed_app_list_item.xml
View File

@@ -9,7 +9,8 @@
android:paddingTop="8dp"
android:paddingBottom="8dp"
android:clickable="true"
android:background="?attr/selectableItemBackground">
android:background="?attr/selectableItemBackground"
android:focusable="true">
<!-- Ignore ContentDescription because it is kind of meaningless to have TTS read out "App icon"
when it will inevitably read out the name of the app straight after. -->