Commit Graph

9481 Commits

Author SHA1 Message Date
Tobias_Groza
b8a80c9196 Add .idea icon for toolbox and Android Studio
This adds the F-Droid icon to the .idea directory which allows .idea applications to show it in several places, e.g. in the Toolbox app. This helps to find the correct project if you are working on the many projects. The file is a copy of /logo-icon.svg
2024-09-16 17:41:03 +00:00
Hans-Christoph Steiner
849510139a Merge branch 'code-quality' into 'master'
Improve code quality and fix Utils.getPercent()

See merge request fdroid/fdroidclient!1425
2024-09-16 16:53:27 +00:00
Tobias_Groza
7076c8dec7 Fix getPercent to return the floored value instead of the rounded up val
Follow up for !1424

With the previous implementation getPercent(1, 200)` returned 1 and getPercent(199, 200) returned 100. The latter is quite misleading, especially when dealing with bigger numbers where the notification could show 100% although the file is still downloading.
2024-09-13 15:50:02 +02:00
Tobias_Groza
6915e1b615 Complete TODO and use DisplayCompat.getMode
F-Droid now uses androidx.appcompat:appcompat:1.6.1
2024-09-13 15:43:25 +02:00
Tobias_Groza
1b75f9c550 Simplify if-else block 2024-09-13 13:52:17 +02:00
Tobias_Groza
841fed8e24 Add missing annotation from overriden method 2024-09-13 13:52:17 +02:00
Hans-Christoph Steiner
f0075a7ded Merge branch 'acra-fixes' into 'master'
Four fixes for acra issues

Closes acra-crash-reports#749, acra-crash-reports#748, acra-crash-reports#741, and acra-crash-reports#740

See merge request fdroid/fdroidclient!1423
2024-09-13 08:35:49 +00:00
Torsten Grote
da717bca62 [app] Don't crash RepoDetailsActivity when repo is gone
Fixes acra-crash-reports#749
2024-09-13 08:35:33 +00:00
Torsten Grote
3590bad5d3 [app] Show Toast from UiThread to avoid crash
Fixes acra-crash-reports#748
2024-09-13 08:35:33 +00:00
Torsten Grote
650dc4432a [app] Don't crash when trying to enable Wi-Fi
Fixes acra-crash-reports#741
2024-09-13 08:35:33 +00:00
Torsten Grote
9f637a602c [app] Don't crash on malformed fdroid.link Uri
Fixes acra-crash-reports#740
2024-09-13 08:35:33 +00:00
Hans-Christoph Steiner
05aa17dea7 Merge branch 'divide-by-zero' into 'master'
Do not divide by zero

Closes acra-crash-reports#737

See merge request fdroid/fdroidclient!1424
2024-09-13 07:53:55 +00:00
Tobias_Groza
8ec282d9c0 Do not divide by zero
Closes fdroid/acra-crash-reports#737
2024-09-12 23:52:04 +02:00
Torsten Grote
32be0026d3 Merge branch '2828-perm-installer-fallback' into 'master'
Don't change installer if APK permissions don't match

Closes #2828

See merge request fdroid/fdroidclient!1410
2024-09-09 19:55:25 +00:00
Torsten Grote
38fe5f6b3c [app] don't change installer if APK permissions don't match 2024-09-06 11:45:54 +00:00
Hans-Christoph Steiner
1cdcec215d Merge branch 'TetheredNet' into 'master'
Add TetheredNet

See merge request fdroid/fdroidclient!1419
2024-09-06 10:31:11 +00:00
linsui
50a966f9bb Add TetheredNet icon imported by Bene 2024-09-06 10:28:59 +00:00
linsui
7f096c714d Add TetheredNet 2024-09-06 10:28:59 +00:00
Hans-Christoph Steiner
374b3251d4 Merge branch 'licaon-kter-master-patch-83050' into 'master'
Update hidden AFs text

See merge request fdroid/fdroidclient!1420
2024-09-06 10:27:34 +00:00
Hans-Christoph Steiner
0c947f8b07 standardize on spelling/caps: Anti-Features 2024-09-05 15:11:23 +02:00
Licaon_Kter
4cfc5c7aa9 Apply 1 suggestion(s) to 1 file(s)
Co-authored-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2024-09-05 09:48:39 +00:00
Licaon_Kter
f581228bcc Update hidden AFs text 2024-09-04 13:16:22 +00:00
Torsten Grote
51a64d3aeb Merge branch 'fts4-search' into 'master'
Fix case insensitive search containing diacritics by changing FTS4 tokenizer

Closes #2636

See merge request fdroid/fdroidclient!1404
2024-09-03 17:23:44 +00:00
Tobias_Groza
f927e7c86d Add test for AppMetadataFTS table migration 2024-09-03 19:06:10 +02:00
Tobias_Groza
14ffc7023b Update tests to use new db schema and migrations 2024-09-03 19:06:10 +02:00
Tobias_Groza
1e7324ca3b Fix case insensitive search containing diacritics by changing FTS4 tokenizer
The default `simple` tokenzier config used in Room/SQLite3 FTS4 makes only ASCII characters case insensitive. The SQLite FTS3/4 doc [1] says:

> All uppercase characters within the ASCII range (Unicode codepoints less than 128), are transformed to their lowercase equivalents as part of the tokenization process. Thus, full-text queries are case-insensitive when using the simple tokenizer.

> The remove_diacritics option may be set to "0", "1" or "2". The default value is "1". If it is set to "1" or "2", then diacritics are removed from Latin script characters as described above. However, if it is set to "1", then diacritics are not removed in the fairly uncommon case where a single unicode codepoint is used to represent a character with more that one diacritic. [...] This is technically a bug, but cannot be fixed without creating backwards compatibility problems. If this option is set to "2", then diacritics are correctly removed from all Latin characters.

This change makes use of the intended behaviour by using the `unicode61` tokenizer with the `diacritics="0"` option to keep the behaviour similar to the current one. This replaces the previously used `simple` tokenizer. A migration is necessary to recreate the AppMetadataFts table to make use of the different tokenizer.

[1] https://www.sqlite.org/fts3.html#tokenizer
2024-09-03 19:06:10 +02:00
Torsten Grote
79424fa757 Merge branch 'licaon-kter-master-patch-51220' into 'master'
Update NFN text

See merge request fdroid/fdroidclient!1418
2024-09-03 16:55:03 +00:00
Licaon_Kter
e3af1897db Update NFN text 2024-09-03 16:54:44 +00:00
Torsten Grote
0ed7a09dde Merge branch 'fix-incompatible-install' into 'master'
Fix visibility of install/update button when no compatible versions are available

Closes #2847

See merge request fdroid/fdroidclient!1414
2024-09-03 16:54:22 +00:00
Tobias_Groza
83139ed5e6 Fix visibility of install/update button when no compatible versions are available
This fixes a regression introduced by 73ce4443b0.
2024-09-03 18:40:41 +02:00
Tobias_Groza
af4de1217e Remove unnecessary null check
canAndWantToUpdate returns false if suggestedApk is null
2024-09-03 18:40:41 +02:00
Torsten Grote
2fdc87c4f6 Merge branch 'fix-repo-adder' into 'master'
Fix mirror detection when adding repo with whitespace in URL input

See merge request fdroid/fdroidclient!1416
2024-09-03 14:53:32 +00:00
Tobias_Groza
0a1297ff3d Fix detecting repo as user mirror when adding a repo URL with preceeding or trailing whitespace characters 2024-09-03 13:53:46 +00:00
Torsten Grote
b670858a38 Merge branch 'fix-repo-remove-crash' into 'master'
Fix crash when deleting repository

Closes #2849

See merge request fdroid/fdroidclient!1415
2024-09-03 13:53:31 +00:00
Tobias_Groza
c015f72370 Fix crash when deleting repository
This fixes an NPE that was triggered when deleting a repo via the RepoDetailsActivity. The repo is null after it has been deleted. The corresponding RepoDetails are now closed after the deletion.
2024-09-03 13:00:07 +00:00
Hans-Christoph Steiner
2cc5f137cf Merge branch 'update-scheduler-tweaks' into 'master'
Don't require device to be idle for RepoUpdateWorker to run

Closes #1794

See merge request fdroid/fdroidclient!1411
2024-09-03 12:51:07 +00:00
Torsten Grote
263c61d8ad [app] don't report negative update scheduling times in settings
When the scheduling time is in the past, our job should have run already, but did not, because conditions we require weren't fulfilled. Times in the past are confusing for users, so we just report that the next run is waiting for conditions to be fulfilled.
2024-08-01 16:25:34 -03:00
Torsten Grote
cc0a036a74 [app] don't require device to be idle for RepoUpdateWorker to run
Sometimes devices are not idle for a long time potentially causing many hours of delay. Some device have been reported to never be idle: https://gitlab.com/fdroid/fdroidclient/-/issues/1794

Closes #1794
2024-08-01 16:22:21 -03:00
Torsten Grote
168f235fd0 Merge branch 'update-worker' into 'master'
Replace UpdateService with WorkManager alternative

Closes #1092 and #2710

See merge request fdroid/fdroidclient!1386
2024-07-12 13:42:43 +00:00
Torsten Grote
c2b021a39a [app] add ktlint checking and fix complaints it has 2024-07-12 10:05:30 -03:00
Torsten Grote
eb367041a3 [app] Remove unused UpdateService and related classes
All functionality was migrated to its new WorkManager based replacement: RepoUpdateWorker and RepoUpdateManager
2024-07-12 09:36:38 -03:00
Torsten Grote
59bbeb7c7c [app] Add new RepoUpdateReceiver for system apps to trigger repository updates
One known use-case for this is to do an initial repository update during SetupWizard, so app data is available when needed, e.g. for restoring app backups.
2024-07-12 09:36:38 -03:00
Torsten Grote
e2eed58b36 [app] show earliest next update check in the UI
This is useful for debugging scheduling issues. The user can immediately see if and when an update is scheduled to happen.
2024-07-12 09:36:38 -03:00
Torsten Grote
7912f870f6 [app] replace all usages of UpdateService with new alternatives
This uses LiveData to replace local broadcasts. One advantage of this is that the last live data value doesn't get lost when the view was stopped.
2024-07-12 09:36:38 -03:00
Torsten Grote
6934c62674 [app] add RepoUpdateManager and RepoUpdateWorker
to replace UpdateService which is still based on deprecated JobService API and known to be unreliable.

This also introduces a new lean NotificationManager which can eventually supersede the old one.
2024-07-12 09:31:38 -03:00
Torsten Grote
92554b6459 [app] Give AppUpdateStatusManager the responsibility to queue app updates
This is mostly for efficiency, since it queries the DB for new updates anyway, so it can already enqueue those for auto-update if the respective settings allow.
2024-07-12 09:31:38 -03:00
Torsten Grote
510a6c07f3 [db] return the repoId of the archive when adding/enabling it 2024-07-12 09:31:37 -03:00
Hans-Christoph Steiner
9aae1d58a1 Merge branch '2825-update-bug' into 'master'
Fix bug where disabled repos were considered for preferred repo calculation

Closes #2825

See merge request fdroid/fdroidclient!1409
1.21.0-alpha0
2024-07-09 16:03:00 +00:00
Torsten Grote
fb041c4450 [db] Fix bug where disabled repos were considered for preferred repo calculation
If an update was available from a disabled repo with a higher priority, the update from an enabled repo with a lower priority would not be offered as an update (i.e. returned by DbUpdateChecker#getUpdatableApps()).
2024-07-09 16:02:37 +00:00
Torsten Grote
15182dc9dc Merge branch '1.21-alpha0' into 'master'
Release 1.21-alpha0

See merge request fdroid/fdroidclient!1408
2024-07-09 15:09:01 +00:00