mirror of
https://github.com/f-droid/fdroidserver.git
synced 2026-05-09 16:23:33 -04:00
🐛 publish: fix exit status integer overflow
publish.py currently uses the number of failed verifications as exit status. `sys.exit(failed)` Whenever the number of failed verification attempts is divisible by 256 the return status is 0. exit status 0 however conveys that there were no errors, so as long as an attacker can controll the number of verification failures they can use this to turn off verification alltogether.
This commit is contained in:
committed by
Hans-Christoph Steiner
parent
f569301ada
commit
d1df6be2e2
@@ -471,7 +471,7 @@ def main():
|
||||
if failed:
|
||||
logging.error(_('%d APKs failed to be signed or verified!') % failed)
|
||||
if options.error_on_failed:
|
||||
sys.exit(failed)
|
||||
sys.exit(1)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
|
||||
Reference in New Issue
Block a user