PlatformIO's upload-port autodetection enumerates boards from every installed
platform, not just the one being built. platform-raspberrypi's
_add_default_debug_tools() acts on any of cmsis-dap, raspberrypi-swd and
picoprobe that a board lists in upload.protocols, and asserts that
debug.openocd_target is set for each of them.
t-impulse-plus lists cmsis-dap but has no openocd_target, so that assert fired
during port detection and aborted `-t upload` for every environment in the
repo. Flashing an ESP32-S3 board failed on an nRF52840 board's manifest:
*** [upload] AssertionError : Missing target configuration for t-impulse-plus
The manifest has been missing the key since #10497; it only started biting when
the platform pin moved in #11814. Use nrf52840-mdk-rs, as the other thirty
nRF52840 boards in boards/ already do. It is the only board in the tree that
trips this.
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>