mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-05-02 13:05:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix a system-helper crash

Browse Source 
As seen in https://github.com/flatpak/flatpak/issues/2829,
the system-helper crashes while trying to access an as
parameter as s. Looking at the likely culprits for this,
I find that the permission check for Deploy has an off-by-one
error where it tries to get the installation, but
passes the offset for the previous_ids  parameter.

Closes: #2831
Approved by: matthiasclasen
This commit is contained in:
Matthias Clasen
2019-04-14 23:38:39 -04:00
committed by Atomic Bot
parent d0842a1e4c
commit 00dfce5283
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
system-helper/flatpak-system-helper.c
View File

@@ -1885,7 +1885,7 @@ flatpak_authorize_method_handler (GDBusInterfaceSkeleton *interface,
g_variant_get_child (parameters, 1, "u", &flags);
g_variant_get_child (parameters, 2, "&s", &ref);
g_variant_get_child (parameters, 3, "&s", &origin);
g_variant_get_child (parameters, 5, "&s", &installation);
g_variant_get_child (parameters, 6, "&s", &installation);
/* For metadata updates, redirect to the metadata-update action which
* should basically always be allowed */