mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-01-22 06:38:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

update portal: Don't allow self-updates if new permissions are needed

Browse Source 
In this case we report a NotSupported error (not permission denied, because
that is used for other things).
This commit is contained in:
Alexander Larsson
2019-10-02 13:48:21 +02:00
committed by Alexander Larsson
parent 13be8b6365
commit 05df609e75
1 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
portal/flatpak-portal.c
View File

@@ -1617,10 +1617,43 @@ static gboolean
transaction_ready (FlatpakTransaction *transaction,
TransactionData *d)
{
GList *ops = flatpak_transaction_get_operations (transaction);
int status;
GList *l;
d->n_ops = g_list_length (flatpak_transaction_get_operations (transaction));
d->n_ops = g_list_length (ops);
d->op = 0;
d->progress = 0;
for (l = ops; l != NULL; l = l->next)
{
FlatpakTransactionOperation *op = l->data;
const char *ref = flatpak_transaction_operation_get_ref (op);
FlatpakTransactionOperationType type = flatpak_transaction_operation_get_operation_type (op);
/* Actual app updates need to not increase premission requirements */
if (type == FLATPAK_TRANSACTION_OPERATION_UPDATE && g_str_has_prefix (ref, "app/"))
{
GKeyFile *new_metadata = flatpak_transaction_operation_get_metadata (op);
GKeyFile *old_metadata = flatpak_transaction_operation_get_old_metadata (op);
g_autoptr(FlatpakContext) new_context = flatpak_context_new ();
g_autoptr(FlatpakContext) old_context = flatpak_context_new ();
if (!flatpak_context_load_metadata (new_context, new_metadata, NULL) ||
!flatpak_context_load_metadata (old_context, old_metadata, NULL) ||
flatpak_context_adds_permissions (old_context, new_context))
{
g_autoptr(GError) error = NULL;
g_set_error (&error, G_DBUS_ERROR, G_DBUS_ERROR_NOT_SUPPORTED,
_("Self update not supported, new version requires new permissions"));
send_progress (d->out,
d->op, d->n_ops, d->progress,
PROGRESS_STATUS_ERROR,
error);
return FALSE;
}
}
}
if (flatpak_transaction_is_empty (transaction))
status = PROGRESS_STATUS_EMPTY;