mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-05-19 14:22:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

flatpak-run: Correctly handle symlinks in flatpak_exports_path_is_visible

Browse Source 
When we're resolving a symlink to see if the destination is visible, then
we have to actually append the rest of the path to look at the final
target, not just the intermediate symlinked directory.
This commit is contained in:
Alexander Larsson
2017-09-25 14:05:52 +02:00
parent 6d5beff5d3
commit 5ca82643d2
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
common/flatpak-run.c
View File

@@ -2560,7 +2560,7 @@ flatpak_exports_path_is_visible (FlatpakExports *exports,
path = canonical = flatpak_canonicalize_filename (path);
parts = g_strsplit (path, "/", -1);
parts = g_strsplit (path+1, "/", -1);
/* A path is visible in the sandbox if no parent
* path element that is mapped in the sandbox is
@@ -2581,10 +2581,21 @@ flatpak_exports_path_is_visible (FlatpakExports *exports,
if (S_ISLNK (st.st_mode))
{
g_autofree char *resolved = flatpak_resolve_link (path_builder->str, NULL);
g_autoptr(GString) path2_builder = NULL;
int j;
if (resolved == NULL)
return FALSE;
path2_builder = g_string_new (resolved);
return flatpak_exports_path_is_visible (exports, resolved);
for (j = i + 1; parts[j] != NULL; j++)
{
g_string_append (path2_builder, "/");
g_string_append (path2_builder, parts[j]);
}
return flatpak_exports_path_is_visible (exports, path2_builder->str);
}
}
else if (parts[i+1] == NULL)