mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-03-28 20:02:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

fdio: Use correct dfd with O_TMPFILE in rename case

Browse Source 
While auditing this code to figure out why ostree's
`tests/test-refs.sh` was failing, while the bug turned out to be
different, I noticed that in the case where `dfd != target_dfd`, we
failed to do the right `renameat()`.  (No code I'm aware of does this
now).
This commit is contained in:
Colin Walters
2016-07-08 12:57:12 -04:00
parent 113c770dc1
commit 78ae787757
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
glnx-fdio.c
View File

@@ -255,7 +255,7 @@ glnx_link_tmpfile_at (int dfd,
g_set_error (error, G_IO_ERROR, G_IO_ERROR_EXISTS,
"Exhausted %u attempts to create temporary file", count);
}
if (renameat (dfd, tmpname_buf, target_dfd, target) < 0)
if (renameat (target_dfd, tmpname_buf, target_dfd, target) < 0)
{
glnx_set_error_from_errno (error);
return FALSE;