mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-03-19 15:37:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Ensure more fds are opened O_CLOEXEC so they are not accidentally inherited

Browse Source
This commit is contained in:
Alexander Larsson
2018-05-16 14:00:46 +02:00
parent f3a61c6dc8
commit a52e102bfb
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/flatpak-exports.c
View File

@@ -419,7 +419,7 @@ check_if_autofs_works (const char *path)
int res;
int wstatus;
if (pipe (selfpipe) == -1)
if (pipe2 (selfpipe, O_CLOEXEC) == -1)
return FALSE;
fcntl (selfpipe[0], F_SETFL, fcntl (selfpipe[0], F_GETFL) | O_NONBLOCK);

4
common/flatpak-run.c
View File

@@ -649,7 +649,7 @@ add_bwrap_wrapper (FlatpakBwrap *bwrap,
struct dirent *dent;
g_autofree char *proxy_socket_dir = g_build_filename (g_get_user_runtime_dir (), ".dbus-proxy/", NULL);
app_info_fd = open (app_info_path, O_RDONLY);
app_info_fd = open (app_info_path, O_RDONLY | O_CLOEXEC);
if (app_info_fd == -1)
return glnx_throw_errno_prefix (error, _("Failed to open app info file"));
@@ -747,7 +747,7 @@ start_dbus_proxy (FlatpakBwrap *app_bwrap,
proxy_start_index = proxy_bwrap->argv->len;
if (pipe (sync_fds) < 0)
if (pipe2 (sync_fds, O_CLOEXEC) < 0)
{
g_set_error_literal (error, G_IO_ERROR, g_io_error_from_errno (errno),
_("Unable to create sync pipe"));