mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-04-03 14:56:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

portal: Fix unset GError issue

Browse Source 
Fix lookup_installation_for_path() to not leave the GError pointer unset
on its error code path. This error is only used by the caller for a
debug message, and shouldn't be hit normally, but it could mean a NULL
pointer dereference when we try to print error->message.

(cherry picked from commit 075c86ca4f)
This commit is contained in:
Phaedrus Leeds
2020-09-14 09:53:51 -07:00
committed by Alexander Larsson
parent f4bdcfbbbc
commit ab3aa8d7db
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
portal/flatpak-portal.c
View File

@@ -1527,11 +1527,10 @@ lookup_installation_for_path (GFile *path, GError **error)
installation = g_hash_table_lookup (installation_cache, path);
if (installation == NULL)
{
g_autoptr(GError) error = NULL;
g_autoptr(FlatpakDir) dir = NULL;
dir = flatpak_dir_get_by_path (path);
installation = flatpak_installation_new_for_dir (dir, NULL, &error);
installation = flatpak_installation_new_for_dir (dir, NULL, error);
if (installation == NULL)
return NULL;