mirror/galaxy-integrations-python-api
1
0
Fork 0
mirror of https://github.com/gogcom/galaxy-integrations-python-api.git synced 2026-01-29 00:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

PLINT-139 added default values for optional UserInfo dataclass parameters

Browse Source
This commit is contained in:
Albert Suralinski
2020-12-03 10:02:25 +01:00
committed by Mieszko Banczerowski
parent 96cb48fcaf
commit f0d65a72ff
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/galaxy/api/types.py
View File

@@ -166,8 +166,8 @@ class UserInfo:
"""
user_id: str
user_name: str
avatar_url: Optional[str]
profile_url: Optional[str]
avatar_url: Optional[str] = None
profile_url: Optional[str] = None
@dataclass

8
tests/test_friends.py
View File

@@ -18,7 +18,9 @@ async def test_get_friends_success(plugin, read, write):
read.side_effect = [async_return_value(create_message(request)), async_return_value(b"", 10)]
plugin.get_friends.return_value = async_return_value([
UserInfo("3", "Jan", "https://avatar.url/u3", None),
UserInfo("5", "Ola", None, "https://profile.url/u5")
UserInfo("5", "Ola", None, "https://profile.url/u5"),
UserInfo("6", "Ola2", None),
UserInfo("7", "Ola3"),
])
await plugin.run()
plugin.get_friends.assert_called_with()
@@ -30,7 +32,9 @@ async def test_get_friends_success(plugin, read, write):
"result": {
"friend_info_list": [
{"user_id": "3", "user_name": "Jan", "avatar_url": "https://avatar.url/u3"},
{"user_id": "5", "user_name": "Ola", "profile_url": "https://profile.url/u5"}
{"user_id": "5", "user_name": "Ola", "profile_url": "https://profile.url/u5"},
{"user_id": "6", "user_name": "Ola2"},
{"user_id": "7", "user_name": "Ola3"},
]
}
}