Don't create log file if not specified

galaxy/api/consts.py

@@ -31,7 +31,7 @@ class LicenseType(Enum):
     OtherUserLicense = "OtherUserLicense"
 
 class LocalGameState(Enum):
-    Unknown = "Unknown"
+    None_ = "None"
     Installed = "Installed"
     Running = "Running"
 

galaxy/api/jsonrpc.py

@@ -104,6 +104,7 @@ class Server():
         method = self._notifications.get(request.method)
         if not method:
             logging.error("Received uknown notification: %s", request.method)
+            return
 
         callback, internal = method
         if internal:

galaxy/api/plugin.py

@@ -315,12 +315,26 @@ class Plugin():
     async def get_game_times(self):
         raise NotImplementedError()
 
-def create_and_run_plugin(plugin_class, argv):
+def _prepare_logging(logger_file):
     root = logging.getLogger()
     root.setLevel(logging.DEBUG)
-    if len(argv) >= 4:
-        handler = logging.handlers.RotatingFileHandler(argv[3], "a", 10000000, 10)
-        root.addHandler(handler)
+    if logger_file:
+        handler = logging.handlers.RotatingFileHandler(
+            logger_file,
+            mode="a",
+            maxBytes=10000000,
+            backupCount=10,
+            encoding="utf-8"
+        )
+    else:
+        handler = logging.StreamHandler()
+    formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s')
+    handler.setFormatter(formatter)
+    root.addHandler(handler)
+
+def create_and_run_plugin(plugin_class, argv):
+    logger_file = argv[3] if len(argv) >= 4 else None
+    _prepare_logging(logger_file)
 
     if len(argv) < 3:
         logging.critical("Not enough parameters, required: token, port")

galaxy/api/types.py

@@ -28,8 +28,13 @@ class Game():
 
 @dataclass
 class Achievement():
-    achievement_id: str
     unlock_time: int
+    achievement_id: Optional[str] = None
+    achievement_name: Optional[str] = None
+
+    def __post_init__(self):
+        assert self.achievement_id or self.achievement_name, \
+            "One of achievement_id or achievement_name is required"
 
 @dataclass
 class LocalGame():

setup.py

@@ -2,7 +2,7 @@ from setuptools import setup, find_packages
 
 setup(
     name="galaxy.plugin.api",
-    version="0.10",
+    version="0.12",
     description="Galaxy python plugin API",
     author='Galaxy team',
     author_email='galaxy@gog.com',

tests/test_achievements.py

@@ -1,9 +1,18 @@
 import asyncio
 import json
+from pytest import raises
 
 from galaxy.api.types import Achievement
 from galaxy.api.errors import UnknownError
 
+def test_initialization_no_unlock_time():
+    with raises(Exception):
+        Achievement(achievement_id="lvl30", achievement_name="Got level 30")
+
+def test_initialization_no_id_nor_name():
+    with raises(AssertionError):
+        Achievement(unlock_time=1234567890)
+
 def test_success(plugin, readline, write):
     request = {
         "jsonrpc": "2.0",
@@ -15,8 +24,9 @@ def test_success(plugin, readline, write):
     }
     readline.side_effect = [json.dumps(request), ""]
     plugin.get_unlocked_achievements.return_value = [
-        Achievement("lvl10", 1548421241),
-        Achievement("lvl20", 1548422395)
+        Achievement(achievement_id="lvl10", unlock_time=1548421241),
+        Achievement(achievement_name="Got level 20", unlock_time=1548422395),
+        Achievement(achievement_id="lvl30", achievement_name="Got level 30", unlock_time=1548495633)
     ]
     asyncio.run(plugin.run())
     plugin.get_unlocked_achievements.assert_called_with(game_id="14")
@@ -32,8 +42,13 @@ def test_success(plugin, readline, write):
                     "unlock_time": 1548421241
                 },
                 {
-                    "achievement_id": "lvl20",
+                    "achievement_name": "Got level 20",
                     "unlock_time": 1548422395
+                },
+                {
+                    "achievement_id": "lvl30",
+                    "achievement_name": "Got level 30",
+                    "unlock_time": 1548495633
                 }
             ]
         }
@@ -65,7 +80,7 @@ def test_failure(plugin, readline, write):
     }
 
 def test_unlock_achievement(plugin, write):
-    achievement = Achievement("lvl20", 1548422395)
+    achievement = Achievement(achievement_id="lvl20", unlock_time=1548422395)
 
     async def couritine():
         plugin.unlock_achievement("14", achievement)