rubocop lint fix ups

This commit is contained in:
Brenda Wallace
2019-07-08 09:04:58 +12:00
parent fe81923ae1
commit 03dfcdcc57
3 changed files with 5 additions and 6 deletions

View File

@@ -2,7 +2,7 @@ module IconsHelper
include FontAwesome::Sass::Rails::ViewHelpers
def icon_for_model(the_model)
self.send("#{the_model.class.name.downcase}_icon")
send("#{the_model.class.name.downcase}_icon")
end
def timeline_icon

View File

@@ -1,11 +1,11 @@
class TimelineService
def self.member_query(member)
self.query.where(owner_id: member.id)
query.where(owner_id: member.id)
end
# A timeline of events by people the member follows
def self.followed_query(member)
self.query.where(owner_id: [member.followed.pluck(:id)])
query.where(owner_id: [member.followed.pluck(:id)])
end
def self.query
@@ -100,5 +100,4 @@ class TimelineService
'slug'
)
end
end

View File

@@ -6,11 +6,11 @@ describe 'timeline' do
describe 'followed_by(member)' do
let!(:planting) { FactoryBot.create :planting, owner: friend, planted_at: 1.day.ago }
let!(:harvest) { FactoryBot.create :harvest, owner: friend, harvested_at: 2.days.ago }
before {friend.followers << member }
before { friend.followers << member }
subject { TimelineService.followed_query(member) }
it { expect(subject.first).to eq planting }
it { expect(TimelineService.resolve_model(subject.second)).to eq harvest }
end
describe
describe
end