Remove Photo.reindex calls from test suite

The Photo model is no longer using Searchkick/Elasticsearch, so calling
`Photo.reindex` causes a NoMethodError. This commit removes these calls
from `spec/spec_helper.rb` and feature specs, and removes the unused
`:reindex` trait from the photo factory call in `likeable_spec.rb`.

Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>

spec/features/home/home_spec.rb

@@ -28,7 +28,6 @@ describe "home page", :search do
     Planting.reindex
     Seed.reindex
     Harvest.reindex
-    Photo.reindex
 
     visit root_path
   end

spec/features/likeable_spec.rb

@@ -6,14 +6,10 @@ describe 'Likeable', :js, :search do
   let(:another_member) { create(:london_member) }
   let!(:post)           { create(:post, :reindex, author: member) }
   let!(:activity)       { create(:activity, :reindex, owner: member) }
-  let!(:photo)          { create(:photo, :reindex, owner: member) }
+  let!(:photo)          { create(:photo, owner: member) }
   let!(:harvest)        { create(:harvest, :reindex, owner: member) }
   let!(:planting)       { create(:planting, :reindex, owner: member) }
 
-  before do
-    Photo.reindex
-  end
-
   include_context 'signed in member'
 
   shared_examples 'object can be liked' do

spec/spec_helper.rb

@@ -47,7 +47,6 @@ RSpec.configure do |config|
     # reindex models
     Crop.reindex
     Harvest.reindex
-    Photo.reindex
     Planting.reindex
     Seed.reindex
   end