Commit Graph

1031 Commits

Author SHA1 Message Date
Skud
7801a7ec09 Merge branch 'dev' into staff 2013-07-09 10:05:37 +10:00
Skud
c2be06e68f Fixed failing timestamp test on postgres 2013-07-08 13:28:59 +10:00
Skud
923f01cd72 cleaned up boring controller tests 2013-07-08 13:24:26 +10:00
Skud
1ff2211c0f removed boring tests from controllers
the tests generated by 'rails g scaffold...' are boring and brittle.
they don't actually test anything other than the rails framework, and
they were causing us all kinds of trouble. we've started to blow them
away (and raised a PT chore to remove them from other controllers in due
course).
2013-07-08 13:09:37 +10:00
Skud
ec80b01c7a cleaning up tests on postgres
- still trying to make sure we explicitly use a real member, not just
assume there's one with id = 1

- also it looks like the tests for post activity are passing for obscure
reasons on sqlite when they shouldn't be. this is a known bug
(https://www.pivotaltracker.com/story/show/51280861) apparently
invisible to us under sqlite.
2013-07-08 12:18:51 +10:00
Skud
0508837303 Can't assume we have a member with id = 1
this works on sqlite but not on postgres (which we now test on, on
travis)
2013-07-08 12:00:45 +10:00
Skud
878af07419 gave up on not_staff, shuffling interesting members instead 2013-07-08 11:54:55 +10:00
Skud
706881dbdb set up test users in travis environment 2013-07-08 11:30:17 +10:00
Skud
68923d49fe load test gems in travis environment too 2013-07-08 11:15:47 +10:00
Skud
8314851a8e fixed c&p error in database.yml 2013-07-08 11:05:46 +10:00
Skud
c17ef8e566 attempt to get travis to test on psql not sqlite 2013-07-08 10:59:31 +10:00
pozorvlak
f16999c3bd Merge pull request #246 from Skud/older-photos
view/select older flickr photos
2013-07-05 08:52:25 -07:00
pozorvlak
c6d038edc0 Merge pull request #245 from Skud/planting-method
Planting method
2013-07-05 07:08:27 -07:00
Skud
db16ad34f7 view/select older flickr photos 2013-07-05 22:07:55 +10:00
Skud
8bee9fcd1b use blank instead of != 0 for qty 2013-07-05 21:11:07 +10:00
Skud
902b82a295 display planted_from on planting page 2013-07-05 21:09:21 +10:00
Skud
1689d7fdb1 added planted_from to planting form 2013-07-05 20:57:14 +10:00
Skud
b71ac3decb added planted_from (eg seed, seedling) 2013-07-05 20:53:11 +10:00
Skud
2483d760d3 Merge pull request #244 from pozorvlak/fix_rake
Fix "uninitialized constant Rake::DSL" on Heroku.
2013-07-04 16:26:03 -07:00
Miles Gould
ffacf272e7 Fix "uninitialized constant Rake::DSL" on Heroku.
From http://stackoverflow.com/questions/6181312/how-to-fix-the-uninitialized-constant-rakedsl-problem-on-heroku/6263256#6263256
2013-07-04 13:46:36 +01:00
Skud
e4dd0f98e8 Merge pull request #243 from lucymclaughlin/forex_link
Forex link
2013-07-04 01:28:40 -07:00
Skud
067fd27837 Merge pull request #238 from pozorvlak/exclude-staff-from-members
Exclude staff from list of interesting members
2013-07-03 16:58:13 -07:00
Skud
6e895376a0 Merge pull request #239 from pozorvlak/kill_unused_helpers
Delete unused helpers and tests for same.
2013-07-03 16:55:06 -07:00
Lucy
778d7a68c3 Fix bug in order total; add conversion link to order show.
The old order total method did not account for quantities. The
view test for order totals was not catching this, so we've
strengthened it. We also added a conversion link to the order
summary page and created an additional test to check that orders
with more than one item were generating the correct total.
2013-07-03 14:10:37 +01:00
Lucy
e674a6572e Added conversion links for recommended prices.
The paragraphs were getting a bit verbose so we shortened the link
text as well. Added an additional test to make sure the link is
working here too.
2013-07-03 13:22:07 +01:00
Lucy
5c92bb04d3 Updated the foreign exchange link to use configured currency. 2013-07-03 13:04:43 +01:00
Lucy
67c457dfcd Modified the foreign exchange link to convert the right price.
Changed the forex site to Wolfram Alpha from XE, which allow us
to convert the right number of AUD with one click. Upated tests to
reflect this change.
2013-07-03 12:59:49 +01:00
Lucy
80ed2179e2 Proof of concept for adding a foreign exchange link to the shop.
Added a function that returns a link for a foreign exchange site
and showed it on the Shop page. Also included a test to make sure
it works.
2013-07-03 12:50:56 +01:00
Miles Gould
6469ed9418 Delete unused helpers and tests for same. 2013-07-03 11:34:08 +01:00
Lucy
e7b0165628 Updated script/deploy-tasks.sh to include nil_account_type task.
We added a rake task to ensure all account have a Free account
type. This ensures the new nil_account_type rake task will be run
at deploy time.
2013-07-03 11:22:47 +01:00
Lucy
9ce85e2f73 Updated tests to test for the default account type.
Tests used to check that the default account type was always "Free".
Now that we have a default account type as a config variable, the
tests test to see the default account type matches the value of that
variable.
2013-07-03 11:17:18 +01:00
Lucy
278db17108 Removed redundant logic for free account type in apps/views
A couple of pages were testing for an account type and displaying
"Free" if account type was nil. Now that we've ensured every account
has an account type, this is no longer necessary.
2013-07-03 11:15:31 +01:00
Lucy
650f24099d Added default account type of "Free" in config/applications.rb 2013-07-03 11:04:42 +01:00
Lucy
1b0a708b04 Documented reason for using south_pole_member in tests. 2013-07-03 10:51:55 +01:00
Joseph Caudle
ce0c7b1e2c Merge pull request #242 from Skud/cancan-messages
prettified some of the error messages
2013-07-02 21:12:21 -07:00
Skud
9f65aad5c6 prettified some of the error messages 2013-07-03 13:06:57 +10:00
Skud
5c7a0a1ff7 Merge pull request #240 from pozorvlak/gem_decruft
Remove some cruft from our Gemfile
2013-07-02 16:54:00 -07:00
Skud
69f8eec209 Merge pull request #241 from pozorvlak/fix-travis
Fix travis
2013-07-02 16:51:51 -07:00
Miles Gould
5b061877ff Upgrade debugger to 1.6.0
This should now include the headers for Ruby 1.9.3-p429 whose absence
was causing our builds to fail. Better late than never...
2013-06-26 12:09:39 +01:00
Miles Gould
3d42844d62 Document gems in test group 2013-06-26 12:00:56 +01:00
Miles Gould
2f93982ae6 Document the :assets group in Gemfile.
I think we can probably delete some of it (in particular compass-rails),
but don't know how to test it. Halp plz?
2013-06-26 11:50:09 +01:00
Miles Gould
4cdadfb385 Document what CanCan does in Gemfile. 2013-06-26 11:50:09 +01:00
Miles Gould
24af32970c Remove watchr continuous-testing gem.
Nobody was using it :-(
2013-06-26 11:50:09 +01:00
Miles Gould
2d8128e54d Slightly simplify tests for not_staff scope.
There's no reason to set a location on the test member.
2013-06-26 10:55:19 +01:00
Miles Gould
d26dd4499c Deleted unused admin_helper_spec.rb 2013-06-26 10:55:19 +01:00
Miles Gould
8dceb985a1 Fix pending tests in views/shop/index.
We needed to stub out current_member, not current_user.
2013-06-26 10:55:19 +01:00
Miles Gould
0040ee8727 Rake task to give everyone free accounts; fix descriptions. 2013-06-26 10:55:19 +01:00
Miles Gould
5bcd4c2edd Use ActiveRecord methods for not_staff join code.
- set member.account_type directly in tests, because changes to
   member.account.account_type weren't being persisted.
2013-06-26 10:55:19 +01:00
Miles Gould
f6073ab01c Remove "if account_type" checks in Account.
- remove account_type_string method
 - simplify paid_until_string.
2013-06-26 10:55:19 +01:00
Miles Gould
0a8aaf0ee6 Create free account type if it doesn't exist; fix tests. 2013-06-26 10:55:19 +01:00