mirror/growstuff
1
0
Fork 0
mirror of https://github.com/Growstuff/growstuff.git synced 2026-06-06 07:07:33 -04:00
Code Issues Packages Projects Releases Wiki Activity
3,327 Commits 64 Branches 82 Tags
release16
Commit Graph

3327 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Cesy
cf8fab8ed9 Merge pull request #1080 from Growstuff/dev 
Release 16
release16 		2016-11-30 15:07:42 +00:00
Mackenzie
376e6c08d3 Merge pull request #1097 from pozorvlak/precompile_assets_in_test 
Precompile assets in test
 2016-11-30 09:44:15 -05:00
Mackenzie
0cbaac3c75 Merge pull request #1098 from pozorvlak/allow_unadorned_rake_without_db 
Run tests with `rake` when DB does not yet exist
 2016-11-30 09:43:40 -05:00
Miles Gould
6be9640625 Run tests with rake when DB does not yet exist 
Previously, `rake spec` ran the tests whether or not the `growstuff_test`
database existed or not, but `rake` crashed unless it had already been
created. The problem was that `rake` was trying to load the environment,
which required the presence of a DB; `rake spec` was running this with
the `dev` environment, so succeeded if `growstuff_dev` existed, but
`rake` was running everything with the `test` environment, so would fail
if `growstuff_test` did not exist.

This patch adds `db:create` to the dependencies of the `spec` task,
forcing an unadorned `rake` to create all necessary databases first.
 2016-11-30 11:35:35 +00:00
Miles Gould
1841548936 Precompile assets in test 
According to
https://github.com/teampoltergeist/poltergeist/issues/677#issuecomment-222919584,
a possible cause of the "Request failed to reach server" problem (#901)
is that assets are being compiled on-demand, causing enough of a
slowdown for PhantomJS to think the connection has failed. This turns
off lazy asset compilation in the test environment and precompiles
assets before testing on Travis. We should also turn off lazy asset
compilation in production - see
http://stackoverflow.com/questions/8821864/config-assets-compile-true-in-rails-production-why-not
Our Heroku deployments already run `rake assets:precompile`.
 2016-11-30 11:01:25 +00:00
pozorvlak
d3b927b44b Merge pull request #1096 from Growstuff/master 
Master to dev for 1092
 2016-11-30 09:44:12 +00:00
Shiny
9d68690d86 Merge pull request #1092 from Br3nda/hotfix/1079 
Check we have a planted_at ts before using
 2016-11-30 17:50:15 +13:00
Brenda Wallace
900e7361c6 Check we have a planted_at ts before doing maths with it 2016-11-30 17:39:26 +13:00
Mackenzie
7b0fdcf007 Merge pull request #1093 from Br3nda/bw/fix-deprecated-methods 
Fixes for two calls to deprecated methods
 2016-11-29 16:34:32 -05:00
Brenda Wallace
9aa4fa8031 Fixes for two calls to deprecated methods 2016-11-30 10:25:23 +13:00
Mackenzie
391111a5bf Merge pull request #1088 from maco/rename_scientific_name 
rename scientific_names.scientific_name to scientific_names.name
 2016-11-29 12:04:21 -05:00
Mackenzie
818c8f0c37 Merge pull request #1090 from pozorvlak/indentation-for-great-glory 
Fix comment-style weirdness
 2016-11-29 09:53:23 -05:00
Mackenzie Morgan
915030e583 whitespace 2016-11-29 09:40:59 -05:00
Mackenzie Morgan
832719b01a merge from upstream dev 2016-11-29 09:37:25 -05:00
Miles Gould
0d8cbc5bf2 Fix comment-style weirdness 
We had an inline comment that had been split over two lines; whitespace
fixes made this look very weird.
 2016-11-29 10:44:04 +00:00
pozorvlak
bac8f5e4cc Merge pull request #1072 from Br3nda/bw/indentation-for-great-glory 
the giant indentation patch of 2016, for great glory
 2016-11-29 10:42:24 +00:00
Mackenzie Morgan
69980d9ec6 tests 2016-11-28 22:50:53 -05:00
Mackenzie Morgan
2129b6480d ...that was a guard clause. oops 2016-11-28 22:42:11 -05:00
Mackenzie Morgan
fe860aa1ab clean up some tests 2016-11-28 22:33:00 -05:00
Mackenzie Morgan
a382caab48 clear up redundant else and unneeded returns 2016-11-28 22:08:41 -05:00
Mackenzie Morgan
e1e9a52186 use a guard clause 2016-11-28 22:08:14 -05:00
Mackenzie Morgan
66c8ce78bc further DRY up crops controller 2016-11-28 22:04:32 -05:00
Mackenzie Morgan
e1a2b168c9 rename scientific_names.scientific_name to scientific_names.name 
this mirrors alternate_names.name and allows making code more DRY
 2016-11-28 21:57:51 -05:00
Brenda Wallace
8763c22284 Merge remote-tracking branch 'upstream/dev' into bw/indentation-for-great-glory 
Conflicts:
	app/models/crop.rb
 2016-11-29 02:33:30 +00:00
Mackenzie
9ec2f76909 Merge pull request #1086 from maco/sunniness_planted_from 
deduplicate sunniness and planted_from functions (Fixes: #1085)
 2016-11-28 20:59:52 -05:00
Mackenzie Morgan
b94cb2abd6 deduplicate sunniness and planted_from functions (Fixes: #1085) 2016-11-28 19:57:34 -05:00
Daniel O'Connor
7abafd7b74 Merge pull request #1084 from maco/improve_crop 
Improve crop model
 2016-11-29 10:27:13 +10:00
Mackenzie Morgan
502862128f break out if/else into discrete blocks 2016-11-28 19:20:35 -05:00
Mackenzie Morgan
96b1e78962 dedup the add from csv code (Fixes: #1082) 2016-11-28 19:12:42 -05:00
Mackenzie
e077f6c7b1 Merge pull request #1076 from Br3nda/bw/poking-travis 
Travis file lint and clean
 2016-11-28 09:57:26 -05:00
Mackenzie
b25a938936 Merge pull request #1081 from CloCkWeRX/upgrade-gems-nov-2016 
Upgrade various gems for Nov 2016
 2016-11-28 09:55:54 -05:00
Mackenzie
0952d7d32f Merge pull request #1078 from Br3nda/bw/garden-names-one-line 
Limit garden names to one line
 2016-11-28 09:55:16 -05:00
Daniel O'Connor
9963502026 bundle update i18n-tasks 2016-11-28 13:55:01 +10:00
Daniel O'Connor
5c2b14376e bundle update terminal-table 2016-11-28 10:43:46 +10:00
Daniel O'Connor
330bc912c1 bundle update bootstrap_form 2016-11-28 10:43:05 +10:00
Daniel O'Connor
bd46c37f07 bundle update activemerchant 2016-11-28 10:42:03 +10:00
Daniel O'Connor
c08c038df1 bundle update active_utils 2016-11-28 10:40:32 +10:00
Daniel O'Connor
0fb9ea7a11 bundle update newrelic_rpm byebug 2016-11-28 10:37:36 +10:00
Daniel O'Connor
89c29ea73c bundle update pg 2016-11-28 10:32:43 +10:00
Daniel O'Connor
9c116f5887 bundle update rspec-rails coveralls capybara-screenshot 2016-11-28 10:31:24 +10:00
Daniel O'Connor
eb1013f925 bundle update jwt kramdown excon 2016-11-28 10:30:02 +10:00
Daniel O'Connor
9bd1484a95 bundle update ruby_parser rb-fsevent redis 2016-11-28 10:29:09 +10:00
Daniel O'Connor
7a90c020fc bundle update thor tins term-ansicolor 2016-11-28 10:28:07 +10:00
Daniel O'Connor
0a69ee682c Merge pull request #1073 from Br3nda/bw/poltergeist-upgrade 
Upgrading poltergeist
 2016-11-28 10:22:21 +10:00
Daniel O'Connor
8b5c63e898 Merge pull request #1077 from Br3nda/bw/wikipedia-url-regex 
Narrow-ed regex on wikipedia url
 2016-11-28 10:08:11 +10:00
Cesy
dfe12fd7f8 Merge pull request #1074 from Br3nda/bw/string-interp 
String interp doesn't need .to_s in test
 2016-11-27 11:02:31 +00:00
Cesy
73a2ac87da Merge pull request #1075 from Br3nda/bw/garden-link 
Bugfix: Link to garden, not member
 2016-11-27 11:00:49 +00:00
Brenda Wallace
9cce0e39f6 Limit garden names to one line 2016-11-27 14:52:07 +13:00
Brenda Wallace
10c20c7f91 Narrow-ed regex on wikipedia url 
and more tests
 2016-11-27 14:35:49 +13:00
Brenda Wallace
f52b828abe Use rake to create database 2016-11-27 13:27:45 +13:00