feat: Convert navbar to Bootstrap 5.1 offcanvas menu

This commit changes the navbar to use the Bootstrap 5.1 offcanvas component.

The following changes were made:
- Modified `app/views/layouts/_header.html.haml` to update the navbar-toggler to trigger the offcanvas menu.
- Modified `app/views/layouts/_menu.haml` to wrap the menu in an offcanvas component.

.github/workflows/ci-features-admin.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-comments.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-conversations.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-crops.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-gardens.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-harvests.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-home.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-members.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-places.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-plantings.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-posts.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-seeds.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features-timeline.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci-features.yml

@@ -38,7 +38,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

.github/workflows/ci.yml

@@ -6,7 +6,7 @@ jobs:
   contributors:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
       - name: Install ruby version specified in .ruby-version
         uses: ruby/setup-ruby@v1
         with:
@@ -53,7 +53,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |

CONTRIBUTORS.md

@@ -12,7 +12,6 @@ submit the change with your pull request.
 - Miles Gould / [pozorvlak](https://github.com/pozorvlak)
 - Mackenzie Morgan / [maco](https://github.com/maco)
 - Brenda Wallace / [br3nda](https://github.com/br3nda)
-- Daniel O'Connor / [CloCkWeRX](https://github.com/CloCkWeRX)
 
 ## Contributors
 
@@ -69,6 +68,7 @@ submit the change with your pull request.
 - Jym Paul Carandang / [jacarandang](https://github.com/jacarandang)
 - Anthony Atkinson / [sha1sum](https://github.com/sha1sum)
 - Terence Conquest / [twconquest](https://github.com/twconquest)
+- Daniel O'Connor / [CloCkWeRX](https://github.com/CloCkWeRX)
 - DV Dasari / [dv2](https://github.com/dv2)
 - Eric Tillberg / [Thrillberg](https://github.com/Thrillberg)
 - Lucas Nogueira / [lucasnogueira](https://github.com/lucasnogueira)
@@ -95,11 +95,10 @@ submit the change with your pull request.
 - Ítalo Pires / [italopires](https://github.com/italopires)
 - Bennett Zink / [bennett-zink](https://github.com/bennett-zink)
 - Dominick Thornton / [domthor](https://github.com/domthor)
- 
+
 ## Bots
 
 ### Security and Dependency Updates
 - `codefactor-io[bot]`
 - DeppBot / [deppbot](https://github.com/deppbot)
 - `dependabot[bot]` [dependabot](https://github.com/dependabot-bot) / [dependabot-preview](https://github.com/apps/dependabot-preview)
-- [google-labs-jules[bot]](https://github.com/apps/google-labs-jules)

Gemfile

@@ -91,9 +91,10 @@ gem 'bootstrap-datepicker-rails'
 # DRY-er easier bootstrap 4 forms
 gem "bootstrap_form", ">= 4.5.0"
 
-# For connecting to other services (eg Flickr)
+# For connecting to other services (eg Twitter)
 gem 'omniauth', '~> 1.3'
 gem 'omniauth-flickr', '>= 0.0.15'
+gem 'omniauth-twitter'
 
 # Pretty charts
 gem "chartkick"
@@ -178,6 +179,7 @@ group :development, :test do
   gem 'dotenv-rails'
 
   # cli utils
+  gem 'haml-i18n-extractor', require: false
   gem 'haml_lint', '>= 0.25.1', require: false # Checks haml files for goodness
   gem 'i18n-tasks', require: false # adds tests for finding missing and unused translations
   gem 'rspectre', require: false # finds unused code in specs
@@ -200,5 +202,3 @@ group :travis do
 end
 
 
-
-gem "i18n_data", "~> 1.1"

Gemfile.lock

@@ -183,7 +183,7 @@ GEM
       image_processing (~> 1.1)
       marcel (~> 1.0.0)
       ssrf_filter (~> 1.0)
-    chartkick (5.2.0)
+    chartkick (5.1.5)
     childprocess (5.0.0)
     coderay (1.1.3)
     coercible (1.0.0)
@@ -294,6 +294,12 @@ GEM
       temple (>= 0.8.2)
       thor
       tilt
+    haml-i18n-extractor (0.5.9)
+      activesupport
+      haml
+      highline
+      tilt
+      trollop (= 1.16.2)
     haml-rails (2.1.0)
       actionpack (>= 5.1)
       activesupport (>= 5.1)
@@ -335,8 +341,6 @@ GEM
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.8, >= 1.8.1)
       terminal-table (>= 1.5.1)
-    i18n_data (1.1.0)
-      simple_po_parser (~> 1.1)
     icalendar (2.11.2)
       base64
       ice_cube (~> 0.16)
@@ -436,7 +440,7 @@ GEM
     nokogiri (1.18.9-x86_64-linux-gnu)
       racc (~> 1.4)
     oauth (0.5.6)
-    oj (3.16.11)
+    oj (3.16.10)
       bigdecimal (>= 3.0)
       ostruct (>= 0.2)
     omniauth (1.9.2)
@@ -448,9 +452,12 @@ GEM
     omniauth-oauth (1.1.0)
       oauth
       omniauth (~> 1.0)
+    omniauth-twitter (1.4.0)
+      omniauth-oauth (~> 1.1)
+      rack
     open-uri (0.1.0)
     orm_adapter (0.5.0)
-    ostruct (0.6.3)
+    ostruct (0.6.2)
     parallel (1.27.0)
     parser (3.3.9.0)
       ast (~> 2.4.1)
@@ -601,7 +608,7 @@ GEM
     rswag-ui (2.16.0)
       actionpack (>= 5.2, < 8.1)
       railties (>= 5.2, < 8.1)
-    rubocop (1.80.1)
+    rubocop (1.79.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -655,7 +662,7 @@ GEM
       sprockets (> 3.0)
       sprockets-rails
       tilt
-    scout_apm (5.7.1)
+    scout_apm (5.7.0)
       parser
     searchkick (5.3.1)
       activemodel (>= 6.1)
@@ -673,7 +680,6 @@ GEM
       logger
       rack (>= 2.2.4)
       redis-client (>= 0.22.2)
-    simple_po_parser (1.1.6)
     sprockets (3.7.5)
       base64
       concurrent-ruby (~> 1.0)
@@ -688,16 +694,17 @@ GEM
     temple (0.10.4)
     terminal-table (4.0.0)
       unicode-display_width (>= 1.1.1, < 4)
-    terser (1.2.6)
+    terser (1.2.5)
       execjs (>= 0.3.0, < 3)
     thor (1.4.0)
     thread_safe (0.3.6)
     tilt (2.6.1)
     timecop (0.9.10)
     timeout (0.4.3)
+    trollop (1.16.2)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.5)
+    unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     unicorn (6.1.0)
@@ -781,11 +788,11 @@ DEPENDENCIES
   gibbon (~> 1.2.0)
   gravatar-ultimate
   haml
+  haml-i18n-extractor
   haml-rails
   haml_lint (>= 0.25.1)
   hashie (>= 3.5.3)
   i18n-tasks
-  i18n_data (~> 1.1)
   icalendar
   jquery-rails
   jquery-ui-rails!
@@ -803,6 +810,7 @@ DEPENDENCIES
   oj
   omniauth (~> 1.3)
   omniauth-flickr (>= 0.0.15)
+  omniauth-twitter
   percy-capybara (~> 5.0.0)
   pg
   platform-api

README.md

@@ -62,3 +62,5 @@ For more information about this project, contact [info@growstuff.org](mailto:inf
 
 Security Issues: If you find an authorization bypass or data breach, please contact our maintainers directly at [maintainers@growstuff.org](mailto:maintainers@growstuff.org).
 
+You can also contact us on [Twitter](http://twitter.com/growstufforg/) or
+[Facebook](https://www.facebook.com/pages/Growstuff/1531133417099494) or [Github](https://github.com/Growstuff/growstuff/issues)..

app/assets/stylesheets/_crops.scss

@@ -1,13 +1,7 @@
 .crop-icon {
   height: 1em;
 }
-.card-footer {
-  .btn-group-vertical {
-    .btn {
-      text-wrap: initial
-    }
-  }
-}
+
 .crop-thumbnail {
   .text {
     bottom: 0;

app/assets/stylesheets/_homepage.scss

@@ -1,8 +1,6 @@
 // stats shown on homepage. eg. "999 members..."
 .stats {
-  a {
-    font-weight: bold;
-  }
+  font-weight: bold;
 }
 
 .crops,

app/assets/stylesheets/_members.scss

@@ -33,6 +33,13 @@
   }
 }
 
+.location-not-set {
+  background-image: image-url("location-not-set.en.png");
+  background-position: center;
+  background-repeat: no-repeat;
+  height: 250px;
+  width: 100%;
+}
 .card {
   .badge-location {
     background-color: darken($blue, 10%);

app/assets/stylesheets/mobile.scss

@@ -10,33 +10,9 @@
     width: 100%;
   }
 
-#navbarSupportedContent {
-  ul {
-    flex-direction: column-reverse;
-    flex-wrap: nowrap;
-
-    li.nav-item {
-      display: block;
-      a { 
-        display: grid;
-        grid-template-columns: 2em 1fr 2em;
-      }
-      a.dropdown-toggle::after {
-        width: 100%;
-        text-align: right;
-      }
-    }
-  }
-}
-
-.crop-actions {
-  flex-direction: column;
-  width: 100%;
-  a {
-    margin: auto;
+  .navbar .nav > li {
     display: block;
   }
-}
 
   .navbar .navbar-form {
     padding-left: 0;

app/assets/stylesheets/overrides.scss

@@ -10,7 +10,6 @@ body {
 
 .navbar {
   flex-wrap: nowrap;
-  align-items: flex-start
 }
 .navbar-brand {
   .site-name {
@@ -368,6 +367,9 @@ ul.thumbnail-buttons {
   h1 {
     font-size: 400%;
   }
+  .stats a {
+    color: $black;
+  }
 
   // signup widget on homepage
   .signup {

app/controllers/alternate_names_controller.rb

@@ -57,6 +57,6 @@ class AlternateNamesController < ApplicationController
   private
 
   def alternate_name_params
-    params.require(:alternate_name).permit(:crop_id, :name, :creator_id, :language)
+    params.require(:alternate_name).permit(:crop_id, :name, :creator_id)
   end
 end

app/controllers/comments_controller.rb

@@ -13,55 +13,43 @@ class CommentsController < ApplicationController
   end
 
   def new
-    @commentable = find_commentable
     @comment = Comment.new
-    if @commentable
-      @comments = @commentable.comments
+    @post = Post.find_by(id: params[:post_id])
+
+    if @post
+      @comments = @post.comments
       respond_with(@comments)
     else
       redirect_to(request.referer || root_url,
-                  alert: "Can't post a comment on a non-existent commentable")
+                  alert: "Can't post a comment on a non-existent post")
     end
   end
 
   def edit
-    # TODO: Why does this need a collection of comments?
-    @comments = @comment.commentable.comments
-    @commentable = @comment.commentable
+    @comments = @comment.post.comments
   end
 
   def create
     @comment = Comment.new(comment_params)
-    @commentable = @comment.commentable
     @comment.author = current_member
     @comment.save
-    respond_with @comment, location: @commentable
+    respond_with @comment, location: @comment.post
   end
 
   def update
     @comment.update(body: comment_params['body'])
-    respond_with @comment, location: @comment.commentable
+    respond_with @comment, location: @comment.post
   end
 
   def destroy
-    @commentable = @comment.commentable
+    @post = @comment.post
     @comment.destroy
-    respond_with(@commentable)
+    respond_with(@post)
   end
 
   private
 
-  def find_commentable
-    return unless params[:comment]
-
-    if params[:comment][:commentable_type] == 'Photo'
-      Photo.find(params[:comment][:commentable_id])
-    elsif params[:comment][:commentable_type] == 'Post'
-      Post.find(params[:comment][:commentable_id])
-    end
-  end
-
   def comment_params
-    params.require(:comment).permit(:body, :commentable_id, :commentable_type)
+    params.require(:comment).permit(:body, :post_id)
   end
 end

app/controllers/crops_controller.rb

@@ -39,6 +39,12 @@ class CropsController < ApplicationController
     respond_with @crops
   end
 
+  def openfarm
+    @crop = Crop.find(params[:crop_slug])
+    @crop.update_openfarm_data!
+    respond_with @crop, location: @crop
+  end
+
   def gbif
     @crop = Crop.find(params[:crop_slug])
     @crop.update_gbif_data!
@@ -131,6 +137,7 @@ class CropsController < ApplicationController
 
       if @crop.approval_status_changed?(from: "pending", to: "approved")
         notifier.deliver_now!
+        @crop.update_openfarm_data!
         @crop.update_gbif_data!
       end
     else
@@ -159,7 +166,7 @@ class CropsController < ApplicationController
   end
 
   def save_crop_names
-    AlternateName.create!(names_params(:alt_name).map { |n| { name: n, creator_id: current_member.id, crop_id: @crop.id, language: "EN" } })
+    AlternateName.create!(names_params(:alt_name).map { |n| { name: n, creator_id: current_member.id, crop_id: @crop.id } })
     ScientificName.create!(names_params(:sci_name).map { |n| { name: n, creator_id: current_member.id, crop_id: @crop.id } })
   end
 
@@ -174,18 +181,20 @@ class CropsController < ApplicationController
   def recreate_names(param_name, name_type)
     return if params[param_name].blank?
 
-    @crop.send("#{name_type}_names").each(&:destroy)
+    destroy_names(name_type)
     params[param_name].each_value do |value|
-      next if value.empty?
-
-      if name_type == 'alternate'
-        @crop.send("#{name_type}_names").create!(name: value, creator_id: current_member.id, language: "EN")
-      else
-        @crop.send("#{name_type}_names").create!(name: value, creator_id: current_member.id)
-      end
+      create_name!(name_type, value) unless value.empty?
     end
   end
 
+  def destroy_names(name_type)
+    @crop.send("#{name_type}_names").each(&:destroy)
+  end
+
+  def create_name!(name_type, value)
+    @crop.send("#{name_type}_names").create!(name: value, creator_id: current_member.id)
+  end
+
   def crop_params
     params.require(:crop).permit(
       :name, :en_wikipedia_url,
@@ -207,12 +216,12 @@ class CropsController < ApplicationController
   def crop_json_fields
     {
       include: {
-        plantings: {
+        plantings:        {
           include: {
             owner: { only: %i(id login_name location latitude longitude) }
           }
         },
-        scientific_names: { only: [:name] }, alternate_names:  { only: %i(name language) }
+        scientific_names: { only: [:name] }, alternate_names:  { only: [:name] }
       }
     }
   end

app/controllers/gardens_controller.rb

@@ -4,7 +4,7 @@ class GardensController < DataController
   def index
     @owner = Member.find_by(slug: params[:member_slug])
     @show_all = params[:all] == '1'
-    @show_jump_to = params[:member_slug].present? || false
+    @show_jump_to = params[:member_slug].present? ? true : false
 
     @gardens = @gardens.includes(:owner)
     @gardens = @gardens.active unless @show_all
@@ -18,7 +18,7 @@ class GardensController < DataController
   end
 
   def show
-    @current_plantings = @garden.plantings.current.where.not(failed: true).includes(:crop, :owner).order(planted_at: :desc)
+    @current_plantings = @garden.plantings.current.includes(:crop, :owner).order(planted_at: :desc)
     @current_activities = @garden.activities.current.includes(:owner).order(created_at: :desc)
     @finished_plantings = @garden.plantings.finished.includes(:crop)
     @suggested_companions = Crop.approved.where(

app/controllers/members_controller.rb

@@ -16,6 +16,7 @@ class MembersController < ApplicationController
 
   def show
     @member        = Member.confirmed.kept.find_by!(slug: params[:slug])
+    @twitter_auth  = @member.auth('twitter')
     @flickr_auth   = @member.auth('flickr')
     @posts         = @member.posts
 

app/controllers/omniauth_callbacks_controller.rb

@@ -28,7 +28,7 @@ class OmniauthCallbacksController < Devise::OmniauthCallbacksController
     @authentication = action.establish_authentication(auth, member)
 
     if action.member_created?
-      raise "Invalid provider" unless %w(flickr).index(auth['provider'].to_s)
+      raise "Invalid provider" unless %w(twitter flickr).index(auth['provider'].to_s)
 
       session["devise.#{auth['provider']}_data"] = request.env["omniauth.auth"]
       sign_in member

app/controllers/photos_controller.rb

@@ -21,7 +21,6 @@ class PhotosController < ApplicationController
 
   def show
     @crops = Crop.distinct.joins(:photo_associations).where(photo_associations: { photo: @photo })
-    @comment = Comment.new(commentable: @photo)
     respond_with(@photo)
   end
 

app/controllers/plantings_controller.rb

@@ -91,32 +91,6 @@ class PlantingsController < DataController
     respond_with @planting, location: @planting.garden
   end
 
-  def transplant
-    # The `load_and_authorize_resource` in DataController will handle finding the
-    # planting and authorizing the action.
-    # We still need to authorize the new garden
-    new_garden = Garden.find(params[:garden_id])
-    authorize! :update, new_garden
-
-    # Mark original planting as finished
-    @planting.update(finished: true, finished_at: Time.zone.now)
-
-    # Create a new planting
-    new_planting = @planting.dup
-    new_planting.garden = new_garden
-    new_planting.slug = nil # let friendly_id generate a new slug
-    new_planting.finished = false
-    new_planting.finished_at = nil
-
-    if new_planting.save
-      redirect_to edit_planting_path(new_planting), notice: 'Planting was successfully transplanted.'
-    else
-      # if the save fails, we should probably roll back the finishing of the original planting
-      @planting.update(finished: false, finished_at: nil)
-      redirect_to @planting, alert: "There was an error transplanting the planting: #{new_planting.errors.full_messages.to_sentence}"
-    end
-  end
-
   private
 
   def update_crop_medians
@@ -133,7 +107,7 @@ class PlantingsController < DataController
       :crop_id, :description, :garden_id, :planted_at,
       :parent_seed_id,
       :quantity, :sunniness, :planted_from, :finished,
-      :finished_at, :failed
+      :finished_at
     )
   end
 

app/controllers/registrations_controller.rb

@@ -6,6 +6,7 @@ class RegistrationsController < Devise::RegistrationsController
   prepend_before_action :check_captcha, only: [:create] # Change this to be any actions you want to protect with recaptcha.
 
   def edit
+    @twitter_auth  = current_member.auth('twitter')
     @flickr_auth   = current_member.auth('flickr')
     render "edit"
   end

app/controllers/seeds_controller.rb

@@ -19,7 +19,9 @@ class SeedsController < DataController
       where['parent_planting'] = @planting.id
     end
 
-    where['tradeable_to'] = params[:tradeable_to] if params[:tradeable_to].present?
+    if params[:tradeable_to].present?
+      where['tradeable_to'] = params[:tradeable_to]
+    end
 
     @show_all = (params[:all] == '1')
     where['finished'] = false unless @show_all
@@ -43,7 +45,6 @@ class SeedsController < DataController
 
   def new
     @seed = Seed.new
-    @seed.source = 'my own seed saving'
 
     if params[:planting_slug]
       @planting = Planting.find_by(slug: params[:planting_slug])
@@ -57,8 +58,6 @@ class SeedsController < DataController
 
   def create
     @seed = Seed.new(seed_params)
-    @seed.source ||= 'my own seed saving'
-    @seed.finished ||= false
     @seed.owner = current_member
     @seed.crop = @seed.parent_planting.crop if @seed.parent_planting
     flash[:notice] = "Successfully added #{@seed.crop} seed to your stash." if @seed.save
@@ -86,7 +85,7 @@ class SeedsController < DataController
       :crop_id, :description, :quantity, :plant_before,
       :parent_planting_id, :saved_at,
       :days_until_maturity_min, :days_until_maturity_max,
-      :organic, :gmo, :source,
+      :organic, :gmo,
       :heirloom, :tradable_to, :slug,
       :finished, :finished_at
     )

app/helpers/application_helper.rb

@@ -21,10 +21,6 @@ module ApplicationHelper
     classes
   end
 
-  def count_github_contibutors
-    File.open(Rails.root.join('CONTRIBUTORS.md')).readlines.grep(/^-/).size
-  end
-
   # Produces a cache key for uniquely identifying cached fragments.
   def cache_key_for(klass, identifier = "all")
     count          = klass.count
@@ -54,6 +50,7 @@ module ApplicationHelper
 
       uri.query = "&width=#{size}&height=#{size}" if uri.host == 'graph.facebook.com'
 
+      # TODO: Assess twitter - https://dev.twitter.com/overview/general/user-profile-images-and-banners
       # TODO: Assess flickr  - https://www.flickr.com/services/api/misc.buddyicons.html
 
       return uri.to_s

app/helpers/buttons_helper.rb

@@ -2,7 +2,6 @@
 
 module ButtonsHelper
   include IconsHelper
-
   def garden_plant_something_button(garden, classes: "btn btn-default")
     return unless can? :edit, garden
 
@@ -53,7 +52,7 @@ module ButtonsHelper
     link_to t('buttons.mark_as_inactive'),
             garden_path(garden, garden: { active: 0 }),
             method: :put, class: classes,
-            data: { confirm: I18n.t('gardens.confirm_deactivate') }
+            data: { confirm: 'All plantings associated with this garden will be marked as finished. Are you sure?' }
   end
 
   def create_button(model_to_create, path, icon, label)
@@ -98,7 +97,7 @@ module ButtonsHelper
   end
 
   def planting_finish_button(planting, classes: 'btn btn-default btn-secondary')
-    return unless can?(:edit, planting) || planting.finished || planting.failed
+    return unless can?(:edit, planting) || planting.finished
 
     link_to planting_path(slug: planting.slug, planting: { finished: 1 }),
             method: :put, class: "#{classes} append-date" do
@@ -106,15 +105,6 @@ module ButtonsHelper
     end
   end
 
-  def planting_failed_button(planting, classes: 'btn btn-default btn-secondary')
-    return unless can?(:edit, planting) || planting.finished || planting.failed
-
-    link_to planting_path(slug: planting.slug, planting: { failed: 1 }),
-            method: :put, class: "#{classes}" do
-      finished_icon + ' ' + t('buttons.mark_as_failed')
-    end
-  end
-
   def seed_finish_button(seed, classes: 'btn btn-default')
     return unless can?(:create, Planting) && seed.active
 
@@ -132,7 +122,7 @@ module ButtonsHelper
   end
 
   def planting_save_seeds_button(planting, classes: 'btn btn-default')
-    return unless can?(:edit, planting) && !planting.failed?
+    return unless can?(:edit, planting)
 
     link_to new_planting_seed_path(planting_slug: planting.slug), class: classes do
       seed_icon + ' ' + t('buttons.save_seeds')

app/helpers/event_helper.rb

@@ -7,8 +7,6 @@ module EventHelper
 
   def event_description(event)
     render "#{event.event_type.pluralize}/description", event_model: resolve_model(event)
-rescue ActionView::MissingTemplate
-  "#{event.event_type.humanize.downcase}d"
   end
 
   def resolve_model(event)

app/helpers/plantings_helper.rb

@@ -43,14 +43,6 @@ module PlantingsHelper
     (planting.first_harvest_predicted_at - Time.zone.today).to_i
   end
 
-  # Returns a list of gardens the planting can be transplanted to
-  # based on the planting's owner.
-  def transplantable_gardens_by_owner(planting)
-    garden_ids = planting.owner.gardens.select(:id).to_a + GardenCollaborator.where(member_id: planting.owner.id).select(:garden_id).to_a
-
-    Garden.active.where.not(id: planting.garden_id).where(id: garden_ids)
-  end
-
   def days_from_now_to_last_harvest(planting)
     return unless planting.planted_at.present? && planting.last_harvest_predicted_at.present?
 

app/models/ability.rb

@@ -111,10 +111,6 @@ class Ability
     can :update, Planting do |planting|
       planting.garden.garden_collaborators.where(member_id: member.id).any?
     end
-    can :transplant, Planting, garden: { owner_id: member.id }
-    can :transplant, Planting do |planting|
-      planting.garden.garden_collaborators.where(member_id: member.id).any?
-    end
     can :destroy, Planting do |planting|
       planting.garden.garden_collaborators.where(member_id: member.id).any?
     end

app/models/alternate_name.rb

@@ -5,7 +5,6 @@ class AlternateName < ApplicationRecord
   belongs_to :creator, class_name: 'Member', inverse_of: :created_alternate_names
   validates :name, presence: true
   validates :crop, presence: true
-  validates :language, presence: true
 
   after_commit :reindex
 

app/models/comment.rb

@@ -2,27 +2,26 @@
 
 class Comment < ApplicationRecord
   belongs_to :author, class_name: 'Member', inverse_of: :comments
-  belongs_to :commentable, polymorphic: true, counter_cache: true
-  # validates :body, presence: true
+  belongs_to :post, counter_cache: true
 
   scope :post_order, -> { order(created_at: :asc) } # for display on post page
 
   after_create do
-    recipient = commentable.author.id
+    recipient = post.author.id
     sender    = author.id
     # don't send notifications to yourself
     if recipient != sender
       Notification.create(
         recipient_id: recipient,
         sender_id:    sender,
-        subject:      "#{author} commented on #{commentable.subject}",
+        subject:      "#{author} commented on #{post.subject}",
         body:,
-        notifiable:   commentable
+        post_id:      post.id
       )
     end
   end
 
   def to_s
-    "#{author.login_name} commented on #{commentable.subject}"
+    "#{author.login_name} commented on #{post.subject}"
   end
 end

app/models/concerns/finishable.rb

@@ -8,12 +8,7 @@ module Finishable
     scope :current, -> { where.not(finished: true) }
 
     def active
-      # Plantings can fail. At the moment, activities and seeds cannot.
-      if respond_to?(:failed)
-        !finished && !failed
-      else
-        !finished
-      end
+      !finished
     end
   end
 end

app/models/concerns/open_farm_data.rb

@@ -4,6 +4,10 @@ module OpenFarmData
   extend ActiveSupport::Concern
 
   included do
+    def update_openfarm_data!
+      OpenfarmService.new.update_crop(self)
+    end
+
     def of_photo
       fetch_attr('main_image_path')
     end
@@ -39,6 +43,10 @@ module OpenFarmData
       fetch_attr('common_names')
     end
 
+    def guides_count
+      fetch_attr('guides_count')
+    end
+
     def binomial_name
       fetch_attr('binomial_name')
     end

app/models/concerns/predict_harvest.rb

@@ -38,7 +38,7 @@ module PredictHarvest
 
     # status
     def harvest_time?
-      return false if crop.perennial || finished || failed
+      return false if crop.perennial || finished
 
       # We have harvests but haven't finished
       harvests.size.positive? ||

app/models/concerns/predict_planting.rb

@@ -8,12 +8,12 @@ module PredictPlanting
     before_save :calculate_lifespan
 
     def calculate_lifespan
-      self.lifespan = (planted_at.present? && finished_at.present? && !failed? ? finished_at - planted_at : nil)
+      self.lifespan = (planted_at.present? && finished_at.present? ? finished_at - planted_at : nil)
     end
 
     # dates
     def finish_predicted_at
-      if planted_at.blank? || failed?
+      if planted_at.blank?
         nil
       elsif crop.median_lifespan.present?
         planted_at + crop.median_lifespan.days
@@ -34,18 +34,15 @@ module PredictPlanting
     end
 
     def actual_lifespan
-      return unless planted_at.present? && finished_at.present? && !failed?
+      return unless planted_at.present? && finished_at.present?
 
       (finished_at - planted_at).to_i
     end
 
     def age_in_days
       return if planted_at.blank?
-      return if failed?
 
       known_last_day ||= finished_at || Time.zone.today
-      known_last_day = Time.zone.today if known_last_day > Time.zone.today
-
       (known_last_day - planted_at).to_i
     end
 
@@ -53,9 +50,9 @@ module PredictPlanting
       Rails.cache.fetch("#{cache_key_with_version}/percentage_grown", expires_in: 8.hours) do
         if finished?
           100
-        elsif !planted? || failed?
+        elsif !planted?
           0
-        elsif crop.perennial || (finish_predicted_at.nil? && finished_at.nil?) # This covers future dated finished_at that hasn't occurrred yet.
+        elsif crop.perennial || finish_predicted_at.nil?
           nil
         else
           calculate_percentage_grown
@@ -74,7 +71,7 @@ module PredictPlanting
     end
 
     def late?
-      crop.annual? && !finished && !failed &&
+      crop.annual? && !finished &&
         planted_at.present? &&
         finish_predicted_at.present? &&
         finish_predicted_at <= Time.zone.today
@@ -94,9 +91,9 @@ module PredictPlanting
     private
 
     def calculate_percentage_grown
-      return 0 if age_in_days.to_i < 0
+      return 0 if age_in_days < 0
 
-      percent = (age_in_days.to_f / expected_lifespan.to_f) * 100
+      percent = (age_in_days / expected_lifespan.to_f) * 100
       (percent > 100 ? 100 : percent)
     end
   end

app/models/concerns/search_seeds.rb

@@ -59,8 +59,7 @@ module SearchSeeds
       search('*', limit:,
                   where:    {
                     finished: false,
-                    tradable: true,
-                    _or:      [{ plant_before: nil }, { plant_before: { lt: Date.today } }]
+                    tradable: true
                   },
                   boost_by: [:created_at],
                   load:     false)

app/models/csv_importer.rb

@@ -59,7 +59,7 @@ class CsvImporter
 
     alternate_names.split(/,\s*/).each do |name|
       altname = AlternateName.find_by(name:, crop: @crop)
-      altname ||= AlternateName.create! name:, crop: @crop, language: "EN", creator: cropbot
+      altname ||= AlternateName.create! name:, crop: @crop, creator: cropbot
       @crop.alternate_names << altname
     end
   end

app/models/follow.rb

@@ -10,8 +10,7 @@ class Follow < ApplicationRecord
       recipient_id: followed_id,
       sender_id:    follower_id,
       subject:      "#{follower.login_name} is now following you",
-      body:         "#{follower.login_name} just followed you on #{ENV.fetch('GROWSTUFF_SITE_NAME', nil)}. ",
-      notifiable:   self
+      body:         "#{follower.login_name} just followed you on #{ENV.fetch('GROWSTUFF_SITE_NAME', nil)}. "
     )
   end
 end

app/models/garden.rb

@@ -5,7 +5,6 @@ class Garden < ApplicationRecord
   include Geocodable
   include PhotoCapable
   include Ownable
-
   friendly_id :garden_slug, use: %i(slugged finders)
 
   has_many :plantings, dependent: :destroy
@@ -45,7 +44,6 @@ class Garden < ApplicationRecord
       .where.not(gardens: { latitude: nil })
       .where.not(gardens: { longitude: nil })
   }
-
   AREA_UNITS_VALUES = {
     "square metres" => "square metre",
     "square feet"   => "square foot",

app/models/notification.rb

@@ -3,7 +3,7 @@
 class Notification < ApplicationRecord
   belongs_to :sender, class_name: 'Member', inverse_of: :sent_notifications
   belongs_to :recipient, class_name: 'Member', inverse_of: :notifications
-  belongs_to :notifiable, polymorphic: true
+  belongs_to :post, optional: true
 
   validates :subject, length: { maximum: 255 }
 

app/models/photo.rb

@@ -8,7 +8,6 @@ class Photo < ApplicationRecord
   PHOTO_CAPABLE = %w(Garden Planting Harvest Seed Post Crop).freeze
 
   has_many :photo_associations, dependent: :delete_all, inverse_of: :photo
-  has_many :comments, as: :commentable, dependent: :destroy
 
   # This doesn't work, ActiveRecord tries to use the polymoriphic photographable
   # relationship instead.
@@ -84,14 +83,6 @@ class Photo < ApplicationRecord
     "#{title} by #{owner.login_name}"
   end
 
-  def subject
-    title
-  end
-
-  def author
-    owner
-  end
-
   def flickr_photo_id
     source_id if source == 'flickr'
   end

app/models/planting.rb

@@ -43,8 +43,7 @@ class Planting < ApplicationRecord
       .where.not(gardens: { latitude: nil })
       .where.not(gardens: { longitude: nil })
   }
-  scope :active, -> { where(finished: false, failed: false).where('finished_at IS NULL OR finished_at < ?', Time.zone.now) }
-  scope :failed, -> { where(failed: true) }
+  scope :active, -> { where('finished <> true').where('finished_at IS NULL OR finished_at < ?', Time.zone.now) }
   scope :annual, -> { joins(:crop).where(crops: { perennial: false }) }
   scope :perennial, -> { joins(:crop).where(crops: { perennial: true }) }
   scope :interesting, -> { has_photos.one_per_owner.order(planted_at: :desc) }
@@ -73,7 +72,6 @@ class Planting < ApplicationRecord
   validates :crop, presence: true, approved: { message: "must be present and exist in our database" }
   validate :finished_must_be_after_planted
   validate :owner_must_match_garden_owner
-  validate :cannot_be_finished_and_failed
   validates :quantity, allow_nil: true, numericality: {
     only_integer: true, greater_than_or_equal_to: 0
   }
@@ -98,11 +96,7 @@ class Planting < ApplicationRecord
   end
 
   def finished?
-    (finished || (finished_at.present? && finished_at <= Time.zone.today)) && !failed?
-  end
-
-  def failed?
-    failed
+    finished || (finished_at.present? && finished_at <= Time.zone.today)
   end
 
   def planted?
@@ -126,10 +120,6 @@ class Planting < ApplicationRecord
 
   private
 
-  def cannot_be_finished_and_failed
-    errors.add(:failed, "can't be true if planting is also finished") if finished && failed
-  end
-
   # check that any finished_at date occurs after planted_at
   def finished_must_be_after_planted
     return unless planted_at && finished_at # only check if we have both

app/models/post.rb

@@ -3,7 +3,6 @@
 class Post < ApplicationRecord
   extend FriendlyId
   include Likeable
-
   friendly_id :author_date_subject, use: %i(slugged finders)
   include PhotoCapable
 
@@ -11,10 +10,9 @@ class Post < ApplicationRecord
   # Relationships
   belongs_to :author, class_name: 'Member', inverse_of: :posts
   belongs_to :forum, optional: true
-  has_many :comments, as: :commentable, dependent: :destroy
+  has_many :comments, dependent: :destroy
   has_many :crop_posts, dependent: :delete_all
   has_many :crops, through: :crop_posts
-  has_many :notifications, as: :notifiable, dependent: :destroy
 
   after_create :send_notification
   #
@@ -97,7 +95,6 @@ class Post < ApplicationRecord
       Notification.create(
         recipient_id:,
         sender_id:    sender,
-        notifiable:   self,
         subject:      "#{author} mentioned you in their post #{subject}",
         body:
       )

app/models/seed.rb

@@ -12,8 +12,6 @@ class Seed < ApplicationRecord
   ORGANIC_VALUES = ['certified organic', 'non-certified organic', 'conventional/non-organic', 'unknown'].freeze
   GMO_VALUES = ['certified GMO-free', 'non-certified GMO-free', 'GMO', 'unknown'].freeze
   HEIRLOOM_VALUES = %w(heirloom hybrid unknown).freeze
-  SOURCE_VALUES = ['seed catalogue', 'retail outlet', 'seed bank or similar institution',
-                   'traded from another person', 'my own seed saving', 'other/unknown'].freeze
 
   #
   # Relationships
@@ -46,9 +44,6 @@ class Seed < ApplicationRecord
   validates :heirloom, allow_blank: false,
                        inclusion:   { in: HEIRLOOM_VALUES, message: "You must say whether the seeds" \
                                                                     "are heirloom, hybrid, or unknown" }
-  validates :source, allow_blank: true,
-                     inclusion:   { in: SOURCE_VALUES, message: "You must say where the seeds are from," \
-                                                                 "or that you don't know" }
 
   #
   # Delegations
@@ -64,7 +59,6 @@ class Seed < ApplicationRecord
   scope :has_location, -> { joins(:owner).where.not('members.location': nil) }
   scope :recent, -> { order(created_at: :desc) }
   scope :active, -> { where('finished <> true').where('finished_at IS NULL OR finished_at < ?', Time.zone.now) }
-  scope :expired, -> { active.where('plant_before < ?', Time.zone.today) }
 
   def tradable
     tradable_to != 'nowhere'

app/resources/api/v1/planting_resource.rb

@@ -13,7 +13,6 @@ module Api
 
       attribute :slug
       attribute :planted_at
-      attribute :failed
       attribute :finished
       attribute :finished_at
       attribute :quantity
@@ -38,7 +37,9 @@ module Api
       filter :finished
 
       attribute :percentage_grown
-      delegate :percentage_grown, to: :@model
+      def percentage_grown
+        @model.percentage_grown
+      end
 
       attribute :crop_name
       attribute :crop_slug

app/services/openfarm_service.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+BASE = 'https://openfarm.cc/api/v1/'
+# BASE = 'http://127.0.0.1:3000/api/v1/'
+
+class OpenfarmService
+  def initialize
+    @cropbot = Member.find_by(login_name: 'cropbot')
+  end
+
+  def import!
+    Crop.all.order(updated_at: :desc).each do |crop|
+      Rails.logger.debug { "#{crop.id}, #{crop.name}" }
+      update_crop(crop) if crop.valid?
+    end
+  end
+
+  def update_crop(crop)
+    openfarm_record = fetch(crop.name)
+    if openfarm_record.present? && openfarm_record.is_a?(String)
+      Rails.logger.info(openfarm_record)
+    elsif openfarm_record.present? && openfarm_record.fetch('data', false)
+      crop.update! openfarm_data: openfarm_record.fetch('data', false)
+      save_companions(crop, openfarm_record)
+      save_photos(crop)
+    else
+      Rails.logger.debug "\tcrop not found on Open Farm"
+      crop.update!(openfarm_data: false)
+    end
+  end
+
+  def save_companions(crop, openfarm_record)
+    companions = openfarm_record.fetch('data').fetch('relationships').fetch('companions').fetch('data')
+    crops = openfarm_record.fetch('included', []).select { |rec| rec["type"] == 'crops' }
+    CropCompanion.transaction do
+      companions.each do |com|
+        companion_crop_hash = crops.detect { |c| c.fetch('id') == com.fetch('id') }
+        companion_crop_name = companion_crop_hash.fetch('attributes').fetch('name').downcase
+        companion_crop = Crop.where('lower(name) = ?', companion_crop_name).first
+        companion_crop = Crop.create!(name: companion_crop_name, requester: @cropbot, approval_status: "pending") if companion_crop.nil?
+        crop.companions << companion_crop unless crop.companions.where(id: companion_crop.id).any?
+      end
+    end
+  end
+
+  def save_photos(crop)
+    pictures = fetch_pictures(crop.name)
+    pictures.each do |picture|
+      data = picture.fetch('attributes')
+      Rails.logger.debug(data)
+      next unless data.fetch('image_url').start_with? 'http'
+      next if Photo.find_by(source_id: picture.fetch('id'), source: 'openfarm')
+
+      photo = Photo.new(
+        source_id:     picture.fetch('id'),
+        source:        'openfarm',
+        owner:         @cropbot,
+        thumbnail_url: data.fetch('thumbnail_url'),
+        fullsize_url:  data.fetch('image_url'),
+        title:         'Open Farm photo',
+        license_name:  'No rights reserved',
+        link_url:      "https://openfarm.cc/en/crops/#{name_to_slug(crop.name)}"
+      )
+      if photo.valid?
+        Photo.transaction do
+          photo.save
+          PhotoAssociation.find_or_create_by! photo:, photographable: crop
+        end
+        Rails.logger.debug { "\t saved photo #{photo.id} #{photo.source_id}" }
+      else
+        Rails.logger.warn "Photo not valid"
+      end
+    end
+  end
+
+  def fetch(name)
+    conn.get("crops/#{name_to_slug(name)}.json").body
+  rescue NoMethodError
+    Rails.logger.debug "error fetching crop"
+    Rails.logger.debug "BODY: "
+    Rails.logger.debug body
+  end
+
+  def name_to_slug(name)
+    CGI.escape(name.gsub(' ', '-').downcase)
+  end
+
+  def fetch_all(page)
+    conn.get("crops.json?page=#{page}").body.fetch('data', {})
+  end
+
+  def fetch_pictures(name)
+    body = conn.get("crops/#{name_to_slug(name)}/pictures.json").body
+    body.fetch('data', false)
+  rescue StandardError
+    Rails.logger.debug "Error fetching photos"
+    Rails.logger.debug []
+  end
+
+  private
+
+  def conn
+    Faraday.new BASE do |conn|
+      conn.response :json, content_type: /\bjson$/
+      conn.adapter Faraday.default_adapter
+    end
+  end
+end

app/services/timeline_service.rb

@@ -18,20 +18,10 @@ class TimelineService
       .union_all(photos_query)
       .union_all(seeds_query)
       .union_all(activities_query)
-      .union_all(likes_query)
       .where.not(event_at: nil)
       .order(event_at: :desc)
   end
 
-  def self.likes_query
-    Like
-      .select("likes.id",
-              "'like' as event_type",
-              "likes.created_at as event_at",
-              "likes.member_id as owner_id",
-              "null as crop_id")
-  end
-
   def self.activities_query
     Activity.select(
       :id,

app/views/activities/_form.html.haml

@@ -39,13 +39,15 @@
           = link_to "Add a planting.", new_planting_path
 
         .col-md-4
-          = f.date_field :due_date, value: @activity.due_date ? @activity.due_date.to_fs(:ymd) : '', label: 'When?'
+          = f.date_field :due_date,
+                     value: @activity.due_date ? @activity.due_date.to_fs(:ymd) : '',
+                     label: 'When?'
 
       %hr
 
       .row
         .col-md-6
-          = f.check_box :finished, label: t('buttons.mark_as_finished')
+          = f.check_box :finished, label: 'Mark as finished'
           %span.help-block= t('.finish_helper')
 
     .card-footer

app/views/alternate_names/_form.html.haml

@@ -31,8 +31,7 @@
         = f.label :name, class: 'control-label col-md-2'
         .col-md-8
           = f.text_field :name, class: 'form-control'
-        .col-md-8
-          = f.select :language, I18nData.languages.map {|code, name| [name.split(";").first, code] }, class: 'form-control'
+
       .form-group
         .form-actions.col-md-offset-2.col-md-8
           = f.submit 'Save', class: 'btn btn-primary'

app/views/comments/_description.haml

@@ -1 +1 @@
-#{link_to 'commented', event_model} on #{link_to event_model.commentable, event_model.commentable}
+#{link_to 'commented', event_model} on #{link_to event_model.post, event_model.post}

app/views/comments/_form.html.haml

@@ -1,4 +1,3 @@
-- @comment ||= Comment.new(commentable: @commentable)
 .card.col-md-8.col-lg-7.mx-auto.float-none.white.z-depth-1.py-2.px-2
   .card-body
     - if content_for? :title
@@ -15,13 +14,13 @@
               %li= msg
 
       .md-form
-        = f.text_area :body, rows: 6, class: 'form-control md-textarea', autofocus: 'autofocus', required: true, pattern: '\w+'
+        = f.text_area :body, rows: 6, class: 'form-control md-textarea', autofocus: 'autofocus'
         = f.label :body, "Your comment:"
 
       %span.help-block
         = render partial: "shared/markdown_help"
       .actions.text-right
         = f.submit 'Post comment', class: 'btn btn-primary'
-      .field
-        = f.hidden_field :commentable_id, value: @commentable.id
-        = f.hidden_field :commentable_type, value: @commentable.class.name
+      - if defined?(@post)
+        .field
+          = f.hidden_field :post_id, value: @post.id

app/views/comments/edit.html.haml

@@ -2,6 +2,6 @@
 
 %p
   Editing comment on
-  = link_to @comment.commentable.subject, @comment.commentable
+  = link_to @comment.post.subject, @comment.post
 
-= render 'form', locals: { comment: @comment, commentable: @comment.commentable }
+= render 'form'

app/views/comments/index.rss.haml

@@ -5,18 +5,17 @@
     %link= comments_url
     - @comments.each do |comment|
       %item
-        %title Comment by #{comment.author.login_name} on #{comment.commentable.subject}
+        %title Comment by #{comment.author.login_name} on #{comment.post.subject}
         %description
           :escaped_markdown
             <p>
             Comment on
-            #{ link_to comment.commentable.subject, polymorphic_url(comment.commentable) }
+            #{ link_to comment.post.subject, post_url(comment.post) }
             </p>
 
           :escaped_markdown
             #{ strip_tags markdownify(comment.body) }
 
         %pubdate= comment.created_at.to_fs(:rfc822)
-        %link= polymorphic_url(comment.commentable)
+        %link= post_url(comment.post)
         %guid= comment_url(comment)
-

app/views/comments/new.html.haml

@@ -1,17 +1,11 @@
 = content_for :title, "New comment"
-- if @commentable.is_a?(Post)
-  %section.blog-post
-    .card.post{ id: "post-#{@commentable.id}" }
-      .card-header
-        %h2.display-3= @commentable.subject
-      .card-body= render "posts/single", post: @commentable || @comment.commentable, subject: true
-- elsif @commentable.is_a?(Photo)
-  %section.blog-post
-    .card.photo{ id: "photo-#{@commentable.id}" }
-      .card-header
-        %h2.display-3= @commentable.subject
-      .card-body= render "photos/card", photo: @commentable || @comment.commentable, subject: true
 
-= render partial: "comments/comments", locals: { commentable: @commentable || @comment.commentable }
+%section.blog-post
+  .card.post{ id: "post-#{@post.id}" }
+    .card-header
+      %h2.display-3= @post.subject
+    .card-body= render "posts/single", post: @post || @comment.post, subject: true
 
-= render 'form', locals: { comment: @comment, commentable: @commentable || @comment.commentable }
+= render partial: "posts/comments", locals: { post: @post || @comment.post }
+
+= render 'form'

app/views/crops/_actions.html.haml

@@ -1,6 +1,6 @@
 - if crop.approved? && signed_in?
 
-  .btn-group.crop-actions{"aria-label" => "Crop Actions", role: "group"}
+  .btn-group{"aria-label" => "Crop Actions", role: "group"}
     = render 'plantings/modal', planting: Planting.new(crop: crop, owner: current_member)
     = render 'harvests/modal', harvest: Harvest.new(crop: @crop,  owner: current_member)
     = render 'seeds/modal', seed: Seed.new(crop: @crop,  owner: current_member)

app/views/crops/_alternate_names.html.haml

@@ -5,7 +5,7 @@
       - if can? :edit, an
         .dropdown.planting-actions
           %a#crop-actions-altnames.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", :type => "button", :href => '#'}
-            = "#{an.name} (#{an.language})"
+            = an.name
           .dropdown-menu.dropdown-menu-xs{"aria-labelledby" => "crop-actions-altnames"}
             - if can? :edit, an
               = link_to edit_alternate_name_path(an), class: 'dropdown-item' do
@@ -16,7 +16,7 @@
                 = delete_icon
                 = t('.delete')
       - else
-        .badge= "#{an.name} (#{an.language})"
+        .badge= an.name
 
 
   %p.text-right

app/views/crops/_crop.html.haml

@@ -25,9 +25,9 @@
           Last harvest expected
           %strong= crop.median_days_to_last_harvest
           days after planting
-  - if member_signed_in?
-    .card-footer
-      .d-flex.btn-group-vertical
-        = render 'plantings/modal', planting: Planting.new(crop: crop, owner: current_member)
-        - #= render 'harvests/modal', harvest: Harvest.new(crop: crop, owner: current_member)
-        = render 'seeds/modal', seed: Seed.new(crop: crop, owner: current_member)
+    - if member_signed_in?
+      .card-footer
+        .d-flex.justify-content-between
+          = render 'plantings/modal', planting: Planting.new(crop: crop, owner: current_member)
+          - #= render 'harvests/modal', harvest: Harvest.new(crop: crop, owner: current_member)
+          = render 'seeds/modal', seed: Seed.new(crop: crop, owner: current_member)

app/views/crops/_planting_advice.html.haml

@@ -0,0 +1,6 @@
+- if crop.guides_count.present? && crop.guides_count.positive?
+  %p
+    There are
+    = link_to "https://openfarm.cc/en/crops/#{CGI.escape @crop.name.gsub(' ', '-').downcase}" do
+      #{crop.guides_count} growing guides on Open Farm
+

app/views/crops/_wrangle.html.haml

@@ -10,6 +10,10 @@
           = edit_icon
           = t('.edit')
 
+        = link_to crop_openfarm_path(crop), method: :post, class: 'dropdown-item' do
+          = icon 'far', 'update'
+          Fetch data from OpenFarm
+
         = link_to crop_gbif_path(crop), method: :post, class: 'dropdown-item' do
           = icon 'far', 'update'
           Fetch data from GBIF

app/views/crops/show.html.haml

@@ -74,6 +74,7 @@
       .card-body
         %h4 How to grow #{@crop.name.pluralize}
         = render 'grown_for', crop: @crop
+        = render 'planting_advice', crop: @crop
         - if @crop.parent
           %hr/
           %p.parent-crop
@@ -123,6 +124,13 @@
             = icon 'fas', 'external-link-alt'
             Wikipedia (English)
 
+        %li.list-group-item
+          = link_to "https://openfarm.cc/en/crops/#{CGI.escape @crop.name.gsub(' ', '-')}",
+                    class: 'card-link',
+                    target: "_blank",
+                    rel: "noopener noreferrer" do
+            = icon 'fas', 'external-link-alt'
+            OpenFarm - Growing guide
         %li.list-group-item
           = link_to "https://www.gardenate.com/plant/#{CGI.escape @crop.name}",
                     target: "_blank",
@@ -139,14 +147,6 @@
               = icon 'fas', 'external-link-alt'
               Google
 
-        %li.list-group-item
-          = link_to 'https://chat.openai.com/?model=gpt-4o&prompt=' + CGI.escape(['How do I grow', @crop.name, "and what grows well with it? What should I plant the next season if practicing crop rotation? Explain why and add links to your sources"].join(' ')),
-                  target: "_blank",
-                  class: 'card-link',
-                  rel: "noopener noreferrer" do
-            = icon 'fas', 'external-link-alt'
-            ChatGPT
-
         %li.list-group-item
           = link_to "https://wikihow.com/wikiHowTo?search=#{CGI.escape "grow #{@crop.name}" }",
                     target: "_blank",

app/views/devise/registrations/_edit_apps.html.haml

@@ -3,6 +3,19 @@
     html: { method: :put, class: 'form-horizontal' }) do |_f|
   %br/
   = render 'devise/shared/error_messages', resource: resource
+  .row
+    .col-md-12
+      %p
+        = image_tag "twitter_32.png", size: "32x32", alt: 'Twitter logo'
+        - if @twitter_auth
+          You are connected to Twitter as
+          = link_to @twitter_auth.name, "https://twitter.com/#{@twitter_auth.name}"
+          = link_to "Disconnect", @twitter_auth,
+                    confirm: "Are you sure you want to remove this connection?",
+                    method: :delete, class: "remove btn btn-danger"
+        - else
+          = link_to 'Connect to Twitter', '/members/auth/twitter', class: 'btn'
+
   .row
     .col-md-12
       %p

app/views/gardens/_actions.html.haml

@@ -15,4 +15,5 @@
 
       - if can?(:destroy, garden)
         .dropdown-divider
-        = delete_button(garden, classes: 'dropdown-item text-danger', message: 'gardens.confirm_delete')
+        = delete_button(garden, classes: 'dropdown-item text-danger',
+          message: 'All plantings associated with this garden will also be deleted. Are you sure?')

app/views/gardens/show.html.haml

@@ -66,7 +66,8 @@
   
       - if can?(:destroy, @garden)
         .dropdown-divider
-        = delete_button(@garden, classes: 'dropdown-item text-danger', message: 'gardens.confirm_delete')
+        = delete_button(@garden, classes: 'dropdown-item text-danger',
+          message: 'All plantings associated with this garden will also be deleted. Are you sure?')
 
     %section
       %h2 Current activities in garden

app/views/harvests/_form.html.haml

@@ -30,7 +30,7 @@
                 = link_to "Request new crops.", new_crop_path
 
         .col-md-4
-          = f.date_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '', label: 'When?', required: true
+          = f.date_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '', label: 'When?'
         .col-12
           = f.form_group :plant_part_id, label: { text: "Harvested Plant Part" } do
             .row

app/views/home/_stats.html.haml

@@ -4,6 +4,6 @@
      member: link_to(t('.member_linktext', count: Member.confirmed.size.to_i), members_path),
      number_crops: link_to(t('.number_crops_linktext', count: Crop.count.to_i), crops_path),
      number_plantings: link_to(t('.number_plantings_linktext', count: Planting.count.to_i), plantings_path),
-     number_gardens: link_to(t('.number_gardens_linktext', count: Garden.count.to_i), gardens_path),
-     contributors: link_to(count_github_contibutors, 'https://github.com/Growstuff/growstuff/blob/dev/CONTRIBUTORS.md', target: '_blank', rel: 'noopener'), 
-     github: link_to('GitHub', 'http://github.com/Growstuff/growstuff', target: '_blank', rel: 'noopener'))
+     number_gardens: link_to(t('.number_gardens_linktext', count: Garden.count.to_i), gardens_path))
+
+

app/views/home/index.html.haml

@@ -8,7 +8,6 @@
 
       %p= render 'stats', cached: true
     .col
-      %br
       %p
         - if current_member.plantings.active.any?
           = link_to member_path(current_member, anchor: "#content"), class: 'btn btn-dark' do
@@ -62,16 +61,3 @@
     %section.members
       = cute_icon
       = render 'members', cached: true
-  .col-12.col-lg-6
-    %section.pwa-install
-      = cute_icon
-      %h2.text-center= t('home.pwa_title')
-      .index-cards
-        .card
-          .card-body
-            %h3= t('home.pwa_ios_title')
-            %p= t('home.pwa_ios_steps_html')
-        .card
-          .card-body
-            %h3= t('home.pwa_android_title')
-            %p= t('home.pwa_android_steps_html')

app/views/layouts/_header.html.haml

@@ -6,6 +6,6 @@
         %span.site-name Growstuff
   .nav= render 'crops/search_bar'
   .nav
-    %button.navbar-toggler.ml-auto{ "aria-controls" => "navbarSupportedContent", "aria-expanded" => "false", "aria-label" => "Toggle navigation", "data-bs-target" => "#navbarSupportedContent", "data-bs-toggle" => "collapse", type: "button" }
-      %span.navbar-toggler-icon
+    %button.navbar-toggler{ "aria-controls" => "offcanvasNavbar", "aria-label" => "Toggle navigation", "data-bs-target" => "#offcanvasNavbar", "data-bs-toggle" => "offcanvas", type: "button" }
+      %i.fas.fa-ellipsis-v.navbar-toggler-icon
     = render 'layouts/menu'

app/views/layouts/_menu.haml

@@ -1,104 +1,102 @@
-#navbarSupportedContent.collapse.navbar-collapse
-  %ul.navbar-nav.mr-auto.bg-dark
-    - if signed_in?
-      %li.nav-item
-        = link_to timeline_index_path, method: :get, class: 'nav-link text-white' do
-          = image_tag 'icons/notification.svg', class: 'img img-icon', alt: "Notifications"
-      %li.nav-item
-        = link_to member_gardens_path(current_member), class: 'nav-link text-white', title: "My gardens" do
-          = image_icon 'gardens'
-      %li.nav-item.dropdown
-        %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}
-          = image_tag "icons/gardener.svg", class: 'img img-icon', alt: t('.record'), aria: { hidden: "true" }
-          = t('.record')
-        .dropdown-menu
-          = link_to new_planting_path, class: 'dropdown-item' do
-            = image_icon('planting-add')
-            = t('buttons.new_planting')
-          = link_to new_harvest_path, class: 'dropdown-item' do
-            = image_icon('harvest-add')
-            = t('buttons.new_harvest')
-          = link_to new_activity_path, class: 'dropdown-item' do
-            = image_icon('activity-add')
-            = t('buttons.new_activity')
-          = link_to new_seed_path, class: 'dropdown-item' do
-            = image_icon('seed-add')
-            = t('buttons.new_seeds')
-          = link_to new_post_path, class: 'dropdown-item' do
-            = post_icon
-            = t('buttons.new_post')
-
-    - cache("everyone-menu", expires_in: 1.week) do
-      %li.nav-item.dropdown
-        %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}
-          %span
-          = t('.crops')
-        .dropdown-menu
-          = link_to crops_path, class: 'dropdown-item' do
-            = t('.browse_crops')
-          = link_to seeds_path, class: 'dropdown-item' do
-            = seed_icon
-            = t('.seeds')
-          = link_to plantings_path, class: 'dropdown-item' do
-            = planting_icon
-            = t('.plantings')
-          = link_to harvests_path, class: 'dropdown-item' do
-            = harvest_icon
-            = t('.harvests')
-      %li.nav-item.dropdown
-        %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}
-          %span
-          = t('.community')
-        .dropdown-menu{"aria-labelledby" => "navbarDropdown"}
-          = link_to t('.community_map'), places_path, class: 'dropdown-item'
-          = link_to t('.browse_members'), members_path, class: 'dropdown-item'
-          = link_to t('.posts'), posts_path, class: 'dropdown-item'
-          = link_to t('.forums'), forums_path, class: 'dropdown-item'
-
-    - if member_signed_in?
-      - if current_member.role?(:crop_wrangler) || current_member.role?(:admin)
+.offcanvas.offcanvas-start#offcanvasNavbar{ 'aria-labelledby' => 'offcanvasNavbarLabel', 'tabindex' => '-1' }
+  .offcanvas-header
+    %h5.offcanvas-title#offcanvasNavbarLabel Menu
+    %button.btn-close.text-reset{ 'data-bs-dismiss' => 'offcanvas', 'aria-label' => 'Close' }
+  .offcanvas-body
+    %ul.navbar-nav.mr-auto
+      - if signed_in?
+        %li.nav-item
+          = link_to timeline_index_path, method: :get, class: 'nav-link' do
+            = image_tag 'icons/notification.svg', class: 'img img-icon', alt: "Notifications"
+        %li.nav-item
+          = link_to member_gardens_path(current_member), class: 'nav-link', title: "My gardens" do
+            = image_icon 'gardens'
         %li.nav-item.dropdown
           %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}
-            %span
-            = t('.admin')
+            = image_tag "icons/gardener.svg", class: 'img img-icon', alt: t('.record'), aria: { hidden: "true" }
+            = t('.record')
+          .dropdown-menu
+            = link_to new_planting_path, class: 'dropdown-item' do
+              = image_icon('planting-add')
+              = t('buttons.new_planting')
+            = link_to new_harvest_path, class: 'dropdown-item' do
+              = image_icon('harvest-add')
+              = t('buttons.new_harvest')
+            = link_to new_activity_path, class: 'dropdown-item' do
+              = image_icon('activity-add')
+              = t('buttons.new_activity')
+            = link_to new_seed_path, class: 'dropdown-item' do
+              = image_icon('seed-add')
+              = t('buttons.new_seeds')
+            = link_to new_post_path, class: 'dropdown-item' do
+              = post_icon
+              = t('buttons.new_post')
+
+      - cache("everyone-menu", expires_in: 1.week) do
+        %li.nav-item.dropdown
+          %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}= t('.crops')
+          .dropdown-menu
+            = link_to crops_path, class: 'dropdown-item' do
+              = t('.browse_crops')
+            = link_to seeds_path, class: 'dropdown-item' do
+              = seed_icon
+              = t('.seeds')
+            = link_to plantings_path, class: 'dropdown-item' do
+              = planting_icon
+              = t('.plantings')
+            = link_to harvests_path, class: 'dropdown-item' do
+              = harvest_icon
+              = t('.harvests')
+        %li.nav-item.dropdown
+          %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}= t('.community')
           .dropdown-menu{"aria-labelledby" => "navbarDropdown"}
-            - if current_member.role?(:crop_wrangler)
-              = link_to t('.crop_wrangling'), wrangle_crops_path, class: 'dropdown-item'
-            - if current_member.role?(:admin)
-              = link_to t('.admin'), admin_path, class: 'dropdown-item'
+            = link_to t('.community_map'), places_path, class: 'dropdown-item'
+            = link_to t('.browse_members'), members_path, class: 'dropdown-item'
+            = link_to t('.posts'), posts_path, class: 'dropdown-item'
+            = link_to t('.forums'), forums_path, class: 'dropdown-item'
 
-      %li.nav-item.dropdown
-        %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}
-          = image_tag(avatar_uri(current_member, 50), alt: 'Avatar of current member', height: 25, width: 25, aria: { hidden: "true" })
-          = current_member.login_name
-          - if current_member.unread_count.positive?
-            %span.badge.badge-info= current_member.unread_count
-        .dropdown-menu{"aria-labelledby" => "navbarDropdown"}
-          = link_to member_path(current_member), class: 'dropdown-item' do
-            = t('.profile')
-          = link_to member_activities_path(current_member), class: 'dropdown-item' do
-            = t('.activities')
-          = link_to member_gardens_path(current_member), class: 'dropdown-item' do
-            = t('.gardens')
-          = link_to member_plantings_path(current_member), class: 'dropdown-item' do
-            = t('.plantings')
-          = link_to member_harvests_path(current_member), class: 'dropdown-item' do
-            = t('.harvest')
-          = link_to member_seeds_path(current_member), class: 'dropdown-item' do
-            = t('.seeds')
-          = link_to t('.posts'), member_posts_path(current_member), class: 'dropdown-item'
+      - if member_signed_in?
+        - if current_member.role?(:crop_wrangler) || current_member.role?(:admin)
+          %li.nav-item.dropdown
+            %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}= t('.admin')
+            .dropdown-menu{"aria-labelledby" => "navbarDropdown"}
+              - if current_member.role?(:crop_wrangler)
+                = link_to t('.crop_wrangling'), wrangle_crops_path, class: 'dropdown-item'
+              - if current_member.role?(:admin)
+                = link_to t('.admin'), admin_path, class: 'dropdown-item'
 
-          - if current_member.unread_count.positive?
+        %li.nav-item.dropdown
+          %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", href: "#", role: "button"}
+            = image_tag(avatar_uri(current_member, 50), alt: 'Avatar of current member', height: 25, width: 25, aria: { hidden: "true" })
+            = current_member.login_name
+            - if current_member.unread_count.positive?
+              %span.badge.badge-info= current_member.unread_count
+          .dropdown-menu{"aria-labelledby" => "navbarDropdown"}
+            = link_to member_path(current_member), class: 'dropdown-item' do
+              = t('.profile')
+            = link_to member_activities_path(current_member), class: 'dropdown-item' do
+              = t('.activities')
+            = link_to member_gardens_path(current_member), class: 'dropdown-item' do
+              = t('.gardens')
+            = link_to member_plantings_path(current_member), class: 'dropdown-item' do
+              = t('.plantings')
+            = link_to member_harvests_path(current_member), class: 'dropdown-item' do
+              = t('.harvest')
+            = link_to member_seeds_path(current_member), class: 'dropdown-item' do
+              = t('.seeds')
+            = link_to t('.posts'), member_posts_path(current_member), class: 'dropdown-item'
+
+            - if current_member.unread_count.positive?
+              .dropdown-divider
+              %strong
+                = link_to(conversations_path, class: 'dropdown-item') do
+                  = t('.inbox')
+                  %span.badge.badge-info= current_member.unread_count
+            - else
+              = link_to t('.inbox'), conversations_path, class: 'dropdown-item'
             .dropdown-divider
-            %strong
-              = link_to(conversations_path, class: 'dropdown-item') do
-                = t('.inbox')
-                %span.badge.badge-info= current_member.unread_count
-          - else
-            = link_to t('.inbox'), conversations_path, class: 'dropdown-item'
-          .dropdown-divider
-          = link_to t('.sign_out'), destroy_member_session_path, method: :delete, class: 'dropdown-item'
+            = link_to t('.sign_out'), destroy_member_session_path, method: :delete, class: 'dropdown-item'
 
-    - else
-      %li.nav-item= link_to t('.sign_in'), new_member_session_path, id: 'navbar-signin', class: 'btn btn-signin'
-      %li.nav-item= link_to t('.sign_up'), new_member_registration_path, id: 'navbar-signup', class: 'btn btn-signup'
+      - else
+        %li.nav-item= link_to t('.sign_in'), new_member_session_path, id: 'navbar-signin', class: 'btn btn-signin'
+        %li.nav-item= link_to t('.sign_up'), new_member_registration_path, id: 'navbar-signup', class: 'btn btn-signup'

app/views/likes/_description.html.haml

@@ -1 +0,0 @@
-#{link_to event_model.member, event_model.member} liked #{link_to event_model.likeable.class.name.downcase, event_model.likeable}

app/views/members/_bio.html.haml

@@ -1 +1,13 @@
 %h2 All about #{member.login_name}
+%p
+  %small
+    %a{href: "#content"}
+      Skip to main content
+- if member.bio.blank?
+  - if can? :edit, member
+    = link_to "Add a bio to complete your profile.", edit_member_registration_path
+  - else
+    #{member.login_name} hasn't written a bio yet.
+- else
+  :markdown
+    #{ strip_tags markdownify(member.bio) }

app/views/members/_contact.html.haml

@@ -1,4 +1,4 @@
-- if member.website_url.present? || member.instagram_handle.present? || member.facebook_handle.present? || member.bluesky_handle.present? || member.other_url.present? || flickr_auth || member.show_email
+- if member.website_url.present? || member.instagram_handle.present? || member.facebook_handle.present? || member.bluesky_handle.present? || member.other_url.present? || twitter_auth || flickr_auth || member.show_email
   %h4 Contact
 
   - if member.website_url.present?
@@ -26,6 +26,11 @@
       = icon 'fas', 'link', class: 'fa-fw'
       = link_to "More...", member.other_url, target: '_blank', rel: 'noopener noreferrer'
 
+  - if twitter_auth
+    %p
+      = image_tag "twitter_32.png", size: "32x32", alt: 'Twitter logo'
+      = link_to twitter_auth.name, "https://twitter.com/#{twitter_auth.name}", target: '_blank', rel: 'noopener noreferrer'
+
   - if flickr_auth
     %p
       = image_tag "flickr_32.png", size: "32x32", alt: 'Flickr logo'

app/views/members/_map.html.haml

@@ -5,5 +5,5 @@
     = link_to member.location, place_path(member.location, anchor: "members")
 - else
   .location-not-set
-    %h1 Location not known or geocodable
-    %p We can't show you what's nearby
+    .sr-only Location not known
+    .sr-only We can't show you what's nearby

app/views/members/_member.haml

@@ -1,5 +1,5 @@
 - cache member do
-  .card
+  .card.card-double
     .card-body
       %h4.login-name= link_to member, member
       %div

app/views/members/show.html.haml

@@ -21,21 +21,6 @@
         .row
           .col= render "bio", member: @member
           .col= render "avatar", member: @member
-        .row
-          .col
-            %p
-              %small
-                %a{href: "#content"}
-                  Skip to main content
-            - if @member.bio.blank?
-              - if member_signed_in? && current_member == @member
-                = link_to "Add a bio to complete your profile.", edit_member_registration_path
-              - else
-                #{@member.login_name} hasn't written a bio yet.
-            - else
-              :markdown
-                #{ strip_tags markdownify(@member.bio) }
-
         - if @member.roles.any?
           %p
             - @member.roles.each do |role|
@@ -45,16 +30,12 @@
             = icon 'fas', 'map-marker'
             = truncate(@member.location, length: 15, separator: ' ', omission: '... ')
         %p
-          %small
-            %strong Member since
-            %br
-            = @member.created_at.to_fs(:date)
+          %strong Member since
+          = @member.created_at.to_fs(:date)
         - if @member.last_sign_in_at
           %p
-            %small
-              %strong Last Login
-              %br
-              = @member.last_sign_in_at&.to_fs(:default)
+            %strong Last Login
+            = @member.last_sign_in_at&.to_fs(:default)
 
         - if can? :update, @member
           = link_to edit_member_registration_path, class: 'btn btn-block' do
@@ -77,13 +58,14 @@
 
       = render "stats", member: @member
       .card-footer
-        = render "contact", member: @member, flickr_auth: @flickr_auth
+        = render "contact", member: @member, twitter_auth: @twitter_auth,
+                                              flickr_auth: @flickr_auth
 
   .col-md-10#content
     .row
       %section.order-3.order-md-1.col-12= render "map", member: @member
-      - if @harvesting.size.positive? 
-        %section.harvests.order-2.order-md-1.col-12
+      - if @harvesting.size.positive?
+        %section.harvests.order-2.order-md-1
           %h2 Ready to harvest
           .index-cards
             - @harvesting.each do |planting|

app/views/photos/show.html.haml

@@ -46,12 +46,4 @@
       - else
         = @photo.license_name
 
-    = render "associations", photo: @photo
-.row
-  - if can? :create, Comment
-    = link_to new_comment_path(comment: { commentable_type: 'Photo', commentable_id: @photo.id }), class: 'btn' do
-      = icon 'fas', 'comment'
-      Comment
-.row
-  .col-md-9
-    = render 'comments/comments', commentable: @photo
+    = render "associations", photo: @photo

app/views/plantings/_actions.html.haml

@@ -7,16 +7,7 @@
       - if planting.active
         = planting_plan_something_button(planting, classes: 'dropdown-item')
         = planting_finish_button(planting, classes: 'dropdown-item')
-        = planting_failed_button(planting, classes: 'dropdown-item')
         = planting_harvest_button(planting, classes: 'dropdown-item')
         = planting_save_seeds_button(planting, classes: 'dropdown-item')
-      - if can?(:transplant, planting) && planting.active && transplantable_gardens_by_owner(planting).any?
-        .dropdown-divider
-        .px-2
-          = form_tag transplant_planting_path(planting), method: :post do
-            .form-group
-              = label_tag :garden_id, 'Transplant to:'
-              = select_tag :garden_id, options_from_collection_for_select(transplantable_gardens_by_owner(planting), :id, :name), class: 'form-control form-control-sm'
-            = submit_tag 'Transplant', class: 'btn btn-sm btn-primary mt-2'
       .dropdown-divider
       = delete_button(planting, classes: 'dropdown-item text-danger')

app/views/plantings/_card.html.haml

@@ -19,7 +19,6 @@
   
               - if planting.active
                 = planting_finish_button(planting, classes: 'dropdown-item')
-                = planting_failed_button(planting, classes: 'dropdown-item')
                 = planting_harvest_button(planting, classes: 'dropdown-item')
                 = planting_save_seeds_button(planting, classes: 'dropdown-item')
   

app/views/plantings/_descendants.html.haml

@@ -1,14 +1,13 @@
 %h2 Seeds saved
 
-- if can?(:edit, planting) && !planting.failed?
-  %a.btn.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", role: "button"}
-    = seed_icon
-    = t('buttons.save_seeds')
-  .dropdown-menu.dropdown-secondary
-    - Seed::TRADABLE_TO_VALUES.each do |trade|
-      = link_to seeds_path(return: 'planting', seed: {crop_id: planting.crop.id, parent_planting_id: planting.id, tradable_to: trade}), method: :post, class: 'dropdown-item' do
-        Will trade:
-        = trade
+%a.btn.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-bs-toggle" => "dropdown", role: "button"}
+  = seed_icon
+  = t('buttons.save_seeds')
+.dropdown-menu.dropdown-secondary
+  - Seed::TRADABLE_TO_VALUES.each do |trade|
+    = link_to seeds_path(return: 'planting', seed: {crop_id: planting.crop.id, parent_planting_id: planting.id, tradable_to: trade}), method: :post, class: 'dropdown-item' do
+      Will trade:
+      = trade
 
 - if planting.child_seeds.size.positive?
   .index-cards

app/views/plantings/_facts.haml

@@ -21,7 +21,7 @@
   - if planting.finish_is_predicatable?
     .card.fact-card
       %h3 Progress
-      - if planting.age_in_days.to_i < 0
+      - if planting.age_in_days < 0
         %strong Planned
       - else
         %strong #{planting.age_in_days}/#{planting.expected_lifespan}
@@ -40,12 +40,12 @@
       - if planting.quantity.to_i.positive? && planting.planted_from.present?
         = planting.planted_from.pluralize(planting.quantity.to_i)
 
-  - unless planting.finished? || planting.failed?
+  - unless planting.finished?
     .card.fact-card.grid-sizer
       %h3 Growing
       %strong= seedling_icon
       %span
-      - if planting.age_in_days.to_i < 0
+      - if planting.age_in_days < 0
         Planting planned
       - else
         Planting is still growing today

app/views/plantings/_form.html.haml

@@ -32,9 +32,11 @@
             label: 'Where did you plant it?')
           = link_to "Add a garden.", new_garden_path
         .col-md-4
-          = f.date_field :planted_at,
+          = f.text_field :planted_at,
                      value: @planting.planted_at ? @planting.planted_at.to_fs(:ymd) : '',
-                     class: 'add-datepicker', label: 'When?', title: "Plan out your future plantings by forward dating, and subscribe to your iCalendar feed for reminders to plant"
+                     class: 'add-datepicker', label: 'When?'
+          %span.help-inline
+            Tip: Plan our your future plantings by forward dating, and subscribe to your iCalendar feed for reminders to plant
 
       .row
         .col-md-4
@@ -47,16 +49,14 @@
 
       .row
         .col-md-6
-          = f.check_box :finished, label: t('buttons.mark_as_finished'), title: t('.finish_helper')
-
+          = f.check_box :finished, label: 'Mark as finished'
+          %span.help-block= t('.finish_helper')
         .col-md-6
-          = f.date_field :finished_at,
+          = f.text_field :finished_at,
                      value: @planting.finished_at ? @planting.finished_at.to_fs(:ymd) : '',
+                     class: 'add-datepicker',
                      label: 'Finished date',
                      placeholder: 'optional'
-      .row
-        .col-md-6
-          = f.check_box :failed, label: t('buttons.mark_as_failed'), title: t('.failed_helper')
 
     .card-footer
       .text-right= f.submit 'Save'

app/views/plantings/_harvests.html.haml

@@ -1,9 +1,10 @@
 %h2 Harvests
-- if can?(:edit, planting) && !planting.failed
+
+- if can? :edit, planting
   = render 'harvests/modal', harvest: Harvest.new(crop: planting.crop, planting: planting)
 - if planting.harvests.empty?
   %p No harvests recorded
-  - if planting.finished? && can?(:edit, planting) && can?(:create, Harvest)
+  - if !planting.finished? && can?(:edit, planting) && can?(:create, Harvest)
     %p Record your harvests here to improve crop predictions, and you'll be able to compare with your garden next season.
 - else
   .index-cards

app/views/plantings/_timeline.html.haml

@@ -8,8 +8,6 @@
       %p.small #{harvest_icon} First harvest expected #{I18n.l planting.first_harvest_predicted_at}
     - if planting.finished_at.present?
       %p.small #{finished_icon} Finished #{I18n.l planting.finished_at}
-    - elsif planting.failed?
-      %p.small #{finished_icon} Failed
     - elsif planting.finish_predicted_at.present?
       %p.small #{finished_icon} Finish expected #{I18n.l planting.finish_predicted_at}
   - if planting.planted_at.present? && planting.expected_lifespan.present?

app/views/plantings/show.html.haml

@@ -32,17 +32,15 @@
             %strong= @planting.crop.name.titleize
             %small.text-muted= @planting.crop.default_scientific_name
           %tt
-            - if @planting.failed?
-              %span.badge.badge-danger Failed
-            - elsif @planting.finished?
-              %span.badge.badge-success Finished
+            - if @planting.finished?
+              Finished
             - elsif @planting.percentage_grown.present?
               #{@planting.percentage_grown.to_i}%
               - if @planting.finish_is_predicatable?
-                - if @planting.age_in_days.to_i < 0
+                - if @planting.age_in_days < 0
                   %strong Planned
                 - else
-                  %strong #{@planting.age_in_days.to_i}/#{@planting.expected_lifespan} days
+                  %strong #{@planting.age_in_days}/#{@planting.expected_lifespan} days
 
         = render 'timeline', planting: @planting
       = render 'likes/likes', object: @planting

app/views/posts/_comments.html.haml

@@ -1,11 +1,12 @@
 %a{ name: "comments" }
-- if commentable.comments
+- if post.comments
   %hr/
   %h2
     = comment_icon
-    = localize_plural(commentable.comments, Comment)
-  - commentable.comments.post_order.each do |comment|
+    = localize_plural(post.comments, Comment)
+  - post.comments.post_order.each do |comment|
     = render "comments/single", comment: comment
 
 - else
   %h2 There are no comments yet
+

app/views/posts/_single.html.haml

@@ -1,4 +1,3 @@
-- @post ||= post if defined?(post)
 %p
   Posted by
   - if @post.author
@@ -14,7 +13,7 @@
     and edited at
     = @post.updated_at.to_fs(:default)
 
-= link_to "Permalink", @post
+= link_to "Permalink", post
 
 :markdown
   #{ strip_tags markdownify(@post.body) }

app/views/posts/show.html.haml

@@ -24,7 +24,7 @@
 
 - content_for :buttonbar do
   - if @post.comments.count > 10 && can?(:create, Comment)
-    = link_to 'Comment', new_comment_path(comment: { commentable_type: 'Post', commentable_id: @post.id }), class: 'btn'
+    = link_to 'Comment', new_comment_path(post_id: @post.id), class: 'btn'
 
 - content_for :breadcrumbs do
   %li.breadcrumb-item= link_to @post.author, @post.author
@@ -48,12 +48,12 @@
         = render 'likes/likes', object: @post
         .float-right
           - if can? :create, Comment
-            = link_to new_comment_path(comment: { commentable_type: 'Post', commentable_id: @post.id }), class: 'btn' do
+            = link_to new_comment_path(post_id: @post.id), class: 'btn' do
               = icon 'fas', 'comment'
               Comment
 
     %section.comments
-      = render "comments/comments", commentable: @post
+      = render "comments", post: @post
 
   .col-md-4.col-12
     = render @post.author

app/views/seeds/_card.html.haml

@@ -16,20 +16,14 @@
       %p
         - if seed.quantity
           .badge.badge-info #{seed.quantity} seeds
-        %ul
-          - if seed.organic != 'unknown'
-            %li
-              %small.seedtitle--organic= seed.organic
-          - if seed.gmo != 'unknown'
-            %li
-              %small.seedtitle--gmo= seed.gmo
-          - if seed.heirloom != 'unknown'
-            %li
-              %small.seedtitle--heirloom= seed.heirloom
-
-    .card-footer
-      .d-flex.w-100.justify-content-between
-        - if seed.tradable
+        - if seed.organic != 'unknown'
+          .badge.badge-success.seedtitle--organic= seed.organic
+        - if seed.gmo != 'unknown'
+          .badge.badge-success.seedtitle--gmo= seed.gmo
+        - if seed.heirloom != 'unknown'
+          .badge.badge-success.seedtitle--heirloom= seed.heirloom
+    - if seed.tradable
+      .card-footer
+        .d-flex.w-100.justify-content-between
           %small Will trade #{seed.tradable_to}
-        - if seed.plant_before
-          %small Plant before #{seed.plant_before}
+          / %a.btn.btn-sm{href: "#"} Request

app/views/seeds/_form.html.haml

@@ -28,40 +28,38 @@
             = link_to "Request new crops.", new_crop_path
       .row
         .col-12.col-md-4
-          = f.date_field :saved_at,
+          = f.text_field :saved_at,
                      value: @seed.saved_at ? @seed.saved_at.to_fs(:ymd) : '',
-                     label: 'When were the seeds harvested/saved?'
+                     class: 'add-datepicker', label: 'When were the seeds harvested/saved?'
         .col-12.col-md-4= f.number_field :quantity, label: 'Quantity', min: 1
         .col-12.col-md-4
-          = f.date_field :plant_before, value: @seed.plant_before ? @seed.plant_before.to_fs(:ymd) : ''
+          = f.text_field :plant_before, class: 'add-datepicker',
+          value: @seed.plant_before ? @seed.plant_before.to_fs(:ymd) : ''
 
       .row
         .col-12.col-md-4
-          = f.check_box :finished, label: t('buttons.mark_as_finished')
+          = f.check_box :finished, label: 'Mark as finished'
         .col-12.col-md-4
-          = f.date_field :finished_at, value: @seed.finished_at ? @seed.finished_at.to_fs(:ymd) : ''
+          = f.text_field :finished_at, class: 'add-datepicker', value: @seed.finished_at ? @seed.finished_at.to_fs(:ymd) : ''
         .col-12.col-md-4
           %span.help-inline= t('.finish_helper')
 
       .row
-        -# TODO: Range control?
         .col-md-6= f.number_field :days_until_maturity_min, label_as_placeholder: true, label: 'min', prepend: 'Days until maturity', min: 1
         .col-md-6= f.number_field :days_until_maturity_max, label_as_placeholder: true, label: 'max', prepend: 'to', append: "days", min: 1
 
       .row
-        .col-md-3
-          = f.select(:organic, Seed::ORGANIC_VALUES, { label: 'Organic?', wrapper: { class: 'required' }, required: true }, default: 'unknown')
-        .col-md-3
-          = f.select(:gmo, Seed::GMO_VALUES, { label: 'GMO?', wrapper: { class: 'required' }, required: true }, default: 'unknown')
-        .col-md-3
-          = f.select(:heirloom, Seed::HEIRLOOM_VALUES, { label: 'Heirloom?', wrapper: { class: 'required' }, required: true }, default: 'unknown')
-        .col-md-3
-          = f.select(:source, Seed::SOURCE_VALUES, { label: 'Source?', wrapper: { class: 'required' }, required: true }, default: 'unknown')
+        .col-md-4
+          = f.select(:organic, Seed::ORGANIC_VALUES, {label: 'Organic?', wrapper: { class: 'required'}, required: true}, default: 'unknown')
+        .col-md-4
+          = f.select(:gmo, Seed::GMO_VALUES, {label: 'GMO?', wrapper: { class: 'required'}, required: true}, default: 'unknown')
+        .col-md-4
+          = f.select(:heirloom, Seed::HEIRLOOM_VALUES, {label: 'Heirloom?', wrapper: { class: 'required'}, required: true}, default: 'unknown')
       = f.text_area :description, rows: 6
 
       %hr/
       =  t('.trade_help', site_name: ENV['GROWSTUFF_SITE_NAME'])
-      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, { label: 'Will trade', wrapper: { class: 'required' }, required: true })
+      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, {label: 'Will trade', wrapper: { class: 'required'}, required: true})
       %span.help_inline
         - if current_member.location.blank?
           Don't forget to