Rename for CodeFactor: member_routing_spec.rb to members_controller_routing_spec.rb

For codefactor

.devcontainer/.env

@@ -0,0 +1,2 @@
+# Ruby version
+VARIANT=3.1.4

.devcontainer/Dockerfile

@@ -0,0 +1,22 @@
+FROM mcr.microsoft.com/devcontainers/ruby:0-3.1-bullseye
+
+# Install Rails
+RUN gem install rails:7.0.7 webdrivers:5.2.0
+
+# Default value to allow debug server to serve content over GitHub Codespace's port forwarding service
+# The value is a comma-separated list of allowed domains
+ENV RAILS_DEVELOPMENT_HOSTS=".githubpreview.dev,.preview.app.github.dev,.app.github.dev"
+
+#RUN bundle
+#RUN bundle exec rake db:create
+#RUN bundle exec rake db:migrate
+
+# [Optional] Uncomment this section to install additional OS packages.
+# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
+#     && apt-get -y install --no-install-recommends <your-package-list-here>
+
+# [Optional] Uncomment this line to install additional gems.
+# RUN gem install <your-gem-names-here>
+
+# [Optional] Uncomment this line to install global node packages.
+# RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && npm install -g <your-package-here>" 2>&1

.devcontainer/create-db-user.sql

@@ -0,0 +1,2 @@
+CREATE USER vscode CREATEDB;
+CREATE DATABASE vscode WITH OWNER vscode;

.devcontainer/devcontainer.json

@@ -0,0 +1,30 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/ruby-rails-postgres
+{
+"name": "Growstuff",
+"dockerComposeFile": "docker-compose.yml",
+"service": "app",
+"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
+
+// Features to add to the dev container. More info: https://containers.dev/features.
+// Need something to get javascript working
+"features": {
+    "ghcr.io/devcontainers/features/node:1": {}
+},
+
+// Use 'forwardPorts' to make a list of ports inside the container available locally.
+// This can be used to network with other containers or the host.
+"forwardPorts": [3000, 5432, 9200],
+
+// Use 'postCreateCommand' to run commands after the container is created.
+// these don't actually work as postCreateCommands, you need to run them manually
+// for some unknown reason, Github codespaces use rbenv and rvm simultaneously
+// and you need both to be correct for it to work
+"postCreateCommand": "nice -n 19 bundle install && nice -n 19 bundle exec rake db:create && nice -n 19 bundle exec rake db:migrate && nice -n19 bundle exec rake db:seed"
+
+// Configure tool-specific properties.
+// "customizations": {},
+
+// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+// "remoteUser": "root"
+}

.devcontainer/docker-compose.yml

@@ -0,0 +1,83 @@
+version: '3'
+
+services:
+  app:
+    build:
+      context: ..
+      dockerfile: .devcontainer/Dockerfile
+    depends_on:
+      db:
+        condition: service_healthy
+      elasticsearch:
+        condition: service_healthy
+    environment:
+      ELASTICSEARCH_URL: http://elasticsearch:9200/
+      APP_DOMAIN_NAME: localhost:3000
+      APP_PROTOCOL: http
+      DEVISE_SECRET_KEY: secret
+      GROWSTUFF_EMAIL: "noreply@test.growstuff.org"
+      GROWSTUFF_FLICKR_KEY: secretkey
+      GROWSTUFF_FLICKR_SECRET: secretsecret
+      GROWSTUFF_SITE_NAME: "Growstuff (local)"
+      RAILS_SECRET_TOKEN: supersecret
+    volumes:
+      - ../..:/workspaces:cached
+
+    # Overrides default command so things don't shut down after the process ends.
+    command: sleep infinity
+
+  db:
+    image: postgres:latest
+    restart: unless-stopped
+    volumes:
+      - postgres-data:/var/lib/postgresql/data
+      - ./create-db-user.sql:/docker-entrypoint-initdb.d/create-db-user.sql
+    environment:
+      POSTGRES_USER: postgres
+      POSTGRES_DB: growstuff_dev
+      POSTGRES_PASSWORD: postgres
+    ports:
+      - "5432:5432"
+    healthcheck:
+      test: ["CMD-SHELL", "pg_isready"]
+      interval: 10s
+      timeout: 5s
+      retries: 5
+
+  elasticsearch:
+    image: docker.elastic.co/elasticsearch/elasticsearch:7.4.0
+    container_name: elasticsearch
+    restart: unless-stopped
+    environment:
+      - xpack.security.enabled=false
+      - discovery.type=single-node
+    ulimits:
+      memlock:
+        soft: -1
+        hard: -1
+      nofile:
+        soft: 65536
+        hard: 65536
+    cap_add:
+      - IPC_LOCK
+    healthcheck:
+      test:
+        [
+          "CMD-SHELL",
+          "curl http://localhost:9200 | grep tagline",
+        ]
+      interval: 10s
+      timeout: 10s
+      retries: 120
+    volumes:
+      - esdata01:/usr/share/elasticsearch/data
+    ports:
+      - 9200:9200
+      - 9300:9300
+
+volumes:
+  postgres-data:
+  certs:
+    driver: local
+  esdata01:
+    driver: local

.github/dependabot.yml

@@ -5,7 +5,7 @@ updates:
   schedule:
     interval: daily
     time: "07:00"
-  open-pull-requests-limit: 10
+  open-pull-requests-limit: 20
   versioning-strategy: lockfile-only
   ignore:
   - dependency-name: active_median

.github/workflows/brakeman-analysis.yml

@@ -5,8 +5,6 @@ name: Brakeman Scan
 
 # This section configures the trigger for the workflow. Feel free to customize depending on your convention
 on:
-  push:
-    branches: [ dev ]
   pull_request:
     branches: [ dev ]
 
@@ -17,17 +15,15 @@ jobs:
     steps:
     # Checkout the repository to the GitHub Actions runner
     - name: Checkout
-      uses: actions/checkout@v2.3.4
+      uses: actions/checkout@v4
 
     # Customize the ruby version depending on your needs
     - name: Setup Ruby
-      uses: actions/setup-ruby@v1.1.3
-      with:
-        ruby-version: '2.7'
+      uses: ruby/setup-ruby@v1
 
     - name: Setup Brakeman
       env:
-        BRAKEMAN_VERSION: '4.10' # SARIF support is provided in Brakeman version 4.10+
+        BRAKEMAN_VERSION: '5.1.1' # SARIF support is provided in Brakeman version 4.10+
       run: |
         gem install brakeman --version $BRAKEMAN_VERSION
 
@@ -39,6 +35,6 @@ jobs:
 
     # Upload the SARIF file generated in the previous step
     - name: Upload SARIF
-      uses: github/codeql-action/upload-sarif@v1
+      uses: github/codeql-action/upload-sarif@v3
       with:
         sarif_file: output.sarif.json

.github/workflows/ci.yml

@@ -6,7 +6,7 @@ jobs:
   contributors:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2.3.4
+      - uses: actions/checkout@v4
       - name: Install ruby version specified in .ruby-version
         uses: ruby/setup-ruby@v1
         with:
@@ -53,7 +53,7 @@ jobs:
 
     steps:
       - name: Checkout this repo
-        uses: actions/checkout@v2.3.4
+        uses: actions/checkout@v4
 
       - name: Configure sysctl limits
         run: |
@@ -76,7 +76,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
       - name: Setup yarn cache
-        uses: actions/cache@v2.1.5
+        uses: actions/cache@v3
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -89,7 +89,7 @@ jobs:
           sudo apt-get -y install libpq-dev google-chrome-stable
 
       - name: Install NodeJS
-        uses: actions/setup-node@v2.4.0
+        uses: actions/setup-node@v4
         with:
           node-version: '12'
 

.rubocop.yml

@@ -1,5 +1,7 @@
 inherit_from: .rubocop_todo.yml
-require: rubocop-rails
+require:
+ - rubocop-rails
+ - rubocop-rspec
 AllCops:
   NewCops: enable
   Exclude:
@@ -16,6 +18,11 @@ Naming/FileName:
     - 'Gemfile'
     - 'Gemfile.lock'
 
+RSpec/DescribeClass:
+  Exclude:
+   - 'spec/views/**/*.rb'
+   - 'spec/features/**/*.rb'
+
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 

.rubocop_todo.yml

@@ -1,41 +1,443 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config --no-offense-counts`
-# on 2019-12-16 21:01:58 +1300 using RuboCop version 0.77.0.
+# `rubocop --auto-gen-config`
+# on 2023-09-16 07:51:19 UTC using RuboCop version 1.56.3.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-Lint/AmbiguousOperator:
+# Offense count: 15
+Capybara/SpecificMatcher:
+  Exclude:
+    - 'spec/features/crops/browse_crops_spec.rb'
+    - 'spec/features/footer_spec.rb'
+    - 'spec/features/gardens/adding_gardens_spec.rb'
+    - 'spec/features/harvests/harvesting_a_crop_spec.rb'
+    - 'spec/features/plantings/planting_a_crop_spec.rb'
+    - 'spec/features/seeds/adding_seeds_spec.rb'
+
+# Offense count: 1
+Capybara/VisibilityMatcher:
+  Exclude:
+    - 'spec/features/shared_examples/crop_suggest.rb'
+
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include, EnforcedStyle, NonImplicitAssociationMethodNames.
+# Include: spec/factories.rb, spec/factories/**/*.rb, features/support/factories/**/*.rb
+# SupportedStyles: explicit, implicit
+FactoryBot/AssociationStyle:
+  Exclude:
+    - 'spec/factories/alternate_names.rb'
+    - 'spec/factories/crop.rb'
+    - 'spec/factories/like.rb'
+    - 'spec/factories/scientific_name.rb'
+
+# Offense count: 8
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include, EnforcedStyle, ExplicitOnly.
+# Include: **/*_spec.rb, **/spec/**/*, spec/factories.rb, spec/factories/**/*.rb, features/support/factories/**/*.rb
+# SupportedStyles: create_list, n_times
+FactoryBot/CreateList:
+  Exclude:
+    - 'spec/factories/member.rb'
+    - 'spec/helpers/gardens_helper_spec.rb'
+    - 'spec/views/comments/index.rss.haml_spec.rb'
+    - 'spec/views/home/index_spec.rb'
+    - 'spec/views/photos/index.html.haml_spec.rb'
+    - 'spec/views/places/show.html.haml_spec.rb'
+    - 'spec/views/posts/index.html.haml_spec.rb'
+
+# Offense count: 1135
+# This cop supports unsafe autocorrection (--autocorrect-all).
+FactoryBot/SyntaxMethods:
+  Enabled: false
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, DefLikeMacros, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'db/migrate/20171129041341_create_photographings.rb'
+    - 'db/migrate/20190130090437_add_crop_to_photographings.rb'
+
+# Offense count: 10
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, no_space
+Layout/LineContinuationSpacing:
+  Exclude:
+    - 'app/mailers/notifier_mailer.rb'
+    - 'app/models/seed.rb'
+    - 'lib/tasks/growstuff.rake'
+    - 'spec/features/rss/plantings_spec.rb'
+    - 'spec/features/rss/posts_spec.rb'
+    - 'spec/features/rss/seeds_spec.rb'
+    - 'spec/models/seed_spec.rb'
+
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: aligned, indented
+Layout/LineEndStringConcatenationIndentation:
+  Exclude:
+    - 'app/mailers/notifier_mailer.rb'
+    - 'app/models/seed.rb'
+    - 'lib/tasks/growstuff.rake'
+    - 'spec/features/rss/plantings_spec.rb'
+    - 'spec/features/rss/posts_spec.rb'
+    - 'spec/features/rss/seeds_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 304
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'db/seeds.rb'
+    - 'spec/helpers/gardens_helper_spec.rb'
+    - 'spec/helpers/seeds_helper_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: RequireParenthesesForMethodChains.
+Lint/AmbiguousRange:
+  Exclude:
+    - 'app/models/concerns/search_harvests.rb'
+    - 'app/models/concerns/search_plantings.rb'
+
+# Offense count: 2
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+Lint/DuplicateBranch:
+  Exclude:
+    - 'app/models/harvest.rb'
+    - 'lib/actions/oauth_signup_action.rb'
+
+# Offense count: 8
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'db/migrate/20171022032108_all_the_predictions.rb'
+    - 'spec/controllers/home_controller_spec.rb'
+    - 'spec/controllers/likes_controller_spec.rb'
+    - 'spec/controllers/plant_parts_controller_spec.rb'
+    - 'spec/factories/crop_companions.rb'
+    - 'spec/features/crops/crop_detail_page_spec.rb'
+    - 'spec/requests/authentications_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/RedundantDirGlobSort:
+  Exclude:
+    - 'spec/rails_helper.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowNil.
+Lint/SuppressedException:
+  Exclude:
+    - 'lib/tasks/testing.rake'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, consistent
+Lint/SymbolConversion:
+  Exclude:
+    - 'app/controllers/likes_controller.rb'
+
+# Offense count: 7
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/UselessAssignment:
+  Exclude:
+    - 'config.rb'
+    - 'config/compass.rb'
+
+# Offense count: 45
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 151
+
+# Offense count: 10
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
+# AllowedMethods: refine
+Metrics/BlockLength:
+  Max: 61
+
+# Offense count: 6
+# Configuration parameters: CountComments, CountAsOne.
+Metrics/ClassLength:
+  Max: 171
+
+# Offense count: 4
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/CyclomaticComplexity:
+  Max: 32
+
+# Offense count: 61
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+Metrics/MethodLength:
+  Max: 59
+
+# Offense count: 3
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/PerceivedComplexity:
+  Max: 32
+
+# Offense count: 3
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/controllers/harvests_controller_spec.rb'
+    - 'spec/controllers/photos_controller_spec.rb'
+
+# Offense count: 292
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Enabled: false
+
+# Offense count: 36
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/models/like_spec.rb'
+    - 'spec/models/member_spec.rb'
+    - 'spec/services/timeline_service_spec.rb'
+
+# Offense count: 13
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/EmptyExampleGroup:
+  Exclude:
+    - 'spec/controllers/authentications_controller_spec.rb'
+    - 'spec/controllers/forums_controller_spec.rb'
+    - 'spec/controllers/home_controller_spec.rb'
+    - 'spec/controllers/likes_controller_spec.rb'
+    - 'spec/controllers/plant_parts_controller_spec.rb'
+    - 'spec/controllers/seeds_controller_spec.rb'
+    - 'spec/features/crops/crop_detail_page_spec.rb'
+    - 'spec/features/plantings/planting_a_crop_spec.rb'
+    - 'spec/requests/authentications_spec.rb'
+    - 'spec/views/home/index_spec.rb'
+    - 'spec/views/photos/edit.html.haml_spec.rb'
+    - 'spec/views/posts/_single.html.haml_spec.rb'
+
+# Offense count: 134
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 25
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/ExcessiveDocstringSpacing:
+  Exclude:
+    - 'spec/controllers/crops_controller_spec.rb'
+    - 'spec/features/crops/crop_photos_spec.rb'
+
+# Offense count: 30
+RSpec/ExpectInHook:
+  Exclude:
+    - 'spec/controllers/garden_types_controller_spec.rb'
+    - 'spec/controllers/gardens_controller_spec.rb'
+    - 'spec/features/admin/forums_spec.rb'
+    - 'spec/features/crops/crop_photos_spec.rb'
+    - 'spec/features/members/list_spec.rb'
+    - 'spec/features/plantings/planting_a_crop_spec.rb'
+    - 'spec/features/shared_examples/append_date.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, each, example
+RSpec/HookArgument:
+  Exclude:
+    - 'spec/requests/api/v1/plantings_request_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/HooksBeforeExamples:
+  Exclude:
+    - 'spec/features/crops/creating_a_crop_spec.rb'
+
+# Offense count: 35
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/controllers/harvests_controller_spec.rb'
+    - 'spec/controllers/plantings_controller_spec.rb'
+    - 'spec/features/crops/crop_photos_spec.rb'
+    - 'spec/features/members/list_spec.rb'
+    - 'spec/features/percy/percy_spec.rb'
+    - 'spec/features/planting_reminder_spec.rb'
+    - 'spec/features/timeline/index_spec.rb'
+    - 'spec/models/crop_spec.rb'
+    - 'spec/models/member_spec.rb'
+    - 'spec/views/forums/index.html.haml_spec.rb'
+
+# Offense count: 710
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Enabled: false
+
+# Offense count: 40
+RSpec/LetSetup:
+  Enabled: false
+
+# Offense count: 2
+RSpec/MessageChain:
+  Exclude:
+    - 'spec/models/member_spec.rb'
+
+# Offense count: 23
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 1
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/features/crops/crop_wranglers_spec.rb'
+
+# Offense count: 147
+RSpec/MultipleExpectations:
+  Max: 19
+
+# Offense count: 137
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 14
+
+# Offense count: 132
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
+RSpec/NamedSubject:
+  Enabled: false
+
+# Offense count: 111
+# Configuration parameters: AllowedGroups.
+RSpec/NestedGroups:
+  Max: 6
+
+# Offense count: 407
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Enabled: false
+
+# Offense count: 3
+RSpec/PendingWithoutReason:
+  Exclude:
+    - 'spec/features/seeds/misc_seeds_spec.rb'
+    - 'spec/features/unsubscribing_spec.rb'
+
+# Offense count: 7
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/Rails/HaveHttpStatus:
+  Exclude:
+    - 'spec/controllers/api/v1/plantings_controller_spec.rb'
+    - 'spec/controllers/harvests_controller_spec.rb'
+    - 'spec/controllers/likes_controller_spec.rb'
+    - 'spec/requests/harvests_spec.rb'
+
+# Offense count: 16
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Inferences.
+RSpec/Rails/InferredSpecType:
+  Enabled: false
+
+# Offense count: 2
+RSpec/RepeatedDescription:
+  Exclude:
+    - 'spec/models/like_spec.rb'
+
+# Offense count: 6
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/controllers/photos_controller_spec.rb'
+    - 'spec/features/members/following_spec.rb'
+    - 'spec/models/like_spec.rb'
+
+# Offense count: 4
+RSpec/RepeatedExampleGroupBody:
   Exclude:
     - 'spec/controllers/crops_controller_spec.rb'
 
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: lowercase, uppercase
-Naming/HeredocDelimiterCase:
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/ScatteredSetup:
   Exclude:
-    - 'config/environments/production.rb'
+    - 'spec/features/percy/percy_spec.rb'
+    - 'spec/features/plantings/prediction_spec.rb'
 
+# Offense count: 1
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
+# Include: **/*_spec.rb
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - 'spec/controllers/member_controller_spec.rb'
+
+# Offense count: 2
 # Configuration parameters: Include.
-# Include: db/migrate/*.rb
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/SpecFilePathSuffix:
+  Exclude:
+    - 'spec/features/seeds/seed_photos.rb'
+    - 'spec/models/garden_type.rb'
+
+# Offense count: 3
+RSpec/StubbedMock:
+  Exclude:
+    - 'spec/controllers/garden_types_controller_spec.rb'
+    - 'spec/controllers/gardens_controller_spec.rb'
+    - 'spec/models/member_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: constant, string
+RSpec/VerifiedDoubleReference:
+  Exclude:
+    - 'spec/models/member_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/controllers/garden_types_controller_spec.rb'
+    - 'spec/controllers/gardens_controller_spec.rb'
+    - 'spec/views/devise/shared/_links_spec.rb'
+
+# Offense count: 26
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql, postgresql
+# Include: db/**/*.rb
+Rails/BulkChangeTable:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: Include.
+# Include: db/**/*.rb
 Rails/CreateTableWithTimestamps:
   Exclude:
-    - 'db/migrate/20130214034838_add_members_roles_table.rb'
-    - 'db/migrate/20130507113915_add_orders_products_table.rb'
-    - 'db/migrate/20130531110729_add_photos_plantings_table.rb'
-    - 'db/migrate/20140905001730_add_harvests_photos_table.rb'
-    - 'db/migrate/20140928044231_add_crops_posts_table.rb'
-    - 'db/migrate/20150127043022_add_gardens_photos_table.rb'
     - 'db/migrate/20150201052245_create_cms.rb'
-    - 'db/migrate/20161201154922_add_photos_seeds_table.rb'
     - 'db/migrate/20171022032108_all_the_predictions.rb'
 
-# Configuration parameters: EnforcedStyle.
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowToTime.
 # SupportedStyles: strict, flexible
 Rails/Date:
   Exclude:
-    - 'app/mailers/notifier.rb'
+    - 'app/mailers/notifier_mailer.rb'
 
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: slashes, arguments
 Rails/FilePath:
@@ -45,6 +447,19 @@ Rails/FilePath:
     - 'config/environments/development.rb'
     - 'db/seeds.rb'
 
+# Offense count: 11
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+# AllowedMethods: order, limit, select, lock
+Rails/FindEach:
+  Exclude:
+    - 'app/controllers/conversations_controller.rb'
+    - 'db/migrate/20171105011017_set_prediction_data.rb'
+    - 'db/migrate/20171129041341_create_photographings.rb'
+    - 'db/migrate/20190130090437_add_crop_to_photographings.rb'
+    - 'db/migrate/20191119030244_cms_tags.rb'
+
+# Offense count: 2
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/HasAndBelongsToMany:
@@ -52,23 +467,39 @@ Rails/HasAndBelongsToMany:
     - 'app/models/member.rb'
     - 'app/models/role.rb'
 
+# Offense count: 5
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/HasManyOrHasOneDependent:
   Exclude:
     - 'app/models/member.rb'
 
+# Offense count: 1
 # Configuration parameters: Include.
-# Include: app/models/**/*.rb
-Rails/InverseOf:
+# Include: spec/**/*.rb, test/**/*.rb
+Rails/I18nLocaleAssignment:
   Exclude:
-    - 'app/models/concerns/ownable.rb'
+    - 'spec/features/locale_spec.rb'
 
+# Offense count: 33
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/controllers/**/*.rb, app/mailers/**/*.rb
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/data_controller.rb'
+
+# Offense count: 2
 Rails/OutputSafety:
   Exclude:
     - 'app/helpers/auto_suggest_helper.rb'
     - 'app/helpers/gardens_helper.rb'
 
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
 # Include: **/Rakefile, **/*.rake
 Rails/RakeEnvironment:
@@ -77,27 +508,104 @@ Rails/RakeEnvironment:
     - 'lib/tasks/i18n.rake'
     - 'lib/tasks/testing.rake'
 
+# Offense count: 10
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/RedundantActiveRecordAllMethod:
+  Exclude:
+    - 'app/controllers/admin/roles_controller.rb'
+    - 'app/controllers/alternate_names_controller.rb'
+    - 'app/controllers/forums_controller.rb'
+    - 'app/controllers/plant_parts_controller.rb'
+    - 'app/controllers/scientific_names_controller.rb'
+    - 'app/services/openfarm_service.rb'
+    - 'spec/features/members/deletion_spec.rb'
+    - 'spec/features/percy/percy_spec.rb'
+    - 'spec/models/harvest_spec.rb'
+
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Exclude:
+    - 'app/models/alternate_name.rb'
+    - 'app/models/like.rb'
+    - 'app/models/planting.rb'
+    - 'app/models/scientific_name.rb'
+
+# Offense count: 15
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
-# Include: db/migrate/*.rb
+# Include: spec/controllers/**/*.rb, spec/requests/**/*.rb, test/controllers/**/*.rb, test/integration/**/*.rb
+Rails/ResponseParsedBody:
+  Exclude:
+    - 'spec/controllers/api/v1/plantings_controller_spec.rb'
+    - 'spec/controllers/likes_controller_spec.rb'
+    - 'spec/requests/api/v1/crop_request_spec.rb'
+    - 'spec/requests/api/v1/gardens_request_spec.rb'
+    - 'spec/requests/api/v1/harvest_request_spec.rb'
+    - 'spec/requests/api/v1/member_request_spec.rb'
+    - 'spec/requests/api/v1/photos_request_spec.rb'
+    - 'spec/requests/api/v1/plantings_request_spec.rb'
+    - 'spec/requests/api/v1/seeds_request_spec.rb'
+
+# Offense count: 9
+# Configuration parameters: Include.
+# Include: db/**/*.rb
 Rails/ReversibleMigration:
   Exclude:
+    - 'db/migrate/20130326092227_change_planted_at_to_date.rb'
     - 'db/migrate/20191119020643_upgrade_cms.rb'
 
-# Configuration parameters: Blacklist, Whitelist.
-# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
-Rails/SkipsModelValidations:
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/RootPathnameMethods:
   Exclude:
-    - 'db/migrate/20190317023129_finished_boolean.rb'
-    - 'db/seeds.rb'
-    - 'db/migrate/20190910022329_add_photo_source.rb'
+    - 'app/controllers/crops_controller.rb'
+    - 'app/helpers/icons_helper.rb'
 
-# Configuration parameters: AllowedChars.
-Style/AsciiComments:
+# Offense count: 20
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ThreeStateBooleanColumn:
   Exclude:
-    - 'config/initializers/comfortable_mexican_sofa.rb'
+    - 'db/migrate/20121203034745_add_tos_agreement_to_users.rb'
+    - 'db/migrate/20130206051328_add_show_email_to_member.rb'
+    - 'db/migrate/20130212123628_create_notifications.rb'
+    - 'db/migrate/20130327120024_add_send_email_to_member.rb'
+    - 'db/migrate/20130517051922_create_account_types.rb'
+    - 'db/migrate/20130718011247_add_trading_to_seeds.rb'
+    - 'db/migrate/20130722050836_remove_tradable_from_seeds.rb'
+    - 'db/migrate/20130827105823_add_newsletter_to_member.rb'
+    - 'db/migrate/20131025104228_add_fields_to_gardens.rb'
+    - 'db/migrate/20140829230600_add_finished_to_planting.rb'
+    - 'db/migrate/20140928085713_add_send_planting_reminder_to_member.rb'
+    - 'db/migrate/20171022032108_all_the_predictions.rb'
+    - 'db/migrate/20180213005731_seed_usage.rb'
+    - 'db/migrate/20190720000555_create_mailboxer.mailboxer_engine.rb'
+    - 'db/migrate/20190720000558_add_delivery_tracking_info_to_mailboxer_receipts.mailboxer_engine.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Offense count: 6
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/UniqueValidationWithoutIndex:
+  Exclude:
+    - 'app/models/follow.rb'
+    - 'app/models/garden.rb'
+    - 'app/models/like.rb'
+    - 'app/models/member.rb'
+    - 'app/models/plant_part.rb'
+    - 'app/models/role.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/WhereEquals:
+  Exclude:
+    - 'app/models/crop.rb'
+    - 'app/models/harvest.rb'
+    - 'app/models/planting.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
@@ -105,23 +613,168 @@ Style/ClassAndModuleChildren:
     - 'lib/haml/filters/escaped_markdown.rb'
     - 'lib/haml/filters/growstuff_markdown.rb'
 
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Style/CommentedKeyword:
   Exclude:
+    - 'db/migrate/20191119030244_cms_tags.rb'
     - 'spec/models/crop_spec.rb'
     - 'spec/models/photo_spec.rb'
     - 'spec/models/planting_spec.rb'
 
-Style/MixinUsage:
+# Offense count: 37
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowedVars.
+Style/FetchEnvVar:
+  Enabled: false
+
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'config/initializers/new_framework_defaults_6_0.rb'
+    - 'db/migrate/20200801084007_add_foreign_key_constraint_to_active_storage_attachments_for_blob_id.active_storage.rb'
+    - 'db/migrate/20200815012538_remove_median_function.rb'
+    - 'spec/lib/haml/filters/growstuff_markdown_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/GlobalStdStream:
+  Exclude:
+    - 'config/environments/production.rb'
+    - 'lib/tasks/openfarm.rake'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+# SupportedShorthandSyntax: always, never, either, consistent
+Style/HashSyntax:
+  Exclude:
+    - 'app/models/csv_importer.rb'
+    - 'spec/requests/api/v1/gardens_request_spec.rb'
+    - 'spec/requests/api/v1/plantings_request_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/IfUnlessModifier:
   Exclude:
     - 'bin/setup'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: nonzero?
+Style/IfWithBooleanLiteralBranches:
+  Exclude:
+    - 'app/controllers/gardens_controller.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/MinMaxComparison:
+  Exclude:
+    - 'app/models/concerns/predict_planting.rb'
+
+# Offense count: 2
+Style/MixinUsage:
+  Exclude:
     - 'bin/update'
     - 'spec/rails_helper.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/NegatedIfElseCondition:
+  Exclude:
+    - 'app/helpers/crops_helper.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
-    - 'spec/**/*'
     - 'app/helpers/harvests_helper.rb'
     - 'app/helpers/plantings_helper.rb'
+
+# Offense count: 6
+Style/OpenStructUse:
+  Exclude:
+    - 'spec/helpers/event_helper_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'app/models/concerns/member_newsletter.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: same_as_string_literals, single_quotes, double_quotes
+Style/QuotedSymbols:
+  Exclude:
+    - 'app/models/seed.rb'
+    - 'spec/controllers/crops_controller_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Methods.
+Style/RedundantArgument:
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantConstantBase:
+  Exclude:
+    - 'config.ru'
+
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SafeForConstants.
+Style/RedundantFetchBlock:
+  Exclude:
+    - 'config/puma.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantRegexpArgument:
+  Exclude:
+    - 'db/migrate/20191119030244_cms_tags.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'app/controllers/messages_controller.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowModifier.
+Style/SoleNestedConditional:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/messages_controller.rb'
+
+# Offense count: 20
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'app/controllers/messages_controller.rb'
+    - 'app/helpers/buttons_helper.rb'
+    - 'config/initializers/rswag_api.rb'
+    - 'spec/helpers/gardens_helper_spec.rb'
+    - 'spec/helpers/seeds_helper_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
+# AllowedMethods: define_method, mail, respond_to
+Style/SymbolProc:
+  Exclude:
+    - 'app/controllers/crops_controller.rb'

.ruby-version

@@ -1 +1 @@
-2.7.2
+3.1.4

CODE_OF_CONDUCT.md

@@ -0,0 +1,129 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our
+community a harassment-free experience for everyone, regardless of age, body
+size, visible or invisible disability, ethnicity, sex characteristics, gender
+identity and expression, level of experience, education, socio-economic status,
+nationality, personal appearance, race, religion, or sexual identity
+and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming,
+diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our
+community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes,
+  and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the
+  overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or
+  advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email
+  address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of
+acceptable behavior and will take appropriate and fair corrective action in
+response to any behavior that they deem inappropriate, threatening, offensive,
+or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct, and will communicate reasons for moderation
+decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when
+an individual is officially representing the community in public spaces.
+Examples of representing our community include using an official e-mail address,
+posting via an official social media account, or acting as an appointed
+representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported to the community leaders responsible for enforcement at
+info@growstuff.org. Any issues with a particular moderator can be reported to
+any one of the other moderators.
+All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the
+reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining
+the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed
+unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing
+clarity around the nature of the violation and an explanation of why the
+behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series
+of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No
+interaction with the people involved, including unsolicited interaction with
+those enforcing the Code of Conduct, for a specified period of time. This
+includes avoiding interactions in community spaces as well as external channels
+like social media. Violating these terms may lead to a temporary or
+permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including
+sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public
+communication with the community for a specified period of time. No public or
+private interaction with the people involved, including unsolicited interaction
+with those enforcing the Code of Conduct, is allowed during this period.
+Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community
+standards, including sustained inappropriate behavior,  harassment of an
+individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within
+the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 2.0, available at
+https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct
+enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at
+https://www.contributor-covenant.org/translations.

CONTRIBUTORS.md

@@ -92,7 +92,7 @@ submit the change with your pull request.
 - André Aubin / [lambda2](https://github.com/lambda2)
 - Martina Simicic / [simicic](https://github.com/simicic)
 - Rowan Crawford / [wombleton](https://github.com/wombleton)
-- Le-jun - [lejun](https://github.com/le-jun)
+- Ítalo Pires / [italopires](https://github.com/italopires)
 
 ## Bots
 

Gemfile

@@ -5,17 +5,17 @@ source 'https://rubygems.org'
 # Match ruby version in .ruby-version
 ruby File.read('.ruby-version')
 
-gem 'rails', '6.0.3.2'
+gem 'rails', '~> 7.0.7'
 
 # Keeping old sprockets
 # https://github.com/rails/sprockets-rails/issues/444#issuecomment-637817050
 gem "sprockets", "<4"
 
-gem 'bundler', '>=1.1.5'
+gem 'bundler', '>= 2.3.10'
 
 gem 'coffee-rails'
 gem 'haml'
-gem 'sass-rails'
+gem 'sassc-rails'
 
 # API data
 gem 'jsonapi-resources'
@@ -24,7 +24,7 @@ gem 'rswag-api'
 gem 'rswag-ui'
 
 # CSS framework
-gem "bootstrap", ">= 4.3.1"
+gem "bootstrap", ">= 4.6.2"
 gem 'material-sass', '4.1.1'
 
 # Icons used by bootstrap/material-sass
@@ -45,21 +45,20 @@ gem 'active_record_union'
 gem 'flickraw'
 gem 'jquery-rails'
 gem 'jquery-ui-rails'
-gem 'js-routes' # provides access to Rails routes in Javascript
 
 gem 'cancancan'                    # for checking member privileges
 gem 'csv_shaper'                   # CSV export
 gem 'gibbon', '~>1.2.0'            # for Mailchimp newsletter subscriptions
 
 # Maps
-gem 'leaflet-rails'
+gem 'leaflet-rails', '>= 1.9.2'
 gem 'rails-assets-leaflet.markercluster', source: 'https://rails-assets.org'
 
-gem 'pg', '< 1.0.0'                # Upstream bug, see https://github.com/Growstuff/growstuff/pull/1539
+gem 'pg'
 gem 'ruby-units'                   # for unit conversion
 gem 'unicorn'                      # http server
 
-gem "comfortable_mexican_sofa", "~> 2.0.0"
+gem "comfortable_mexican_sofa", git: "https://github.com/restarone/comfortable-mexican-sofa.git"
 
 gem 'active_utils'
 gem 'sidekiq'
@@ -69,7 +68,7 @@ gem 'bluecloth'
 
 # Pagination
 gem 'will_paginate'
-gem 'will_paginate-bootstrap4'
+gem 'will_paginate-bootstrap-style'
 
 # user signup/login/etc
 gem 'devise'
@@ -90,11 +89,10 @@ gem 'geocoder'
 gem 'bootstrap-datepicker-rails'
 
 # DRY-er easier bootstrap 4 forms
-gem "bootstrap_form", ">= 4.2.0"
+gem "bootstrap_form", ">= 4.5.0"
 
 # For connecting to other services (eg Twitter)
 gem 'omniauth', '~> 1.3'
-gem 'omniauth-facebook'
 gem 'omniauth-flickr', '>= 0.0.15'
 gem 'omniauth-twitter'
 
@@ -119,11 +117,11 @@ gem 'xmlrpc' # fixes rake error - can be removed if not needed later
 
 gem 'puma'
 
-gem 'loofah', '>= 2.2.1'
+gem 'loofah', '>= 2.19.1'
 gem 'rack-protection', '>= 2.0.1'
 
 # Member to member messaging system
-gem 'mailboxer'
+gem 'mailboxer', '>= 0.15.1'
 
 gem 'faraday'
 gem 'faraday_middleware'
@@ -175,7 +173,6 @@ end
 
 group :test do
   gem 'codeclimate-test-reporter', require: false
-  gem 'percy-capybara'
   gem 'rails-controller-testing'
   gem 'selenium-webdriver'
   gem 'timecop'
@@ -185,3 +182,5 @@ end
 group :travis do
   gem 'platform-api'
 end
+
+gem "percy-capybara", "~> 5.0.0"

README.md

@@ -20,7 +20,7 @@ encourage participation from people of all backgrounds and skill levels.
 * [Issues](https://github.com/orgs/Growstuff/projects/1) (features we're
   working on, known bugs, etc)
 * [![Gitter](https://badges.gitter.im/Growstuff/growstuff.svg)](https://gitter.im/Growstuff/growstuff?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
-* [Wiki](https://github.com/Growstuff/growstuff/wiki) (general documentation, etc. Help by migrating from the [old wiki](https://web.archive.org/web/*/wiki.growstuff.org))
+* [Wiki](https://github.com/Growstuff/growstuff/wiki) (general documentation, etc.)
 
 ## For coders
 
@@ -29,7 +29,6 @@ frontend features. We welcome contributions -- see
 [CONTRIBUTING](CONTRIBUTING.md) for details.
 
 * To set up your development environment, see [Getting started](https://github.com/Growstuff/growstuff/wiki/New-contributor-guide).
-* We encourage [pair programming](http://wiki.growstuff.org/index.php/Pairing), especially for newer developers.
 * You may also be interested in our [API](https://github.com/Growstuff/growstuff/wiki/API).
 
 ## For designers, writers, researchers, data wranglers, and other contributors

app/assets/javascripts/application.js

@@ -12,7 +12,6 @@
 //
 // = require leaflet
 // = require leaflet.markercluster
-// = require js-routes
 // = require popper
 // = require jquery
 // = require jquery_ujs

app/assets/javascripts/cropmap.js.erb

@@ -1,10 +1,6 @@
 function showCropMap(cropmap) {
-  var mapbox_map_id = "<%= Rails.env == 'test' ? 0 : Rails.application.config.mapbox_map_id %>";
-  var mapbox_access_token = "<%= Rails.env == 'test' ? 0 : Rails.application.config.mapbox_access_token %>";
-  var mapbox_base_url = "https://a.tiles.mapbox.com/v4/" + mapbox_map_id + "/{z}/{x}/{y}.png?access_token=" + mapbox_access_token;
-
-  L.tileLayer(mapbox_base_url, {
-    attribution: 'Map data &copy; <a href="https://openstreetmap.org">OpenStreetMap</a> contributors under <a href="https://www.openstreetmap.org/copyright">ODbL</a> | Map imagery &copy; <a href="https://mapbox.com">Mapbox</a>',
+  L.tileLayer('https://tile.openstreetmap.org/{z}/{x}/{y}.png', {
+    attribution: '&copy; <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a> contributors',
     maxZoom: 18
   }).addTo(cropmap);
   var markers = new L.MarkerClusterGroup({showCoverageOnHover: false, maxClusterRadius: 20 });

app/assets/javascripts/members.js.erb

@@ -1,10 +1,4 @@
 if (document.getElementById("membermap") !== null) {
-  var mapbox_map_id = "<%= Rails.env == 'test' ? 0 : Rails.application.config.mapbox_map_id %>";
-  var mapbox_access_token = "<%= Rails.env == 'test' ? 0 : Rails.application.config.mapbox_access_token %>";
-  var mapbox_base_url = "https://a.tiles.mapbox.com/v4/" + mapbox_map_id + "/{z}/{x}/{y}.png?access_token=" + mapbox_access_token;
-
-  L.Icon.Default.imagePath = '/assets'
-
   L.Icon.Default.imagePath = '/assets';
 
   var default_marker_icon = L.icon({
@@ -18,8 +12,8 @@ if (document.getElementById("membermap") !== null) {
     if (member.latitude && member.longitude) {
       var membermap = L.map('membermap').setView([member.latitude, member.longitude], 4);
 
-      L.tileLayer(mapbox_base_url, {
-        attribution: 'Map data &copy; <a href="https://openstreetmap.org">OpenStreetMap</a> contributors under <a href="https://www.openstreetmap.org/copyright">ODbL</a> | Map imagery &copy; <a href="https://mapbox.com">Mapbox</a>',
+      L.tileLayer('https://tile.openstreetmap.org/{z}/{x}/{y}.png', {
+        attribution: '&copy; <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a> contributors',
         maxZoom: 18
       }).addTo(membermap);
       var marker = new L.Marker(new L.LatLng(member.latitude, member.longitude),

app/assets/javascripts/places.js.erb

@@ -1,8 +1,5 @@
 if (document.getElementById("placesmap") !== null) {
   var places_base_path = "/places";
-  var mapbox_map_id = "<%= Rails.env == 'test' ? 0 : Rails.application.config.mapbox_map_id %>";
-  var mapbox_access_token = "<%= Rails.env == 'test' ? 0 : Rails.application.config.mapbox_access_token %>";
-  var mapbox_base_url = "https://a.tiles.mapbox.com/v4/" + mapbox_map_id + "/{z}/{x}/{y}.png?access_token=" + mapbox_access_token;
   var nominatim_base_url = 'https://nominatim.openstreetmap.org/search/';
   var nominatim_user_agent_email = "<%= Rails.env == 'test' ? 0 : Rails.application.config.user_agent_email %>";
 
@@ -31,8 +28,8 @@ if (document.getElementById("placesmap") !== null) {
 }
 
 function showMap(placesmap) {
-  L.tileLayer(mapbox_base_url, {
-    attribution: 'Map data &copy; <a href="https://openstreetmap.org">OpenStreetMap</a> contributors under <a href="https://www.openstreetmap.org/copyright">ODbL</a> | Map imagery &copy; <a href="https://mapbox.com">Mapbox</a>',
+  L.tileLayer('https://tile.openstreetmap.org/{z}/{x}/{y}.png', {
+    attribution: '&copy; <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a> contributors',
     maxZoom: 18
   }).addTo(placesmap);
 
@@ -61,6 +58,7 @@ function showMap(placesmap) {
   });
 
   function fetchCropsForMap(url) {
+    var n = 0;
     $.getJSON(url, function(crop_data) {
       $.each(crop_data['data'], function(i, p) {
         if (p.attributes.latitude && p.attributes.longitude) {
@@ -81,7 +79,8 @@ function showMap(placesmap) {
           markers.addLayer(marker);
         }
       });
-      if (crop_data['links']['next']) {
+      // We fetch pages of 10 at a time. Stop after 200 crops; so we are showing only 'active' plantings.
+      if (crop_data['links']['next'] && n++ < 20) {
         fetchCropsForMap(crop_data['links']['next'])
       }
       return crop_data;

app/controllers/admin/members_controller.rb

@@ -13,12 +13,6 @@ module Admin
       @members = @members.order(:login_name).paginate(page: params[:page])
     end
 
-    def destroy
-      @member = Member.find_by!(slug: params[:slug])
-      @member.discard
-      redirect_to admin_members_path
-    end
-
     def edit
       @member = Member.find_by!(slug: params[:slug])
     end
@@ -30,6 +24,12 @@ module Admin
       respond_with @member, location: admin_members_path
     end
 
+    def destroy
+      @member = Member.find_by!(slug: params[:slug])
+      @member.discard
+      redirect_to admin_members_path
+    end
+
     private
 
     def search_term

app/controllers/authentications_controller.rb

@@ -14,14 +14,14 @@ class AuthenticationsController < ApplicationController
 
       @authentication = current_member.authentications
         .create_with(
-          name:   name,
+          name:,
           token:  auth['credentials']['token'],
           secret: auth['credentials']['secret']
         )
         .find_or_create_by(
           provider: auth['provider'],
           uid:      auth['uid'],
-          name:     name
+          name:
         )
 
       flash[:notice] = "Authentication successful."

app/controllers/conversations_controller.rb

@@ -71,7 +71,7 @@ class ConversationsController < ApplicationController
     @conversation = Mailboxer::Conversation.find_by(id: params[:id])
     return unless @conversation.nil? || !@conversation.is_participant?(current_member)
 
-    redirect_to conversations_path(box: box)
+    redirect_to conversations_path(box:)
     nil
   end
 end

app/controllers/crops_controller.rb

@@ -57,7 +57,7 @@ class CropsController < ApplicationController
     @crops = CropSearchService.search(@term,
                                       page:           params[:page],
                                       per_page:       Crop.per_page,
-                                      current_member: current_member)
+                                      current_member:)
     respond_with @crops
   end
 
@@ -191,7 +191,7 @@ class CropsController < ApplicationController
   end
 
   def filename
-    "Growstuff-Crops-#{Time.zone.now.to_s(:number)}.csv"
+    "Growstuff-Crops-#{Time.zone.now.to_fs(:number)}.csv"
   end
 
   def crop_json_fields

app/controllers/follows_controller.rb

@@ -5,6 +5,10 @@ class FollowsController < ApplicationController
   load_and_authorize_resource
   skip_load_resource only: :create
 
+  def index
+    @follows = @member.followed.paginate(page: params[:page])
+  end
+
   def create
     @follow = current_member.follows.build(followed: Member.find(params[:followed]))
 
@@ -25,10 +29,6 @@ class FollowsController < ApplicationController
     redirect_to @unfollowed
   end
 
-  def index
-    @follows = @member.followed.paginate(page: params[:page])
-  end
-
   def followers
     @followers = @member.followers.paginate(page: params[:page])
   end

app/controllers/harvests_controller.rb

@@ -20,7 +20,7 @@ class HarvestsController < DataController
       where['planting_id'] = @planting.id
     end
 
-    @harvests = Harvest.search('*', where:    where,
+    @harvests = Harvest.search('*', where:,
                                     limit:    100,
                                     page:     params[:page],
                                     load:     false,
@@ -92,7 +92,7 @@ class HarvestsController < DataController
                 elsif @crop
                   "#{@crop.to_param}-"
                 end
-    "Growstuff-#{specifics}Harvests-#{Time.zone.now.to_s(:number)}.csv"
+    "Growstuff-#{specifics}Harvests-#{Time.zone.now.to_fs(:number)}.csv"
   end
 
   def update_crop_medians

app/controllers/likes_controller.rb

@@ -39,7 +39,7 @@ class LikesController < ApplicationController
     {
       id:              like.likeable.id,
       like_count:      like.likeable.likes.count,
-      liked_by_member: liked_by_member,
+      liked_by_member:,
       description:     ActionController::Base.helpers.pluralize(like.likeable.likes.count, "like")
     }
   end
@@ -50,7 +50,7 @@ class LikesController < ApplicationController
       format.json do
         render(json: render_json(
           like,
-          liked_by_member: liked_by_member
+          liked_by_member:
         ), status: status_code)
       end
     end

app/controllers/members_controller.rb

@@ -18,7 +18,6 @@ class MembersController < ApplicationController
     @member        = Member.confirmed.kept.find_by!(slug: params[:slug])
     @twitter_auth  = @member.auth('twitter')
     @flickr_auth   = @member.auth('flickr')
-    @facebook_auth = @member.auth('facebook')
     @posts         = @member.posts
 
     @activity = TimelineService.member_query(@member).limit(30)

app/controllers/omniauth_callbacks_controller.rb

@@ -9,10 +9,6 @@ require './lib/actions/oauth_signup_action'
 # Heavily overlaps with Authentications controller
 #
 class OmniauthCallbacksController < Devise::OmniauthCallbacksController
-  def facebook
-    create
-  end
-
   def failure
     flash[:alert] = "Authentication failed."
     redirect_to request.env['omniauth.origin'] || "/"
@@ -32,7 +28,7 @@ class OmniauthCallbacksController < Devise::OmniauthCallbacksController
     @authentication = action.establish_authentication(auth, member)
 
     if action.member_created?
-      raise "Invalid provider" unless %w(facebook twitter flickr).index(auth['provider'].to_s)
+      raise "Invalid provider" unless %w(twitter flickr).index(auth['provider'].to_s)
 
       session["devise.#{auth['provider']}_data"] = request.env["omniauth.auth"]
       sign_in member

app/controllers/photos_controller.rb

@@ -8,11 +8,6 @@ class PhotosController < ApplicationController
   respond_to :html, :json
   responders :flash
 
-  def show
-    @crops = Crop.distinct.joins(:photo_associations).where(photo_associations: { photo: @photo })
-    respond_with(@photo)
-  end
-
   def index
     @photos = Photo.search(
       load:     false,
@@ -24,6 +19,11 @@ class PhotosController < ApplicationController
     respond_with(@photos)
   end
 
+  def show
+    @crops = Crop.distinct.joins(:photo_associations).where(photo_associations: { photo: @photo })
+    respond_with(@photo)
+  end
+
   def new
     @photo = Photo.new
     @item = item_to_link_to

app/controllers/plantings_controller.rb

@@ -12,7 +12,7 @@ class PlantingsController < DataController
 
     if params[:member_slug]
       @owner = Member.find_by(slug: params[:member_slug])
-      where['owner_id'] = @owner.id
+      where['owner_id'] = @owner.id unless @owner.nil?
     end
 
     if params[:crop_slug]
@@ -21,14 +21,14 @@ class PlantingsController < DataController
     end
 
     @plantings = Planting.search(
-      where:    where,
+      where:,
       page:     params[:page],
       limit:    30,
       boost_by: [:created_at],
       load:     false
     )
 
-    @filename = "Growstuff-#{specifics}Plantings-#{Time.zone.now.to_s(:number)}.csv"
+    @filename = "Growstuff-#{specifics}Plantings-#{Time.zone.now.to_fs(:number)}.csv"
 
     respond_with(@plantings)
   end

app/controllers/registrations_controller.rb

@@ -6,7 +6,6 @@ class RegistrationsController < Devise::RegistrationsController
   def edit
     @twitter_auth  = current_member.auth('twitter')
     @flickr_auth   = current_member.auth('flickr')
-    @facebook_auth = current_member.auth('facebook')
     render "edit"
   end
 

app/controllers/seeds_controller.rb

@@ -24,7 +24,7 @@ class SeedsController < DataController
 
     @filename = csv_filename
     @seeds = Seed.search(
-      where:    where,
+      where:,
       page:     params[:page],
       limit:    30,
       boost_by: [:created_at],
@@ -89,9 +89,9 @@ class SeedsController < DataController
 
   def csv_filename
     if @owner
-      "Growstuff-#{@owner.to_param}-Seeds-#{Time.zone.now.to_s(:number)}.csv"
+      "Growstuff-#{@owner.to_param}-Seeds-#{Time.zone.now.to_fs(:number)}.csv"
     else
-      "Growstuff-Seeds-#{Time.zone.now.to_s(:number)}.csv"
+      "Growstuff-Seeds-#{Time.zone.now.to_fs(:number)}.csv"
     end
   end
 end

app/helpers/application_helper.rb

@@ -24,7 +24,7 @@ module ApplicationHelper
   # Produces a cache key for uniquely identifying cached fragments.
   def cache_key_for(klass, identifier = "all")
     count          = klass.count
-    max_updated_at = klass.maximum(:updated_at).try(:utc).try(:to_s, :number)
+    max_updated_at = klass.maximum(:updated_at).try(:utc).try(:to_fs, :number)
     "#{klass.name.downcase.pluralize}/#{identifier}-#{count}-#{max_updated_at}"
   end
 
@@ -55,7 +55,7 @@ module ApplicationHelper
       return uri.to_s
     end
 
-    Gravatar.new(member.email).image_url(size:    size,
+    Gravatar.new(member.email).image_url(size:,
                                          default: :identicon,
                                          ssl:     true)
   end
@@ -70,11 +70,11 @@ module ApplicationHelper
     all = show_all ? '' : 1
 
     if owner.present?
-      public_send("member_#{type}_path", owner, all: all)
+      public_send("member_#{type}_path", owner, all:)
     elsif crop.present?
-      public_send("crop_#{type}_path", crop, all: all)
+      public_send("crop_#{type}_path", crop, all:)
     else
-      public_send("#{type}_path", all: all)
+      public_send("#{type}_path", all:)
     end
   end
 

app/helpers/buttons_helper.rb

@@ -44,19 +44,19 @@ module ButtonsHelper
   end
 
   def seed_edit_button(seed, classes: "btn btn-raised btn-info")
-    edit_button(edit_seed_path(seed), classes: classes)
+    edit_button(edit_seed_path(seed), classes:)
   end
 
   def harvest_edit_button(harvest, classes: "btn btn-raised btn-info")
-    edit_button(edit_harvest_path(harvest), classes: classes)
+    edit_button(edit_harvest_path(harvest), classes:)
   end
 
   def garden_edit_button(garden, classes: "btn btn-raised btn-info")
-    edit_button(edit_garden_path(garden), classes: classes)
+    edit_button(edit_garden_path(garden), classes:)
   end
 
   def planting_edit_button(planting, classes: "btn btn-raised btn-info")
-    edit_button(edit_planting_path(planting), classes: classes)
+    edit_button(edit_planting_path(planting), classes:)
   end
 
   def planting_finish_button(planting, classes: 'btn btn-default btn-secondary')

app/helpers/crops_helper.rb

@@ -2,7 +2,7 @@
 
 module CropsHelper
   def display_seed_availability(member, crop)
-    seeds = member.seeds.where(crop: crop)
+    seeds = member.seeds.where(crop:)
     total_quantity = seeds.where.not(quantity: nil).sum(:quantity)
 
     return "You don't have any seeds of this crop." if seeds.none?

app/helpers/editable_form_helper.rb

@@ -2,7 +2,7 @@
 
 module EditableFormHelper
   def editable(field_type, model, field, display_field:, collection: [])
-    render 'shared/editable/form', field_type: field_type,
-                                   model: model, field: field, display_field: display_field, collection: collection
+    render 'shared/editable/form', field_type:,
+                                   model:, field:, display_field:, collection:
   end
 end

app/helpers/posts_helper.rb

@@ -2,11 +2,11 @@
 
 module PostsHelper
   def display_post_truncated(post, length: 300)
-    truncate(strip_tags(post.body), length: length,
+    truncate(strip_tags(post.body), length:,
                                     separator: ' ', omission: '... ') { link_to "Read more", post_path(post) }
   end
 
   def post_stripped_tags(post, length: 300)
-    truncate(strip_tags(post.body), length: length)
+    truncate(strip_tags(post.body), length:)
   end
 end

app/models/ability.rb

@@ -70,7 +70,7 @@ class Ability
     can :create, Notification do |n|
       n.recipient_id != member.id
     end
-    # note we don't support update for notifications
+    # NOTE: we don't support update for notifications
 
     # only crop wranglers can create/edit/destroy crops
     if member.role? :crop_wrangler

app/models/comment.rb

@@ -15,7 +15,7 @@ class Comment < ApplicationRecord
         recipient_id: recipient,
         sender_id:    sender,
         subject:      "#{author} commented on #{post.subject}",
-        body:         body,
+        body:,
         post_id:      post.id
       )
     end

app/models/concerns/member_newsletter.rb

@@ -32,8 +32,8 @@ module MemberNewsletter
 
       gibbon.lists.subscribe(
         id:           Rails.application.config.newsletter_list_id,
-        email:        { email: email },
-        merge_vars:   { login_name: login_name },
+        email:        { email: },
+        merge_vars:   { login_name: },
         double_optin: false # they already confirmed their email with us
       )
     end
@@ -42,7 +42,7 @@ module MemberNewsletter
       return true if Rails.env.test? && !testing
 
       gibbon.lists.unsubscribe(id:    Rails.application.config.newsletter_list_id,
-                               email: { email: email })
+                               email: { email: })
     end
   end
 end

app/models/concerns/predict_harvest.rb

@@ -33,7 +33,7 @@ module PredictHarvest
         days_to_first_harvest = (first_harvest_date - planted_at).to_i
         days_to_last_harvest = (last_harvest_date - planted_at).to_i if finished?
       end
-      update(days_to_first_harvest: days_to_first_harvest, days_to_last_harvest: days_to_last_harvest)
+      update(days_to_first_harvest:, days_to_last_harvest:)
     end
 
     # status

app/models/concerns/search_crops.rb

@@ -29,19 +29,19 @@ module SearchCrops
 
     def search_data
       {
-        name:             name,
-        description:      description,
-        slug:             slug,
+        name:,
+        description:,
+        slug:,
         alternate_names:  alternate_names.pluck(:name),
         scientific_names: scientific_names.pluck(:name),
         photos_count:     photo_associations_count,
         # boost the crops that are planted the most
-        plantings_count:  plantings_count,
-        harvests_count:   harvests_count,
+        plantings_count:,
+        harvests_count:,
         # boost this crop for these members
         planters_ids:     plantings.pluck(:owner_id),
         has_photos:       photos.size.positive?,
-        thumbnail_url:    thumbnail_url,
+        thumbnail_url:,
         scientific_name:  default_scientific_name&.name,
         created_at:       created_at.to_i
       }

app/models/concerns/search_harvests.rb

@@ -17,22 +17,22 @@ module SearchHarvests
 
     def search_data
       {
-        slug:             slug,
-        quantity:         quantity,
+        slug:,
+        quantity:,
 
         # crop
-        crop_id:          crop_id,
-        crop_name:        crop_name,
+        crop_id:,
+        crop_name:,
         crop_slug:        crop.slug,
 
         # owner
-        owner_id:         owner_id,
-        owner_login_name: owner_login_name,
-        owner_slug:       owner_slug,
+        owner_id:,
+        owner_login_name:,
+        owner_slug:,
         plant_part_name:  plant_part&.name,
 
         # planting
-        planting_id:      planting_id,
+        planting_id:,
         planting_slug:    planting&.slug,
 
         # photo
@@ -43,7 +43,7 @@ module SearchHarvests
         photos_count:     photos.count,
 
         # timestamps
-        harvested_at:     harvested_at,
+        harvested_at:,
         created_at:       created_at.to_i
       }
     end
@@ -58,7 +58,7 @@ module SearchHarvests
         }
         one_record = search('*',
                             limit:    1,
-                            where:    where,
+                            where:,
                             boost_by: [:created_at],
                             load:     false).first
         return records if one_record.nil?

app/models/concerns/search_photos.rb

@@ -15,20 +15,20 @@ module SearchPhotos
 
     def search_data
       {
-        id:                     id,
-        title:                  title,
-        thumbnail_url:          thumbnail_url,
-        fullsize_url:           fullsize_url,
+        id:,
+        title:,
+        thumbnail_url:,
+        fullsize_url:,
         # crops
         crops:                  crops.pluck(:id),
         # likes
-        liked_by_members_names: liked_by_members_names,
+        liked_by_members_names:,
         # owner
-        owner_id:               owner_id,
-        owner_login_name:       owner_login_name,
-        owner_slug:             owner_slug,
+        owner_id:,
+        owner_login_name:,
+        owner_slug:,
         # counts
-        likes_count:            likes_count,
+        likes_count:,
 
         created_at:             created_at.to_i
       }

app/models/concerns/search_plantings.rb

@@ -18,39 +18,39 @@ module SearchPlantings
 
     def search_data
       {
-        slug:                       slug,
-        active:                     active,
+        slug:,
+        active:,
         finished:                   finished?,
         has_photos:                 photos.size.positive?,
-        location:                   location,
+        location:,
         percentage_grown:           percentage_grown.to_i,
-        planted_at:                 planted_at,
-        planted_from:               planted_from,
+        planted_at:,
+        planted_from:,
         planted_year:               planted_at&.year,
-        quantity:                   quantity,
-        sunniness:                  sunniness,
-        garden_id:                  garden_id,
+        quantity:,
+        sunniness:,
+        garden_id:,
 
-        first_harvest_predicted_at: first_harvest_predicted_at,
-        finish_predicted_at:        finish_predicted_at,
+        first_harvest_predicted_at:,
+        finish_predicted_at:,
 
         # crops
-        crop_id:                    crop_id,
-        crop_name:                  crop_name,
-        crop_slug:                  crop_slug,
-        crop_perennial:             crop_perennial,
+        crop_id:,
+        crop_name:,
+        crop_slug:,
+        crop_perennial:,
 
         # owner
-        owner_id:                   owner_id,
-        owner_location:             owner_location,
-        owner_login_name:           owner_login_name,
-        owner_slug:                 owner_slug,
+        owner_id:,
+        owner_location:,
+        owner_login_name:,
+        owner_slug:,
 
         # photos
         thumbnail_url:              default_photo&.thumbnail_url || crop.default_photo&.thumbnail_url,
         # counts
         photos_count:               photos.size,
-        harvests_count:             harvests_count,
+        harvests_count:,
 
         # timestamps
         created_at:                 created_at.to_i
@@ -67,7 +67,7 @@ module SearchPlantings
         }
         one_record = search('*',
                             limit:    1,
-                            where:    where,
+                            where:,
                             boost_by: [:created_at],
                             load:     false).first
         return records if one_record.nil?

app/models/concerns/search_seeds.rb

@@ -18,31 +18,31 @@ module SearchSeeds
 
     def search_data
       {
-        slug:             slug,
+        slug:,
         finished:         finished?,
-        gmo:              gmo,
-        active:           active,
-        heirloom:         heirloom,
+        gmo:,
+        active:,
+        heirloom:,
         location:         owner.location,
-        organic:          organic,
-        quantity:         quantity,
-        plant_before:     plant_before&.to_s(:ymd),
-        tradable_to:      tradable_to,
-        tradable:         tradable,
+        organic:,
+        quantity:,
+        plant_before:     plant_before&.to_fs(:ymd),
+        tradable_to:,
+        tradable:,
 
         # crop
-        crop_id:          crop_id,
+        crop_id:,
         crop_name:        crop.name,
         crop_slug:        crop.slug,
 
         # owner
-        owner_id:         owner_id,
-        owner_location:   owner_location,
-        owner_login_name: owner_login_name,
-        owner_slug:       owner_slug,
+        owner_id:,
+        owner_location:,
+        owner_login_name:,
+        owner_slug:,
 
         # planting
-        parent_planting:  parent_planting,
+        parent_planting:,
 
         # counts
         photos_count:     photos.size,
@@ -56,7 +56,7 @@ module SearchSeeds
     end
 
     def self.homepage_records(limit)
-      search('*', limit:    limit,
+      search('*', limit:,
                   where:    {
                     finished: false,
                     tradable: true

app/models/crop.rb

@@ -54,6 +54,7 @@ class Crop < ApplicationRecord
               message: 'is not a valid English Wikipedia URL'
             },
             if:     :approved?
+  validates :name, uniqueness: { scope: :approval_status }, if: :pending?
 
   def to_s
     name

app/models/csv_importer.rb

@@ -10,9 +10,9 @@ class CsvImporter
   def import_crop(row)
     name, en_wikipedia_url, parent_name, scientific_names, alternate_names = row
 
-    @crop = Crop.find_or_create_by(name: name)
+    @crop = Crop.find_or_create_by(name:)
     @crop.update(
-      en_wikipedia_url: en_wikipedia_url,
+      en_wikipedia_url:,
       creator_id:       cropbot.id
     )
 
@@ -47,8 +47,8 @@ class CsvImporter
     return if names_to_add.empty?
 
     names_to_add.each do |name|
-      sciname = ScientificName.find_by(name: name, crop: @crop)
-      sciname ||= ScientificName.create!(name: name, crop: @crop, creator: cropbot)
+      sciname = ScientificName.find_by(name:, crop: @crop)
+      sciname ||= ScientificName.create!(name:, crop: @crop, creator: cropbot)
       @crop.scientific_names << sciname
     end
   end
@@ -58,7 +58,7 @@ class CsvImporter
     return if alternate_names.blank?
 
     alternate_names.split(/,\s*/).each do |name|
-      altname = AlternateName.find_by(name: name, crop: @crop)
+      altname = AlternateName.find_by(name:, crop: @crop)
       altname ||= AlternateName.create! name: name, crop: @crop, creator: cropbot
       @crop.alternate_names << altname
     end

app/models/forum.rb

@@ -4,6 +4,7 @@ class Forum < ApplicationRecord
   extend FriendlyId
   include Ownable
   validates :name, presence: true
+  validates :description, presence: true
   friendly_id :name, use: %i(slugged finders)
 
   has_many :posts, dependent: :destroy

app/models/member.rb

@@ -21,7 +21,7 @@ class Member < ApplicationRecord
   has_many :harvests, foreign_key: 'owner_id', dependent: :destroy, inverse_of: :owner
   has_and_belongs_to_many :roles
   has_many :notifications, foreign_key: 'recipient_id', inverse_of: :recipient
-  has_many :sent_notifications, foreign_key: 'sender_id', inverse_of: :sender
+  has_many :sent_notifications, foreign_key: 'sender_id', inverse_of: :sender, class_name: "Notification"
   has_many :authentications, dependent: :destroy
   has_many :photos, inverse_of: :owner
   has_many :likes, dependent: :destroy
@@ -127,7 +127,7 @@ class Member < ApplicationRecord
   end
 
   def auth(provider)
-    authentications.find_by(provider: provider)
+    authentications.find_by(provider:)
   end
 
   def unread_count

app/models/photo.rb

@@ -27,7 +27,7 @@ class Photo < ApplicationRecord
              source_type: type
   end
 
-  scope :by_crop, ->(crop) { joins(:photo_associations).where(photo_associations: { crop: crop }) }
+  scope :by_crop, ->(crop) { joins(:photo_associations).where(photo_associations: { crop: }) }
   scope :by_model, lambda { |model_name|
     joins(:photo_associations).where(photo_associations: { photographable_type: model_name.to_s })
   }

app/models/photo_association.rb

@@ -33,8 +33,8 @@ class PhotoAssociation < ApplicationRecord
   end
 
   def crop_present
-    if %w(Planting Seed Harvest).include?(photographable_type)
-      errors.add(:crop_id, "failed to calculate crop") if crop_id.blank?
-    end
+    return unless %w(Planting Seed Harvest).include?(photographable_type)
+
+    errors.add(:crop_id, "failed to calculate crop") if crop_id.blank?
   end
 end

app/models/planting.rb

@@ -89,7 +89,7 @@ class Planting < ApplicationRecord
 
   # stringify as "beet in Skud's backyard" or similar
   def to_s
-    I18n.t('plantings.string', crop: crop.name, garden: garden.name, owner: owner)
+    I18n.t('plantings.string', crop: crop.name, garden: garden.name, owner:)
   end
 
   def finished?
@@ -109,7 +109,7 @@ class Planting < ApplicationRecord
 
     # latitude, longitude = Geocoder.coordinates(location, params: { limit: 1 })
     Planting.joins(:garden)
-      .where(crop: crop)
+      .where(crop:)
       .located
       .where('gardens.latitude < ? AND gardens.latitude > ?',
              latitude + 10, latitude - 10)

app/models/post.rb

@@ -90,10 +90,10 @@ class Post < ApplicationRecord
       next unless recipient_id != sender
 
       Notification.create(
-        recipient_id: recipient_id,
+        recipient_id:,
         sender_id:    sender,
         subject:      "#{author} mentioned you in their post #{subject}",
-        body:         body
+        body:
       )
     end
   end

app/models/role.rb

@@ -11,7 +11,7 @@ class Role < ApplicationRecord
     %i(crop_wranglers admins).each do |method|
       define_method method do
         slug = method.to_s.singularize.dasherize
-        Role.where(slug: slug).try(:first).try(:members)
+        Role.where(slug:).try(:first).try(:members)
       end
     end
   end

app/models/seed.rb

@@ -69,6 +69,6 @@ class Seed < ApplicationRecord
   end
 
   def to_s
-    I18n.t('seeds.string', crop: crop.name, owner: owner)
+    I18n.t('seeds.string', crop: crop.name, owner:)
   end
 end

app/resources/api/v1/member_resource.rb

@@ -5,10 +5,10 @@ module Api
     class MemberResource < BaseResource
       immutable
 
-      has_many :gardens
-      has_many :plantings
-      has_many :harvests
-      has_many :seeds
+      has_many :gardens, foreign_key: 'owner_id'
+      has_many :plantings, foreign_key: 'owner_id'
+      has_many :harvests, foreign_key: 'owner_id'
+      has_many :seeds, foreign_key: 'owner_id'
 
       has_many :photos
 

app/resources/api/v1/planting_resource.rb

@@ -33,6 +33,7 @@ module Api
       filter :planted_from
       filter :garden
       filter :owner
+      filter :owner_id
       filter :finished
 
       attribute :percentage_grown

app/services/crop_search_service.rb

@@ -4,8 +4,8 @@ class CropSearchService
   # Crop.search(string)
   def self.search(query, page: 1, per_page: 12, current_member: nil)
     search_params = {
-      page:         page,
-      per_page:     per_page,
+      page:,
+      per_page:,
       fields:       %i(name^5 alternate_names scientific_names),
       match:        :word_start,
       boost_by:     [:plantings_count],
@@ -16,28 +16,28 @@ class CropSearchService
     # prioritise crops the member has planted
     search_params[:boost_where] = { planters_ids: current_member.id } if current_member
 
-    Crop.search(query, search_params)
+    Crop.search(query, **search_params)
   end
 
   def self.random_with_photos(limit)
     body = {
-      "query": {
-        "function_score": {
-          "query":        { "query_string": { "query": 'has_photos:true' } },
-          "random_score": { "seed": DateTime.now.to_i }
+      query: {
+        function_score: {
+          query:        { query_string: { query: 'has_photos:true' } },
+          random_score: { seed: DateTime.now.to_i }
         }
       }
     }
     Crop.search(
-      limit: limit,
+      limit:,
       load:  false,
-      body:  body
+      body:
     )
   end
 
   def self.recent(limit)
     Crop.search(
-      limit:    limit,
+      limit:,
       load:     false,
       boost_by: { created_at: { factor: 100 } } # default factor is 1
     )

app/services/openfarm_service.rb

@@ -10,7 +10,7 @@ class OpenfarmService
 
   def import!
     Crop.all.order(updated_at: :desc).each do |crop|
-      Rails.logger.debug("#{crop.id}, #{crop.name}")
+      Rails.logger.debug { "#{crop.id}, #{crop.name}" }
       update_crop(crop) if crop.valid?
     end
   end
@@ -64,9 +64,9 @@ class OpenfarmService
       if photo.valid?
         Photo.transaction do
           photo.save
-          PhotoAssociation.find_or_create_by! photo: photo, photographable: crop
+          PhotoAssociation.find_or_create_by! photo:, photographable: crop
         end
-        Rails.logger.debug "\t saved photo #{photo.id} #{photo.source_id}"
+        Rails.logger.debug { "\t saved photo #{photo.id} #{photo.source_id}" }
       else
         Rails.logger.warn "Photo not valid"
       end

app/validators/approved_validator.rb

@@ -2,6 +2,6 @@
 
 class ApprovedValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, _value)
-    record.errors[attribute] << (options[:message] || 'must be approved') unless record.crop.try(:approved?)
+    record.errors.add(attribute, options[:message] || 'must be approved') unless record.crop.try(:approved?)
   end
 end

app/views/comments/index.rss.haml

@@ -16,6 +16,6 @@
           :escaped_markdown
             #{ strip_tags comment.body }
 
-        %pubdate= comment.created_at.to_s(:rfc822)
+        %pubdate= comment.created_at.to_fs(:rfc822)
         %link= post_url(comment.post)
         %guid= comment_url(comment)

app/views/crops/_form.html.haml

@@ -19,7 +19,7 @@
         %p
           %span.help-block
             For detailed crop wrangling guidelines, please consult the
-            = link_to "crop wrangling guide", "http://wiki.growstuff.org/index.php/Crop_wrangling"
+            = link_to "crop wrangling guide", "https://github.com/Growstuff/growstuff/wiki/Crop-Wrangling"
             on the Growstuff wiki.
 
       -# Everyone (wranglers and requesters) sees the basic info section

app/views/crops/index.csv.shaper

@@ -107,8 +107,8 @@ csv.headers *all_headers
 
     csv.cell :added_by_member_id, c.creator.id
     csv.cell :added_by_member_name, c.creator.to_s
-    csv.cell :date_added, c.created_at.to_s(:db)
-    csv.cell :last_modified, c.updated_at.to_s(:db)
+    csv.cell :date_added, c.created_at.to_fs(:db)
+    csv.cell :last_modified, c.updated_at.to_fs(:db)
 
     csv.cell :license, "CC-BY-SA Growstuff http://growstuff.org/"
 

app/views/crops/index.rss.haml

@@ -6,6 +6,6 @@
     - @crops.each do |crop|
       %item
         %title= crop.name
-        %pubdate= crop.created_at.to_s(:rfc822)
+        %pubdate= crop.created_at.to_fs(:rfc822)
         %link= crop_url(crop)
         %guid= crop_url(crop)

app/views/devise/registrations/_edit_apps.html.haml

@@ -28,17 +28,3 @@
                     method: :delete, class: "remove btn btn-danger"
         - else
           = link_to 'Connect to Flickr', '/members/auth/flickr', class: 'btn'
-
-  .row
-    .col-md-12
-      %p
-        = image_tag "facebook_32.png", size: "32x32", alt: 'Facebook logo'
-        - if @facebook_auth
-          You are connected to Facebook as
-          = succeed "." do
-            = link_to @facebook_auth.name, "https://facebook.com/profile/#{@facebook_auth.uid}"
-          = link_to "Disconnect", @facebook_auth,
-                    confirm: "Are you sure you want to remove this connection?",
-                    method: :delete, class: "remove btn btn-danger"
-        - else
-          = link_to 'Connect to Facebook', '/members/auth/facebook', class: 'btn'

app/views/gardens/_form.html.haml

@@ -27,7 +27,7 @@
         - else
           = link_to "Change your location.", edit_member_registration_path
       .row
-        .col-md-5.col-12= f.number_field :area, class: 'input-small'
+        .col-md-5.col-12= f.number_field :area, class: 'input-small', step: "any"
         .col-md-7.col-12= f.select(:area_unit, Garden::AREA_UNITS_VALUES, { include_blank: false })
         .col-12= f.select(:garden_type_id, GardenType.all.order(:name).pluck(:name, :id),
                           selected: @garden.garden_type_id, include_blank: true)

app/views/harvests/_form.html.haml

@@ -31,7 +31,7 @@
                 = link_to "Request new crops.", new_crop_path
 
         .col-md-4
-          = f.text_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_s(:ymd) : '',
+          = f.text_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '',
                          class: 'add-datepicker', label: 'When?'
         .col-12
           = f.form_group :plant_part_id, label: { text: "Harvested Plant Part" } do

app/views/harvests/index.csv.shaper

@@ -34,12 +34,12 @@ csv.headers :id,
 
     csv.cells :quantity, :unit, :weight_quantity, :weight_unit, :si_weight
 
-    csv.cell :date_harvested, h.created_at.to_s(:db)
+    csv.cell :date_harvested, h.created_at.to_fs(:db)
 
     csv.cell :description
 
-    csv.cell :date_added, h.created_at.to_s(:db)
-    csv.cell :last_modified, h.updated_at.to_s(:db)
+    csv.cell :date_added, h.created_at.to_fs(:db)
+    csv.cell :last_modified, h.updated_at.to_fs(:db)
 
     csv.cell :license, "CC-BY-SA Growstuff http://growstuff.org/"
 

app/views/layouts/_head.html.haml

@@ -30,6 +30,6 @@
   = csrf_meta_tags
   = stylesheet_link_tag "application", media: "all"
 
-  %link{ href: "/growstuff-apple-touch-icon-precomposed.png", rel: "apple-touch-icon-precomposed" }
+  %link{ href: path_to_image("growstuff-apple-touch-icon-precomposed.png"), rel: "apple-touch-icon-precomposed" }
   %link{ href: "https://fonts.googleapis.com/css?family=Modak|Raleway&display=swap", rel: "stylesheet" }
   = favicon_link_tag 'favicon.ico'

app/views/layouts/_menu.haml

@@ -3,13 +3,13 @@
     - if signed_in?
       %li.nav-item
         = link_to timeline_index_path, method: :get, class: 'nav-link text-white' do
-          = image_tag 'icons/notification.svg', alt: 'Timeline', class: 'img img-icon'
+          = image_tag 'icons/notification.svg', class: 'img img-icon'
       %li.nav-item
         = link_to member_gardens_path(current_member), class: 'nav-link text-white' do
-          = image_icon 'gardens', alt: 'My gardens'
+          = image_icon 'gardens'
       %li.nav-item.dropdown
         %a.nav-link.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-toggle" => "dropdown", href: "#", role: "button"}
-          = image_tag "icons/gardener.svg", alt: 'New record', class: 'img img-icon'
+          = image_tag "icons/gardener.svg", class: 'img img-icon'
           = t('.record')
         .dropdown-menu
           = link_to new_planting_path, class: 'dropdown-item' do

app/views/members/_contact.html.haml

@@ -1,4 +1,4 @@
-- if twitter_auth || flickr_auth || facebook_auth || member.show_email
+- if twitter_auth || flickr_auth || member.show_email
   %h4 Contact
 
   - if twitter_auth
@@ -11,11 +11,6 @@
       = image_tag "flickr_32.png", size: "32x32", alt: 'Flickr logo'
       = link_to flickr_auth.name, "https://flickr.com/photos/#{flickr_auth.uid}"
 
-  - if facebook_auth
-    %p
-      = image_tag "facebook_32.png", size: "32x32", alt: 'Facebook logo'
-      = link_to facebook_auth.name, "https://facebook.com/profile/#{facebook_auth.uid}"
-
   - if member.show_email
     %p
       Email:

app/views/members/_member.haml

@@ -1,19 +1,18 @@
 - cache member do
   .card.card-double
     .card-body
-      .row
-        .col-12.col-md-6
-          = render "members/avatar", member: member
-        .col-12.col-md-6
-          %h4.login-name= link_to member, member
-          = link_to "view all #{member}'s gardens", member_gardens_path(member)
-          %p
-            %small
-              Joined
-              = distance_of_time_in_words(member.created_at, Time.zone.now)
-              ago.
-          - if member.location.present?
-            = link_to member.location, place_path(member.location)
+      %h4.login-name= link_to member, member
+      %div
+        = render "members/avatar", member: member
+      %div
+        = link_to "view all #{member}'s gardens", member_gardens_path(member)
+        %p
+          %small
+            Joined
+            = distance_of_time_in_words(member.created_at, Time.zone.now)
+            ago.
+        - if member.location.present?
+          = link_to member.location, place_path(member.location)
     .card-footer
       %ul.nav.nav-justified.small
         %li.nav-item.border-right

app/views/members/_stats.html.haml

@@ -2,39 +2,39 @@
   %h3 Activity
 %ul.list-group.list-group-flush
   %li.list-group-item
-    - if !member.gardens.empty?
+    - if member.gardens.present?
       = link_to localize_plural(member.gardens, Garden), member_gardens_path(member)
     - else
       0 gardens
   %li.list-group-item
-    - if !member.plantings.empty?
+    - if member.plantings.present?
       = link_to localize_plural(member.plantings, Planting), member_plantings_path(member)
     - else
       0 plantings
   %li.list-group-item
-    - if !member.harvests.empty?
+    - if member.harvests.present?
       = link_to localize_plural(member.harvests, Harvest), member_harvests_path(member)
     - else
       0 harvests
   %li.list-group-item
-    - if !member.seeds.empty?
+    - if member.seeds.present?
       = link_to localize_plural(member.seeds, Seed), member_seeds_path(member)
     - else
       0 seeds
   %li.list-group-item
-    - if !member.posts.empty?
+    - if member.posts.present?
       = link_to localize_plural(member.posts, Post), member_posts_path(member)
     - else
       0 posts
 
   %li.list-group-item
-    - if !member.followed.empty?
+    - if member.followed.present?
       = link_to localize_plural(member.followed, Follow), member_follows_path(member)
     - else
       0 following
 
   %li.list-group-item
-    - if !member.followers.empty?
+    - if member.followers.present?
       = link_to pluralize(member.followers.size, "follower"), member_followers_path(member)
     - else
       0 followers

app/views/members/show.html.haml

@@ -30,7 +30,7 @@
             = truncate(@member.location, length: 25, separator: ' ', omission: '... ')
         %p
           %strong Member since
-          = @member.created_at.to_s(:date)
+          = @member.created_at.to_fs(:date)
         %p
           %strong Last Login
           = @member.last_sign_in_at
@@ -57,8 +57,7 @@
       = render "stats", member: @member
       .card-footer
         = render "contact", member: @member, twitter_auth: @twitter_auth,
-                                              flickr_auth: @flickr_auth,
-                                              facebook_auth: @facebook_auth
+                                              flickr_auth: @flickr_auth
 
   .col-md-10
     %section= render "map", member: @member

app/views/members/show.rss.haml

@@ -6,7 +6,7 @@
     - @member.posts.each do |post|
       %item
         %title #{post.subject} by #{post.author.login_name}
-        %pubdate= post.created_at.to_s(:rfc822)
+        %pubdate= post.created_at.to_fs(:rfc822)
         %link= post_url(post)
         %guid= post_url(post)
         %description

app/views/places/_search_form.html.haml

@@ -1,6 +1,6 @@
 %form.form-inline{ action: search_places_path, method: :get, role: 'form' }
   .form-group
     = label_tag :new_place, "Change location:", class: 'sr-only'
-    = text_field_tag :new_place, '', class: 'form-control', placeholder: "New location..."
+    = text_field_tag :new_place, '', class: 'form-control', placeholder: "Search for city, suburb or state..."
   = submit_tag "Search", class: 'btn btn-primary', id: "search_button"
 %br/

app/views/plantings/_form.html.haml

@@ -34,7 +34,7 @@
           = link_to "Add a garden.", new_garden_path
         .col-md-4
           = f.text_field :planted_at,
-                     value: @planting.planted_at ? @planting.planted_at.to_s(:ymd) : '',
+                     value: @planting.planted_at ? @planting.planted_at.to_fs(:ymd) : '',
                      class: 'add-datepicker', label: 'When?'
 
       .row
@@ -52,7 +52,7 @@
           %span.help-block= t('.finish_helper')
         .col-md-6
           = f.text_field :finished_at,
-                     value: @planting.finished_at ? @planting.finished_at.to_s(:ymd) : '',
+                     value: @planting.finished_at ? @planting.finished_at.to_fs(:ymd) : '',
                      class: 'add-datepicker',
                      label: 'Finished date',
                      placeholder: 'optional'

app/views/plantings/index.csv.shaper

@@ -34,15 +34,15 @@ csv.headers :id,
 
     csv.cells :quantity, :planted_from, :sunniness
 
-    csv.cell :date_planted, p.planted_at ? p.planted_at.to_s(:db) : ''
+    csv.cell :date_planted, p.planted_at ? p.planted_at.to_fs(:db) : ''
 
     csv.cell :finished
-    csv.cell :date_finished, p.finished_at ? p.finished_at.to_s(:db) : ''
+    csv.cell :date_finished, p.finished_at ? p.finished_at.to_fs(:db) : ''
 
     csv.cell :description
 
-    csv.cell :date_added, p.created_at.to_s(:db)
-    csv.cell :last_modified, p.updated_at.to_s(:db)
+    csv.cell :date_added, p.created_at.to_fs(:db)
+    csv.cell :last_modified, p.updated_at.to_fs(:db)
 
     csv.cell :license, "CC-BY-SA Growstuff http://growstuff.org/"
 

app/views/plantings/index.rss.haml

@@ -7,7 +7,7 @@
     - @plantings.each do |planting|
       %item
         %title #{planting['crop_name']} in #{planting['location']}
-        %pubdate= planting['created_at'].to_s(:rfc822)
+        %pubdate= planting['created_at'].to_fs(:rfc822)
         %description
           :escaped
             <p>Quantity: #{planting['quantity'] ? planting['quantity'] : 'unknown' }</p>

app/views/posts/_summary.html.haml

@@ -2,10 +2,10 @@
 - unless posts.empty?
   %table.table.table-striped
     %tr
-      %th Subject
-      %th.hidden-xs Posted by
-      %th Most recent activity
-      %th.hidden-xs Comments
+      %th.col-6 Subject
+      %th.col-2.hidden-xs Posted by
+      %th.col-2 Most recent activity
+      %th.col-2.hidden-xs Comments
 
     - posts.recently_active[0..howmany - 1].each do |post|
       - cache post do
@@ -16,9 +16,11 @@
             = link_to post.author, post.author
           %td
             - if post.updated_at > post.recent_activity
-              = post.updated_at.to_date.to_formatted_s(:short)
+              %span{ title: post.updated_at.to_date.to_formatted_s(:long) }
+                = post.updated_at.to_date.to_formatted_s(:short)
             - else
-              = post.recent_activity.to_date.to_formatted_s(:short)
+              %span{ title: post.recent_activity.to_date.to_formatted_s(:long) }
+                = post.recent_activity.to_date.to_formatted_s(:short)
             // once the site gets more active, can change this to include time as well
             // can't make it relative (distance_of_time_in_words) as it's cached
           %td.hidden-xs

app/views/posts/index.rss.haml

@@ -10,6 +10,6 @@
         %description
           :escaped_markdown
             #{ strip_tags post.body }
-        %pubdate= post.created_at.to_s(:rfc822)
+        %pubdate= post.created_at.to_fs(:rfc822)
         %link= post_url(post)
         %guid= post_url(post)

app/views/posts/show.rss.haml

@@ -17,6 +17,6 @@
           :escaped_markdown
             #{ strip_tags comment.body }
 
-        %pubdate= comment.created_at.to_s(:rfc822)
+        %pubdate= comment.created_at.to_fs(:rfc822)
         %link= post_url(@post)
         %guid= comment_url(comment)

app/views/seeds/_form.html.haml

@@ -30,18 +30,18 @@
       .row
         .col-12.col-md-4
           = f.text_field :saved_at,
-                     value: @seed.saved_at ? @seed.saved_at.to_s(:ymd) : '',
+                     value: @seed.saved_at ? @seed.saved_at.to_fs(:ymd) : '',
                      class: 'add-datepicker', label: 'When were the seeds harvested/saved?'
         .col-12.col-md-4= f.number_field :quantity, label: 'Quantity'
         .col-12.col-md-4
           = f.text_field :plant_before, class: 'add-datepicker',
-          value: @seed.plant_before ? @seed.plant_before.to_s(:ymd) : ''
+          value: @seed.plant_before ? @seed.plant_before.to_fs(:ymd) : ''
 
       .row
         .col-12.col-md-4
           = f.check_box :finished, label: 'Mark as finished'
         .col-12.col-md-4
-          = f.text_field :finished_at, class: 'add-datepicker', value: @seed.finished_at ? @seed.finished_at.to_s(:ymd) : ''
+          = f.text_field :finished_at, class: 'add-datepicker', value: @seed.finished_at ? @seed.finished_at.to_fs(:ymd) : ''
         .col-12.col-md-4
           %span.help-inline= t('.finish_helper')
 

app/views/seeds/index.csv.shaper

@@ -44,8 +44,8 @@ csv.headers :id,
     csv.cell :gmo
     csv.cell :heirloom
 
-    csv.cell :date_added, s.created_at.to_s(:db)
-    csv.cell :last_modified, s.updated_at.to_s(:db)
+    csv.cell :date_added, s.created_at.to_fs(:db)
+    csv.cell :last_modified, s.updated_at.to_fs(:db)
 
     csv.cell :license, "CC-BY-SA Growstuff http://growstuff.org/"
 

app/views/seeds/index.rss.haml

@@ -7,7 +7,7 @@
     - @seeds.each do |seed|
       %item
         %title #{seed.owner_login_name}'s #{seed.crop_name} seeds
-        %pubdate= seed.created_at.to_s(:rfc822)
+        %pubdate= seed.created_at.to_fs(:rfc822)
         %description
           :escaped
             <p>Quantity: #{seed.quantity ||= 'unknown' }</p>

app/views/shared/editable/_date.html.haml

@@ -6,6 +6,6 @@
   .hide{id: "date--#{model.id}-#{field.to_s}"}
     = bootstrap_form_for(model) do |f|
       = f.text_field field,
-               value: model.send(field) ? model.send(field).to_s(:ymd) : '',
+               value: model.send(field) ? model.send(field).to_fs(:ymd) : '',
                class: 'add-datepicker', label: 'When?'
       = f.submit :save

app/views/shared/editable/_form.html.haml

@@ -13,6 +13,6 @@
         = f.select field, collection
       - elsif field_type == :date
         = f.text_field field,
-                 value: model.send(field) ? model.send(field).to_s(:ymd) : '',
+                 value: model.send(field) ? model.send(field).to_fs(:ymd) : '',
                  class: 'add-datepicker', label: 'When?'
       = f.submit :save

config/application.rb

@@ -12,15 +12,19 @@ Bundler.require(*Rails.groups)
 module Growstuff
   class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.
-    config.load_defaults 6.0
+    config.load_defaults 7.0
 
     I18n.config.enforce_available_locales = true
 
+    config.active_record.legacy_connection_handling = false
+
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
     # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
     config.time_zone = 'UTC'
     config.active_record.default_timezone = :local
 
+    config.active_record.yaml_column_permitted_classes = [Symbol, Date, Time, ActiveSupport::TimeWithZone, ActiveSupport::TimeZone]
+
     # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
     I18n.load_path += Dir[Rails.root.join('config', 'locales', '*.{rb,yml}')]
     I18n.default_locale = :en

config/database.yml

@@ -1,10 +1,16 @@
 development:
   adapter: postgresql
   database: growstuff_dev
+  user: postgres
+  password: postgres
+  host: db
 
 test:
   adapter: postgresql
   database: growstuff_test
+  user: postgres
+  password: postgres
+  host: db
 
 production:
   adapter: postgresql

config/elasticsearch.yml

@@ -0,0 +1,5 @@
+development: &default
+  host: 'http://es01:9200'
+  log: true
+test:
+  host: 'http://es01:9200'

config/environments/development.rb

@@ -67,13 +67,9 @@ Rails.application.configure do
   config.action_mailer.delivery_method = :letter_opener
 
   config.host = 'localhost:3000'
+  config.hosts << ".preview.app.github.dev"
   config.analytics_code = ''
 
-  # this config variable cannot be put in application.yml as it is needed
-  # by the assets pipeline, which doesn't have access to ENV.
-  config.mapbox_map_id = 'growstuff.i3n2il6a'
-  config.mapbox_access_token = 'pk.eyJ1IjoiZ3Jvd3N0dWZmIiwiYSI6IkdxMkx4alUifQ.n0igaBsw97s14zMa0lwKCA'
-
   config.action_controller.action_on_unpermitted_parameters = :raise
 
   config.active_job.queue_adapter = :sidekiq

config/environments/production.rb

@@ -83,7 +83,7 @@ Rails.application.configure do
   config.active_support.deprecation = :notify
 
   # Use default logging formatter so that PID and timestamp are not suppressed.
-  config.log_formatter = ::Logger::Formatter.new
+  config.log_formatter = Logger::Formatter.new
 
   # Do not dump schema after migrations.
   config.active_record.dump_schema_after_migration = false
@@ -92,10 +92,10 @@ Rails.application.configure do
   config.action_mailer.default_url_options = { host: ENV['HOST'] }
 
   config.action_mailer.smtp_settings = {
-    user_name:            ENV['SENDGRID_USERNAME'],
-    password:             ENV['SENDGRID_PASSWORD'],
+    user_name:            ENV['MAILGUN_SMTP_LOGIN'],
+    password:             ENV['MAILGUN_SMTP_PASSWORD'],
     domain:               ENV['GROWSTUFF_EMAIL_DOMAIN'],
-    address:              'smtp.sendgrid.net',
+    address:              ENV['MAILGUN_SMTP_SERVER'],
     port:                 587,
     authentication:       :plain,
     enable_starttls_auto: true
@@ -103,16 +103,11 @@ Rails.application.configure do
   ActionMailer::Base.delivery_method = :smtp
 
   config.host = ENV['HOST']
-  config.analytics_code = <<-eos
+  config.analytics_code = <<-GET_CLICKY_SCRIPT
     <script src="//static.getclicky.com/js" type="text/javascript"></script>
     <script type="text/javascript">try{ clicky.init(100594260); }catch(e){}</script>
     <noscript><p><img alt="Clicky" width="1" height="1" src="//in.getclicky.com/100594260ns.gif" /></p></noscript>
-  eos
-
-  # this config variable cannot be put in application.yml as it is needed
-  # by the assets pipeline, which doesn't have access to ENV.
-  config.mapbox_map_id = ENV['GROWSTUFF_MAPBOX_MAP_ID']
-  config.mapbox_access_token = ENV['GROWSTUFF_MAPBOX_ACCESS_TOKEN']
+  GET_CLICKY_SCRIPT
 
   config.active_job.queue_adapter = :sidekiq
   # Use a different logger for distributed setups.

config/environments/test.rb

@@ -104,16 +104,3 @@ Capybara.configure do |config|
 end
 
 OmniAuth.config.test_mode = true
-# Fake the omniauth
-OmniAuth.config.mock_auth[:facebook] = OmniAuth::AuthHash.new(provider:    'facebook',
-                                                              uid:         '123545',
-                                                              info:        {
-                                                                name:     "John Testerson",
-                                                                nickname: 'JohnnyT',
-                                                                email:    'example.oauth.facebook@example.com',
-                                                                image:    'http://findicons.com/files/icons/1072/face_avatars/300/i04.png'
-                                                              },
-                                                              credentials: {
-                                                                token:  "token",
-                                                                secret: "donttell"
-                                                              })

config/initializers/devise.rb

@@ -86,7 +86,7 @@ Devise.setup do |config|
   config.stretches = Rails.env.test? ? 1 : 10
 
   # Setup a pepper to generate the encrypted password.
-  # config.pepper = "dd24b97208cc11ebae765edd19bee764aacafa99b3711440f08fe92e8f790d0b4ab60ebb6bc3bcc2c526438eefa50326eddf4d3e429a2431f8a646d8a7d7bd1f"
+  # config.pepper = "..."
 
   # ==> Configuration for :confirmable
   # A period that the user is allowed to access the website even without
@@ -233,7 +233,4 @@ Devise.setup do |config|
   # When using omniauth, Devise cannot automatically set Omniauth path,
   # so you need to do it manually. For the users scope, it would be:
   # config.omniauth_path_prefix = "/my_engine/users/auth"
-
-  # Later we may wish to ask for user_photos,user_location, however this means we need to be reviewed by facebook
-  config.omniauth :facebook, ENV['GROWSTUFF_FACEBOOK_KEY'], ENV['GROWSTUFF_FACEBOOK_SECRET'], scope: 'email,public_profile', display: 'page', info_fields: 'email,name,first_name,last_name,id'
 end