Brenda WallaceandClaude Sonnet 5
82480f9ce8
* Wait for the page reload in the members list spec The "members list" feature specs click "Show" and then read the list of members right away. "Show" submits a GET form, so the browser loads a whole new page. The spec could read the list from the old page. The old page was then replaced, and Selenium raised StaleElementReferenceError. This failed once in CI on the pull request for #4800: https://github.com/Growstuff/growstuff/actions/runs/35477162596 Both examples now wait for the new URL before they read the list. The URL contains the chosen sort order, so the wait only ends once the new page has loaded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Wait for the place page in the places search spec The "User searches" specs fill in the search form, click "Search", and then read the page straight away. The search goes to /places/search, which redirects to /places/<place>. The spec could read the page while the browser was still moving to the new page. Selenium then raised "Node with given id does not belong to the document". It failed in CI on the first example in "with a valid place": https://github.com/Growstuff/growstuff/actions/runs/35481754102 The search_with helper now waits for the place page URL before it returns. A blank search stays on the same URL, so it does not wait. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Rename the places CI workflow from "Admin" to "Places" The workflow in ci-features-places.yml was named "CI Features - Admin". It looks like it was copied from the admin workflow and never renamed. It runs spec/features/places/. Two workflows then had the same name. Every commit showed two "CI Features - Admin" runs. A failing places spec appeared under the admin name, which sent people to the wrong specs: https://github.com/Growstuff/growstuff/actions/runs/35481754102 Branch protection requires a check called "rspec". That is the job name, not the workflow name, so the required check does not change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
🌱 Growstuff
Welcome to the Growstuff project.
You can find our app at https://www.growstuff.org
Growstuff is an open source/open data project for food gardeners. We crowdsource information on what our members are growing and harvesting, aggregate it, and make it available as open data via our API.
Growstuff was founded in 2012 and has been built by dozens of contributors. We are an inclusive, welcoming project, and encourage participation from people of all backgrounds and skill levels.
Want to contribute?
Don't ask to ask, the best way to get started is to fork the project, start a codespace and get hacking. Dive on in and submit your PRs!
Vibe Coding is more than okay, just make sure you indicate if you have done so and ensure there are tests.
Important links
For coders
Growstuff is built in Ruby on Rails and also uses JavaScript for frontend features. We welcome contributions -- see CONTRIBUTING for details.
- To set up your development environment, see Getting started.
- You may also be interested in our API.
For Home Automation enthusiasts
https://github.com/Growstuff/homeassistant-growstuff/
For designers, writers, researchers, data wranglers, and other contributors
There are heaps of ways to get involved and contribute no matter what your skills and interests.
You might like to check out:
- The New Contributor Guide page on our wiki, which has lots of detail for different areas
Here on Github, you might find these useful:
- Github Project Board has stories in "ready" that can be worked on.
- needs: design - tasks requiring high-level design
- needs: visual design - tasks requiring visual/graphical design
- needs: documentation
- needs: data - tasks requiring data entry, data design, data import, or similar
- curated:beginner - tasks that are ideal for beginner programmers or people new to the project
Feel free to comment on any of the issues on Github.
Contact
For more information about this project, contact info@growstuff.org.
Security Issues: If you find an authorization bypass or data breach, please contact our maintainers directly at maintainers@growstuff.org.