mirror of
https://github.com/Growstuff/growstuff.git
synced 2026-02-02 13:41:00 -05:00
d8bf8ae4df
We deprecated controller and view specs on the grounds that they were brittle, and were a poorer measure of user experience than feature specs. However, feature specs have their own problems: they're much slower to run, and flakier (see #901). We also ran into a few cases where feature specs erroneously passed because they were checking for the presence of a string that occurred in the error page! Hence, we're cautiously un-deprecating controller and view specs. Fixes #1132
105 lines
3.0 KiB
Ruby
105 lines
3.0 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe CommentsController do
|
|
before(:each) do
|
|
@member = FactoryBot.create(:member)
|
|
sign_in @member
|
|
controller.stub(:current_member) { @member }
|
|
end
|
|
|
|
def valid_attributes
|
|
@post = FactoryBot.create(:post)
|
|
{ post_id: @post.id, body: "some text" }
|
|
end
|
|
|
|
describe "GET RSS feed" do
|
|
it "returns an RSS feed" do
|
|
get :index, format: "rss"
|
|
response.should be_success
|
|
response.should render_template("comments/index")
|
|
response.content_type.should eq("application/rss+xml")
|
|
end
|
|
end
|
|
|
|
describe "GET new" do
|
|
let(:post) { FactoryBot.create(:post) }
|
|
|
|
describe "with valid params" do
|
|
before { get :new, post_id: post.id }
|
|
|
|
it "picks up post from params" do
|
|
assigns(:post).should eq(post)
|
|
end
|
|
|
|
let(:old_comment) { FactoryBot.create(:comment, post: post) }
|
|
it "assigns the old comments as @comments" do
|
|
assigns(:comments).should eq [old_comment]
|
|
end
|
|
end
|
|
|
|
it "dies if no post specified" do
|
|
get :new
|
|
expect(response).not_to be_success
|
|
end
|
|
end
|
|
|
|
describe "GET edit" do
|
|
let(:post) { FactoryBot.create(:post) }
|
|
before { get :edit, id: comment.to_param }
|
|
|
|
describe "my comment" do
|
|
let!(:comment) { FactoryBot.create :comment, author: @member, post: post }
|
|
let!(:old_comment) { FactoryBot.create(:comment, post: post, created_at: Time.zone.yesterday) }
|
|
it "assigns previous comments as @comments" do
|
|
assigns(:comments).should eq([comment, old_comment])
|
|
end
|
|
end
|
|
|
|
describe "not my comment" do
|
|
let(:comment) { FactoryBot.create :comment, post: post }
|
|
it { expect(response).not_to be_success }
|
|
end
|
|
end
|
|
|
|
describe "PUT update" do
|
|
before { put :update, id: comment.to_param, comment: valid_attributes }
|
|
|
|
describe "my comment" do
|
|
let(:comment) { FactoryBot.create :comment, author: @member }
|
|
it "redirects to the comment's post" do
|
|
expect(response).to redirect_to(comment.post)
|
|
end
|
|
end
|
|
describe "not my comment" do
|
|
let(:comment) { FactoryBot.create :comment }
|
|
it { expect(response).not_to be_success }
|
|
end
|
|
describe "attempting to change post_id" do
|
|
let(:post) { FactoryBot.create :post, subject: 'our post' }
|
|
let(:other_post) { FactoryBot.create :post, subject: 'the other post' }
|
|
let(:valid_attributes) { { post_id: other_post.id, body: "kōrero" } }
|
|
let(:comment) { FactoryBot.create :comment, author: @member, post: post }
|
|
it "does not change post_id" do
|
|
comment.reload
|
|
expect(comment.post_id).to eq(post.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "DELETE destroy" do
|
|
before { delete :destroy, id: comment.to_param }
|
|
|
|
describe "my comment" do
|
|
let(:comment) { FactoryBot.create :comment, author: @member }
|
|
it "redirects to the post the comment was on" do
|
|
expect(response).to redirect_to(comment.post)
|
|
end
|
|
end
|
|
|
|
describe "not my comment" do
|
|
let(:comment) { FactoryBot.create :comment }
|
|
it { expect(response).not_to be_success }
|
|
end
|
|
end
|
|
end
|