mirror/iNaturalistReactNative
1
0
Fork 0
mirror of https://github.com/inaturalist/iNaturalistReactNative.git synced 2025-12-23 22:18:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Migrate fetchPlaceName to TS (#3122)

Browse Source 
* Rename file

* Add some types

* Rename file

* Revert "Rename file"

This reverts commit ae7d85c23f.
This commit is contained in:
Johannes Klein
2025-10-07 10:56:37 +02:00
committed by GitHub
parent 9c90c2e45f
commit 6535f399f9
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/sharedHelpers/fetchPlaceName.js → src/sharedHelpers/fetchPlaceName.ts
View File

@@ -1,7 +1,5 @@
// @flow
import NetInfo from "@react-native-community/netinfo";
import Geocoder from "react-native-geocoder-reborn";
import Geocoder, { GeocodingObject } from "react-native-geocoder-reborn";
// 2.5 seconds, half the time as online Suggestions
// feel free to tweak this but it's here to make the camera feel speedier
@@ -10,7 +8,7 @@ const GEOCODER_TIMEOUT = 2500;
const TIMEOUT_ERROR_MESSAGE = "Geocoder timeout";
// lifted from SeekReactNative repo
const setPlaceName = ( results: Array<Object> ): string => {
const setPlaceName = ( results: GeocodingObject[] ): string => {
let placeName = "";
const {
@@ -22,7 +20,7 @@ const setPlaceName = ( results: Array<Object> ): string => {
// this seems to be preferred formatting for iNat web
// TODO: localize formatting
// TODO: throttle requests on iOS so this doesn't error out in location picker
const appendName = name => ( placeName.length > 0
const appendName = ( name: string ) => ( placeName.length > 0
? `, ${name}`
: name );
@@ -41,7 +39,7 @@ const setPlaceName = ( results: Array<Object> ): string => {
return placeName;
};
const fetchPlaceName = async ( lat: ?number, lng: ?number ): Promise<?string> => {
const fetchPlaceName = async ( lat?: number, lng?: number ): Promise<string | null> => {
if ( !lat || !lng ) { return null; }
const { isConnected } = await NetInfo.fetch( );
if ( !isConnected ) { return null; }
@@ -56,13 +54,15 @@ const fetchPlaceName = async ( lat: ?number, lng: ?number ): Promise<?string> =>
timeoutPromise
] );
if ( results.length === 0 || typeof results !== "object" ) { return null; }
return setPlaceName( results );
return setPlaceName( results as GeocodingObject[] );
} catch ( geocoderError ) {
if ( geocoderError?.message === TIMEOUT_ERROR_MESSAGE ) {
if ( ( geocoderError as Error )?.message === TIMEOUT_ERROR_MESSAGE ) {
console.warn( "Geocoder operation timed out" );
return null;
}
if ( !geocoderError?.message?.includes( "geocodePosition failed" ) ) throw geocoderError;
if ( !( geocoderError as Error )?.message?.includes( "geocodePosition failed" ) ) {
throw geocoderError;
}
return null;
}
};