mirror/iNaturalistReactNative
1
0
Fork 0
mirror of https://github.com/inaturalist/iNaturalistReactNative.git synced 2025-12-23 22:18:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Only update observation keys when there's an observation

Browse Source
This commit is contained in:
Amanda Bullington
2024-07-09 16:16:02 -07:00
parent 62a2748922
commit a4cd17a513
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/sharedHooks/useWatchPosition.ts
View File

@@ -2,6 +2,7 @@ import Geolocation, {
GeolocationError,
GeolocationResponse
} from "@react-native-community/geolocation";
import _ from "lodash";
import { useEffect, useState } from "react";
import {
RESULTS as PERMISSION_RESULTS
@@ -68,21 +69,28 @@ const useWatchPosition = ( options: {
positional_accuracy: accuracy
};
if ( !currentPosition || !accuracy ) { return; }
updateObservationKeys( newLocation );
// right now, we're returning a userLocation for the Projects and Camera
// screens, and we're updating observation keys in ObsEdit so the location
// is added directly to the observation. once changes to permissions flow are
// done, we'll want to also update observation keys via Suggestions (instead of
// adding location in the Camera)
if ( !_.isEmpty( currentObservation ) ) {
updateObservationKeys( newLocation );
}
setUserLocation( newLocation );
if ( accuracy < TARGET_POSITIONAL_ACCURACY ) {
Geolocation.clearWatch( subscriptionId );
setSubscriptionId( null );
setCurrentPosition( null );
}
}, [currentPosition, subscriptionId, updateObservationKeys] );
}, [currentPosition, subscriptionId, updateObservationKeys, currentObservation] );
useEffect( ( ) => {
const beginLocationFetch = async ( ) => {
const permissionResult = await checkLocationPermission( );
setLocationPermissionResult( permissionResult );
const startFetchLocation = await shouldFetchObservationLocation( currentObservation );
if ( startFetchLocation ) {
if ( _.isEmpty( currentObservation ) || startFetchLocation ) {
watchPosition( );
} else {
setShouldFetchLocation( false );