Commit Graph

1141 Commits

Author SHA1 Message Date
Ken-ichi
899076e67a Only ask for permission to add photos from cameras (#1869)
* Patch camera roll to not ask for readwrite after addonly granted
* Only request add permission from cameras
2024-07-29 11:51:14 -07:00
Amanda Bullington
182196a205 Change url for connectivity check (#1868)
* Change connectivity url to ping inat; remove unnecessary useIsConnected hook; closes #1770

* Ensure inaturalist.org/ping is being pinged

* Fix e2e tests by using isConnected, not isInternetReachable
2024-07-26 20:16:32 -07:00
Amanda Bullington
bfa4c61f16 Add remove button to ObsEdit taxon result; closes #1853 (#1867) 2024-07-26 17:27:04 -07:00
Amanda Bullington
4beda5691c Use DisplayTaxonName component for disagreements (#1865)
* Use DisplayTaxonName as component in Trans to show DisagreementText

* Use DisplayTaxonName for top of disagree sheet

* Use DisplayTaxonName styling in radio button labels

* Remove italic from disagree text

* Add testing for DisplayTaxonName with plain text and scientific name only
2024-07-26 16:39:06 -07:00
Amanda Bullington
9b34e7e3f6 Show only scientific names when user prefers this; closes #1849 (#1863) 2024-07-25 17:47:45 -07:00
Amanda Bullington
54b3f5f716 Only show offline notice if sound url includes http; closes #1855 (#1862) 2024-07-25 16:52:05 -07:00
Amanda Bullington
a1836224ba Persist keyboard taps in bottom sheet; closes #1850 (#1861) 2024-07-25 15:32:24 -07:00
Amanda Bullington
7b5544cce2 Show iconic taxon icons from offline suggestions; closes #1845 (#1859) 2024-07-25 13:11:00 -07:00
Ken-ichi Ueda
4da51418e3 Disable nav to user profile for selected user on Explore filters 2024-07-25 11:40:44 -07:00
Amanda Bullington
b61ff38f7c Reset stack when user navigates from AddObsModal (#1858)
* Reset navigation stack when user navigates from AddObsModal; closes #1857

* Fix AddObs nav test
2024-07-25 09:58:54 -07:00
Johannes Klein
b6ea37e7e2 Add reset button to Explore searches for taxon, user, and project (#1836)
* Add reset button to set user to null

* Update type

* Update project to be null with reset button

* Reset button to set taxon to null

* Fix test for null now

* Project can also be null now
2024-07-25 15:06:22 +02:00
Amanda Bullington
5c1a5142a4 Load suggestions with location after permission granted (#1846)
* Refactor into useReducer

* Use reducer for Suggestions

* Offline working

* Progress on getting location permissions button to work as expected

* Code improvements

* Fix photo deletion test

* Fix AICamera nav test

* Ensure suggestions location permission uses location immediately

* Loading wheel fixes

* Fix photo deletion test

* Use online result to advance to obsedit in PhotoDeletion

* Fix test by using online mock
2024-07-24 22:19:05 -07:00
Ken-ichi
10bbea44c4 e2e mock for Geolocation.watchPosition to deflake tests (#1842) 2024-07-24 17:15:03 -07:00
Angie
27912676dc Loading wheel to explore filters searches (#1840) 2024-07-23 20:04:13 -07:00
Ken-ichi
2a67ec0a42 Bugfix: stop watching location when screen blurs (#1841)
This wasn't quite working as intended. Also sets isFetchingLocation correctly
when it starts to fetch location.
2024-07-23 17:04:50 -07:00
Johannes Klein
28c27e241a 1785 debug hide (#1837) 2024-07-23 12:30:04 +02:00
Amanda Bullington
fbd22f9e9d Fix location toggle on Suggestions (#1833)
* Fix Suggestions test & create test for online suggestions with location

* Fetch location according to toggle

* Update tests

* Show loading & remove prev queries when toggling location

* Fix loading test
2024-07-22 06:44:35 -07:00
Johannes Klein
b655c896cc Increase width of upload circle to 2.5 (#1835)
* Increase width of upload circle to 2.5

* Update UploadStatus.test.js.snap
2024-07-22 15:38:56 +02:00
Amanda Bullington
c3c98deeda Create new obs when backing out to AICamera (#1832)
* Write test to confirm only one obs photo added when backing out of AICamera

* Create new obs when backing out to AICamera; closes #1822
2024-07-19 09:57:16 -07:00
Amanda Bullington
59959317d7 Fix photo deletion test (#1830) 2024-07-19 07:47:59 -07:00
Johannes Klein
2a2983caed Update explore context with current location on permission being granted (#1831) 2024-07-19 12:21:03 +02:00
Angie Ta
00678d169f Remove RadioButtonSheet.js 2024-07-18 18:31:15 -07:00
Amanda Bullington
90a803d55b Only show select button when coming from Suggestions/Search; closes #1813 (#1829) 2024-07-18 13:55:33 -07:00
Angie
6cd952d733 1747 taxon detail spacing UI fix (#1823)
* taxondetails title ui adjustments

* update snapshot
2024-07-18 10:07:58 -07:00
Johannes Klein
860b2ae924 1820 multiple navigations camera (#1828)
* GreenCheckmark TS

* Param type

* Allow only once to navigate on checkmark press

* Update TransparentCircleButton.tsx

* Close TS

* Flash TS

* Zoom TS

* CloseButton TS

* CameraFlip TS

* TabletButtons TS

* handleCheckmarkPress is optional

* AICameraButtons TS

* Let type be inferred

* Update AICameraButtons.tsx

* Prop takingPhoto to buttons
2024-07-18 13:05:49 +02:00
Johannes Klein
5684130532 1811 ai button home align (#1827)
* Update flash-list

* Remove superfluous classname

* Update workaround to center empty list component

* GradientButton TS
2024-07-17 13:34:37 +02:00
Johannes Klein
2b3407af81 Flip disabled state for tablets in AICamera (#1826) 2024-07-17 09:44:46 +02:00
Johannes Klein
e2cbeb6896 Set current tab depending on wether user is logged in or not (#1825) 2024-07-17 09:44:31 +02:00
Amanda Bullington
92cafdde83 Land user on Suggestions when one photo imported (#1824)
* Create navigation test for PhotoGallery

* Code and test land user on Suggestions when one photo imported
2024-07-16 14:47:02 -07:00
Amanda Bullington
abd4bcee23 Refactored location fetching for accurate locations (#1788)
* Refactor to use watchPosition

* Update useWatchPosition with permissions/retry

* Replace useUserLocation with useWatchPosition and fix tests; return userLocation from watch position hook

* Only update observation keys when there's an observation

* Improve TypeScript definitions

* Revert TypeScript commit

* Revert "Only update observation keys when there's an observation"

This reverts commit a4cd17a513.

* Code cleanup: make useWatchPosition more modular

* Code cleanup; location permission in ObsEdit instead of subcomponent

* Use correct accuracy in Camera photos

* Camera fixes

* Fixes to watching position in ObsEdit

* Fix useWatchPosition tests

* Fix tests

* Make sure state updates when renavigating to OsEdit; test fixes
2024-07-16 09:23:09 -07:00
budowski
b06ffd0f5e #1737 - projects UI fixes (#1797) 2024-07-16 08:37:24 -07:00
Johannes Klein
400436dd2a 1476 collaborators text (#1819)
* Replace collaborators text

* Update strings.ftl

* Add team members
2024-07-16 13:33:50 +02:00
Angie
1b05562a6c change external browser strings to all caps (#1818) 2024-07-15 21:50:41 -07:00
Angie
0f9dabe9f7 Change DQA and Settings headings to Heading4 (#1817) 2024-07-15 20:37:08 -07:00
Angie
1fb7d2a642 Add margins to location obsedit (#1816) 2024-07-15 19:46:16 -07:00
Angie
6672baeb24 Added font color to wikipedia text (#1815) 2024-07-15 17:47:54 -07:00
budowski
656a1c6bf3 #1104 - when searching for taxon, use the general /search endpoint (#1717)
* #1104 - Taxon search - use general search endpoint (not taxa/search endpoint)

* Linter fixes

* Updated inaturalistjs library to v2.12.0

* Test fix

* Further test fixes

* Linter fixes
2024-07-15 17:34:00 -07:00
Ken-ichi
934e486402 Hide skip ID button on Suggestions sometimes (#1791)
* Hide skip ID button on Suggestions sometimes

We only want to show the text "Add an ID later" when one needs to move forward
without adding an ID, so this hides it

* When reached from ObsDetails (you can go back)
* When reaced from ObsEdit and there is an existing identification
  (you've already added an ID so if you're editing it you need to choose a
  taxon or back out)

* Update test

---------

Co-authored-by: Johannes Klein <johannes.t.klein@gmail.com>
2024-07-12 13:34:27 +02:00
Johannes Klein
a52996f535 Changes to the way permissions are asked for (#1793)
* Replace name in permission requests

* TakePhoto TS

* PermissionGate TS

* Type

* PermissionGateContainer TS

* Interface

* Types

* LocationGate TS

* Remove LocationPermissionGate from Camera

* Remove write only permission

* Type

* ObsPhotoSelectionList TS

* Code style

* Show the improve with location button

* Create useLocationPermission.tsx

* Use new hook on suggestions

* Doc comment

* Use new hook in camera view

* Add strings

* Refactor Explore main content

* Use permission hook on RootExplore

* Add no location permission component

* Rename function

* Prop request permissions and use with button

* Default to Nearby label

* Remove Node type

* Projects TS

* Use useLocationPermission hook in projects screen

* Add string

* Prop permission down

* Refactor list render

* Refactor tab id into enum

* Tab type

* On nearby tab if without permission show button to prompt

* Leftovers

* Remove location permission gate from ObsEdit

* Use location permission hook on evidence section

* SearchBar TS

* Do not autoFocus on search bar in location picker.

Closes #1743

* Update type

* LocationSearch TS

* Show location permission gate on location picker's mount

* Add location permission to CurrentLocationButton

* Remove unused props of Map

* Remove unused exports from useMapLocation

* Migration

* Revert "Show location permission gate on location picker's mount"

This reverts commit 30ff75698c53d54d0b14cd2bd629f7155b743bf8.

* Add callbacks to useLocationPermission hook

* Show location permission ask on Obs Edit

* Remove unused string

* Reset explore filters should set location always to worldwide

* Add helper function to show place text in Explore

* Remove unused state of filter modal

* Show place text in filters modal with helper

* Show location permission button only for Nearby explore state

* Add a placeMode state

* Do not send placeMode to API

* Also treat limited permission as yes

* useLocationPermission in ExploreLocationSearch

* Refactor to setting place mode

Instead of logic based on the translated text of the place_guess string that is stored in ExploreContext, we are switching to an enum state that signifies which mode to show on explore:
1.) Nearby: Filters explore results based on the user's location. This also has a state without location permission that does not query the API.
2.) Place: Filtering by a specific place (as retrieved by /places API).
3.) Worldwide: Retrieve worldwide results, i.e. not having a place filter set.
4.) Map area: Filtering explore results precisely to the map rectangle shown on the explore map.

* Remove import from test

* Remove export

* Use blocked title only for blocked permission asks

* Move gallery permission container to Tab navigator as are the others

* Add gallery save title

* Split location permission explanation into two

* Update strings.ftl

* Only nav to location picker if permission was not  granted

* Check permission on app being foregrounded

* The location permission part is handled by useLocationPermission

* Do not store permission result in hook

* Use hasPermission from permissions hook

* Update fetchUserLocation.e2e-mock

* Move hook one higher

* Show user location if permission is given

* PermissionGate callbacks should use useCallback

* Add permission hook to map usage

* Fix test

* Update layout to be asserted

* Add location permission hook to Explore

* Remove console.log

* Few TS fixes

* Indentation

* Remove superficial check

* Update Podfile.lock
2024-07-12 11:00:24 +02:00
Angie
b3143d06ee Change unfollow button to correct button outline (#1795) 2024-07-11 22:12:48 -07:00
Angie
aa2f703fc4 Notifications with jsut sound shows sound icon (#1794) 2024-07-11 21:26:25 -07:00
Angie
b55db96db8 1723 agree button should not appear while signed out (#1792)
* Agree with id button does not show when logged out, test added

* updated pod

* Fix failing test
2024-07-11 12:38:10 -07:00
Ken-ichi
fe0229291e Restore photo deletion (#1789)
* Restore photo deletion
* Rename methods for accessing media files
* Added integration test for photo deletion
* Cleaned up some accessibility labels

Closes #1429
2024-07-10 15:23:53 -07:00
Amanda Bullington
ce39b03495 Changes to showing select taxon button & vision attribute; closes #1773 (#1790) 2024-07-10 13:18:27 -07:00
Angie Ta
9d498167c7 remove comments 2024-07-09 09:58:39 -07:00
Angie
29c0f6beb7 1593 potential disagreement bottom sheet and disagreeing ids (#1749)
* Disagreeing IDs and Potential disagreement bottomsheet

* Change back to js

* Styling for withdrawn disagree text, string adjustments

* Agree taxon and disagree taxon share same state var, Reuse existing RadioButtonSheet for potential disagree, UI changes, styling for scientific name

* Remove duplicate

* Fix suggest id sheet not showing from teaxon details
2024-07-08 22:39:15 -07:00
Ken-ichi Ueda
e8f0b7f49d Ignore iOS permission error when trying to write to gallery
In theory we are checking for this permission before attempting to save, but
in practice it does happen, albeit rarely.
2024-07-08 15:39:33 -07:00
Ken-ichi Ueda
cf9e41657f v0.35.2; make sure recently-created obs appear at top of MyObs 2024-07-07 19:41:04 -07:00
Ken-ichi Ueda
ddf928ed04 Remove unsynced-first sorting because it's very slow
Re-opens #1577
2024-07-07 19:09:35 -07:00
Ken-ichi
50d9d1e60c Media clearing (#1771)
* (Re-)Fix bug where shared photo got deleted before it could be used
* Only run cleanup when MyObs has focus
* Only run cleanup once a minute
* Only delete files that are a day old or more
2024-07-05 21:33:52 -07:00