mirror of
https://github.com/Kong/insomnia.git
synced 2026-11-04 03:55:19 -05:00
Bingbing
bf6dc9658e
## Background
CI occasionally fails while uploading smoke test traces with `The path for one of the files in artifact is not valid: ... Colon :`.
The Electron-context trace in the `app` fixture names the zip file from the raw `testInfo.title`. Titles such as `project environment: show variable source and value renders the source inline` contain a colon, which `actions/upload-artifact` rejects. On Windows the file cannot be written at all. Because traces are retained only for failed tests, the upload error also hides the real test failure.
## Changes
- Name the trace `trace-${testInfo.status}.zip` instead of embedding the test title.
- `testInfo.outputDir` already contains the sanitized test title, project, retry, and repeat index, so the title in the file name adds only redundancy and invalid characters.
## Testing
- `npm run test:dev -w insomnia-smoke-test -- --project=Smoke --trace on -g "project environment: show variable source and value renders the source inline"` → 1 passed; trace written as `traces/smoke-variable-source-live-...-Smoke/trace-passed.zip`.
- `eslint packages/insomnia-smoke-test/playwright/test.ts`