mirror of
https://github.com/Kong/insomnia.git
synced 2026-08-04 03:42:20 -04:00
* Add vault-crypto/mime utilities and remove heavyweight third-party imports
- Add AES-GCM vault-crypto utility with tests (replaces node-forge usage)
- Add common/mime.ts to replace mime-types package dependency
- Replace tough-cookie import in response-cookies-viewer with inline parser
- Replace @grpc/grpc-js status import in grpc-status-tag with inline constant
- Replace electron.ipcRenderer in auth.clear-vault-key with showToast()
- Remove unused analytics call from window-utils
* Fix impure Date.now() key on CodeEditor; use setValue via ref instead
Replace key={Date.now()} with a useEffect that calls editorRef.current.setValue(snippet)
whenever snippet changes, keeping the editor mounted. Also apply prettier fixes from quick-check.
* fix: address Copilot review comments on PR #9992
- vault-crypto: replace forge-in-renderer with IPC bridge (main process
retains forge; renderer calls window.main.vault.{en,de}cryptSecretValue)
- mime.ts: expand lookup table to 48 entries (webp, wasm, mp4, docx, xlsx,
fonts, audio/video, etc.) and fix remaining mime-types import in send route
- response-viewer: move charset alias map to module level; normalise iconv-lite
alias names (utf8, latin1, win1252, …) to WHATWG labels for TextDecoder
- auth.clear-vault-key: fix typo "all you local" → "all your local"
* fix: sort imports in send route
* feat: disable nodeIntegration in renderer mainWindow, remove import check tooling
- Set nodeIntegration:false and contextIsolation:true on mainWindow webPreferences
(hidden window keeps nodeIntegration:true for user script execution)
- Split script-security-rules.ts out of script-security-policy.ts so the renderer
can import display-only constants without pulling in require-interceptor
- Add templating/renderer-safe.ts with Node-free render/reload/getTagDefinitions;
update all renderer callers to import from it instead of templating/index
- Split insomnia-testing generate.ts: move generateToFile to generate-to-file.ts
so generate() has no Node imports; expose generateToFile from new entry point
- Move runTests execution to main process via IPC (run-tests channel) so the
renderer routes no longer import the Mocha-backed test runner directly
- Delete vite-plugin-electron-node-require.ts, check-renderer-node-imports.ts,
renderer-node-import-baseline.json and all related scripts/plugins now that the
renderer bundle is free of Node built-in imports
* fix: sort imports, use static TestResults type, remove unused analytics import
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* remove mime stuff
* remove ci step
* update plan
* insomnia testing adapter
* use export method
* trick react router ssr
* add renderer errors
* globalThis
* improve error
* move plugin types
* ipc validate proto
* fix import
* plugin types
* polyfill events for jshint
* restore node require plugin
* vault adapter
* add crypto bridges
* tough-cookie ipc
* util stub
* split cookie into network adapter
* assert
* fix plugin index import
* serialise cookie
* decouple renderer from scripting
* Fix rebase conflicts and import path issues
- Fix incorrect ~/insomnia-data imports (should be insomnia-data package)
- Remove non-existent mime utility imports and provide simple fallback
- Remove incorrect analytics call from main process
- Remove unused imports (Settings, Cookie)
- Fix Response type annotation for getResponseBodyBuffer
* lint
* fix tests
* fix: use dynamic import for crypt in session.ts for main process compatibility
The session.ts module is used in both renderer and main process contexts (via sync.invoke IPC handlers). When running in the main process, window.main is undefined, causing TypeError when trying to access window.main.crypt.decryptAES().
Changes:
- Use dynamic import of crypt module (only loaded in main process context)
- In renderer: window.main.crypt is always available so dynamic import never executes
- In main process: dynamic import loads crypt with node:crypto support
- Protect loginStateChange() calls with window existence checks
This avoids bundling node:crypto in the Vite renderer build while still supporting both execution contexts.
Fixes E2E test failures in sync operations (remoteBackendProjects, _assertSession, etc.) caused by disabled nodeIntegration.
* fix: add aria-label to template tag preview and browser-safe encoding fallback
- Add aria-label="Live Preview" to textarea in TagEditor for better Playwright accessibility
- Add atob() fallback for decodeEncoding in browser contexts where Buffer isn't available
- Fixes smoke test element discovery for template tag preview modal
* fix: add explicit waits for element stability in environment test
Add toBeEnabled() and toBeVisible() waits before clicking elements in the
'kv pair environment can be updated' test. This prevents timeout errors from
unstable/flickering elements during modal interactions, especially in
high-concurrency shard execution.
* remove unused
* add autocomplete generate test step
* fix lint
* put analytics back in
* combine vault and crypto adapter
* remove unused export split
* remove insomnia-testing cruft, addressing feedback
* fix: use direct imports in insomnia-inso after insomnia-testing index.ts removal
* fix circular reference
* fix: move createElectronNotifier to main process to fix SSR error
Move the electron-dependent createElectronNotifier function from repo-file-watcher.ts
to git-service.ts to prevent electron imports from being evaluated in the renderer/SSR context.
* export har ipc bridge
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
277 lines
10 KiB
YAML
277 lines
10 KiB
YAML
name: Test App
|
|
|
|
on:
|
|
merge_group:
|
|
workflow_dispatch:
|
|
push:
|
|
branches:
|
|
- develop
|
|
pull_request:
|
|
types:
|
|
- opened
|
|
- synchronize
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions: {}
|
|
|
|
jobs:
|
|
Test:
|
|
timeout-minutes: 20
|
|
runs-on: ubuntu-24.04
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
packages: read
|
|
steps:
|
|
- name: Checkout branch
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
|
|
- name: Setup Node
|
|
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
|
|
with:
|
|
node-version-file: .nvmrc
|
|
cache: npm
|
|
cache-dependency-path: package-lock.json
|
|
registry-url: 'https://npm.pkg.github.com'
|
|
scope: '@kong'
|
|
|
|
- name: Install packages
|
|
run: npm ci
|
|
env:
|
|
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
|
|
|
|
- name: Lint
|
|
run: npm run lint
|
|
|
|
- name: Type checks
|
|
run: npm run type-check
|
|
|
|
- name: Unit Tests
|
|
run: npm test
|
|
|
|
- name: Check autocomplete snippets are up to date
|
|
run: |
|
|
npm run generate:autocomplete -w insomnia-scripting-environment
|
|
if ! git diff --exit-code packages/insomnia-scripting-environment/src/autocomplete-snippets.json; then
|
|
echo "::error::autocomplete-snippets.json is out of date. Run 'npm run generate:autocomplete -w insomnia-scripting-environment' and commit the result."
|
|
exit 1
|
|
fi
|
|
|
|
- name: Checkout base branch (cycle comparison)
|
|
if: github.event_name == 'pull_request' && always()
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
ref: ${{ github.event.pull_request.base.ref }}
|
|
path: insomnia-base
|
|
|
|
- name: Setup Node (base branch tree)
|
|
if: github.event_name == 'pull_request' && always()
|
|
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
|
|
with:
|
|
node-version-file: insomnia-base/.nvmrc
|
|
cache: npm
|
|
cache-dependency-path: insomnia-base/package-lock.json
|
|
registry-url: 'https://npm.pkg.github.com'
|
|
scope: '@kong'
|
|
|
|
- name: Install packages (base branch tree)
|
|
if: github.event_name == 'pull_request' && always()
|
|
working-directory: insomnia-base
|
|
run: npm ci
|
|
env:
|
|
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
|
|
|
|
- name: Check Circular References
|
|
if: github.event_name == 'pull_request' && always()
|
|
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
|
|
env:
|
|
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
script: |
|
|
const path = require('path');
|
|
|
|
const workspaceRoot = process.env.GITHUB_WORKSPACE;
|
|
const prPackagesDir = path.join(workspaceRoot, 'packages');
|
|
const basePackagesDir = path.join(workspaceRoot, 'insomnia-base', 'packages');
|
|
|
|
async function analyzeCircularReferences(rootDir) {
|
|
const madge = require('madge');
|
|
const res = await madge(rootDir, {
|
|
fileExtensions: ['ts', 'tsx'],
|
|
});
|
|
return res.circular();
|
|
}
|
|
|
|
// Function to generate markdown report
|
|
function generateMarkdownReport(prCircularRefs, baseCircularRefs, prCount, baseCount, baseBranch) {
|
|
const timestamp = new Date().toISOString();
|
|
const diff = prCount - baseCount;
|
|
const diffPercent = baseCount > 0 ? ((diff / baseCount) * 100).toFixed(2) : '0.00';
|
|
|
|
let status = '✅ PASSED';
|
|
let statusEmoji = '✅';
|
|
|
|
if (diff > 0) {
|
|
status = '⚠️ WARNING';
|
|
statusEmoji = '⚠️';
|
|
} else if (diff === 0) {
|
|
status = '✅ NO CHANGE';
|
|
statusEmoji = '✅';
|
|
} else {
|
|
status = '✨ IMPROVED';
|
|
statusEmoji = '✨';
|
|
}
|
|
|
|
// Find new and removed circular references
|
|
const prCycleStrings = new Set(prCircularRefs.map(cycle => cycle.join(' -> ')));
|
|
const baseCycleStrings = new Set(baseCircularRefs.map(cycle => cycle.join(' -> ')));
|
|
|
|
const newCycles = Array.from(prCycleStrings).filter(cycle => !baseCycleStrings.has(cycle)).sort();
|
|
const removedCycles = Array.from(baseCycleStrings).filter(cycle => !prCycleStrings.has(cycle)).sort();
|
|
|
|
return `# ${statusEmoji} Circular References Report
|
|
|
|
**Generated at:** ${timestamp}
|
|
**Status:** ${status}
|
|
|
|
## Summary
|
|
| Metric | Base (\`${baseBranch}\`) | PR | Change |
|
|
|--------|----------------|-----|---------|
|
|
| Total Circular References | ${baseCount} | ${prCount} | ${diff > 0 ? '+' : ''}${diff} (${diffPercent > 0 ? '+' : ''}${diffPercent}%) |
|
|
|
|
${newCycles.length > 0 ? `
|
|
## ⚠️ New Circular References Added (${newCycles.length})
|
|
|
|
<details open>
|
|
<summary>Click to expand/collapse</summary>
|
|
|
|
\`\`\`
|
|
${newCycles.join('\n')}
|
|
\`\`\`
|
|
|
|
</details>
|
|
` : ''}
|
|
|
|
${removedCycles.length > 0 ? `
|
|
## ✨ Circular References Removed (${removedCycles.length})
|
|
|
|
<details open>
|
|
<summary>Click to expand/collapse</summary>
|
|
|
|
\`\`\`
|
|
${removedCycles.join('\n')}
|
|
\`\`\`
|
|
|
|
</details>
|
|
` : ''}
|
|
|
|
<details>
|
|
<summary>Click to view all circular references in PR (${prCount})</summary>
|
|
|
|
\`\`\`
|
|
${prCircularRefs.length > 0 ? prCircularRefs.sort().map(cycle => cycle.join(' -> ')).join('\n') : 'No circular references found'}
|
|
\`\`\`
|
|
|
|
</details>
|
|
|
|
<details>
|
|
<summary>Click to view all circular references in base branch (${baseCount})</summary>
|
|
|
|
\`\`\`
|
|
${baseCircularRefs.length > 0 ? baseCircularRefs.sort().map(cycle => cycle.join(' -> ')).join('\n') : 'No circular references found'}
|
|
\`\`\`
|
|
|
|
</details>
|
|
|
|
## Analysis
|
|
|
|
${
|
|
diff > 0
|
|
? `⚠️ **Warning:** This PR introduces ${diff} new circular ${diff === 1 ? 'reference' : 'references'}. Consider refactoring to avoid adding circular dependencies.`
|
|
: diff < 0
|
|
? `✨ **Great Job!** This PR removes ${Math.abs(diff)} circular ${Math.abs(diff) === 1 ? 'reference' : 'references'}. Keep up the good work!`
|
|
: `✅ **No Change:** This PR does not introduce or remove any circular references.`
|
|
}
|
|
|
|
---
|
|
*This report was generated automatically by comparing against the \`${baseBranch}\` branch.*
|
|
`;
|
|
}
|
|
|
|
try {
|
|
const baseBranch = context.payload.pull_request.base.ref;
|
|
console.log(`Base branch (PR target): ${baseBranch}`);
|
|
console.log(`PR packages dir: ${prPackagesDir}`);
|
|
console.log(`Base packages dir: ${basePackagesDir}`);
|
|
|
|
console.log('Analyzing circular references in PR (merge) tree...');
|
|
const prCircularRefs = await analyzeCircularReferences(prPackagesDir);
|
|
const prCount = prCircularRefs.length;
|
|
console.log(`PR: Found ${prCount} circular references`);
|
|
|
|
console.log(`Analyzing circular references in ${baseBranch} tree...`);
|
|
const baseCircularRefs = await analyzeCircularReferences(basePackagesDir);
|
|
const baseCount = baseCircularRefs.length;
|
|
console.log(`Base: Found ${baseCount} circular references`);
|
|
|
|
// Generate report
|
|
const diff = prCount - baseCount;
|
|
const markdownContent = generateMarkdownReport(prCircularRefs, baseCircularRefs, prCount, baseCount, baseBranch);
|
|
|
|
// Post PR comment
|
|
if (context.eventName === 'pull_request') {
|
|
try {
|
|
const { data: comments } = await github.rest.issues.listComments({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: context.issue.number,
|
|
});
|
|
|
|
const botComment = comments.find(comment =>
|
|
comment.user?.type === 'Bot' &&
|
|
comment.body?.includes('# ') &&
|
|
comment.body?.includes('Circular References Report')
|
|
);
|
|
|
|
if (botComment) {
|
|
await github.rest.issues.updateComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
comment_id: botComment.id,
|
|
body: markdownContent
|
|
});
|
|
console.log('Updated existing PR comment');
|
|
} else {
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: context.issue.number,
|
|
body: markdownContent
|
|
});
|
|
console.log('Created new PR comment');
|
|
}
|
|
} catch (error) {
|
|
console.error('Error posting PR comment:', error);
|
|
}
|
|
}
|
|
|
|
// Log results but don't fail the build
|
|
if (diff > 0) {
|
|
console.log(`⚠️ Warning: This PR introduces ${diff} new circular ${diff === 1 ? 'reference' : 'references'}. Base: ${baseCount}, PR: ${prCount}`);
|
|
} else if (diff < 0) {
|
|
console.log(`✨ Great! This PR removes ${Math.abs(diff)} circular ${Math.abs(diff) === 1 ? 'reference' : 'references'}!`);
|
|
} else {
|
|
console.log(`✅ No change in circular references (${prCount})`);
|
|
}
|
|
|
|
} catch (error) {
|
|
console.error('Error analyzing circular references:', error);
|
|
core.setFailed('Failed to analyze circular references');
|
|
}
|