mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-04 04:33:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix scrolling corruption when scrollbar is placed on the left-side of the display.

Browse Source 
Take into account the scrollbar position when computing the region of the 
display widget to do an optimised scroll on.

BUG: 162958


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=815891
This commit is contained in:
Robert Knight
2008-06-02 19:38:20 +00:00
parent c5a7818129
commit 08fa3ef8f5
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/TerminalDisplay.cpp
View File

@@ -795,16 +795,25 @@ void TerminalDisplay::scrollImage(int lines , const QRect& screenWindowRegion)
// to get the correct (newly exposed) part of the widget repainted.
//
// The right edge must be before the the left edge of the scroll bar to
// avoid triggering a repaint of the entire widget.
// avoid triggering a repaint of the entire widget, the distance is
// given by SCROLLBAR_CONTENT_GAP
//
// Set the QT_FLUSH_PAINT environment variable to '1' before starting the
// application to monitor repainting.
//
int scrollBarWidth = _scrollBar->isHidden() ? 0 : _scrollBar->width();
const int SCROLLBAR_CONTENT_GAP = 1;
QRect scrollRect;
scrollRect.setLeft(0);
scrollRect.setRight(width() - scrollBarWidth - 1);
if ( _scrollbarLocation == ScrollBarLeft )
{
scrollRect.setLeft(scrollBarWidth+SCROLLBAR_CONTENT_GAP);
scrollRect.setRight(width());
}
else
{
scrollRect.setLeft(0);
scrollRect.setRight(width() - scrollBarWidth - SCROLLBAR_CONTENT_GAP);
}
void* firstCharPos = &_image[ region.top() * this->_columns ];
void* lastCharPos = &_image[ (region.top() + abs(lines)) * this->_columns ];