mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-03 12:15:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add some testing for calculating the title.profile file name"

Browse Source 
This builds fine on my Mac but not my Linux machine - what a pain

This reverts commit ef949e963b.
This commit is contained in:
Kurt Hindenburg
2013-03-23 22:41:26 -04:00
parent ef949e963b
commit 0f889323c8
2 changed files with 0 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/tests/ProfileTest.cpp
View File

@@ -25,7 +25,6 @@
// Konsole
#include "../Profile.h"
#include "../ProfileWriter.h"
using namespace Konsole;
@@ -171,45 +170,6 @@ void ProfileTest::testProfileGroup()
QVERIFY(profile[0]->property<QString>(Profile::Command) != "fish");
}
// Verify the correct file name is created from the untranslatedname
void ProfileTest::testProfileFileNames()
{
Profile::Ptr profile = Profile::Ptr(new Profile);
QFileInfo fileInfo;
ProfileWriter* writer = new KDE4ProfileWriter;
profile->setProperty(Profile::UntranslatedName, "Indiana");
fileInfo.setFile(writer->getPath(profile));
QCOMPARE(fileInfo.fileName(), QString("Indiana.profile"));
profile->setProperty(Profile::UntranslatedName, "Old Paris");
fileInfo.setFile(writer->getPath(profile));
QCOMPARE(fileInfo.fileName(), QString("Old Paris.profile"));
// FIXME: deal w/ file systems that are case-insensitive
// This leads to confusion as both Test and test can appear in the Manager
// Profile dialog while really there is only 1 test.profile file.
// Suggestions: all lowercase, testing the file system, ...
/*
profile->setProperty(Profile::UntranslatedName, "New Profile");
fileInfo.setFile(writer->getPath(profile));
QCOMPARE(fileInfo.fileName(), QString("new profile.profile"));
*/
// FIXME: don't allow certain characters in file names
// Consider: ,^@=+{}[]~!?:&*\"|#%<>$\"'();`'/\
// Suggestions: changing them all to _, just remove them, ...
// Bug 315086 comes from an user using / in the profile name - multiple
// issues there.
/*
profile->setProperty(Profile::UntranslatedName, "new/profile");
fileInfo.setFile(writer->getPath(profile));
QCOMPARE(fileInfo.fileName(), QString("new_profile.profile"));
*/
delete writer;
}
QTEST_KDEMAIN_CORE(ProfileTest)
#include "ProfileTest.moc"

1
src/tests/ProfileTest.h
View File

@@ -33,7 +33,6 @@ private slots:
void testProfile();
void testClone();
void testProfileGroup();
void testProfileFileNames();
};
}