Validate initial working directory Profile entry

Verify the Profile's initial working directory exists and is a dir

This applies to KonsolePart as well as Konsole
This commit is contained in:
Kurt Hindenburg
2016-10-08 16:32:01 -04:00
parent 1b8c9ca40a
commit 6e2d3f4e7e
3 changed files with 19 additions and 1 deletions

View File

@@ -139,6 +139,7 @@ void Part::showShellInDir(const QString& dir)
if (activeSession()->isRunning())
return;
// All other checking is done in setInitialWorkingDirectory()
if (!dir.isEmpty())
activeSession()->setInitialWorkingDirectory(dir);

View File

@@ -264,7 +264,7 @@ void Session::setArguments(const QStringList& arguments)
void Session::setInitialWorkingDirectory(const QString& dir)
{
_initialWorkingDir = KShell::tildeExpand(ShellCommand::expand(dir));
_initialWorkingDir = validDirectory(KShell::tildeExpand(ShellCommand::expand(dir)));
}
QString Session::currentWorkingDirectory()
@@ -1550,6 +1550,21 @@ void Session::restoreSession(KConfigGroup& group)
if (!value.isEmpty()) setCodec(value.toUtf8());
}
QString Session::validDirectory(const QString& dir) const
{
QString validDir = dir;
if (validDir.isEmpty()) {
validDir = QDir::currentPath();
}
const QFileInfo fi(validDir);
if (!fi.exists() || !fi.isDir()) {
validDir = QDir::homePath();
}
return validDir;
}
SessionGroup::SessionGroup(QObject* parent)
: QObject(parent), _masterMode(0)
{

View File

@@ -730,6 +730,8 @@ private:
bool updateForegroundProcessInfo();
void updateWorkingDirectory();
QString validDirectory(const QString& directory) const;
QUuid _uniqueIdentifier; // SHELL_SESSION_ID
Pty* _shellProcess;