mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-06-08 14:05:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

ViewSplitter: merge containerWidgetForDisplayImpl into its public counterpart

Browse Source 
The Impl free function and the public static member had identical logic.
Inline the body into ViewSplitter::containerWidgetForDisplay so both
file-local callers and external callers use the same method.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Markus Hoffmann
2026-05-24 23:11:31 +02:00
parent bc1272a092
commit a428d65fe2
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/widgets/ViewSplitter.cpp
View File

@@ -48,21 +48,9 @@ TerminalDisplay *terminalDisplayFromWidget(QWidget *widget)
return widget->findChild<TerminalDisplay *>(QString(), Qt::FindDirectChildrenOnly);
}
QWidget *containerWidgetForDisplayImpl(TerminalDisplay *display)
{
if (display == nullptr) {
return nullptr;
}
QWidget *parent = display->parentWidget();
if (parent != nullptr && parent->property(kTerminalContainerProperty).toBool()) {
return parent;
}
return display;
}
QWidget *ensureContainerWidget(TerminalDisplay *display)
{
QWidget *container = containerWidgetForDisplayImpl(display);
QWidget *container = ViewSplitter::containerWidgetForDisplay(display);
if (container == nullptr || container != display) {
return container;
}
@@ -107,7 +95,14 @@ ViewSplitter::ViewSplitter(QWidget *parent)
QWidget *ViewSplitter::containerWidgetForDisplay(TerminalDisplay *display)
{
return containerWidgetForDisplayImpl(display);
if (display == nullptr) {
return nullptr;
}
QWidget *parent = display->parentWidget();
if (parent != nullptr && parent->property(kTerminalContainerProperty).toBool()) {
return parent;
}
return display;
}
TerminalDisplay *ViewSplitter::terminalDisplayForWidget(QWidget *widget)
@@ -429,7 +424,7 @@ void restoreAll(QList<TerminalDisplay *> &&terminalDisplays, QList<ViewSplitter
}
for (auto terminalDisplay : terminalDisplays) {
terminalDisplay->setVisible(true);
containerWidgetForDisplayImpl(terminalDisplay)->setVisible(true);
ViewSplitter::containerWidgetForDisplay(terminalDisplay)->setVisible(true);
}
}
}