mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-06-10 06:55:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Perform some initializations in initialization list

Browse Source 
Fixes some variable is assigned in constructor body. Consider performing
initialization in initialization list. (CWE-398)
This commit is contained in:
Willyanto Willyanto
2022-12-20 22:58:47 +07:00
committed by Kurt Hindenburg
parent 031ca6f72c
commit c3176abb17
3 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/ShellCommand.cpp
View File

@@ -13,14 +13,13 @@
using Konsole::ShellCommand;
ShellCommand::ShellCommand(const QString &aCommand)
: _arguments(KShell::splitArgs(aCommand))
{
_arguments = KShell::splitArgs(aCommand);
}
ShellCommand::ShellCommand(const QString &aCommand, const QStringList &aArguments)
: _arguments(aArguments)
{
_arguments = aArguments;
if (!_arguments.isEmpty()) {
_arguments[0] = aCommand;
}