Simplify by using sessionId and not passing around randomSeed.
The randomEngine is still initialized the same.
This also avoids passing session to createTerminalDisplay().
This is from !301
Since the keyboard files are bundled in the executable now,
there should be no need for a fallback translator. The code
is still there for reference w/o using a separate class.
Implements OSC-52 write-only clipboard access. Already supported by a
wide range of other terminals, including alacritty, foot, kitty,
urxvt, wezterm, xterm, and others.
I've intentionally omitted read access to the clipboard as that comes
with several security concerns, which should be discussed first.
BUG: 372116
Adjusted UrlFilter::newHotSpot to strip non-URL trailing characters (e.g., commas, dots) using regex "[',.:;]+$". This ensures correct URL parsing without trailing punctuation.
Test case: 'https://example.com.' should exclude the trailing dot.
BUG: 472274
BUG: 473285
The autosave functionality is contained in a SaveHistoryAutoTask
class, which inherits from SessionTask. The autosave mechanism
hinges on two pieces of information regarding the autosave file:
the number of bytes used to store the contents of dropped lines
(represented by SaveHistoryAutoTask::_droppedBytes) and a list
of byte offsets corresponding to the start of the contents of lines
on the screen (represented by SaveHistoryAutoTask::_bytesLines).
Everytime a line is dropped, SaveHistoryAutoTask::_droppedBytes
is updated using _bytesLines. Everytime the output is read and
saved to file, the autosave file is resized to _droppedBytes and
the current screen output is appended. Everytime the output is read
or the screen is resized, _bytesLines is updated.
The autosave can be started using an "Auto Save Ouput As" button in
the "File" tab of the toolbar. Once the autosave is started, said
button is replaced by a "Stop Auto Save" button which allows the
user to stop the autosave. Internally, any errors encountered by
the program would result in an KMessageBox reporting the details of
the error and stopping the autosave as well. Clicking on the stop
button reveals the start button again.
Similar to SaveHistoryTask, there is a file dialog which allows the
user to choose which file they would like the autosave contents to
be stored in.
Apart from errors involving reading session output and writing to
file, modifying the file externally, renaming the file and deleting
the file will also result in an error. Emulation::_currentScreen
being changed will also result in an error.
The autosave is conducted at a fixed time interval, apart from an
edge case where an autosave is required immediately due to internal
constraints. Said fixed time interval can be set by the user in the
settings of their current profile, specifically the "Advanced" tab.
Details on the internals of the autosave functionality is documented
in the source files.
GUI
FEATURE: 208620
Users can add markers to the scrollbar by double clicking on the
scrollbar. A user can remove a marker by double clicking on it again.
The position of the marker is stored internally as a percentage offset
of the scrollbar's length and is not attached to any line of output.
This means that on resize, a scrollbar marker originally created at
x percentile of the scrollbar's length from the top will still remain
at x percentile of the scrollbar's length from the top.
In the "Scrolling" tab in the settings, there are options for the
user to change the color of the markers and the size of the markers.
The size of the marker can be specified as a floating point number,
representing the percentage of the entire scrollbar's length it occupies.
GUI:
FEATURE: 338901
The player was basically stuck in the QMediaPlayer::BufferingMedia
state, never playing or deleting itself. I guess this still could
happen on systems without valid audio outputs.
BUG: 490264
Shifting an operand by a shift amount greater than or equal to the width
of that operand results in UB, which can happen when shifting an
unsigned long on a 32 bit target by an amount from 0 to 63.
This is probably the cause of the crash at the following bug:
BUG: 479319
Expression repeated inside endif; better to use only endif()
[readability/logic]
Extra spaces between 'if' and its () [whitespace/extra]
Do not mix upper and lower case commands [readability/mixedcase]
Weird indentation; use 2 spaces [whitespace/indent]
Mismatching spaces inside () after command [whitespace/mismatch]
Extra spaces between 'set' and its () [whitespace/extra]
Previously, when eg. hitting `Ctrl+Shift+(` multiple times, the resulting
panes would look like:
-------------------------------------
| | | | |
| Pane 1 | Pane 4 | Pane 3 | Pane 2 |
| | | | |
-------------------------------------
This was caused by `AddBehavior` being ignored when splitting more than
once in the same orientation. The new pane would always be created at
the index of the current pane. This commit fixes the problem so that
`AddBehavior::AddAfter` will open a new pane downwards or to the right in
all scenarios.
