TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
To build for KF5 pass the option -DQT5_BUILD=ON to CMake
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
compile all the platform-specific *ProcessInfo implementations only
in the OS they belong to, basically extending this conditional
compilation also to the Linux and Solaris implementations.
This allows to use proper OS-specific API/etc in each, removing quirks
(like the one for the Solaris psinfo struct) to emulate such APIs on
other OSes.
New feature in 4.11 allows Shift+Click to extend the selection.
However, for programs not interested in mouse (vim, mc, etc) this
causes issues. Fix is to ignore extending selection for those apps.
BUG: 321516
FIXED-IN: 4.11
Neither of the two standard shortcuts used here are *guaranteed* to be
present (kdelibs filters both with some KAuthorized magic, and
help_contents also depends on the documentation subsystem), so avoid
crashing just because they're not around.
First noticed on my Gentoo-provided Konsole which is compiled without
the handbook USE flag.
(cherry picked from commit 8950584966)
Hide EditProfileDialog when opening ColorSchemeEditor. When the color
scheme is open, the terminal is usually blocked by the EditProfile
dialog. So users have to move that dialog to see the terminal. This
patch hides the EditProfile dialog.
Patch by renan fargetton renan.fargetton@gmail.com
REVIEW: 110536
Move some code from EditProfileDialog::showColorSchemeEditor
* a part went in the slot EditProfileDialog::saveColorScheme
* a part becomes obsolete since ColorSchemeEditor is the whole KDialog
* a small part went into ColorSchemeEditor constructor
Make ColorSchemeEditor a non-modal dialog : The terminal is not frozen
when the dialog is open
- The Kdialog has an Apply button
- Some safeguard to check that there is only one ColorSchemeEditor open
- Use reference rather than pointer in ColorSchemeEditor interface
Thanks to Renan for improving on Konsole's ColorScheme.
Patch by renan fargetton renan.fargetton@gmail.com
REVIEW: 110560
GUI:
Add _isNewScheme bool as private member in ColorSchemeEditor class,
making the dialog aware if it correspond to a new theme or not.
Patch by renan fargetton renan.fargetton@gmail.com
REVIEW: 110534
Instead of keeping track of constants and +1 -1, use a QRect to handle
the terminal margins. There is no GUI for this currently and the
margins are hard-coded to what they are now. Code to center the
terminal is also include (w/o GUI).
This patch comes from review 109891 w/ a few changes from me.
Thanks to Mariusz Glebocki mglb@arccos-1.net
A lot of crashes in copyLineToStream _screenLines[screenLine]; this
likely needs to be a container, for now add an extra variable to watch
the size.
I still can't reproduce it though a lot of people can doing various
things.
319888, 313711, 312006, 306939, 304837
Add extra column for intense colors so each color and the corresponding
intense color is side by side (the data model colorScheme is unchanged,
only the ui has the additional column)
Also adjust the GUI such that there are no scrollbars for the table. The
EditProfileDialog is still larger.
Patch by renan fargetton renan.fargetton@gmail.com
with minor edits by me
From review 110318
CCMAIL: renan.fargetton@gmail.com
GUI:
A fix to prevent an infinite loop if user puts / in ColorScheme name;
Konsole will create a sub-folder in that case.
More code will have to go in to prevent the users from doing that.
FIXED-IN: 4.11
BUG: 315086
If an user had only one profile and accidently puts a non-interactive
program (eg pwd) in the Command section it will start, run command and
then close.
The FALLBACK/ profile is the internal basic profile.
REVIEW: 109558
FIXED-IN: 4.11
Since the early KDE 4.x, konsole has allowed each color entry to have
a "Bold=true|false" entry to specify whether the color should be drawn
in bold or not (there was never an UI).
The per-profile 'Draw intense colors in bold font' should be enough.
See bko 168300 for more info
There's more than a few issues w/ generating the profile's filename
from the untranslatedName property. Two of the main issues are
commented out since I don't want them failing just yet.
There's more than a few issues w/ generating the profile's filename
from the untranslatedName property. Two of the main issues are
commented out since I don't want them failing just yet.
This crash in isSpace() is due to invalid Character; check for valid
array size before grabbing it. No one can reproduce the crash but this
can't hurt hopefully.
CCBUG: 309954
Fixing the wrong behaviour to open two or more "edit dialog" for
one session/tab with the same profile, and the crash with two or
more "edit dialog", one for different session(tabs) with the same profile.
BUG: 311270
REVIEW: 107640
FIXED-IN: 4.11
Currently the presence of the search bar is maintained per-tab, but the
search term itself is per-window. This leads to curiously inconsistent
behaviour. I believe there is little to suggest search terms remain
relevant across different tabs, and there is significant user
expectation that search terms/bar constrained to a tab (see browsers).
Patch by Lindsay Roberts linds.r@gmail.com
REVIEW: 109130
Current history search searches "down", wrapping instantly from the
current location to search from oldest to newest. As lines in a
terminal generally decrease in relevance as they move away from current
output, the most relevant lines and therefore search results can be
found "upwards" of the current output line.
This patch makes searches default to "up".
Patch by Lindsay Roberts linds.r@gmail.com
REVIEW: 108998
