mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-02 19:56:46 -04:00
Code Issues Packages Projects Releases Wiki Activity
3,811 Commits 139 Branches 416 Tags
ce496b59330c2f81875ae03f97eddb4fc052da41
Commit Graph

3811 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jekyll Wu
ce496b5933 Make the code a bit more readable. 2011-09-06 15:39:05 +08:00
Jekyll Wu
b7e4742eb6 add KDialog:: prefix before ButtonCode. 2011-09-06 08:35:52 +08:00
Jekyll Wu
ca7beebb0e KTabWidget is not used by konsole yet. 2011-09-06 08:23:16 +08:00
Jekyll Wu
50a38c2fcb small changes with #include . 2011-09-06 08:17:41 +08:00
Jekyll Wu
e828def700 Reorgnazie some #include. 2011-09-06 06:53:38 +08:00
Jekyll Wu
de61d40c63 Include Qt headers in the form of "#include <Module/Class>" 2011-09-06 06:42:42 +08:00
Jekyll Wu
f78b734ef2 Remove unused #include . 2011-09-06 06:38:51 +08:00
Jekyll Wu
0f89f1bba9 Check the validity of context menu after it gets closed. 
The patch is from Francesco Cecconi <francesco.cecconi@gmail.com>,
with slight modification by committer.

BUG: 233377
FIXED-in : 4.8
 2011-09-06 05:48:56 +08:00
Jekyll Wu
d90862d060 replace Q_SLOTS with slots. 2011-09-06 02:58:12 +08:00
Jekyll Wu
4b02eba623 Change slotClose() as private slot, since it is not used externally. 2011-09-06 02:39:23 +08:00
Jekyll Wu
6d08d04b56 adjust indentation to 4 spaces. 2011-09-06 02:33:15 +08:00
Jekyll Wu
1b5d836219 Add KDialog:: prefix for ButtonCode. 
Ok, Cancel and Default are so generic that they look ambiguous without
the KDialog:: prefix.
 2011-09-06 01:25:15 +08:00
Jekyll Wu
d99422730f Less one-liner definitions for class methods . 
This really hurts readability, especially when they appear successively.
 2011-09-06 00:32:53 +08:00
Jekyll Wu
976077e37f Do not select the fixed size mode by default. 
Current code always sets the line count spinbox as focused and selected,
even when the current setting of history size is no history or unlimited
history. This is counter-intuitive and may confuse users.
 2011-09-05 23:28:14 +08:00
Jekyll Wu
0012355e2e slight adjustment of code layout. No functionality changes. 2011-09-05 23:06:08 +08:00
Jekyll Wu
6f3b4bbab6 Use "{ }" consistently in "if... else..." statements. 2011-09-05 22:28:44 +08:00
Jekyll Wu
0016b3c0c2 remove the TODO about unicode charcter composition, which is done. 2011-09-05 21:39:06 +08:00
Jekyll Wu
050454280b Remove emacs mode information from the bottom of some source files. 
This is a follow-up of commit dd9df43b44
 2011-09-05 17:33:31 +08:00
Jekyll Wu
495b66f705 member _profileKey is not used anymore. 2011-09-05 17:12:28 +08:00
Jekyll Wu
2818d96536 Calling Session::run() on a already running sesssion makes no sense. 2011-09-05 15:26:22 +08:00
Jekyll Wu
c246e94fb5 Check whether the pointer _shellProcess is null before using it. 2011-09-05 15:26:07 +08:00
Yuri Chornoivan
cd50a74e7a fix typo: varible -> variable 2011-09-05 07:55:29 +03:00
Jekyll Wu
3c562ef7fe Add tootip for the KTextEdit widget within environment editor. 
The code assumes one environment variable per line, but users may
not guess out that assumption without prompt.
 2011-09-04 21:11:46 +08:00
Jekyll Wu
b916dd22d0 Rename 'persistant' to 'persistent'. 
This is a common misspelling.
 2011-09-04 13:24:56 +08:00
Jekyll Wu
a64772444f reorganize some code to make it more readable. 
This commit is purely about style and layourt. No functionality changes.
 2011-09-04 12:11:17 +08:00
Jekyll Wu
5fb01e1017 slight improvement on style and readability. 2011-09-04 02:09:59 +08:00
Jekyll Wu
4b7ce422a5 The argument should not used before it passes the assertion. 2011-09-04 01:58:59 +08:00
Jekyll Wu
0c5a853e92 Add helper method createTempProfile() to reduce duplicated code. 2011-09-04 01:37:05 +08:00
Jekyll Wu
709445ceee Make sure the _tempProfile is alwasy hidden. 2011-09-04 01:20:14 +08:00
Jekyll Wu
dec20a58a7 Assign new value to _tempProfile in a way clearly indicating its type. 
This avoids potential doubt about its type and memory leak.
 2011-09-04 01:19:31 +08:00
Jekyll Wu
0e184eeda9 KStandardDirs::findExe() is actually a static method. 2011-09-03 17:09:34 +08:00
Jekyll Wu
9971d3d117 prefer using convenient method KStandardDirs::locate() . 2011-09-03 16:37:05 +08:00
Jekyll Wu
afea863b2a Stop tracking the session/profile pair after a session is closed. 
The patch(slightly modified) is from Gu Rui <chaos.proton@gmail.com>

REVIEW: 102507
 2011-09-02 10:01:16 +08:00
Jekyll Wu
a5eaba7f76 Create runtime profile only once per session. 
The patch is provied by Gu Rui <chaos.proton@gmail.com>

REVIEW: 102506
 2011-09-02 09:06:25 +08:00
Jekyll Wu
93f98ef422 Align successive assignments for better readability. 2011-09-01 17:27:45 +08:00
Jaime Torres
f1ae6db882 return the rigth value for the rigth value 
Use the right command value instead of a duplicated.
 2011-08-31 19:20:48 +02:00
Jekyll Wu
b4c73b4ad1 slightly more readable. 2011-08-31 22:44:44 +08:00
Jekyll Wu
621bde6f99 implement operator != by inverting the result of operator ==. 2011-08-31 16:20:36 +08:00
Jekyll Wu
d6ca64fe4d Delete one duplicated declaration. 2011-08-30 14:46:56 +08:00
Jekyll Wu
2d8b4a0a63 Delete one line of no use. 2011-08-30 07:57:55 +08:00
Jekyll Wu
a52cd60e9e Delete 2 un-used member variables. 2011-08-30 07:47:36 +08:00
Jekyll Wu
2822ca86eb Make sure the d&d popup menu provided by libkonq get translated. 
This is a follow-up of 2dcd584255.

BUG: 280931
 2011-08-29 09:55:47 +08:00
Raphael Kubo da Costa
681e8870a2 Use find_package() instead of macro_optional_find_package(). 
Since libkonq is required, it makes little sense to optionally find it.

Reported by:	krop
 2011-08-27 19:24:18 -03:00
Raphael Kubo da Costa
1e1658f018 Display feature log at the end. 
(cherry picked from commit 95e30b5835)
 2011-08-27 16:49:18 -03:00
Raphael Kubo da Costa
19412f8c68 Look for LibKonq before using it. 
Follow-up to 2dcd584255.

konsole is not in the same repository as libkonq anymore, so we need
to check if it is installed before using it, and it is also better to
use the whole library path when linking instead of hardcoding "konq".

CCMAIL: konsole-devel@kde.org
 2011-08-27 16:46:46 -03:00
Jekyll Wu
ed5ae75839 Check stdin instead of stdout to detect whether invoked from terminal. 
It is possible that users invoke konsole from terminal in the form of
'konsole &> /dev/null' to get rid of warning messages. Checking stdout
won't give expected result.

On the other hand, 'konsole < ....' is almost never used. So checking
stdin should be more reliable.
 2011-08-27 19:42:34 +08:00
Jekyll Wu
ad535d4432 Make minor adjustment to the comments. 2011-08-27 17:58:00 +08:00
Jekyll Wu
0dc37168cb Rename forceNewProcess() into shouldUseNewProcess(). 
That function just reports whether new konsole process should be use. It
has no side effect and does not create new process, while the old name
may give the impression that it does.
 2011-08-27 17:41:14 +08:00
Jekyll Wu
473f1726c0 move member initialization into initialization list of constructor. 2011-08-27 14:41:29 +08:00
Jekyll Wu
e63c9b8388 Delete one line of useless code. 2011-08-27 14:38:36 +08:00