Commit Graph

58 Commits

Author SHA1 Message Date
Ahmad Samir
c83bb19a68 Port away from deprecated foreach, use for-range instead, first take
The code compiles and konsole loads and seems to work as before.
2019-11-24 19:24:12 +02:00
Kurt Hindenburg
8040bb2678 fix memory leak (coverity) 2019-08-28 22:37:38 -04:00
Kurt Hindenburg
afe5bb4300 For returns use a braced initializer list 2018-10-27 23:07:38 -04:00
Kurt Hindenburg
dbdc8ce973 modernize use auto 2018-10-27 23:00:49 -04:00
Kurt Hindenburg
7bc9794503 For returns use a braced initializer list 2018-10-27 22:37:16 -04:00
Kurt Hindenburg
46e4938cb3 Fix base-class-event issue; return QDialog::eventFilter() 2018-07-24 01:05:06 -04:00
Ahmad Samir
581df2a23a Improve the Keyboard tab and the KeyBindings editor
Summary:
- Change updateKeyBindingsList() to select the last edited keybindings
  scheme after closing the editor dialog
- Add a tooltip showing the path of each keybinding scheme, this should
  lessen the confusion when the scheme description and the file name of
  the .keytab file are different
- Add a button to the Keyboard tab to reset a scheme to its default
  values, this is only applicable for schemes that exist in both
  system-wide and user specific locations
- Move a lot of the construction of the keybinding editor widgets from
  EditProfileDialog to  KeyBindingEditor
- Change the wording from "key bindings list" to "key bindings scheme"
  to differentiate between a keyboard translator "scheme" and the key
  bindings "list" on the Keyboard tab

KeyBindingEditor:
- Make the KeyBindingEditor a QDialog and set Qt::WA_DeleteOnClose
- Disallow saving a scheme with an empty description
- Add a QLineEdit to show only the rows that have strings matching the
  text entered in the line edit box
- Reimplement sizeHint() to make the dialog slightly smaller than the
  Edit Profile dialog, for better visibility of the entries

KeyboardTranslatorManager:
- Make findTranslatorPath() const and public
- Make allTranslators() return type const

Test Plan:
- Editing a key bindings scheme works and closing the dialog selects the edited scheme
- Creating a new scheme works as before
- "Defaults" button works for system-wide schemes if they were previously edited and saved under the user's home dir
- Remove button is only enabled for schemes saved in a dir writable for the user

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D12981
2018-05-22 19:11:15 -04:00
Kurt Hindenburg
8b4cbcaf7a Use constuctor initialization list for all members 2018-04-01 11:30:45 -04:00
Ahmad Samir
bd560c563f Make the key binding editor dialog bigger
Summary:
The first column in the key binding editor dialog usually has long lines of
text, to improve usability set a minimum size of 480x430 for that dialog
and an initial size of 500x500. Also set the initial width of that column
to 300.

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: ngraham, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D11637
2018-03-24 20:41:30 -04:00
Kurt Hindenburg
cf56e5db4c sync declarations with definitions (have .h and .cpp variable names match) 2018-01-06 14:32:02 -05:00
Kurt Hindenburg
c907fcea7a remove unneeded casts 2017-09-16 16:12:09 -04:00
Kurt Hindenburg
9bd78534a0 uncrustify using kf5 config 2017-05-29 17:49:41 -04:00
Kurt Hindenburg
eade05a4bd Do not specify Qt modules in includes 2017-04-26 21:33:34 -04:00
Kurt Hindenburg
a540e6fdd0 Fix readability-implicit-bool-cast issues using nullptr 2017-04-21 10:51:31 -04:00
Montel Laurent
83515eafbc Port to new connect api 2014-10-18 14:11:18 +02:00
Michal Humpula
d3310de9e0 port KIcon to QIcon
REVIEW: 120493
2014-10-11 14:38:18 +02:00
Alex Richardson
a3ce74d4eb Convert to Qt5 signal slot syntax
REVIEW: 117482
2014-04-30 19:16:54 +02:00
Kurt Hindenburg
e3e06ff153 s/KLineEdit/QLineEdit 2014-01-18 14:35:35 -05:00
Kurt Hindenburg
597d4657a7 s/kde4_add_ui_files/qt5_wrap_ui cmake fix 2014-01-12 10:22:51 -05:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Alex Richardson
a83db71590 Port to KF5/Qt5
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-20 23:34:35 +02:00
Alex Richardson
ab5e15b1b7 Revert "Port to KF5/Qt5"
This reverts commit 4adfbe84bd.

This work will go into a new branch instead
2013-08-13 23:26:19 +02:00
Alex Richardson
4adfbe84bd Port to KF5/Qt5
To build for KF5 pass the option -DQT5_BUILD=ON to CMake

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-13 21:26:59 +02:00
Kurt Hindenburg
7a2a5beb00 Correct spelling errors/word usage
All these are in the comments - no code changes
2013-01-09 22:07:11 -05:00
Kurt Hindenburg
9e25784d6d A few more c style casts -> static_casts 2012-12-24 09:55:58 -05:00
Jekyll Wu
6ddd34e9cb Fix the problem of cursor keeping moving when editing keytab description.
Thanks to Yichao Yu for the spotting and the patch.

REVIEW: 107287
2012-11-14 12:11:14 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
f0529c1c02 Prefer foreach(..) over iterating manually for readability 2012-02-13 21:28:48 +08:00
Kurt Hindenburg
ed77ae37d6 Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 10:37:22 -05:00
Kurt Hindenburg
bc087ae51b Remove unused KDebug includes 2011-12-18 00:01:32 -05:00
Jekyll Wu
b95f9443a0 Trivial change on #include 2011-11-16 13:31:24 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Montel Laurent
b91f50015d Normalize signals/slots 2011-07-30 14:10:56 +02:00
Montel Laurent
aa00ff2ede Fix mem leak 2011-04-21 13:41:15 +02:00
Montel Laurent
a955ae6e36 Don't check pointer before to delete it 2011-04-21 13:37:01 +02:00
Kurt Hindenburg
b4afdc95ea Fix crash on removing key bindings. Patch by Dario Andres
BUG: 183069

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1082422
2010-01-30 14:25:13 +00:00
Kurt Hindenburg
bf32017d57 Selecting any cell will select entire row.
BUG: 183070

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1038235
2009-10-20 21:19:46 +00:00
Kurt Hindenburg
e8cb1c4996 Change QLineEdit to KLineEdit and set the Clear button where appropriate.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=989491
2009-06-30 12:25:59 +00:00
Robert Knight
5d9997446e Update copyright year to 2008. Remove '(C)' from copyright lines.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
2008-04-24 14:53:43 +00:00
Robert Knight
971a5315f9 Remove debugging messages.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800628
2008-04-24 14:52:39 +00:00
Robert Knight
46cfc108d3 * Replace all usage of qDebug() with kDebug(), since kDebug() provides information about
which part of the code the message came from and allows filtering of output
  using kdebugdialog
* Remove explicit creation of singleton classes SessionManager,ColorSchemeManager and
  KeyboardTranslatorManager and automate it with K_GLOBAL_STATIC.
  This ensures that the singleton destructors are called appropriately by KPart clients
  when they unload the libkonsolepart library.


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=754334
2007-12-29 16:07:31 +00:00
Robert Knight
645d82ec1e Fix character sequences produced by <Ctrl/Alt/Ctrl+Alt> + <Left Arrow/Right Arrow> key inputs. Implement support for wild card '*' characters in the result string for keyboard translator entries.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=743477
2007-12-01 03:25:14 +00:00
Andreas Pakulat
f412e5b5aa Merge the KConfig branch. This are the 3 main modules (+kdeadmin), which are
needed now because friday is the last BC day. The rest of the modules will
follow as fast as my laptop allows.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=721704
2007-10-05 22:21:25 +00:00
Robert Knight
72241ef4a6 * Comment out many debugging messages
* Experimental optimization, disable kerning since this is not required
  with the mono-spaced fonts which are used in the terminal.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=682702
2007-07-03 09:14:21 +00:00
Robert Knight
098629a394 Missed from last commit. Use QFlags<Enum> instead of Enum where necessary.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=680120
2007-06-25 13:14:47 +00:00
Robert Knight
dbedf8d412 Fix setting of key binding description /doh. Fix crash in key binding editor if used without setting it up with an existing translator. Fixes crash in translator list if it is empty.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=677187
2007-06-18 16:39:40 +00:00
Robert Knight
bb696c3cbf Allow removal of existing entries and adding of new entries in the key binding editor. Fix binding table referring to old entries when making changes.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=677166
2007-06-18 15:37:56 +00:00
Robert Knight
ffda8d3ccc Implement saving of key binding changes. Adapt Pty changes to use Konsole's more verbose variable naming style.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=676902
2007-06-17 22:05:45 +00:00
Robert Knight
5872b79ef1 Replace old key translator with new key translator. Lightly tested. Fix some bugs in the new translator's decoding.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=676512
2007-06-17 01:01:53 +00:00