fix(ci): remove gocritic unnecessaryDefer exclusion (#4525)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

.golangci.yml

@@ -133,9 +133,6 @@ linters:
       - text: "Magic number: 1e"
         linters:
           - mnd
-      - text: "unnecessaryDefer"
-        linters:
-          - gocritic
       - text: "filepathJoin"
         linters:
           - gocritic

repo/blob/filesystem/filesystem_storage_test.go

@@ -336,7 +336,7 @@ func TestFileStorage_New_MkdirAllFailureIsIgnored(t *testing.T) {
 	}, true)
 	require.NoError(t, err)
 
-	defer st.Close(ctx)
+	st.Close(ctx)
 }
 
 func TestFileStorage_New_ChecksDirectoryExistence(t *testing.T) {

tests/end_to_end_test/restore_test.go

@@ -809,7 +809,7 @@ func verifyValidZipFile(t *testing.T, fname string) {
 	zr, err := zip.OpenReader(fname)
 	require.NoError(t, err)
 
-	defer zr.Close()
+	zr.Close()
 }
 
 func verifyValidTarFile(t *testing.T, fname string) {